Re: RFR: 8236907: JTable added to nested panels does not paint last visible row

2022-02-17 Thread Prasanta Sadhukhan
On Thu, 10 Feb 2022 09:49:41 GMT, Tejesh R wrote: > Issue in painting last row of JTable due to decrement in `MaxRow `during > computation. Differences in `MaxRow `computation between `TablePrintable` and > `BasicTableUI `class. The Bug is fixed in both the classes. Test Case added > to valida

Integrated: 8037573: Typo in DefaultTreeModel docs: askAllowsChildren instead of asksAllowsChildren

2022-02-17 Thread Prasanta Sadhukhan
On Wed, 16 Feb 2022 07:15:20 GMT, Prasanta Sadhukhan wrote: > [DefaultTreeModel.html#isLeaf](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/tree/DefaultTreeModel.html#isLeaf(java.lang.Object)) > to an "askAllowsChildren" attribute that doesn't exist. The real attrib

Re: RFR: 8280861: Robot color picker broken on Linux with scaling above 100% [v4]

2022-02-17 Thread Sergey Bylokhov
On Tue, 15 Feb 2022 06:01:46 GMT, Maxim Kartashev wrote: >> The primary API for image capture on modern Linuxes is >> `gdk_pixbuf_get_from_window()` that expects both coordinates and the size >> unscaled (i.e. not multiplied by the current desktop scale). At the same >> time, `gtk3_interface.c

Re: RFR: 8012675: Javadoc for javax.swing.text.html.parser.Parser.handleComment() needs to be updated

2022-02-17 Thread DamonGuy
On Fri, 11 Feb 2022 19:20:16 GMT, DamonGuy wrote: > Updated Parser class doc by appending to the doc regarding lack of support > for HTML script tags. Adding this information to the "parse" function did not > seem as consistent for formatting as adding it to the Parser class doc. I have a loca

Re[2]: Area#add(Area) Optimization

2022-02-17 Thread Jeremy Wood
OK, thanks for the feedback. Regards, - Jeremy -- Original Message -- From: "Philip Race" To: "Jeremy Wood" ; client-libs-dev@openjdk.java.net Sent: 2/12/2022 5:26:37 PM Subject: Re: Area#add(Area) Optimization I suppose this could be added but it is something an application also c

Re: RFR: 8015854: [macosx] JButton's HTML ImageView adding unwanted padding [v4]

2022-02-17 Thread DamonGuy
> Html does not fit in JButton at certain sizes because default Insets cause > html to be displayed off-center. > > Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable > clipping if html does not fit, similar to regular text. AquaButtonUI.java now > detects when html d

Re: RFR: 8015854: [macosx] JButton's HTML ImageView adding unwanted padding [v3]

2022-02-17 Thread DamonGuy
> Html does not fit in JButton at certain sizes because default Insets cause > html to be displayed off-center. > > Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable > clipping if html does not fit, similar to regular text. AquaButtonUI.java now > detects when html d

Re: RFR: 8037573: Typo in DefaultTreeModel docs: askAllowsChildren instead of asksAllowsChildren

2022-02-17 Thread Alexander Zvegintsev
On Wed, 16 Feb 2022 07:15:20 GMT, Prasanta Sadhukhan wrote: > [DefaultTreeModel.html#isLeaf](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/tree/DefaultTreeModel.html#isLeaf(java.lang.Object)) > to an "askAllowsChildren" attribute that doesn't exist. The real attrib

Re: RFR: 8281738: Create a regression test for checking the 'Space' key activation of focused Button [v2]

2022-02-17 Thread Jayathirth D V
On Thu, 17 Feb 2022 02:12:01 GMT, Manukumar V S wrote: >> test/jdk/javax/swing/JButton/SpaceKeyActivatesButton.java line 39: >> >>> 37: >>> 38: /* >>> 39: * @test >> >> @bug ? >> >> And I presume you've verified this using mach 5? >> >> Also do we actually specify that Space generates an Ac

Re: RFR: 8037573: Typo in DefaultTreeModel docs: askAllowsChildren instead of asksAllowsChildren

2022-02-17 Thread Jayathirth D V
On Wed, 16 Feb 2022 07:15:20 GMT, Prasanta Sadhukhan wrote: > [DefaultTreeModel.html#isLeaf](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/tree/DefaultTreeModel.html#isLeaf(java.lang.Object)) > to an "askAllowsChildren" attribute that doesn't exist. The real attrib

Re: RFR: 8012675: Javadoc for javax.swing.text.html.parser.Parser.handleComment() needs to be updated

2022-02-17 Thread Jayathirth D V
On Fri, 11 Feb 2022 19:20:16 GMT, DamonGuy wrote: > Updated Parser class doc by appending to the doc regarding lack of support > for HTML script tags. Adding this information to the "parse" function did not > seem as consistent for formatting as adding it to the Parser class doc. I just traced

RFR: JDK-8282046: Create a regression test for CCC8000326

2022-02-17 Thread Srinivas Mandalika
Create a regression test for CCC8000326 Issue is identified by [JDK-8000326](https://bugs.openjdk.java.net/browse/JDK-8000326), which identifies that after focus moves into JMenuBar, whose focus traversal key is disabled by default, it never moves to other focusable component. By default, pre

Integrated: 8264743: Add forRemoval for deprecated classes and method in javax/swing/plaf/basic

2022-02-17 Thread Prasanta Sadhukhan
On Mon, 24 Jan 2022 09:38:09 GMT, Prasanta Sadhukhan wrote: > Few methods and classes were deprecated in JDK-8049700 where it was decided > to add forRemoval in jdk19. > Added "forRemoval" to start the process of removing in near future jdk > release. This pull request has now been integrate