On Tue, 15 Feb 2022 02:48:54 GMT, Manukumar V S wrote:
> Create a regression test for JDK-4514331.
> It checks whether pressing 'Tab' key always shift focus to next component,
> even though the current focus is in JTextArea and some text is already
> selected.
>
> Testing:
> I have verified th
> This test verifies in all platforms and in all 'Look and Feels' that pressing
> the 'Space' key generates ActionEvent on focused Button or not.
Manukumar V S has updated the pull request incrementally with one additional
commit since the last revision:
Fixed review comments: Updated code co
> Create a regression test for
> [JDK-4618767](https://bugs.openjdk.java.net/browse/JDK-4618767)
>
> Issue identified in
> [JDK-4618767](https://bugs.openjdk.java.net/browse/JDK-4618767):
> Typing a letter while a JList has focus now makes the selection jump to the
> first/next node/item whose
On Mon, 21 Feb 2022 18:13:12 GMT, Phil Race wrote:
> As per the bug evaluation, the root of this issue is that on this platform
> "char" is treated as "unsigned char"
> and the code here expects it to be "signed char", so we need to make it
> explicitly so.
> For all other supported platforms t
On Mon, 21 Feb 2022 18:13:12 GMT, Phil Race wrote:
> As per the bug evaluation, the root of this issue is that on this platform
> "char" is treated as "unsigned char"
> and the code here expects it to be "signed char", so we need to make it
> explicitly so.
> For all other supported platforms t
On Sun, 20 Feb 2022 17:04:39 GMT, Alexey Ivanov wrote:
> Drop redundant `text-align: left` from `` elements, which don't affect
> the table alignment. Then drop `text-align: center` from ` elements which
> counter-act the align set on the ``.
>
> Also drop `vertical-align: top` from table cell
> Issue in painting last row of JTable due to decrement in `MaxRow `during
> computation. Differences in `MaxRow `computation between `TablePrintable` and
> `BasicTableUI `class. The Bug is fixed in both the classes. Test Case added
> to validate the same.
Tejesh R has updated the pull request
On Sat, 19 Feb 2022 07:55:26 GMT, Manukumar V S wrote:
>> Create a regression test for JDK-4514331.
>> It checks whether pressing 'Tab' key always shift focus to next component,
>> even though the current focus is in JTextArea and some text is already
>> selected.
>>
>> Testing:
>> I have veri
On Sat, 12 Feb 2022 00:52:34 GMT, Anton Litvinov wrote:
>> src/java.desktop/share/classes/javax/swing/JTable.java line 5508:
>>
>>> 5506: (table != null) && table.isEnabled() &&
>>> 5507: table.isCellEditable(row, column)) {
>>> 5508:
On Thu, 17 Feb 2022 09:56:45 GMT, Srinivas Mandalika
wrote:
> Create a regression test for CCC8000326
>
> Issue is identified by
> [JDK-8000326](https://bugs.openjdk.java.net/browse/JDK-8000326), which
> identifies that after focus moves into JMenuBar, whose focus traversal key is
> disabled
On Fri, 11 Feb 2022 17:28:09 GMT, Srinivas Mandalika
wrote:
> Create tests for setMinimumSize functionality
> Create a test which verifies that on increasing the Frame's minimumSize, it
> gets reflected in the subsequent getSize call
> Create a test which verifies that on frame resizes back to
On Sat, 19 Feb 2022 07:47:34 GMT, Manukumar V S wrote:
>> This test verifies in all platforms and in all 'Look and Feels' that
>> pressing the 'Space' key generates ActionEvent on focused Button or not.
>
> Manukumar V S has updated the pull request incrementally with one additional
> commit si
On Sat, 19 Feb 2022 08:09:32 GMT, Manukumar V S wrote:
>> Create a regression test for
>> [JDK-4618767](https://bugs.openjdk.java.net/browse/JDK-4618767)
>>
>> Issue identified in
>> [JDK-4618767](https://bugs.openjdk.java.net/browse/JDK-4618767):
>> Typing a letter while a JList has focus now
On Sat, 19 Feb 2022 08:09:32 GMT, Manukumar V S wrote:
>> Create a regression test for
>> [JDK-4618767](https://bugs.openjdk.java.net/browse/JDK-4618767)
>>
>> Issue identified in
>> [JDK-4618767](https://bugs.openjdk.java.net/browse/JDK-4618767):
>> Typing a letter while a JList has focus now
On Mon, 17 Jan 2022 08:28:35 GMT, Erik Gahlin wrote:
>> src/jdk.jfr/share/classes/jdk/jfr/internal/TypeLibrary.java line 405:
>>
>>> 403: Object res = m.invoke(a, new Object[0]);
>>> 404: if (res instanceof Annotation[]) {
>>> 405:
As per the bug evaluation, the root of this issue is that on this platform
"char" is treated as "unsigned char"
and the code here expects it to be "signed char", so we need to make it
explicitly so.
For all other supported platforms this is a no-op since that is the default
elsewhere.
So this sh
On Tue, 8 Feb 2022 11:41:16 GMT, Daniel Jeliński wrote:
> This patch fixes jdk.accessibility compilation under VisualStudio 2019 with
> /Zc:strictStrings enabled.
>
> Strict string handling is already enabled in GCC and Clang. With some effort
> we should be able to enable it in MSVC as well.
On Mon, 14 Feb 2022 21:25:42 GMT, Daniel Jeliński wrote:
>> This patch fixes jdk.accessibility compilation under VisualStudio 2019 with
>> /Zc:strictStrings enabled.
>>
>> Strict string handling is already enabled in GCC and Clang. With some effort
>> we should be able to enable it in MSVC as
On Mon, 14 Feb 2022 21:25:42 GMT, Daniel Jeliński wrote:
>> This patch fixes jdk.accessibility compilation under VisualStudio 2019 with
>> /Zc:strictStrings enabled.
>>
>> Strict string handling is already enabled in GCC and Clang. With some effort
>> we should be able to enable it in MSVC as
Vote: yes
On 2/9/22 12:06, Philip Race wrote:
I hereby nominate Dmitry Markov (dmarkov) to Membership in the Client
Libraries Group.
Dmitry has worked in the client libraries sustaining team at Oracle
since 2013 and in that time
has contributed 61 client fixes [1], [2].
He has been active on
Vote: yes
On 2/9/22 12:06, Philip Race wrote:
I hereby nominate Alexey Ivanov (aivanov) to Membership in the Client
Libraries Group.
Alexey has worked in the client libraries sustaining team at Oracle
since 2014 and in that time
has contributed 60 client fixes [1], [2].
He has been active on
On Mon, 21 Feb 2022 10:03:30 GMT, Tejesh R wrote:
>> Issue in painting last row of JTable due to decrement in `MaxRow `during
>> computation. Differences in `MaxRow `computation between `TablePrintable`
>> and `BasicTableUI `class. The Bug is fixed in both the classes. Test Case
>> added to va
On Mon, 21 Feb 2022 05:50:06 GMT, Prasanta Sadhukhan
wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8236907: JTable added to nested panels does not paint last
>
> test/jdk/javax/swing/JTable/8236907/LastVisibleRow.ja
On Mon, 21 Feb 2022 07:57:32 GMT, Emmanuel Bourg wrote:
>> When a list of icons is set on a window, the most appropiate icon is
>> selected depending on the graphics configuration. But if the graphics
>> configuration changes (because the window is moved to a different screen, or
>> because th
On Mon, 21 Feb 2022 07:57:32 GMT, Emmanuel Bourg wrote:
>> When a list of icons is set on a window, the most appropiate icon is
>> selected depending on the graphics configuration. But if the graphics
>> configuration changes (because the window is moved to a different screen, or
>> because th
On Mon, 21 Feb 2022 12:53:35 GMT, Alexey Ivanov wrote:
>> Emmanuel Bourg has updated the pull request incrementally with five
>> additional commits since the last revision:
>>
>> - Test case for the window icon update on DPI change (other changes)
>> - Test case for the window icon update on
On Thu, 20 Jan 2022 01:34:20 GMT, Phil Race wrote:
>In short I see insufficient value in the changes here and would prefer you
>drop the client part so I don't have to worry about it.
I think, usage of `isInstance` is much clear for most java developers. Everyone
knows about java _instanceof_
On Thu, 13 Jan 2022 08:25:22 GMT, Andrey Turbanov wrote:
> Method `Class.isAssignableFrom` is often used in form of:
>
> if (clazz.isAssignableFrom(obj.getClass())) {
> Such condition could be simplified to more shorter and performarnt code
>
> if (clazz.isInstance(obj)) {
>
> Repl
On Thu, 10 Feb 2022 14:08:48 GMT, Maxim Kartashev wrote:
> The primary API for image capture on modern Linuxes is
> `gdk_pixbuf_get_from_window()` that expects both coordinates and the size
> unscaled (i.e. not multiplied by the current desktop scale). At the same
> time, `gtk3_interface.c:gtk
On Sun, 20 Feb 2022 08:01:28 GMT, Manukumar V S wrote:
> Call Robot.waitForIdle() after createUI and before getting the location of
> the JSpinner component in the test:
> javax/swing/JSpinner/4515999/JSpinnerMouseAndKeyPressTest.java.
>
> This is needed to ensure all the events for creating a
> Issue in painting last row of JTable due to decrement in `MaxRow `during
> computation. Differences in `MaxRow `computation between `TablePrintable` and
> `BasicTableUI `class. The Bug is fixed in both the classes. Test Case added
> to validate the same.
Tejesh R has updated the pull request
On Sun, 20 Feb 2022 08:01:28 GMT, Manukumar V S wrote:
> Call Robot.waitForIdle() after createUI and before getting the location of
> the JSpinner component in the test:
> javax/swing/JSpinner/4515999/JSpinnerMouseAndKeyPressTest.java.
>
> This is needed to ensure all the events for creating a
On Fri, 28 Jan 2022 09:38:35 GMT, Prasanta Sadhukhan
wrote:
> If we press " ´ " (on U.S. keyboard layout it is the [+] button just before
> the [delete] button), and then press "s" , 2 "´" characters are entered in a
> text field instead of "´s" with "Finish" keyboard layout.
> This is because
On Wed, 16 Feb 2022 07:44:27 GMT, Prasanta Sadhukhan
wrote:
> When invalid unicode codepoints 0x and 0x1 are added to an empty
> javax.swing.JTextComponent (JTextArea or JTextField), the view cannot be
> updated due to a NullPointerException in TextLayout.getBaselineFromGraphic()
> ow
On Mon, 14 Feb 2022 21:25:42 GMT, Daniel Jeliński wrote:
>> This patch fixes jdk.accessibility compilation under VisualStudio 2019 with
>> /Zc:strictStrings enabled.
>>
>> Strict string handling is already enabled in GCC and Clang. With some effort
>> we should be able to enable it in MSVC as
On Sun, 6 Feb 2022 19:53:45 GMT, Phil Race wrote:
>> Dmitry Batrak has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove 'headful' requirement from test case
>
>> As you say, one could possibly also try to compare font2DHandle-s instead
Vote : Yes
Thanks,
Jay
> On 10-Feb-2022, at 1:36 AM, Philip Race wrote:
>
> I hereby nominate Dmitry Markov (dmarkov) to Membership in the Client
> Libraries Group.
>
> Dmitry has worked in the client libraries sustaining team at Oracle since
> 2013 and in that time
> has contributed 61 clie
Vote : Yes
Thanks,
Jay
> On 10-Feb-2022, at 1:36 AM, Philip Race wrote:
>
> I hereby nominate Alexey Ivanov (aivanov) to Membership in the Client
> Libraries Group.
>
> Alexey has worked in the client libraries sustaining team at Oracle since
> 2014 and in that time
> has contributed 60 clie
38 matches
Mail list logo
