On Mon, 14 Feb 2022 20:12:39 GMT, Phil Race wrote:
>> Masanori Yano has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8275715: D3D pipeline processes multiple PaintEvent at initial drawing
>
> Ok. Please confirm you have run all automated
> Create tests for setMinimumSize functionality
> Create a test which verifies that on increasing the Frame's minimumSize, it
> gets reflected in the subsequent getSize call
> Create a test which verifies that on frame resizes back to minimumSize on
> calling pack.
Srinivas Mandalika has updated
On Tue, 1 Mar 2022 23:27:57 GMT, DamonGuy wrote:
>> Html does not fit in JButton at certain sizes because default Insets cause
>> html to be displayed off-center.
>>
>> Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable
>> clipping if html does not fit, similar to re
> Html does not fit in JButton at certain sizes because default Insets cause
> html to be displayed off-center.
>
> Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable
> clipping if html does not fit, similar to regular text. AquaButtonUI.java now
> detects when html d
On Tue, 1 Mar 2022 12:20:13 GMT, Alexey Ivanov wrote:
>> The text was also unexpectedly shifted, so this zero inset fixes that issue
>> as well. Setting the insets to zero for all HTML fixes the unwanted padding.
>
> Should we create a separate test for HTML text? Probably manual only but
> sti
On Tue, 1 Mar 2022 10:16:16 GMT, Prasanta Sadhukhan
wrote:
> Prevailing JDK coding practices use "@throws" rather than "@exception".
> Refactor existing swing classes javadoc to use @throws
Marked as reviewed by aivanov (Reviewer).
src/java.desktop/share/classes/javax/swing/JApplet.java line 1
On Tue, 1 Mar 2022 08:31:47 GMT, Prasanta Sadhukhan
wrote:
> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced Gulim
> korean font so it needs to be updated to show korean fonts
Is it OK to replace all of them? According to this document:
https://docs.microsoft.com/en-us/
On Sun, 20 Feb 2022 18:07:54 GMT, Alexey Ivanov wrote:
> Drops the redundant `` elements from tables and lists in java.desktop
> HTML files.
This pull request has now been integrated.
Changeset: b86a8c00
Author:Alexey Ivanov
URL:
https://git.openjdk.java.net/jdk/commit/b86a8c004f4e
On Fri, 25 Feb 2022 12:39:50 GMT, Emmanuel Bourg wrote:
>> When a list of icons is set on a window, the most appropiate icon is
>> selected depending on the graphics configuration. But if the graphics
>> configuration changes (because the window is moved to a different screen, or
>> because th
On Wed, 23 Feb 2022 21:15:02 GMT, Alexey Ivanov wrote:
> Does anyone have any comments or objections?
Having heard no comments, I'm integrating.
-
PR: https://git.openjdk.java.net/jdk/pull/7460
On Mon, 14 Feb 2022 14:04:33 GMT, Manukumar V S wrote:
> This test verifies in all platforms and in all 'Look and Feels' that pressing
> the 'Space' key generates ActionEvent on focused Button or not.
This pull request has now been integrated.
Changeset: 941e97c4
Author:Manukumar V S
Comm
On Mon, 28 Feb 2022 07:16:52 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/table/DefaultTableColumnModel.java
>> line 294:
>>
>>> 292: * at columnIndex
>>> 293: * @exception ArrayIndexOutOfBoundsException if
>>> columnIndex
>>
On Mon, 28 Feb 2022 07:24:27 GMT, Prasanta Sadhukhan
wrote:
>> If invalid ie 0 or > getColumnCount() index is passed to
>> DefaultTableColumnModel.getColumn() then it returns AIOBE in current
>> implementation which should be documented in the spec. Fixed the spec to
>> mention the exception.
On Mon, 28 Feb 2022 07:59:24 GMT, Prasanta Sadhukhan
wrote:
>> It is observed that mouseWheel doesn't scroll through a list if there is no
>> scrollbar even though pressing PageUp/Down using keyboard moves up/down the
>> list.
>> Issue stems from the fact that BasicScrollPaneUI.Handler.mouseWh
On Mon, 28 Feb 2022 08:02:39 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/javax/swing/JScrollPane/TestMouseWheelScroll.java line 80:
>>
>>> 78:
>>> scrollPane.setVerticalScrollBarPolicy(JScrollPane.VERTICAL_SCROLLBAR_NEVER);
>>> 79: frame.add(scrollPane);
On Mon, 28 Feb 2022 11:45:32 GMT, Srinivas Mandalika
wrote:
>> Create tests for setMinimumSize functionality
>> Create a test which verifies that on increasing the Frame's minimumSize, it
>> gets reflected in the subsequent getSize call
>> Create a test which verifies that on frame resizes back
On Thu, 3 Feb 2022 01:43:07 GMT, DamonGuy wrote:
> > The JBS says "This is reproducible with the Mac default (Aqua) look and
> > feel; using another LAF (Metal for instance) seems to position the
> > ImageView correctly." so it seems to be a mac issue not generic, so fixing
> > in shared code
On Mon, 28 Feb 2022 23:27:50 GMT, DamonGuy wrote:
>> Html does not fit in JButton at certain sizes because default Insets cause
>> html to be displayed off-center.
>>
>> Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable
>> clipping if html does not fit, similar to r
On Fri, 4 Feb 2022 02:55:02 GMT, DamonGuy wrote:
>> DamonGuy has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add cycling of all installed LAFs. Add image generation to avoid saving
>> an image to repo.
>> - Changed frame to dispose r
On Thu, 24 Feb 2022 09:26:48 GMT, Prasanta Sadhukhan
wrote:
>> DamonGuy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed incomplete comment.
>
> test/jdk/javax/swing/JButton/HtmlButtonImageTest/HtmlButtonImageTest.java
> line 85:
On Thu, 24 Feb 2022 16:07:41 GMT, DamonGuy wrote:
>> src/java.desktop/macosx/classes/com/apple/laf/AquaButtonUI.java line 313:
>>
>>> 311: // use zero insets for view since layout only handles text
>>> calculations
>>> 312: text = layoutAndGetText(g, b, aquaBorder, new
>
On Sat, 5 Feb 2022 18:16:34 GMT, Phil Race wrote:
>> DamonGuy has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add cycling of all installed LAFs. Add image generation to avoid saving
>> an image to repo.
>> - Changed frame to dispose
On Mon, 28 Feb 2022 23:27:50 GMT, DamonGuy wrote:
>> Html does not fit in JButton at certain sizes because default Insets cause
>> html to be displayed off-center.
>>
>> Changes made to SwingUtilities.java layoutCompoundLabelImpl method to enable
>> clipping if html does not fit, similar to r
Prevailing JDK coding practices use "@throws" rather than "@exception".
Refactor existing swing classes javadoc to use @throws
-
Commit messages:
- Fix
- Fix
- Fix
Changes: https://git.openjdk.java.net/jdk/pull/7644/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7644
Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced Gulim
korean font so it needs to be updated to show korean fonts
-
Commit messages:
- 8190907: Windows 10 default Korean Font Malgun Gothic available not used by
GUI elements even though available without Korea
25 matches
Mail list logo
