Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack

2022-03-02 Thread Prasanta Sadhukhan
On Wed, 2 Mar 2022 23:13:48 GMT, Phil Race wrote: > But is there a new Serif font available too ? I could not find any replacement for Batang serif font so have kept it same. > Bold version of Malgun Gothic in its own ttf file : Malgunbd.ttf So we should > start using that Added > Arabic sup

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v2]

2022-03-02 Thread Prasanta Sadhukhan
> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced Gulim > korean font so it needs to be updated to show korean fonts Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Add bold version - Chang

Re: RFR: 8282402: Create a regression test for JDK-4666101 [v2]

2022-03-02 Thread Manukumar V S
> Create a regression test for > [JDK-4666101](https://bugs.openjdk.java.net/browse/JDK-4666101). > > DESCRIPTION OF THE ACTUAL PROBLEM : > In a JEditorPane, the down arrow has no effect after you add text on a line > preceding a blank line. > > Testing: > As the original issue was reported in

Integrated: 8281569: Create tests for Frame.setMinimumSize() method

2022-03-02 Thread Srinivas Mandalika
On Fri, 11 Feb 2022 17:28:09 GMT, Srinivas Mandalika wrote: > Create tests for setMinimumSize functionality > Create a test which verifies that on increasing the Frame's minimumSize, it > gets reflected in the subsequent getSize call > Create a test which verifies that on frame resizes back to

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack

2022-03-02 Thread Phil Race
On Tue, 1 Mar 2022 08:31:47 GMT, Prasanta Sadhukhan wrote: > Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced Gulim > korean font so it needs to be updated to show korean fonts There's no chaining mechanism in the way you describe it .. it would have to be in our fallba

RFR: 8282577: ICC_Profile.setTagData() invalidates the profile

2022-03-02 Thread Phil Race
As per the bug eval, we are returning a pointer to a native raw LittleCMS profile and it should be a cooked one. The simple test fails before the fix with ~/jdk17/Contents/Home/bin/java SetTagDataValidation Exception in thread "main" java.awt.color.CMMException: LCM

Re: RFR: 8281284 : Write JSlider accessibility test [v4]

2022-03-02 Thread lawrence . andrews
> This testcase covers both old and new api ( api added in jdk17 > getAccessibleAction(), getAccessibleActionCount() , > getAccessibleActionDescription ) > > @shurymury > @savoptik lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8281284 : Write JSlider accessibility test [v2]

2022-03-02 Thread lawrence . andrews
On Wed, 23 Feb 2022 02:03:24 GMT, lawrence.andrews wrote: >> test/jdk/javax/accessibility/JSlider/JSliderAccessibilityTest.java line 68: >> >>> 66: frame.setLocationRelativeTo(null); >>> 67: frame.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE); >>> 68: frame.setVisibl

Re: RFR: 8281284 : Write JSlider accessibility test [v2]

2022-03-02 Thread lawrence . andrews
On Sun, 6 Feb 2022 08:22:04 GMT, Sergey Bylokhov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added @key headful > > test/jdk/javax/accessibility/JSlider/JSliderAccessibilityTest.java line 2: > >> 1: /* >>

Re: RFR: 8281284 : Write JSlider accessibility test [v3]

2022-03-02 Thread lawrence . andrews
> This testcase covers both old and new api ( api added in jdk17 > getAccessibleAction(), getAccessibleActionCount() , > getAccessibleActionDescription ) > > @shurymury > @savoptik lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8277817: java/awt/dnd/BadSerializationTest/BadSerializationTest.java failed: ClassNotFoundException: com.apple.laf.AquaImageFactory$SystemColorProxy [v10]

2022-03-02 Thread Liam Miller-Cushon
On Tue, 1 Feb 2022 16:55:16 GMT, Liam Miller-Cushon wrote: > Hi, is there any feedback on this change, or the alternate fix in #7100 that > updates the binary files, or the related cleanup in #7099? Friendly ping. My opinion is that https://github.com/openjdk/jdk/pull/7099 is a clear improvem

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack

2022-03-02 Thread Naoto Sato
On Tue, 1 Mar 2022 08:31:47 GMT, Prasanta Sadhukhan wrote: > Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced Gulim > korean font so it needs to be updated to show korean fonts I thought there is some mechanism to chain physical fonts, such as if `glim.ttc` is not avail

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor

2022-03-02 Thread Alisen Chung
On Mon, 14 Feb 2022 23:26:25 GMT, Sergey Bylokhov wrote: >> I think there's a rounding error when doing x.5 scalings causing the drawing >> area to be one pixel too small on the left side > > Can you please check how it will work for the undecorated frame, if it will > be fine then the problem

Re: RFR: 8282473: Refactor swing classes javadoc to use @throws instead of @exception

2022-03-02 Thread Alexey Ivanov
On Tue, 1 Mar 2022 20:13:30 GMT, Alexey Ivanov wrote: >> Prevailing JDK coding practices use "@throws" rather than "@exception". >> Refactor existing swing classes javadoc to use @throws > > src/java.desktop/share/classes/javax/swing/JRootPane.java line 582: > >> 580: * @param content the C

Re: RFR: 8282473: Refactor swing classes javadoc to use @throws instead of @exception

2022-03-02 Thread Alexey Ivanov
On Tue, 1 Mar 2022 10:16:16 GMT, Prasanta Sadhukhan wrote: > Prevailing JDK coding practices use "@throws" rather than "@exception". > Refactor existing swing classes javadoc to use @throws Submitted: - [JDK-8282539](https://bugs.openjdk.java.net/browse/JDK-8282539): Remove ending punctuation

Re: RFR: 6911375: mouseWheel has no effect without vertical scrollbar [v3]

2022-03-02 Thread Alexey Ivanov
On Wed, 2 Mar 2022 13:14:08 GMT, Prasanta Sadhukhan wrote: >> I see, thank you for explanation. Does it make sense to put the test in >> ProblemList.txt for macOS, so that it's not forgotten the test is to be run >> on macOS too? > > We problemlist a test if it fails in a particular platform w

Re: RFR: 6911375: mouseWheel has no effect without vertical scrollbar [v3]

2022-03-02 Thread Prasanta Sadhukhan
On Tue, 1 Mar 2022 16:41:18 GMT, Alexey Ivanov wrote: >> This testcase was failing on macos which needs to be debugged, so it is >> excluded in mac for now. But as I told in description, the fix is not >> affecting other regression test in macos. >> It's working on other platforms and I have so

Re: RFR: 6911375: mouseWheel has no effect without vertical scrollbar [v2]

2022-03-02 Thread Prasanta Sadhukhan
On Tue, 1 Mar 2022 16:38:30 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix test comments > > test/jdk/javax/swing/JScrollPane/TestMouseWheelScroll.java line 48: > >> 46: static Po

Re: RFR: 6911375: mouseWheel has no effect without vertical scrollbar [v3]

2022-03-02 Thread Prasanta Sadhukhan
> It is observed that mouseWheel doesn't scroll through a list if there is no > scrollbar even though pressing PageUp/Down using keyboard moves up/down the > list. > Issue stems from the fact that BasicScrollPaneUI.Handler.mouseWheelMoved() > skips the mouse wheel events when the scrollbar is no

Re: RFR: 6911375: mouseWheel has no effect without vertical scrollbar [v3]

2022-03-02 Thread Alexey Ivanov
On Wed, 2 Mar 2022 13:17:28 GMT, Prasanta Sadhukhan wrote: >> It is observed that mouseWheel doesn't scroll through a list if there is no >> scrollbar even though pressing PageUp/Down using keyboard moves up/down the >> list. >> Issue stems from the fact that BasicScrollPaneUI.Handler.mouseWhe

Re: RFR: 8281569: Create tests for Frame.setMinimumSize() method [v7]

2022-03-02 Thread Srinivas Mandalika
On Wed, 2 Mar 2022 09:52:45 GMT, Alexey Ivanov wrote: >> Srinivas Mandalika has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review comments fixed: field declared on different line, finally block on >> same line, changed to +=,.. > > Mar

Re: RFR: 8282473: Refactor swing classes javadoc to use @throws instead of @exception

2022-03-02 Thread Dmitry Markov
On Tue, 1 Mar 2022 10:16:16 GMT, Prasanta Sadhukhan wrote: > Prevailing JDK coding practices use "@throws" rather than "@exception". > Refactor existing swing classes javadoc to use @throws Marked as reviewed by dmarkov (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7644

Re: RFR: 8281569: Create tests for Frame.setMinimumSize() method [v7]

2022-03-02 Thread Alexey Ivanov
On Wed, 2 Mar 2022 06:10:42 GMT, Srinivas Mandalika wrote: >> Create tests for setMinimumSize functionality >> Create a test which verifies that on increasing the Frame's minimumSize, it >> gets reflected in the subsequent getSize call >> Create a test which verifies that on frame resizes back

Re: RFR: 8282473: Refactor swing classes javadoc to use @throws instead of @exception

2022-03-02 Thread Prasanta Sadhukhan
On Tue, 1 Mar 2022 10:16:16 GMT, Prasanta Sadhukhan wrote: > Prevailing JDK coding practices use "@throws" rather than "@exception". > Refactor existing swing classes javadoc to use @throws No, you can submit.. - PR: https://git.openjdk.java.net/jdk/pull/7644

Re: RFR: 8282473: Refactor swing classes javadoc to use @throws instead of @exception

2022-03-02 Thread Alexey Ivanov
On Wed, 2 Mar 2022 09:25:35 GMT, Prasanta Sadhukhan wrote: > I would rather keep this PR simple just to replace @exception with @throws. > Other anomalies/idiosyncracies can be tackled in separate issue, if you dont > mind. I didn't make myself clear: I absolutely agree with your approach. If

Re: RFR: 8282473: Refactor swing classes javadoc to use @throws instead of @exception

2022-03-02 Thread Prasanta Sadhukhan
On Tue, 1 Mar 2022 10:16:16 GMT, Prasanta Sadhukhan wrote: > Prevailing JDK coding practices use "@throws" rather than "@exception". > Refactor existing swing classes javadoc to use @throws I would rather keep this PR simple just to replace @exception with @throws. Other anomalies/idiosyncraci

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack

2022-03-02 Thread Prasanta Sadhukhan
On Tue, 1 Mar 2022 08:31:47 GMT, Prasanta Sadhukhan wrote: > Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced Gulim > korean font so it needs to be updated to show korean fonts Malgun Gothic is supposed to be the default korean font replacing Gulim as per the wiki menti