Re: RFR: 8282234: Create a regression test for JDK-4532513 [v6]

2022-03-07 Thread Manukumar V S
> Create a regression test for > [JDK-4532513](https://bugs.openjdk.java.net/browse/JDK-4532513). > This test verifies that the DefaultCaret doesn't requests focus in mouseClick > and mousePressed causing the associated input verifier to fire twice. > As per [JDK-4532513](https://bugs.openjdk.jav

Re: RFR: 8281284 : Write JSlider accessibility test [v5]

2022-03-07 Thread lawrence . andrews
On Tue, 8 Mar 2022 04:34:35 GMT, Sergey Bylokhov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> run the on windows and mac > > test/jdk/java/awt/a11y/AccessibleJSliderTest.java line 2: > >> 1: /* >> 2: * Cop

Re: RFR: 8281284 : Write JSlider accessibility test [v6]

2022-03-07 Thread lawrence . andrews
> This testcase covers both old and new api ( api added in jdk17 > getAccessibleAction(), getAccessibleActionCount() , > getAccessibleActionDescription ) > > @shurymury > @savoptik lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8282771 : Create test case for JDK-8262981 [v2]

2022-03-07 Thread lawrence . andrews
> Following methods are covered in this testcase > getAccessibleAction() > getAccessibleActionCount() > getAccessibleActionDescription() > doAccessibleAction(int direction) > > @shurymury lawrence.andrews has updated the pull request incrementally with one additional commit since the last revis

Re: RFR: 8282577: ICC_Profile.setData(int, byte[]) invalidates the profile [v3]

2022-03-07 Thread Sergey Bylokhov
On Thu, 3 Mar 2022 21:27:36 GMT, Phil Race wrote: >> As per the bug eval, we are returning a pointer to a native raw LittleCMS >> profile and it should be a cooked one. >> The simple test fails before the fix with >> ~/jdk17/Contents/Home/bin/java SetTagDataValidation >

Re: RFR: 8282270: java/awt/Robot Screen Capture tests fail after 8280861 [v2]

2022-03-07 Thread Sergey Bylokhov
On Sat, 5 Mar 2022 08:27:10 GMT, Maxim Kartashev wrote: >> test/jdk/java/awt/Robot/HiDPIScreenCapture/ScreenCaptureGtkTest.java line 44: >> >>> 42: * @run main/othervm -Djdk.gtk.version=2 -Dsun.java2d.uiScale=1 >>> ScreenCaptureGtkTest >>> 43: * @run main/othervm -Djdk.gtk.version=3 -Dsun.jav

Re: RFR: 8281284 : Write JSlider accessibility test [v5]

2022-03-07 Thread Sergey Bylokhov
On Thu, 3 Mar 2022 17:11:39 GMT, lawrence.andrews wrote: >> This testcase covers both old and new api ( api added in jdk17 >> getAccessibleAction(), getAccessibleActionCount() , >> getAccessibleActionDescription ) >> >> @shurymury >> @savoptik > > lawrence.andrews has updated the pull reques

Re: RFR: 8280468: Crashes in getConfigColormap, getConfigVisualId, XVisualIDFromVisual on Linux

2022-03-07 Thread Sergey Bylokhov
On Fri, 21 Jan 2022 17:02:38 GMT, Maxim Kartashev wrote: > These crashes were not reproducible, so the fix is based on a hypothesis that > there are two possible reasons for them: > 1. `makeDefaultConfig()` returning `NULL`. > 2. A race condition when the number of screens changes. > The race sc

Re: RFR: 8282577: ICC_Profile.setData(int, byte[]) invalidates the profile [v3]

2022-03-07 Thread Sergey Bylokhov
On Thu, 3 Mar 2022 21:27:36 GMT, Phil Race wrote: >> As per the bug eval, we are returning a pointer to a native raw LittleCMS >> profile and it should be a cooked one. >> The simple test fails before the fix with >> ~/jdk17/Contents/Home/bin/java SetTagDataValidation >

Re: RFR: 8249592 : Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode [v2]

2022-03-07 Thread Sergey Bylokhov
On Tue, 8 Mar 2022 03:04:40 GMT, Rajat Mahajan wrote: >> 8249592 : Robot.mouseMove moves cursor to incorrect location when display >> scale varies and Java runs in DPI Unaware mode > > Rajat Mahajan has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: 8249592 : Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode [v2]

2022-03-07 Thread Rajat Mahajan
> 8249592 : Robot.mouseMove moves cursor to incorrect location when display > scale varies and Java runs in DPI Unaware mode Rajat Mahajan has updated the pull request incrementally with one additional commit since the last revision: removed stdlib.h, not needed - Changes: - a

RFR: 8249592 : Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode

2022-03-07 Thread Rajat Mahajan
8249592 : Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode - Commit messages: - 8249592: Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode - 8249592: Robot.mo

RFR: 8282771 : Create test case for JDK-8262981

2022-03-07 Thread lawrence . andrews
Following methods are covered in this testcase getAccessibleAction() getAccessibleActionCount() getAccessibleActionDescription() doAccessibleAction(int direction) @shurymury - Commit messages: - Fixed white issue - 8282771 : Create test case for JDK-8262981 Changes: https://git.o

Integrated: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-07 Thread Matteo Baccan
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo This pull request has now been integrated. Changeset: ccad3923 Author:Matteo Baccan Committer: Magnus Ihse Bursie URL:

Re: RFR: 8282234: Create a regression test for JDK-4532513 [v5]

2022-03-07 Thread Alexey Ivanov
On Mon, 7 Mar 2022 10:25:59 GMT, Manukumar V S wrote: >> Create a regression test for >> [JDK-4532513](https://bugs.openjdk.java.net/browse/JDK-4532513). >> This test verifies that the DefaultCaret doesn't requests focus in >> mouseClick and mousePressed causing the associated input verifier to

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-07 Thread Kevin Rushforth
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo But as the JBS title and PR title now match, this is a moot point. - PR: https://git.openjdk.java.net/jdk/pull/726

Re: RFR: 8276058: Some swing test fails on specific CI macos system [v3]

2022-03-07 Thread Phil Race
On Fri, 29 Oct 2021 06:43:38 GMT, Prasanta Sadhukhan wrote: >> As per JDK-8252813, some tests fails recurringly in CI macos system. This is >> an attempt to fix the swing tests. >> It was seen from the logs that we have color mismatch in these tests. >> >> For example, in PressedIcon test, we

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-07 Thread Kevin Rushforth
On Mon, 7 Mar 2022 17:12:25 GMT, Magnus Ihse Bursie wrote: > TheShermanTanker is not the author of this PR, he's just assisting the author > by creating the JBS issue. Ah, that explains it then. - PR: https://git.openjdk.java.net/jdk/pull/7268

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-07 Thread Magnus Ihse Bursie
On Mon, 7 Mar 2022 16:40:15 GMT, Lance Andersen wrote: >> Hi >> >> I have reviewed the code for removing double semicolons at the end of lines >> >> all the best >> matteo > > What problem are you having editing the PR header? You should be able to do > so as the author of the PR @LanceAnde

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-07 Thread Kevin Rushforth
On Mon, 7 Mar 2022 16:40:15 GMT, Lance Andersen wrote: > What problem are you having editing the PR header? You should be able to do > so as the author of the PR Exactly. You should see an "Edit" button near the right edge of the PR title. See the attached image: ![PR-title](https://user-imag

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-07 Thread Lance Andersen
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo What problem are you having editing the PR header? You should be able to do so as the author of the PR - PR: ht

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-07 Thread Julian Waters
On Mon, 7 Mar 2022 13:40:48 GMT, Erik Joelsson wrote: > > Should I change the JBS issue title to match the PR title, or is it > > preferred for the PR title to change? > > They need to match. You can either do it manually, or change the title to > just the bug number and the bot will change it

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

2022-03-07 Thread Erik Joelsson
On Sat, 5 Mar 2022 06:49:16 GMT, Julian Waters wrote: > Should I change the JBS issue title to match the PR title, or is it preferred > for the PR title to change? They need to match. You can either do it manually, or change the title to just the bug number and the bot will change it for you.

Re: RFR: 8282234: Create a regression test for JDK-4532513 [v5]

2022-03-07 Thread Manukumar V S
> Create a regression test for > [JDK-4532513](https://bugs.openjdk.java.net/browse/JDK-4532513). > This test verifies that the DefaultCaret doesn't requests focus in mouseClick > and mousePressed causing the associated input verifier to fire twice. > As per [JDK-4532513](https://bugs.openjdk.jav