Re: RFR: JDK-8283015: Create a test for JDK-4715496 [v2]

2022-03-13 Thread Srinivas Mandalika
> Create a test for JDK-4715496 > > Issue observed in the above bug is that the > JTable.AccessibleJTableCell.getAccessible name returns the cell instance > string instead of the cell text. > The test is being added to verify the same. > This review is for migrating tests from a closed test suit

Re: RFR: JDK-8282933: Create a test for JDK-4529616 [v2]

2022-03-13 Thread Srinivas Mandalika
> JDK-8282933: Create a test for JDK-4529616 > AccessibleJTableCell.isShowing() returns false when the cell is actually on > the screen. > The test validates the fix for the above issue by verifying that the > isShowing call returns true when invoked via the accessiblity context. > This review i

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v3]

2022-03-13 Thread Dmitry Batrak
On Fri, 4 Mar 2022 05:07:44 GMT, Prasanta Sadhukhan wrote: >> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced >> Gulim korean font so it needs to be updated to show korean fonts > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional comm

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v3]

2022-03-13 Thread Prasanta Sadhukhan
On Fri, 11 Mar 2022 18:25:02 GMT, Dmitry Batrak wrote: > It's a bit hard to talk about 'fallback' fonts here without confusion, as > this word might mean at least two things - we have Korean fallback fonts, in > a sense that `sequence.fallback` contains `korean` entry, so all logical > fonts a

Re: RFR: 8282526: Default icon is not painted properly

2022-03-13 Thread Jeremy
On Sun, 13 Mar 2022 21:06:24 GMT, Alexander Zuev wrote: > Detect the situation where we do need to perform interpolation during > ImageIcon > painting and set a hint to the rendering to perform bicubic approximation so > image details are preserved during transition. test/jdk/javax/swing/ImageI

Re: RFR: 8282526: Default icon is not painted properly

2022-03-13 Thread Alexander Zuev
On Sun, 13 Mar 2022 23:28:01 GMT, Jeremy wrote: > This might be a rookie question: > > When it comes to modifying and restoring a Graphics, I've seen two common > patterns: A. Call `newG = g.create()` and later `newG.dispose()` B. Call > `g.setX(newValue)` and then call `g.setX(oldValue)` late

Re: RFR: 8282526: Default icon is not painted properly

2022-03-13 Thread Jeremy
On Sun, 13 Mar 2022 21:06:24 GMT, Alexander Zuev wrote: > Detect the situation where we do need to perform interpolation during > ImageIcon > painting and set a hint to the rendering to perform bicubic approximation so > image details are preserved during transition. src/java.desktop/share/clas

Re: RFR: 8282526: Default icon is not painted properly

2022-03-13 Thread Alexander Zuev
On Sun, 13 Mar 2022 21:06:24 GMT, Alexander Zuev wrote: > Detect the situation where we do need to perform interpolation during > ImageIcon > painting and set a hint to the rendering to perform bicubic approximation so > image details are preserved during transition. The icon returned by the sy

RFR: 8282526: Default icon is not painted properly

2022-03-13 Thread Alexander Zuev
Detect the situation where we do need to perform interpolation during ImageIcon painting and set a hint to the rendering to perform bicubic approximation so image details are preserved during transition. - Commit messages: - 8282526: Default icon is not painted properly Changes: htt

RFR: 8282937: Write a regression test for JDK-4820080

2022-03-13 Thread Manukumar V S
Write a regression test for [JDK-4820080](https://bugs.openjdk.java.net/browse/JDK-4820080) : RFE: Cannot Change the JSplitPane Divider Color while dragging Issue(as per bug description): I want to change the color of the JSplitPane divider. I opened the code and found that, the color is hard co

RFR: 8282936: Write a regression test for JDK-4615365

2022-03-13 Thread Manukumar V S
Write a regression test for [JDK-4615365](https://bugs.openjdk.java.net/browse/JDK-4615365) : JSplitPane current and last divider positions incorrect when realized Issue: JSplitPane component with a left and right component has its current divider position incorrectly set to -1 once it is fully

Re: RFR: 8282860: Write a regression test for JDK-4164779 [v2]

2022-03-13 Thread Manukumar V S
> Write a regression test for > [JDK-4164779](https://bugs.openjdk.java.net/browse/JDK-4164779) : JSplitPane > keyboard navigation does not support F6 and Ctrl+Tab > Context: Migrating tests from a closed tonga based test suite to open > regression based one. > > Issue: > The specified keyboard

RFR: 8282860: Write a regression test for JDK-4164779

2022-03-13 Thread Manukumar V S
Write a regression test for [JDK-4164779](https://bugs.openjdk.java.net/browse/JDK-4164779) : JSplitPane keyboard navigation does not support F6 and Ctrl+Tab Context: Migrating tests from a closed tonga based test suite to open regression based one. Issue: The specified keyboard support for JSp