Re: RFR: 8282270: java/awt/Robot Screen Capture tests fail after 8280861 [v3]

2022-03-15 Thread Maxim Kartashev
On Tue, 15 Mar 2022 17:38:37 GMT, Alexey Ivanov wrote: > The test is run on Linux, so it makes sense to keep Linux in the summary. True; will rectify that. > Why do you remove 8280861 from the list of bugs? While the test technically executes the lines of code changed for 8280861, I cannot im

Re: RFR: 8282270: java/awt/Robot Screen Capture tests fail after 8280861 [v2]

2022-03-15 Thread Maxim Kartashev
On Tue, 15 Mar 2022 18:33:52 GMT, Alexey Ivanov wrote: > You mentioned uiScale=3 doesn't work correctly. Does it not work with > uiScale=2 either? > > Is it proven the test can't get the colored pixels precisely with uiScale=2? Yes to both. - PR: https://git.openjdk.java.net/jdk/

Re: RFR: 8282937: Write a regression test for JDK-4820080

2022-03-15 Thread Manukumar V S
On Wed, 16 Mar 2022 05:53:50 GMT, Sergey Bylokhov wrote: >> Write a regression test for >> [JDK-4820080](https://bugs.openjdk.java.net/browse/JDK-4820080) : RFE: >> Cannot Change the JSplitPane Divider Color while dragging >> >> Issue(as per bug description): >> I want to change the color of t

Re: RFR: JDK-8283087: Create a test or JDK-4715503

2022-03-15 Thread Sergey Bylokhov
On Mon, 14 Mar 2022 09:28:50 GMT, Srinivas Mandalika wrote: > Create a test or > [JDK-4715503](https://bugs.openjdk.java.net/browse/JDK-4715503) > > The getAccessibleContext method for JTable column header cells returns an > AccessibleContext which cannot get the Bounding Rectangle for table

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v3]

2022-03-15 Thread Prasanta Sadhukhan
On Mon, 14 Mar 2022 18:19:19 GMT, Phil Race wrote: > > It seems then if we have > > allfonts.korean-fallback=Malgun Gothic > > and add this korean-fallback to sequence.fallback instead of korean then I > > guess we can have fix for both. > > Will this be accepted change? > > It is fine by me. I

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v4]

2022-03-15 Thread Prasanta Sadhukhan
> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced Gulim > korean font so it needs to be updated to show korean fonts Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: korean fallback added -

Re: RFR: 8282937: Write a regression test for JDK-4820080

2022-03-15 Thread Sergey Bylokhov
On Sun, 13 Mar 2022 14:07:22 GMT, Manukumar V S wrote: > Write a regression test for > [JDK-4820080](https://bugs.openjdk.java.net/browse/JDK-4820080) : RFE: Cannot > Change the JSplitPane Divider Color while dragging > > Issue(as per bug description): > I want to change the color of the JSpli

Re: RFR: 8282526: Default icon is not painted properly

2022-03-15 Thread Sergey Bylokhov
On Mon, 14 Mar 2022 01:47:20 GMT, Alexander Zuev wrote: >> src/java.desktop/share/classes/javax/swing/ImageIcon.java line 463: >> >>> 461: if (hintChanged) { >>> 462: ((Graphics2D) >>> g).setRenderingHint(RenderingHints.KEY_INTERPOLATION, >>> 463: oldHint

client-libs-dev@openjdk.java.net

2022-03-15 Thread Sergey Bylokhov
On Sat, 12 Mar 2022 01:27:34 GMT, DamonGuy wrote: > Apple Pages has no support at all for these table navigation functions other > than `COMMAND+LEFT_CLICK`. Excel has a selection mode that can be toggled > on/off using SHIFT+F8. I also tested in macOS's `System Preferences > > Keyboard > Text

Integrated: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled

2022-03-15 Thread Toshio Nakamura
On Thu, 22 Apr 2021 09:21:20 GMT, Toshio Nakamura wrote: > Hi, > > Could you review the fix? > When non-English characters were printed from JTable on MacOS, > CTextPipe.doDrawGlyphs was called by OSXSurfaceData.drawGlyphs. However, > CTextPipe seems not support glyph with slot number of compo

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v3]

2022-03-15 Thread lukeu
On Mon, 14 Mar 2022 16:15:47 GMT, Alisen Chung wrote: >> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > added functions for drawing b

Re: RFR: 8283217: Leak FcObjectSet in getFontConfigLocations() in fontpath.c [v2]

2022-03-15 Thread Zhengyu Gu
> Please review this small patch to fix leaking of `FcObjectSet` in > `getFontConfigLocations()` > > > Test: > - [x] jdk_2d Zhengyu Gu has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merg

Re: RFR: 8257733: Move module-specific data from make to respective module [v6]

2022-03-15 Thread Magnus Ihse Bursie
On Tue, 15 Mar 2022 23:50:20 GMT, Magnus Ihse Bursie wrote: >> A lot (but not all) of the data in make/data is tied to a specific module. >> For instance, the publicsuffixlist is used by java.base, and fontconfig by >> java.desktop. (A few directories, like mainmanifest, is *actually* used by

Re: RFR: 8257733: Move module-specific data from make to respective module [v5]

2022-03-15 Thread Magnus Ihse Bursie
On Mon, 18 Jan 2021 13:47:20 GMT, Magnus Ihse Bursie wrote: >> A lot (but not all) of the data in make/data is tied to a specific module. >> For instance, the publicsuffixlist is used by java.base, and fontconfig by >> java.desktop. (A few directories, like mainmanifest, is *actually* used by

Re: RFR: 8257733: Move module-specific data from make to respective module [v6]

2022-03-15 Thread Magnus Ihse Bursie
> A lot (but not all) of the data in make/data is tied to a specific module. > For instance, the publicsuffixlist is used by java.base, and fontconfig by > java.desktop. (A few directories, like mainmanifest, is *actually* used by > make for the whole build.) > > These data files should move t

RFR: 8283217: Leak FcObjectSet in getFontConfigLocations() in fontpath.c

2022-03-15 Thread Zhengyu Gu
Please review this small patch to fix leaking of `FcObjectSet` in `getFontConfigLocations()` Test: - [x] jdk_2d - Commit messages: - v0 Changes: https://git.openjdk.java.net/jdk/pull/7826/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=7826&range=00 Issue: https:

Re: RFR: 8282270: java/awt/Robot Screen Capture tests fail after 8280861 [v3]

2022-03-15 Thread Alexey Ivanov
On Wed, 9 Mar 2022 15:04:13 GMT, Maxim Kartashev wrote: > > Does it make sense to run all the checks before throwing the exception? > > I mean run all the checks that the test performs and accumulate failures if > > any. If the list of failures isn't empty, throw an exception to fail the > > en

Re: RFR: 8282270: java/awt/Robot Screen Capture tests fail after 8280861 [v3]

2022-03-15 Thread Alexey Ivanov
On Wed, 9 Mar 2022 13:35:44 GMT, Maxim Kartashev wrote: >> The two tests `ScreenCaptureGtkTest.java` and >> `HiDPIRobotScreenCaptureTest.java` under `java/awt/Robot/HiDPIScreenCapture` >> started to intermittently fail under Windows and Linux after the [recent >> changes](https://github.com/op

Re: RFR: 8282270: java/awt/Robot Screen Capture tests fail after 8280861 [v2]

2022-03-15 Thread Alexey Ivanov
On Wed, 9 Mar 2022 07:01:57 GMT, Maxim Kartashev wrote: >> you can check both cases, if the scale=1 then use high precision. >> if the scale > 1 then you can use low precision -> if the scale is equal to >> 2 then shift by two/four pixels or something like that? > >> if the scale > 1 then you ca

Re: RFR: 8282270: java/awt/Robot Screen Capture tests fail after 8280861 [v3]

2022-03-15 Thread Alexey Ivanov
On Thu, 10 Mar 2022 11:22:15 GMT, Maxim Kartashev wrote: >> Maxim Kartashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> HiDPIRobotScreenCaptureTest.java: smaller frame size such that it fits on >> a 1200x600 screen. >> >> Scree

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v3]

2022-03-15 Thread lukeu
On Mon, 14 Mar 2022 16:15:47 GMT, Alisen Chung wrote: >> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > added functions for drawing b

Re: RFR: 8282270: java/awt/Robot Screen Capture tests fail after 8280861 [v3]

2022-03-15 Thread Alexey Ivanov
On Fri, 11 Mar 2022 18:46:25 GMT, Phil Race wrote: > I recognise that positioning is another issue but I've never seen a window > manager position a window so that it is partially off-screen unless it cannot > fit ! Windows allows positioning a window so that it's partially or completely off

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-15 Thread Alexey Ivanov
On Tue, 15 Mar 2022 16:42:41 GMT, Alexey Ivanov wrote: >> A small file from local storage loads fast enough. By the time you get to >> read status, load could complete. >> >> For the url, do you use the same URL? If the connection can be established, >> it should load pretty fast too. However,

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-15 Thread Alexey Ivanov
On Tue, 15 Mar 2022 12:00:33 GMT, Alexey Ivanov wrote: >> For url image I'm getting "ERRORED" as output.. > > A small file from local storage loads fast enough. By the time you get to > read status, load could complete. > > For the url, do you use the same URL? If the connection can be esta

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-15 Thread Tejesh R
On Tue, 15 Mar 2022 12:00:33 GMT, Alexey Ivanov wrote: >> For url image I'm getting "ERRORED" as output.. > > A small file from local storage loads fast enough. By the time you get to > read status, load could complete. > > For the url, do you use the same URL? If the connection can be esta

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-15 Thread Tejesh R
On Tue, 15 Mar 2022 12:00:33 GMT, Alexey Ivanov wrote: >> For url image I'm getting "ERRORED" as output.. > > A small file from local storage loads fast enough. By the time you get to > read status, load could complete. > > For the url, do you use the same URL? If the connection can be esta

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-15 Thread Tejesh R
On Tue, 15 Mar 2022 12:09:12 GMT, Tejesh R wrote: >> A small file from local storage loads fast enough. By the time you get to >> read status, load could complete. >> >> For the url, do you use the same URL? If the connection can be established, >> it should load pretty fast too. However, if y

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-15 Thread Alexey Ivanov
On Tue, 15 Mar 2022 11:48:23 GMT, Tejesh R wrote: >> I have loaded gif image from local storage. >> >> INTERRUPTED while loading Image >> false >> COMPLETE > > For url image I'm getting "ERRORED" as output.. A small file from local storage loads fast enough. By the time you get to r

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-15 Thread Tejesh R
On Tue, 15 Mar 2022 09:43:13 GMT, Alexey Ivanov wrote: >> @aivanov-jdk , even after interrupted the load status gets the "COMPLETE" >> status and I'm able to use the Imageicon for frame.. > > @TejeshR13, What kind of image do you load? > > If I load an image from the Internet, I get `LOADIN

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-15 Thread Tejesh R
On Tue, 15 Mar 2022 11:47:28 GMT, Tejesh R wrote: >> @TejeshR13, What kind of image do you load? >> >> If I load an image from the Internet, I get `LOADING` status. I've attached >> `ImageIconInterrupt.java` to >> [JDK-6421373](https://bugs.openjdk.java.net/browse/JDK-6421373). It produces >>

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-03-15 Thread Alexey Ivanov
On Tue, 15 Mar 2022 06:09:40 GMT, Tejesh R wrote: >> Since the image is removed from MediaTracker, its status can't change after >> that. Therefore `LOADING` status should be changed to `ABORTED`. >> [JDK-6421373](https://bugs.openjdk.java.net/browse/JDK-6421373) has a test >> case which can be

Re: RFR: 8282548: Create a regression test for JDK-4330998

2022-03-15 Thread Manukumar V S
On Tue, 8 Mar 2022 10:06:23 GMT, Manukumar V S wrote: > Create a regression test for > [JDK-4330998](https://bugs.openjdk.java.net/browse/JDK-4330998) > Context: Migrating tests from a closed tonga based test suite to open > regression based one. > > Issue tested: > When calling JEditorPane.se

Re: RFR: 8282789: Create a regression test for the JTree usecase of JDK-4618767

2022-03-15 Thread Manukumar V S
On Tue, 8 Mar 2022 10:52:44 GMT, Manukumar V S wrote: > Create a regression test for the JTree usecase of > [JDK-4618767](https://bugs.openjdk.java.net/browse/JDK-4618767) > Context: Migrating tests from a closed tonga based test suite to open > regression based one. > > Issue identified in >

client-libs-dev@openjdk.java.net

2022-03-15 Thread Alexander Zuev
On Fri, 11 Mar 2022 23:13:15 GMT, DamonGuy wrote: > Aqua L&F tables lacked support for `CTRL+ARROW`, `CTRL+PG_UP/DOWN`, and > `CTRL+SHIFT+PG_UP/DOWN` key bindings. This allows for navigation and > selection of table cells without the need of a mouse and without deselecting > the current select