Re: RFR: 8282270: java/awt/Robot Screen Capture tests fail after 8280861 [v5]

2022-03-17 Thread Maxim Kartashev
On Wed, 16 Mar 2022 13:41:26 GMT, Alexey Ivanov wrote: >> Maxim Kartashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Reverted HiDPIRobotScreenCaptureTest back to 8280861 with minor changes > > Let's give a while for Sergey and/or Ph

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v6]

2022-03-17 Thread lukeu
On Thu, 17 Mar 2022 23:50:21 GMT, Alisen Chung wrote: >> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > fixed apostrophe in comment o

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v5]

2022-03-17 Thread Alisen Chung
> Changed the drawing area to be increased by 0.5 on the left side to prevent > clipping Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: updated test - Changes: - all: https://git.openjdk.java.net/jdk/pull/7449/files

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v6]

2022-03-17 Thread Alisen Chung
> Changed the drawing area to be increased by 0.5 on the left side to prevent > clipping Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: fixed apostrophe in comment of saveImage - Changes: - all: https://git.openjdk.j

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v4]

2022-03-17 Thread Alisen Chung
> Changed the drawing area to be increased by 0.5 on the left side to prevent > clipping Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: changed approach to render border without transforms - Changes: - all: https://g

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v3]

2022-03-17 Thread Alisen Chung
On Mon, 14 Mar 2022 16:15:47 GMT, Alisen Chung wrote: >> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > added functions for drawing b

RFR: 8270331 : [TESTBUG] Error: Not a test or directory containing tests: java/awt/print/PrinterJob/InitToBlack.java

2022-03-17 Thread lawrence . andrews
1) Removed =yesno since it was throwing Error: Not a test or directory containing tests 2) Test was just printing the "Test passes" on the printer and user did not had any option to mark the test as pass or fail and test was always passing. so created test UI with test instruction and test contr

Re: RFR: 8282526: Default icon is not painted properly

2022-03-17 Thread Phil Race
On Sun, 13 Mar 2022 21:06:24 GMT, Alexander Zuev wrote: > Detect the situation where we do need to perform interpolation during > ImageIcon > painting and set a hint to the rendering to perform bicubic approximation so > image details are preserved during transition. src/java.desktop/share/clas

Re: RFR: 8283217: Leak FcObjectSet in getFontConfigLocations() in fontpath.c [v2]

2022-03-17 Thread Phil Race
On Wed, 16 Mar 2022 01:05:19 GMT, Zhengyu Gu wrote: >> Please review this small patch to fix leaking of `FcObjectSet` in >> `getFontConfigLocations()` >> >> >> Test: >> - [x] jdk_2d > > Zhengyu Gu has updated the pull request with a new target base due to a merge > or a rebase. The incremen

Re: RFR: 8282863: java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java fails on Windows 10 with HiDPI screen

2022-03-17 Thread Phil Race
On Wed, 16 Mar 2022 07:39:21 GMT, Dmitry Kulikov wrote: > Hello, > Please review this fix for JDK-8282863. > > The failing > `java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java` test > basically checks that full-screen window remains full-screen when a display > mode change

Re: RFR: 8274735: javax.imageio.IIOException: Unsupported Image Type while processing a valid JPEG image

2022-03-17 Thread Phil Race
On Thu, 17 Mar 2022 17:23:10 GMT, Sergey Bylokhov wrote: > > Integration blocker > > ⚠️ Failed to retrieve information on issue 8274735. Please make sure it > > exists and is accessible. > > Looks like the JDK-8274735 is closed. Hmm it had been closed as a dup of 5100094 but that is about full

Re: RFR: 7124282: [macosx] Can't see table cell highlighter when the highlight border is the same color as the cell. [v3]

2022-03-17 Thread Harshitha Onkar
On Thu, 17 Mar 2022 17:56:03 GMT, Harshitha Onkar wrote: >> @prsadhuk Thank you for suggesting possible alternatives. > > There are two different approaches that we can take at this point. > > 1. Do we go forward with the present changes? (hue and saturation offset, > brightness set to 100%) >

Re: RFR: 7124282: [macosx] Can't see table cell highlighter when the highlight border is the same color as the cell. [v3]

2022-03-17 Thread Harshitha Onkar
On Wed, 16 Mar 2022 07:43:03 GMT, Prasanta Sadhukhan wrote: >> > src="https://user-images.githubusercontent.com/43534309/158540377-e97cc3c7-64e9-487d-948d-bc1941d5af28.png";> > > Probably to get an identical focus ring, we need to use > [NSSetFocusRingStyle](https://developer.apple.com/documenta

Re: RFR: 7124282: [macosx] Can't see table cell highlighter when the highlight border is the same color as the cell. [v3]

2022-03-17 Thread Harshitha Onkar
On Thu, 17 Mar 2022 17:54:41 GMT, Harshitha Onkar wrote: >> Probably to get an identical focus ring, we need to use >> [NSSetFocusRingStyle](https://developer.apple.com/documentation/appkit/1473702-nssetfocusringstyle?language=objc) > > @prsadhuk Thank you for suggesting possible alternatives. T

Re: RFR: 8274735: javax.imageio.IIOException: Unsupported Image Type while processing a valid JPEG image

2022-03-17 Thread Sergey Bylokhov
On Thu, 17 Mar 2022 03:23:49 GMT, Phil Race wrote: > The JDK's built-in Image I/O JPEG plugin decodes JPEGs which are YCbCr and > RGb and Grayscale but rejects CMYK and YCCK JPEGs. > These would correspond to JFIF encapsulated JPEGs. > > This was a reasonable decision to limit support to what w

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v4]

2022-03-17 Thread Prasanta Sadhukhan
On Wed, 16 Mar 2022 06:02:28 GMT, Prasanta Sadhukhan wrote: >> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced >> Gulim korean font so it needs to be updated to show korean fonts > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional com

Re: RFR: 8282548: Create a regression test for JDK-4330998 [v5]

2022-03-17 Thread Manukumar V S
> Create a regression test for > [JDK-4330998](https://bugs.openjdk.java.net/browse/JDK-4330998) > Context: Migrating tests from a closed tonga based test suite to open > regression based one. > > Issue tested: > When calling JEditorPane.setText(null), the following exception is thrown: > > jav

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v4]

2022-03-17 Thread Phil Race
On Wed, 16 Mar 2022 06:02:28 GMT, Prasanta Sadhukhan wrote: >> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced >> Gulim korean font so it needs to be updated to show korean fonts > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional com

Re: RFR: 8257733: Move module-specific data from make to respective module [v9]

2022-03-17 Thread Naoto Sato
On Thu, 17 Mar 2022 00:12:38 GMT, Magnus Ihse Bursie wrote: >> A lot (but not all) of the data in make/data is tied to a specific module. >> For instance, the publicsuffixlist is used by java.base, and fontconfig by >> java.desktop. (A few directories, like mainmanifest, is *actually* used by

Re: RFR: 8257733: Move module-specific data from make to respective module [v9]

2022-03-17 Thread Erik Joelsson
On Thu, 17 Mar 2022 00:12:38 GMT, Magnus Ihse Bursie wrote: >> A lot (but not all) of the data in make/data is tied to a specific module. >> For instance, the publicsuffixlist is used by java.base, and fontconfig by >> java.desktop. (A few directories, like mainmanifest, is *actually* used by

Integrated: 8282602: Refactor awt classes javadoc to use @throws instead of @exception

2022-03-17 Thread Prasanta Sadhukhan
On Thu, 3 Mar 2022 12:26:19 GMT, Prasanta Sadhukhan wrote: > Prevailing JDK coding practices use "@throws" rather than "@exception". > Refactor existing java/awt classes javadoc to use @throws This pull request has now been integrated. Changeset: 249d5536 Author:Prasanta Sadhukhan URL:

Integrated: 8282473: Refactor swing classes javadoc to use @throws instead of @exception

2022-03-17 Thread Prasanta Sadhukhan
On Tue, 1 Mar 2022 10:16:16 GMT, Prasanta Sadhukhan wrote: > Prevailing JDK coding practices use "@throws" rather than "@exception". > Refactor existing swing classes javadoc to use @throws This pull request has now been integrated. Changeset: 096bca4a Author:Prasanta Sadhukhan URL:

Re: RFR: JDK-8282046: Create a regression test for JDK-8000326 [v5]

2022-03-17 Thread Srinivas Mandalika
> Create a regression test for CCC8000326 > > Issue is identified by > [JDK-8000326](https://bugs.openjdk.java.net/browse/JDK-8000326), which > identifies that after focus moves into JMenuBar, whose focus traversal key is > disabled by default, it never moves to other focusable component. > >

Re: RFR: JDK-8282046: Create a regression test for JDK-8000326 [v3]

2022-03-17 Thread Srinivas Mandalika
On Wed, 16 Mar 2022 14:47:48 GMT, Alexey Ivanov wrote: > You copied the test into the new folder but the old folder still remains. You > have to remove it. We don't want two identical tests in different locations. I have now deleted the duplicate file. - PR: https://git.openjdk.ja

Re: RFR: JDK-8282046: Create a regression test for JDK-8000326 [v4]

2022-03-17 Thread Srinivas Mandalika
> Create a regression test for CCC8000326 > > Issue is identified by > [JDK-8000326](https://bugs.openjdk.java.net/browse/JDK-8000326), which > identifies that after focus moves into JMenuBar, whose focus traversal key is > disabled by default, it never moves to other focusable component. > >

Re: RFR: JDK-8282046: Create a regression test for JDK-8000326 [v3]

2022-03-17 Thread Srinivas Mandalika
On Fri, 11 Mar 2022 14:38:28 GMT, Srinivas Mandalika wrote: >> Create a regression test for CCC8000326 >> >> Issue is identified by >> [JDK-8000326](https://bugs.openjdk.java.net/browse/JDK-8000326), which >> identifies that after focus moves into JMenuBar, whose focus traversal key >> is di