> Removed the println() line from the Interrupted catch block. Since
> waitForID() Interrupt indicates completion of Image Loading, println as
> Interrupt handling was not required.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Update
On Tue, 22 Mar 2022 01:35:52 GMT, Sergey Bylokhov wrote:
>> Manukumar V S has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Removed extra blank line before import static
>> - Review comment fixed: Limited 80 chars per line
>
> test/jdk/
> Write a regression test for
> [JDK-4615365](https://bugs.openjdk.java.net/browse/JDK-4615365) : JSplitPane
> current and last divider positions incorrect when realized
>
> Issue:
> JSplitPane component with a left and right component has its current divider
> position incorrectly set to -1 onc
On Sun, 13 Mar 2022 14:01:25 GMT, Manukumar V S wrote:
>> Write a regression test for
>> [JDK-4164779](https://bugs.openjdk.java.net/browse/JDK-4164779) : JSplitPane
>> keyboard navigation does not support F6 and Ctrl+Tab
>>
>>
>> Issue:
>> The specified keyboard support for JSplitPane also r
On Mon, 21 Feb 2022 12:16:53 GMT, Andrey Turbanov wrote:
> Method `isAssignableFrom` is opposite: it brings unnecessary complexity in
> the code. And it's easy to confuse orders of parameters. Even JBS confirms
> that:
Maybe we should add `Class::isSubclassOf(Class that)` that performs
`that.
On Tue, 22 Mar 2022 01:26:38 GMT, Sergey Bylokhov wrote:
>> @mrserb Can you please sponsor my changes?
>
> @srmandal please confirm that the test works fine in the mach5.
@mrserb Yes The test ran successfully on Mach5 with multiple runs (30) on
windows-x64, linux-x64 and macos-x64.
---
On Fri, 18 Mar 2022 18:21:06 GMT, Phil Race wrote:
>> The JDK's built-in Image I/O JPEG plugin decodes JPEGs which are YCbCr and
>> RGb and Grayscale but rejects CMYK and YCCK JPEGs.
>> These would correspond to JFIF encapsulated JPEGs.
>>
>> This was a reasonable decision to limit support to w
On Sun, 13 Mar 2022 13:54:47 GMT, Manukumar V S wrote:
> Write a regression test for
> [JDK-4615365](https://bugs.openjdk.java.net/browse/JDK-4615365) : JSplitPane
> current and last divider positions incorrect when realized
>
> Issue:
> JSplitPane component with a left and right component has
On Sun, 13 Mar 2022 14:01:25 GMT, Manukumar V S wrote:
>> Write a regression test for
>> [JDK-4164779](https://bugs.openjdk.java.net/browse/JDK-4164779) : JSplitPane
>> keyboard navigation does not support F6 and Ctrl+Tab
>>
>>
>> Issue:
>> The specified keyboard support for JSplitPane also r
On Thu, 17 Mar 2022 23:50:21 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed apostrophe in comment o
On Sun, 13 Mar 2022 14:07:22 GMT, Manukumar V S wrote:
> Write a regression test for
> [JDK-4820080](https://bugs.openjdk.java.net/browse/JDK-4820080) : RFE: Cannot
> Change the JSplitPane Divider Color while dragging
>
> Issue(as per bug description):
> I want to change the color of the JSpli
On Thu, 17 Mar 2022 06:45:00 GMT, Srinivas Mandalika
wrote:
>> Marked as reviewed by serb (Reviewer).
>
> @mrserb Can you please sponsor my changes?
@srmandal please confirm that the test works fine in the mach5.
-
PR: https://git.openjdk.java.net/jdk/pull/7807
On Thu, 17 Mar 2022 23:50:21 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed apostrophe in comment o
On Thu, 3 Dec 2020 23:44:20 GMT, Magnus Ihse Bursie wrote:
> A lot (but not all) of the data in make/data is tied to a specific module.
> For instance, the publicsuffixlist is used by java.base, and fontconfig by
> java.desktop. (A few directories, like mainmanifest, is *actually* used by
> ma
> This testcase covers both old and new api ( api added in jdk17
> getAccessibleAction(), getAccessibleActionCount() ,
> getAccessibleActionDescription )
>
> @shurymury
> @savoptik
lawrence.andrews has updated the pull request incrementally with one additional
commit since the last revision:
> A lot (but not all) of the data in make/data is tied to a specific module.
> For instance, the publicsuffixlist is used by java.base, and fontconfig by
> java.desktop. (A few directories, like mainmanifest, is *actually* used by
> make for the whole build.)
>
> These data files should move t
On Mon, 21 Mar 2022 16:29:25 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Mon, 21 Mar 2022 16:29:25 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Fri, 18 Mar 2022 21:24:43 GMT, Phil Race wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix typos
>
> This doesn't seem right to me to put x11wrappergen into share.
>
> This is X11 specific. It should no
On Wed, 16 Mar 2022 21:17:44 GMT, lawrence.andrews
wrote:
>> Following methods are covered in this testcase
>> getAccessibleAction()
>> getAccessibleActionCount()
>> doAccessibleAction(int direction)
>>
>> @shurymury
>
> lawrence.andrews has updated the pull request incrementally with one
> a
On Mon, 21 Mar 2022 16:29:25 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
> A lot (but not all) of the data in make/data is tied to a specific module.
> For instance, the publicsuffixlist is used by java.base, and fontconfig by
> java.desktop. (A few directories, like mainmanifest, is *actually* used by
> make for the whole build.)
>
> These data files should move t
> A lot (but not all) of the data in make/data is tied to a specific module.
> For instance, the publicsuffixlist is used by java.base, and fontconfig by
> java.desktop. (A few directories, like mainmanifest, is *actually* used by
> make for the whole build.)
>
> These data files should move t
On Fri, 18 Mar 2022 21:24:43 GMT, Phil Race wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix typos
>
> This doesn't seem right to me to put x11wrappergen into share.
>
> This is X11 specific. It should no
On Mon, 21 Mar 2022 13:19:14 GMT, Alexey Ivanov wrote:
>> How about setting the status to ABORTED only if it is Interrupted.?
>>
>>> try {
>>> mTracker.waitForID(id, 0);
>>> } catch (InterruptedException e) {
>>> bIsInterrupted = true;
> A lot (but not all) of the data in make/data is tied to a specific module.
> For instance, the publicsuffixlist is used by java.base, and fontconfig by
> java.desktop. (A few directories, like mainmanifest, is *actually* used by
> make for the whole build.)
>
> These data files should move t
> A lot (but not all) of the data in make/data is tied to a specific module.
> For instance, the publicsuffixlist is used by java.base, and fontconfig by
> java.desktop. (A few directories, like mainmanifest, is *actually* used by
> make for the whole build.)
>
> These data files should move t
On Mon, 21 Mar 2022 09:02:17 GMT, Andrey Turbanov wrote:
>> Fix repeated typo `exeption`
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8283426: Fix 'exeption' typo
>
> Apply suggestion
>
> Co-authored-by: Ale
On Mon, 21 Mar 2022 04:10:48 GMT, Tejesh R wrote:
>>> N for current bug, where to change to change the status to
>>> "ABORTED"..?? As I cannot change in ImageIcon class..
>>
>> Why can't you change the status in `ImageIcon`? It's where you change it.
>>
>>
>> loadStatus =
On Tue, 15 Mar 2022 19:26:19 GMT, Zhengyu Gu wrote:
> Please review this small patch to fix leaking of `FcObjectSet` in
> `getFontConfigLocations()`
>
>
> Test:
> - [x] jdk_2d
This pull request has now been integrated.
Changeset: 909986c7
Author:Zhengyu Gu
URL:
https://git.open
On Thu, 17 Mar 2022 20:46:57 GMT, Phil Race wrote:
>> Zhengyu Gu has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commits since
On Wed, 16 Mar 2022 01:05:19 GMT, Zhengyu Gu wrote:
>> Please review this small patch to fix leaking of `FcObjectSet` in
>> `getFontConfigLocations()`
>>
>>
>> Test:
>> - [x] jdk_2d
>
> Zhengyu Gu has updated the pull request with a new target base due to a merge
> or a rebase. The incremen
> Fix repeated typo `exeption`
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8283426: Fix 'exeption' typo
Apply suggestion
Co-authored-by: Alexey Ivanov <70774172+aivanov-...@users.noreply.github.com>
-
Ch
On Mon, 21 Mar 2022 06:13:24 GMT, Prasanta Sadhukhan
wrote:
> Prevailing JDK coding practices use "@throws" rather than "@exception".
> Refactor existing imageio classes javadoc to use @throws
Marked as reviewed by serb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7885
On Tue, 8 Mar 2022 10:52:44 GMT, Manukumar V S wrote:
> Create a regression test for the JTree usecase of
> [JDK-4618767](https://bugs.openjdk.java.net/browse/JDK-4618767)
>
>
> Issue identified in
> [JDK-4618767](https://bugs.openjdk.java.net/browse/JDK-4618767):
> Typing a letter while a JT
On Tue, 8 Mar 2022 10:06:23 GMT, Manukumar V S wrote:
> Create a regression test for
> [JDK-4330998](https://bugs.openjdk.java.net/browse/JDK-4330998)
>
>
> Issue tested:
> When calling JEditorPane.setText(null), the following exception is thrown:
>
> java.lang.NullPointerException:
>
On Sun, 20 Mar 2022 13:30:01 GMT, Andrey Turbanov wrote:
> Fix repeated typo `exeption`
Marked as reviewed by aivanov (Reviewer).
src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java
line 201:
> 199: /*
> 200: * The method could not be implemented due to CALay
On Thu, 24 Feb 2022 14:32:39 GMT, Maxim Kartashev wrote:
> The two tests `ScreenCaptureGtkTest.java` and
> `HiDPIRobotScreenCaptureTest.java` under `java/awt/Robot/HiDPIScreenCapture`
> started to intermittently fail under Windows and Linux after the [recent
> changes](https://github.com/openj
38 matches
Mail list logo
