On Mon, 28 Mar 2022 20:23:20 GMT, lawrence.andrews
wrote:
> Fixed the following issue.
> 1) Removed yes/no since test was failing due to "Parser error due to yesno in
> @run main/manual=yesno"
> 2) After removing yes/no test run( just shows the UI and gets dispose
> immediately). User cannot i
On Thu, 24 Mar 2022 20:24:35 GMT, lawrence.andrews
wrote:
> Following issues were fixed in this test
> 1) Fixed - Parser error due to yesno in @run main/manual=yesno
> 2) Fixed Wrong test name specified in @run jtreg
> @run main/manual=yesno PrintTextTest . It should be @run main/manual=yesno
On Tue, 29 Mar 2022 04:16:06 GMT, Prasanta Sadhukhan
wrote:
> > Suitable classes across the JDK are being retro-fitted to be sealed
>
> How does this "suitability" check done? Are these exhaustive or more awt
> classes will be added? Do we need to do the same for swing classes too?
I wrote an
On Mon, 28 Mar 2022 16:30:50 GMT, Phil Race wrote:
> Suitable classes across the JDK are being retro-fitted to be sealed
How does this "suitability" check done? Are these exhaustive or more awt
classes will be added?
Do we need to do the same for swing classes too?
-
Marked as re
On Fri, 25 Mar 2022 11:27:36 GMT, Alexey Ushakov wrote:
>> Used setOpaque() method to set correct background of platform window
>> Extracted setting background to the particular method in PlatformWindow.
>> Provided appropriate implementation in CPlatformWindow.
>
> Alexey Ushakov has updated th
On Mon, 28 Mar 2022 04:29:24 GMT, Dmitry Kulikov wrote:
>> Hello,
>> Please review this fix for JDK-8282863.
>>
>> The failing
>> `java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java` test
>> basically checks that full-screen window remains full-screen when a display
>> mode
On Mon, 28 Mar 2022 22:31:31 GMT, Alexander Zuev wrote:
> Check parent component visibility status before asking it for its screen
> coordinates.
src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessibility.java line 472:
> 470: return invokeAndWait(new Callable() {
> 471:
On Mon, 28 Mar 2022 16:30:50 GMT, Phil Race wrote:
> JDK 17 delivered JEP 409: Sealed Classes : https://openjdk.java.net/jeps/409
> In essence this JEP allows a class to limit which classes can subclass it.
> If a class has no subclasses and cannot be subclassed outside the JDK it can
> also be
On Mon, 28 Mar 2022 16:30:50 GMT, Phil Race wrote:
> JDK 17 delivered JEP 409: Sealed Classes : https://openjdk.java.net/jeps/409
> In essence this JEP allows a class to limit which classes can subclass it.
> If a class has no subclasses and cannot be subclassed outside the JDK it can
> also be
On Fri, 25 Mar 2022 11:27:36 GMT, Alexey Ushakov wrote:
>> Used setOpaque() method to set correct background of platform window
>> Extracted setting background to the particular method in PlatformWindow.
>> Provided appropriate implementation in CPlatformWindow.
>
> Alexey Ushakov has updated th
On Mon, 28 Mar 2022 16:30:50 GMT, Phil Race wrote:
> JDK 17 delivered JEP 409: Sealed Classes : https://openjdk.java.net/jeps/409
> In essence this JEP allows a class to limit which classes can subclass it.
> If a class has no subclasses and cannot be subclassed outside the JDK it can
> also be
On Mon, 28 Mar 2022 16:30:50 GMT, Phil Race wrote:
> JDK 17 delivered JEP 409: Sealed Classes : https://openjdk.java.net/jeps/409
> In essence this JEP allows a class to limit which classes can subclass it.
> If a class has no subclasses and cannot be subclassed outside the JDK it can
> also be
On Mon, 28 Mar 2022 21:20:00 GMT, Alisen Chung wrote:
> This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
This pull request has now been integrated.
Changeset: 634800a5
Author:Alisen Chung
Committer: Naoto Sato
URL:
https://git.openjdk.java.net/jdk/commit/634800a536e7f9
On Mon, 28 Mar 2022 21:20:00 GMT, Alisen Chung wrote:
> This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
LGTM
-
Marked as reviewed by naoto (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8005
Check parent component visibility status before asking it for its screen
coordinates.
-
Commit messages:
- 8283215: [macos] Screen Magnifier: Getting
java.awt.IllegalComponentStateException when menu item is selected
Changes: https://git.openjdk.java.net/jdk/pull/8008/files
Webre
This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
-
Commit messages:
- Revert "8280400: JDK 19 L10n resource files update - msgdrop 10"
Changes: https://git.openjdk.java.net/jdk/pull/8005/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8005&range=00
Issue:
On Mon, 28 Mar 2022 21:20:00 GMT, Alisen Chung wrote:
> This reverts commit c0aecd15ae8d7abf37901f785fccaff2317c3b23.
I confirm that this is an exact backout of
[JDK-8280400](https://bugs.openjdk.java.net/browse/JDK-8280400).
-
Marked as reviewed by kcr (Author).
PR: https://git.
On Mon, 28 Mar 2022 20:39:26 GMT, Sergey Bylokhov wrote:
>> JDK 17 delivered JEP 409: Sealed Classes : https://openjdk.java.net/jeps/409
>> In essence this JEP allows a class to limit which classes can subclass it.
>> If a class has no subclasses and cannot be subclassed outside the JDK it can
>
On Wed, 23 Mar 2022 18:24:05 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> scale stroke width at higher
On Mon, 28 Mar 2022 08:44:00 GMT, Prasanta Sadhukhan
wrote:
> test/jdk/javax/swing/JInternalFrame/Test6325652.java test was failing in
> macos in Aqua L&F due to nonsupport in macos of such shortcuts Ctrl+F5 to
> restore or Ctrl+F9 to iconify. Keyboard->Shortcut in macos System->Preference
>
On Mon, 28 Mar 2022 16:30:50 GMT, Phil Race wrote:
> JDK 17 delivered JEP 409: Sealed Classes : https://openjdk.java.net/jeps/409
> In essence this JEP allows a class to limit which classes can subclass it.
> If a class has no subclasses and cannot be subclassed outside the JDK it can
> also be
On Mon, 28 Mar 2022 16:30:50 GMT, Phil Race wrote:
> JDK 17 delivered JEP 409: Sealed Classes : https://openjdk.java.net/jeps/409
> In essence this JEP allows a class to limit which classes can subclass it.
> If a class has no subclasses and cannot be subclassed outside the JDK it can
> also be
Fixed the following issue.
1) Removed yes/no since test was failing due to "Parser error due to yesno in
@run main/manual=yesno"
2) After removing yes/no test run( just shows the UI and gets dispose
immediately). User cannot interact with the test UI and mark the test pass or
failed.
So added P
On Fri, 25 Mar 2022 06:48:22 GMT, Tejesh R wrote:
>> It seems to me that as I mentioned there's at least a possibility that the
>> image actually is loaded. This thread being interrupted doesn't stop the
>> Media loading threads.
>>
>> Since there's only one image for this id, LOADING and COMP
On Mon, 28 Mar 2022 06:31:19 GMT, Prasanta Sadhukhan
wrote:
>> @prsadhuk Cell Focus ring color does not change with highlight color
>> settings. Tested for following cases -
>>
>> > src="https://user-images.githubusercontent.com/95945681/160217226-7d4236c7-1d3e-4062-8fad-974a13374624.png";>
>
> Previously while tabbing through the JTable cell, the cell highlighter/focus
> ring was not visible against the selection background.
>
> Changes are made to Aqua LAF to derive a brighter focus ring color by
> changing hue, saturation and brightness of selection background color so that
> it
On Sun, 27 Mar 2022 03:02:55 GMT, Phil Race wrote:
> So perhaps, this needs real printer testing printing to a real printer. Or
> may be more than one.
I have an HP OfficeJet Pro, and happy to print the odd test manually if it
would help increase coverage. If so, just let me know when the code
On Wed, 9 Mar 2022 21:09:30 GMT, Alisen Chung wrote:
> msg drop for jdk19, Mar 9, 2022
This pull request has now been integrated.
Changeset: c0aecd15
Author:Alisen Chung
Committer: Naoto Sato
URL:
https://git.openjdk.java.net/jdk/commit/c0aecd15ae8d7abf37901f785fccaff2317c3b23
Stat
On Mon, 28 Mar 2022 07:49:59 GMT, Sergey Bylokhov wrote:
> BTW why this PR is in the draft state?
This PR was in draft while I was learning about the correct process to convert
a test. I just made the branch ready for review again, thanks!
-
PR: https://git.openjdk.java.net/jdk/pu
On Mon, 28 Mar 2022 07:34:52 GMT, Prasanta Sadhukhan
wrote:
> Default directory name has changed from "My Documents" to "Documents" in
> recent WIndows version, so javadoc needs to be updated.
Looks good to me.
I think it doesn't require a CSR, it just updates the name of the default
folder
On Thu, 24 Mar 2022 03:07:28 GMT, Phil Race wrote:
> I also think there's at least some analogy with OpenJFX's snap-to-pixel idea
> that it is sometimes better to pick a pixel and stick with it rather than
> span pixels and be fuzzy. Not an expert on the details of that by any means
> @kevinru
On Sat, 26 Mar 2022 02:38:41 GMT, Phil Race wrote:
>> lawrence.andrews has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed the white space issue
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 127:
>
>> 125:
> We need a common manual test framework code that can be shared across all the
> client manual test. This framework class should have the following
> 1) Frame which contains test instruction .
> 2) Pass & Fail button so that user can mark the test pass or fail
> 3) Upon failing the test user shou
On Sat, 26 Mar 2022 02:37:09 GMT, Phil Race wrote:
>> lawrence.andrews has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixed the white space issue
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 103:
>
>> 101: * If us
On Mon, 28 Mar 2022 06:31:19 GMT, Prasanta Sadhukhan
wrote:
>> @prsadhuk Cell Focus ring color does not change with highlight color
>> settings. Tested for following cases -
>>
>> > src="https://user-images.githubusercontent.com/95945681/160217226-7d4236c7-1d3e-4062-8fad-974a13374624.png";>
>
On Mon, 28 Mar 2022 16:30:50 GMT, Phil Race wrote:
> JDK 17 delivered JEP 409: Sealed Classes : https://openjdk.java.net/jeps/409
> In essence this JEP allows a class to limit which classes can subclass it.
> If a class has no subclasses and cannot be subclassed outside the JDK it can
> also be
JDK 17 delivered JEP 409: Sealed Classes : https://openjdk.java.net/jeps/409
In essence this JEP allows a class to limit which classes can subclass it.
If a class has no subclasses and cannot be subclassed outside the JDK it can
also be made final.
Suitable classes across the JDK are being retro-f
On Wed, 23 Mar 2022 18:24:05 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> scale stroke width at higher
On Mon, 28 Mar 2022 15:16:52 GMT, Phil Race wrote:
>> ExceptionClear(env) is removed from the `if (nameArray == NULL)` check.
>
> I should have said (as I did in the beginning) remove the clear - and the new
> throw - and just return null.
JNU_ThrowOutOfMemoryError is removed from code where na
> The issue is reproduced on macOS Big Sur 11.0.1 with jdk 16.0.1+9.
>
> Create a native macOS app from the Hello.java file, sign and run it in
> sandbox:
>
> import javax.print.*;
> import javax.swing.*;
>
> public class Hello {
>
> public static void main(String[] args) throws Exception
On Wed, 23 Mar 2022 18:24:05 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> scale stroke width at higher
On Mon, 28 Mar 2022 09:45:11 GMT, Alexander Scherbatiy
wrote:
>> I can't agree with the apparent reasoning that "well that thing over there
>> is wrong, so it's ok for me to add something here that's wrong too".
>>
>> And the getMedia(..) case is different. It doesn't re-create the same
>> e
Write a regression test for
[JDK-4390885](https://bugs.openjdk.java.net/browse/JDK-4390885) Enhancement
Request.
Issue:
Please add the ability to set the location of a JFileChooser. This might be a
bug, but JFileChooser.setLocation() has no effect when
JFileChooser.showDialog() is called. Th
On Fri, 25 Mar 2022 17:31:37 GMT, Phil Race wrote:
>> The array creation error handling is implemented in the similar way as it is
>> done in the getMedia() function.
>> The ExceptionClear() has been added to the getMedia() by `8031001: [Parfait]
>> warnings from b121 for jdk/src/solaris/native
On Thu, 24 Mar 2022 02:49:49 GMT, Phil Race wrote:
>> Dmitry Batrak has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove 'headful' requirement from test case
>
> I know .. I know .. I just (a) don't like it, and (b) don't have a good
> The issue is reproduced on macOS Big Sur 11.0.1 with jdk 16.0.1+9.
>
> Create a native macOS app from the Hello.java file, sign and run it in
> sandbox:
>
> import javax.print.*;
> import javax.swing.*;
>
> public class Hello {
>
> public static void main(String[] args) throws Exception
test/jdk/javax/swing/JInternalFrame/Test6325652.java test was failing in macos
in Aqua L&F due to nonsupport in macos of such shortcuts Ctrl+F5 to restore or
Ctrl+F9 to iconify. Keyboard->Shortcut in macos System->Preference do not have
these shortcut usage.
https://docs.oracle.com/javase/tutori
On Fri, 25 Mar 2022 19:20:43 GMT, DamonGuy wrote:
>> Aqua L&F tables lacked support for `CTRL+ARROW`, `CTRL+PG_UP/DOWN`, and
>> `CTRL+SHIFT+PG_UP/DOWN` key bindings. This allows for navigation and
>> selection of table cells without the need of a mouse and without deselecting
>> the current se
On Mon, 28 Mar 2022 07:34:52 GMT, Prasanta Sadhukhan
wrote:
> Default directory name has changed from "My Documents" to "Documents" in
> recent WIndows version, so javadoc needs to be updated.
I guess it will not need a CSR
-
PR: https://git.openjdk.java.net/jdk/pull/7983
On Thu, 24 Mar 2022 18:25:32 GMT, Sergey Bylokhov wrote:
>>> If it skips the texture property I guess it will break it?
>> I've not noticed it in my testing. Do you mean particular tests? But anyway
>> your suggestion looks more elegant and it works in my scenarios, also I've
>> run test-jdk_de
Default directory name has changed from "My Documents" to "Documents" in recent
WIndows version, so javadoc needs to be updated.
-
Commit messages:
- 8283642: JavaDoc of JFileChooser() need to be updated for default directory
in Windows
Changes: https://git.openjdk.java.net/jdk/pu
51 matches
Mail list logo
