> JDK-8282933: Create a test for JDK-4529616
> AccessibleJTableCell.isShowing() returns false when the cell is actually on
> the screen.
> The test validates the fix for the above issue by verifying that the
> isShowing call returns true when invoked via the accessiblity context.
> This review i
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as `
On Thu, 7 Apr 2022 01:16:32 GMT, Naoto Sato wrote:
>> test/jdk/java/text/Format/NumberFormat/CurrencyFormat.java line 63:
>>
>>> 61: Locale.of("it", "IT", "EURO"),
>>> 62: Locale.forLanguageTag("de-AT"),
>>> 63: Locale.forLanguageTag("fr-CH"),
>>
>> Use the n
On Thu, 7 Apr 2022 01:16:27 GMT, Naoto Sato wrote:
>> test/jdk/java/text/Format/DateFormat/DateFormatRoundTripTest.java line 81:
>>
>>> 79:
>>> 80: /**
>>> 81: * Parse a name like "fr_FR" into Locale.of("fr", "FR", "");
>>
>> Locale.France?
>
> The test code parses the input string (e
On Wed, 6 Apr 2022 20:14:12 GMT, Sergey Bylokhov wrote:
>> Yes, that is fine; javadoc will filter out displaying non-public classes in
>> a permits clause.
>
> Just to double-check, it is fine to have it in the output of the
> getPermittedSubclasses for the public class as well?
I'm not certai
On Wed, 30 Mar 2022 22:21:51 GMT, Alexander Zuev wrote:
> It is impossible right now to manipulate state of the accessible children of
> the JTabbedPane via their AccessibleValue and because of that some of the
> assistive technologies are unable to interact with the parts of the
> JTabbedPane
On Thu, 7 Apr 2022 00:09:58 GMT, Joe Wang wrote:
>> This is a follow-on task after deprecating the Locale constructors
>> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
>> simple replacements to Locale constructors with `Locale.of()` or Locale
>> constants, such as
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as `
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as `
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as `
On Wed, 6 Apr 2022 18:15:09 GMT, Alexander Zuev wrote:
>> test/jdk/javax/accessibility/JTabbedPane/AccessibleTabbedPaneTest.java line
>> 39:
>>
>>> 37: public class AccessibleTabbedPaneTest {
>>> 38: public static void main(String[] args) {
>>> 39: JTabbedPane pane = new JTabbedPane
On Wed, 30 Mar 2022 22:21:51 GMT, Alexander Zuev wrote:
> It is impossible right now to manipulate state of the accessible children of
> the JTabbedPane via their AccessibleValue and because of that some of the
> assistive technologies are unable to interact with the parts of the
> JTabbedPane
On Fri, 2 Apr 2021 23:02:50 GMT, Sergey Bylokhov wrote:
> - The hand-crafted methods for addition and multiplication are replaced by
> the "Math" versions.
> - Cleanup: the usage of do/while(false) is removed
I think the usage of these methods in this class is wrong. Both allow negative
values
On Wed, 6 Apr 2022 16:47:17 GMT, Daniel Jeliński wrote:
>> This patch adds missing `r` in `string`s
>
> Daniel Jeliński has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - revert xalan changes
> - revert icu changes
JFR changes look fine, t
On Wed, 6 Apr 2022 05:42:08 GMT, Joe Darcy wrote:
>> src/java.desktop/share/classes/javax/swing/GroupLayout.java line 2461:
>>
>>> 2459: */
>>> 2460: public sealed class ParallelGroup extends Group
>>> 2461: permits BaselineGroup {
>>
>> The BaselineGroup class is private so n
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as `
On Wed, 6 Apr 2022 10:18:36 GMT, Alexey Ivanov wrote:
>> It is impossible right now to manipulate state of the accessible children of
>> the JTabbedPane via their AccessibleValue and because of that some of the
>> assistive technologies are unable to interact with the parts of the
>> JTabbedPa
On Wed, 6 Apr 2022 16:47:17 GMT, Daniel Jeliński wrote:
>> This patch adds missing `r` in `string`s
>
> Daniel Jeliński has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - revert xalan changes
> - revert icu changes
The changes look fine to
On Wed, 6 Apr 2022 16:47:17 GMT, Daniel Jeliński wrote:
>> This patch adds missing `r` in `string`s
>
> Daniel Jeliński has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - revert xalan changes
> - revert icu changes
The `jpackage` part of t
On Wed, 6 Apr 2022 14:12:49 GMT, Daniel Jeliński wrote:
>> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties
>> line 63:
>>
>>> 61: message.creating-association-with-null-extension=Creating association
>>> with null extension.
>>> 62: message.wrong-tool-v
This is a follow-on task after deprecating the Locale constructors
(https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
simple replacements to Locale constructors with `Locale.of()` or Locale
constants, such as `Locale.US`.
-
Commit messages:
- 8283698: Refa
On Tue, 5 Apr 2022 16:15:48 GMT, Harshitha Onkar wrote:
>> Also, I see if we start off with "Graphite" accent color then the focus ring
>> is "Graphite" but then even if we change to any other accent color, the
>> focus ring remains "Graphite"
>
> @prsadhuk I was able to replicate the above sce
On Wed, 6 Apr 2022 16:48:38 GMT, Daniel Jeliński wrote:
>> src/java.base/share/classes/jdk/internal/icu/text/StringPrep.java line 63:
>>
>>> 61: * http://www.ietf.org/rfc/rfc3454.txt";>RFC 3454.
>>> 62: * StringPrep prepares Unicode strings for use in network protocols.
>>> 63: * Profiles of
On Wed, 6 Apr 2022 15:49:06 GMT, Naoto Sato wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert liblcms changes
>
> src/java.base/share/classes/jdk/internal/icu/text/StringPrep.java line 63:
>
>> 61: * http
> This patch adds missing `r` in `string`s
Daniel Jeliński has updated the pull request incrementally with two additional
commits since the last revision:
- revert xalan changes
- revert icu changes
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8125/files
- new: htt
On Wed, 6 Apr 2022 14:12:17 GMT, Daniel Jeliński wrote:
>> This patch adds missing `r` in `string`s
>
> Daniel Jeliński has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Revert liblcms changes
src/java.base/share/classes/jdk/internal/icu/tex
On Wed, 6 Apr 2022 09:48:13 GMT, Ajit Ghaisas wrote:
> This PR makes Metal rendering pipeline as the default Java 2D rendering
> pipeline for macOS.
>
> Please refer "JBS Description" for more details.
Reviewed (committer)
Marked as reviewed by avu (Committer).
-
PR: https://git
On Wed, 6 Apr 2022 13:36:05 GMT, Alexey Ivanov wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert liblcms changes
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties
> This patch adds missing `r` in `string`s
Daniel Jeliński has updated the pull request incrementally with one additional
commit since the last revision:
Revert liblcms changes
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8125/files
- new: https://git.openjdk.java.
On Wed, 6 Apr 2022 13:38:03 GMT, Alexey Ivanov wrote:
>> This patch adds missing `r` in `string`s
>
> src/java.desktop/share/native/liblcms/cmstypes.c line 3668:
>
>> 3666: // Auxiliary, read an string specified as count + string
>> 3667: static
>> 3668: cmsBool ReadCountAndString(struct _cms_t
On Wed, 6 Apr 2022 12:07:30 GMT, Daniel Jeliński wrote:
> This patch adds missing `r` in `string`s
src/java.desktop/share/native/liblcms/cmstypes.c line 3668:
> 3666: // Auxiliary, read an string specified as count + string
> 3667: static
> 3668: cmsBool ReadCountAndString(struct _cms_typehand
On Wed, 6 Apr 2022 09:48:13 GMT, Ajit Ghaisas wrote:
> This PR makes Metal rendering pipeline as the default Java 2D rendering
> pipeline for macOS.
>
> Please refer "JBS Description" for more details.
Marked as reviewed by kcr (Author).
-
PR: https://git.openjdk.java.net/jdk/pul
On Wed, 30 Mar 2022 19:13:24 GMT, Zhengyu Gu wrote:
> Please review this small patch that fixes memory leak of
> `XdbeScreenVisualInfo` obtained from `XdbeGetVisualInfo()` method call.
>
> Test:
> - [x] jdk_awt
This pull request has now been integrated.
Changeset: ec205f68
Author:Zhengyu
On Wed, 6 Apr 2022 05:20:34 GMT, Sergey Bylokhov wrote:
>> Zhengyu Gu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @mrserb's comment
>
> Marked as reviewed by serb (Reviewer).
Thanks, @mrserb
-
PR: https://git.openjdk.j
On Wed, 6 Apr 2022 12:07:30 GMT, Daniel Jeliński wrote:
> This patch adds missing `r` in `string`s
This PR cuts across many areas, so will need multiple reviewers. Regarding the
LCMS file, we typically don't make these kind of changes in third-party code,
since it will cause our code to diverg
This patch adds missing `r` in `string`s
-
Commit messages:
- Fix sting typo
Changes: https://git.openjdk.java.net/jdk/pull/8125/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8125&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-828
Stats: 25 lines in
On Thu, 17 Mar 2022 21:55:05 GMT, Phil Race wrote:
>> Detect the situation where we do need to perform interpolation during
>> ImageIcon
>> painting and set a hint to the rendering to perform bicubic approximation so
>> image details are preserved during transition.
>
> src/java.desktop/share/cl
Hi Eirik,
Thank you for bringing this up.
On 30/03/2022 20:22, Eirik Bakke wrote:
In fact, Windows 10 renders titled border flat: one grey line instead of etched
border that was used in previous versions. Shall we update Swing's Windows L&F?
Here my point was that the rendering of GroupBox c
On Tue, 5 Apr 2022 20:16:28 GMT, lawrence.andrews wrote:
>> We need a common manual test framework code that can be shared across all
>> the client manual test. This framework class should have the following
>> 1) Frame which contains test instruction .
>> 2) Pass & Fail button so that user can
On Mon, 4 Apr 2022 11:17:16 GMT, Alexey Ivanov wrote:
> Both `FocusSpec.html` and `Modality.html` use GIF images for diagrams. The
> images look jagged, especially on High DPI screens which are common now. The
> images in `Modality.html` use dithered colours which don't look sharp even on
> re
On Wed, 6 Apr 2022 09:52:47 GMT, Tejesh R wrote:
>> Removed the println() line from the Interrupted catch block. Since
>> waitForID() Interrupt indicates completion of Image Loading, println as
>> Interrupt handling was not required.
>
> Tejesh R has updated the pull request incrementally with
On Wed, 6 Apr 2022 10:24:15 GMT, Tejesh R wrote:
>> Removed the println() line from the Interrupted catch block. Since
>> waitForID() Interrupt indicates completion of Image Loading, println as
>> Interrupt handling was not required.
>
> Tejesh R has updated the pull request incrementally with
> Removed the println() line from the Interrupted catch block. Since
> waitForID() Interrupt indicates completion of Image Loading, println as
> Interrupt handling was not required.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Update
On Wed, 30 Mar 2022 22:21:51 GMT, Alexander Zuev wrote:
> It is impossible right now to manipulate state of the accessible children of
> the JTabbedPane via their AccessibleValue and because of that some of the
> assistive technologies are unable to interact with the parts of the
> JTabbedPane
The test was failing on macos and was excluded in macos because the
viewposition was not changed after mouse wheel scroll. Seems like mouse wheel
scroll direction is opposite in macos compared to windows etc so if we try to
down-wheel scroll in macos when view position is at center of viewport (
On Fri, 1 Apr 2022 19:18:39 GMT, Phil Race wrote:
> Along the same lines as other recent additions of the sealed modifier but
> this one is quite simple.
> Only MultiGradientPaint is touched. The two extant sub-classes it permits are
> already final
>
> CSR for review : https://bugs.openjdk.ja
On Sat, 2 Apr 2022 23:21:03 GMT, Phil Race wrote:
> Update Swing classes to use JEP 409 sealed and non-sealed modifiers and add
> the final modifier where appropriate.
>
> jtreg tests and JCK API tests pass
>
> CSR for review here : https://bugs.openjdk.java.net/browse/JDK-8284214
Marked as r
getText function returned extra endOfLine when appended. The reason was in
`EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)`
method, where translation happens from buffer to Out(Writer Object) if
endOfLine is other than '\n' ( which is '\r\n' in windows). In order to w
This PR makes Metal rendering pipeline as the default Java 2D rendering
pipeline for macOS.
Please refer "JBS Description" for more details.
-
Commit messages:
- Make Metal the default 2D pipeline
Changes: https://git.openjdk.java.net/jdk/pull/8121/files
Webrev: https://webrevs.o
> Removed the println() line from the Interrupted catch block. Since
> waitForID() Interrupt indicates completion of Image Loading, println as
> Interrupt handling was not required.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Update
On Wed, 30 Mar 2022 15:24:17 GMT, Artem Semenov wrote:
> If the JPopupMenu has menu items with submenus, those items are not spoken by
> VoiceOver.
>
> @forantar @azuev-java please review.
This pull request has now been integrated.
Changeset: e18414a3
Author:Artem Semenov
URL:
htt
On Mon, 4 Apr 2022 18:13:28 GMT, Phil Race wrote:
>> Artem Semenov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Is the check for the AccessibleRole.POPUP_MENU is needed here? How it will
>> work if the Menu is added to some container
On Thu, 31 Mar 2022 10:19:26 GMT, Artem Semenov wrote:
>> If the JPopupMenu has menu items with submenus, those items are not spoken
>> by VoiceOver.
>>
>> @forantar @azuev-java please review.
>
> Artem Semenov has updated the pull request incrementally with one additional
> commit since the l
On Mon, 4 Apr 2022 14:05:14 GMT, Manukumar V S wrote:
> Create an automated regression test for
> [JDK-4138746](https://bugs.openjdk.java.net/browse/JDK-4138746)
>
> Issue:
> In the following example (and similarly with other components) you cannot
> specify the correct character to underline:
> Create a regression test for
> [JDK-4702690](https://bugs.openjdk.java.net/browse/JDK-4702690)
>
> In many cases in Swing it is possible to easily programatically determine
> that a JScrollBar (or two) is scrolling some JPanel (the cannonical case is a
> JScrollPane).
> In these cases, when a
55 matches
Mail list logo
