Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v3]

2022-04-07 Thread Tejesh R
> getText function returned extra endOfLine when appended. The reason was in > `EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)` > method, where translation happens from buffer to Out(Writer Object) if > endOfLine is other than '\n' ( which is '\r\n' in windows). In or

Re: RFR: 8280468: Crashes in getConfigColormap, getConfigVisualId, XVisualIDFromVisual on Linux [v3]

2022-04-07 Thread Maxim Kartashev
On Thu, 7 Apr 2022 23:03:26 GMT, Sergey Bylokhov wrote: >> Maxim Kartashev has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains three commits: >> >> - Merge branch 'master' into JDK-8280468 >> - Addressed PR comments >> >>1.

Re: RFR: 8280468: Crashes in getConfigColormap, getConfigVisualId, XVisualIDFromVisual on Linux [v5]

2022-04-07 Thread Maxim Kartashev
> These crashes were not reproducible, so the fix is based on a hypothesis that > there are two possible reasons for them: > 1. `makeDefaultConfig()` returning `NULL`. > 2. A race condition when the number of screens changes. > The race scenario: `X11GraphisDevice.makeDefaultConfiguration()` is ca

Re: RFR: 8280468: Crashes in getConfigColormap, getConfigVisualId, XVisualIDFromVisual on Linux [v2]

2022-04-07 Thread Maxim Kartashev
On Thu, 7 Apr 2022 23:05:04 GMT, Sergey Bylokhov wrote: >> Maxim Kartashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Addressed PR comments >> >> 1. Got rid of X11GraphicsDevice.configLock in favour of the AWT lock. >> 2. Red

Re: RFR: 8280468: Crashes in getConfigColormap, getConfigVisualId, XVisualIDFromVisual on Linux [v4]

2022-04-07 Thread Maxim Kartashev
> These crashes were not reproducible, so the fix is based on a hypothesis that > there are two possible reasons for them: > 1. `makeDefaultConfig()` returning `NULL`. > 2. A race condition when the number of screens changes. > The race scenario: `X11GraphisDevice.makeDefaultConfiguration()` is ca

Re: RFR: 7124282: [macosx] Can't see table cell highlighter when the highlight border is the same color as the cell. [v8]

2022-04-07 Thread Harshitha Onkar
On Wed, 6 Apr 2022 17:29:27 GMT, Harshitha Onkar wrote: >> @prsadhuk I was able to replicate the above scenario and as mentioned it >> oddly happens only when we start with Graphite as accent color. Looking into >> it further. > > Following type properties where checked for cellFocusRing color

Re: RFR: 8280468: Crashes in getConfigColormap, getConfigVisualId, XVisualIDFromVisual on Linux [v3]

2022-04-07 Thread Sergey Bylokhov
On Tue, 5 Apr 2022 05:42:53 GMT, Maxim Kartashev wrote: >> These crashes were not reproducible, so the fix is based on a hypothesis >> that there are two possible reasons for them: >> 1. `makeDefaultConfig()` returning `NULL`. >> 2. A race condition when the number of screens changes. >> The rac

Re: RFR: 8284316 : Support accessibility ManualTestFrame.java for non SwingSet tests [v2]

2022-04-07 Thread lawrence . andrews
> 1) Modified ManualTestFrame.java to support non SwingSet2 and this include > modification of SwingSetTest.java > 2) Added new TestJProgressBarAccessibility.java testcase that uses > ManualTestFrame > 3) Added timeout support in case user does not interact with the > ManualTestFrame > > @shu

Re: RFR: 8283706: Add final or sealed modifier to appropriate javax.swing API classes

2022-04-07 Thread Joe Darcy
On Thu, 7 Apr 2022 19:33:28 GMT, Phil Race wrote: >> Thank you for your clarification. > > You have to include it in the list, else it would not be a permitted > sub-class, and then you couldn't use the new syntax at all. > > the javadoc doesn't mention it - it still just says > public sealed c

Re: RFR: 8284521: Write an automated regression test for RFE 4371575

2022-04-07 Thread Phil Race
On Thu, 7 Apr 2022 11:08:38 GMT, Manukumar V S wrote: > Write an automated regression test for > [JDK-4371575](https://bugs.openjdk.java.net/browse/JDK-4371575) > > Issue: > As part of the Merlin focus project, JComponent.setRequestFocusEnabled was > deprecated and its implementation was change

Re: RFR: 8282526: Default icon is not painted properly [v2]

2022-04-07 Thread Alexander Zuev
> Detect the situation where we do need to perform interpolation during > ImageIcon > painting and set a hint to the rendering to perform bicubic approximation so > image details are preserved during transition. Alexander Zuev has updated the pull request with a new target base due to a merge or

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v7]

2022-04-07 Thread Alisen Chung
On Wed, 23 Mar 2022 18:24:05 GMT, Alisen Chung wrote: >> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > scale stroke width at higher

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v8]

2022-04-07 Thread Alisen Chung
> Changed the drawing area to be increased by 0.5 on the left side to prevent > clipping Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: fixed 1.25 scaling overdraw, fixed calcs for right and bottom side borders - Chang

Re: RFR: 8283706: Add final or sealed modifier to appropriate javax.swing API classes

2022-04-07 Thread Phil Race
On Thu, 7 Apr 2022 18:36:55 GMT, Sergey Bylokhov wrote: >> I'm not certain what question you are asking. If the question is, is it fine >> for core reflection to return non-public information about the class, in >> general sure. For example, in jshell evaluating >> StringBuilder.class.getSuperc

Re: RFR: 8283706: Add final or sealed modifier to appropriate javax.swing API classes

2022-04-07 Thread Sergey Bylokhov
On Thu, 7 Apr 2022 04:43:48 GMT, Joe Darcy wrote: >> Just to double-check, it is fine to have it in the output of the >> getPermittedSubclasses for the public class as well? > > I'm not certain what question you are asking. If the question is, is it fine > for core reflection to return non-publ

Re: RFR: 8283706: Add final or sealed modifier to appropriate javax.swing API classes

2022-04-07 Thread Sergey Bylokhov
On Sat, 2 Apr 2022 23:21:03 GMT, Phil Race wrote: > Update Swing classes to use JEP 409 sealed and non-sealed modifiers and add > the final modifier where appropriate. > > jtreg tests and JCK API tests pass > > CSR for review here : https://bugs.openjdk.java.net/browse/JDK-8284214 Marked as r

Re: RFR: 8284378: Make Metal the default Java 2D rendering pipeline for macOS

2022-04-07 Thread Jayathirth D V
On Wed, 6 Apr 2022 09:48:13 GMT, Ajit Ghaisas wrote: > This PR makes Metal rendering pipeline as the default Java 2D rendering > pipeline for macOS. > > Please refer "JBS Description" for more details. Marked as reviewed by jdv (Reviewer). - PR: https://git.openjdk.java.net/jdk/p

Re: RFR: 8284378: Make Metal the default Java 2D rendering pipeline for macOS

2022-04-07 Thread Phil Race
On Wed, 6 Apr 2022 09:48:13 GMT, Ajit Ghaisas wrote: > This PR makes Metal rendering pipeline as the default Java 2D rendering > pipeline for macOS. > > Please refer "JBS Description" for more details. Marked as reviewed by prr (Reviewer). - PR: https://git.openjdk.java.net/jdk/p

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v2]

2022-04-07 Thread Tejesh R
On Thu, 7 Apr 2022 11:19:53 GMT, Alexey Ivanov wrote: > > Why can't the test be automatic? Actually had thought about automating the test case, but since endOfLine(Win - '\r\n', linux - '\n') is different for different OS, have made it manual. - PR: https://git.openjdk.java.ne

Re: RFR: 8284535 : Fix PrintLatinCJKTest.java test that is failing with Parse Exception [v5]

2022-04-07 Thread lawrence . andrews
On Wed, 6 Apr 2022 10:39:44 GMT, Alexey Ivanov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed review comments > > test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java line 85: > >> 83:

Re: RFR: 8284535 : Fix PrintLatinCJKTest.java test that is failing with Parse Exception [v4]

2022-04-07 Thread lawrence . andrews
On Tue, 5 Apr 2022 18:58:27 GMT, Alexey Ivanov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Dispose the Frame based in EDT > > test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java line 91: > >> 89:

Re: RFR: 8284535 : Fix PrintLatinCJKTest.java test that is failing with Parse Exception [v5]

2022-04-07 Thread lawrence . andrews
On Tue, 5 Apr 2022 20:16:28 GMT, lawrence.andrews wrote: >> We need a common manual test framework code that can be shared across all >> the client manual test. This framework class should have the following >> 1) Frame which contains test instruction . >> 2) Pass & Fail button so that user can

Re: RFR: 8284535 : Fix PrintLatinCJKTest.java test that is failing with Parse Exception [v6]

2022-04-07 Thread lawrence . andrews
> We need a common manual test framework code that can be shared across all the > client manual test. This framework class should have the following > 1) Frame which contains test instruction . > 2) Pass & Fail button so that user can mark the test pass or fail > 3) Upon failing the test user shou

Re: RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible [v3]

2022-04-07 Thread Prasanta Sadhukhan
> Issue was when printing a JTable which sits inside a JScrollPane and the > table is scrolled down to the end to about 1000th row, only the first page is > printed. > This is because when the table is scrolled down to last page, the bounds.y > becomes -ve > [x=0,y=-15260,width=968,height=1600

Integrated: 8284444: Sting typo

2022-04-07 Thread Daniel Jeliński
On Wed, 6 Apr 2022 12:07:30 GMT, Daniel Jeliński wrote: > This patch adds missing `r` in `string`s This pull request has now been integrated. Changeset: 5bafcfdc Author:Daniel Jeliński URL: https://git.openjdk.java.net/jdk/commit/5bafcfdc171b5a514ecf620703e77fa2f4a49c58 Stats: 1

Re: RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible [v2]

2022-04-07 Thread Prasanta Sadhukhan
On Thu, 7 Apr 2022 11:48:19 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Test updated >> - Test updated > > test/jdk/javax/swing/JTable/PrintAllPagesTest.java line 53: > >> 51:

Re: RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible [v2]

2022-04-07 Thread Prasanta Sadhukhan
> Issue was when printing a JTable which sits inside a JScrollPane and the > table is scrolled down to the end to about 1000th row, only the first page is > printed. > This is because when the table is scrolled down to last page, the bounds.y > becomes -ve > [x=0,y=-15260,width=968,height=1600

Re: RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible

2022-04-07 Thread Alexey Ivanov
On Thu, 7 Apr 2022 09:17:02 GMT, Prasanta Sadhukhan wrote: > Issue was when printing a JTable which sits inside a JScrollPane and the > table is scrolled down to the end to about 1000th row, only the first page is > printed. > This is because when the table is scrolled down to last page, the

RFR: 8284521: Write an automated regression test for RFE 4371575

2022-04-07 Thread Manukumar V S
Write an automated regression test for [JDK-4371575](https://bugs.openjdk.java.net/browse/JDK-4371575) Issue: As part of the Merlin focus project, JComponent.setRequestFocusEnabled was deprecated and its implementation was changed to map exactly to the new method Component.setFocusable. Scott bel

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v2]

2022-04-07 Thread Alexey Ivanov
On Thu, 7 Apr 2022 10:26:20 GMT, Tejesh R wrote: >> getText function returned extra endOfLine when appended. The reason was in >> `EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)` >> method, where translation happens from buffer to Out(Writer Object) if >> endOfLine

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v2]

2022-04-07 Thread Tejesh R
> getText function returned extra endOfLine when appended. The reason was in > `EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)` > method, where translation happens from buffer to Out(Writer Object) if > endOfLine is other than '\n' ( which is '\r\n' in windows). In or

RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible

2022-04-07 Thread Prasanta Sadhukhan
Issue was when printing a JTable which sits inside a JScrollPane and the table is scrolled down to the end to about 1000th row, only the first page is printed. This is because when the table is scrolled down to last page, the bounds.y becomes -ve [x=0,y=-15260,width=968,height=16000] so the ch

Integrated: 8284166: [macos] Replace deprecated alternateSelectedControlColor with selectedContentBackgroundColor

2022-04-07 Thread Prasanta Sadhukhan
On Fri, 1 Apr 2022 09:39:05 GMT, Prasanta Sadhukhan wrote: > [alternateSelectedControlColor](https://developer.apple.com/documentation/appkit/nscolor/1533135-alternateselectedcontrolcolor?language=objc) > is deprecated since osx10.14 so we need to replace with its alternative > "[selectedConte

Re: RFR: 8283245: Create a test for JDK-4670319 [v2]

2022-04-07 Thread Srinivas Mandalika
> Write an automated regression test for JDK-4670319 > > Issue > When a JTree node is expanded or collapsed, an Accessibility PropertyChange > event is fired with the old state of "collapsed" and new state of "expanded" > (or vice versa). The problem is that the source of the event is the > Ac

RFR: 8284077: Create an automated test for JDK-4170173

2022-04-07 Thread Srinivas Mandalika
Create an automated test for [JDK-4170173](https://bugs.openjdk.java.net/browse/JDK-4170173) Issue JTextComponent.AccessibleJTextComponent.getAfterIndex(int part, int index) works incorrectly, when 'part' parameter is AccessibleText.WORD. It returns a space (" ") instead of the correct word. Th

Re: RFR: JDK-8282933: Create a test for JDK-4529616 [v4]

2022-04-07 Thread Srinivas Mandalika
> JDK-8282933: Create a test for JDK-4529616 > AccessibleJTableCell.isShowing() returns false when the cell is actually on > the screen. > The test validates the fix for the above issue by verifying that the > isShowing call returns true when invoked via the accessiblity context. > This review i