On Sun, 10 Apr 2022 04:53:38 GMT, Prasanta Sadhukhan
wrote:
> > The scroll direction on macOS can be configured, can the test check what
> > type of scroll is used on the current system and then use that to verify
> > the old fix?
>
> I see "Scroll direction: Natural" check in mouse in System
> The test was failing on macos and was excluded in macos because the
> viewposition was not changed after mouse wheel scroll. Seems like mouse wheel
> scroll direction is opposite in macos compared to windows etc so if we try to
> down-wheel scroll in macos when view position is at center of vi
On Sat, 9 Apr 2022 05:35:30 GMT, Sergey Bylokhov wrote:
> The scroll direction on macOS can be configured, can the test check what type
> of scroll is used on the current system and then use that to verify the old
> fix?
I see "Scroll direction: Natural" check in mouse in SystemPreference whic
On Sat, 9 Apr 2022 09:35:39 GMT, Maxim Kartashev wrote:
>>>This is just a named copy of lines 67 to 75. Since now this is the only
>>>piece of code that needs to work holding the AWT lock, I thought it best to
>>>isolate it.
>> As I understand, the purpose of the piece is to find the "new"
>>
> Previously while tabbing through the JTable cell, the cell highlighter/focus
> ring was not visible against the selection background.
>
> Changes are made to Aqua LAF to derive a lighter focus ring color by changing
> saturation and setting brightness component to 100% of original focus ring
On Sat, 9 Apr 2022 06:02:13 GMT, Sergey Bylokhov wrote:
>>> I don't understand why this was extracted out. It isn't called anywhere
>>> else and again makes the diff harder to understand.
>>
>> This AWT lock should be held for a very small portion of the original
>> method. Initially, I left t
On Sat, 9 Apr 2022 05:41:26 GMT, Sergey Bylokhov wrote:
>> Srinivas Mandalika has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Review Comments Fixed: 80 characters line fixed, typo in File Name fixed
>> - Review Comments Fixed: 80 char
On Sat, 9 Apr 2022 05:43:26 GMT, Sergey Bylokhov wrote:
>> Srinivas Mandalika has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review Comment Fixed: Line Length fixed to < 80 characters.
>
> Marked as reviewed by serb (Reviewer).
@mrserb
On Thu, 7 Apr 2022 15:09:27 GMT, lawrence.andrews wrote:
>> We need a common manual test framework code that can be shared across all
>> the client manual test. This framework class should have the following
>> 1) Frame which contains test instruction .
>> 2) Pass & Fail button so that user can
