On Fri, 8 Apr 2022 07:55:57 GMT, Prasanta Sadhukhan
wrote:
>> @prrace @prsadhuk
>> The issue with the system color returned by **keyboardFocusIndicatorColor**
>> mentioned above, persists on macOS 12.3 as well.
>
> "accentColor" is swift property so not usable for jdk but you can use
> "contr
On Sat, 9 Apr 2022 22:13:57 GMT, Sergey Bylokhov wrote:
>> @mrserb I agree with your logic, but fixing this now would certainly be not
>> a semantically null change and would complicate the fix that has already
>> been under review for over two months. I'd be happy to file a bug for this
>> se
On Mon, 11 Apr 2022 05:21:49 GMT, Prasanta Sadhukhan
wrote:
> I guess in that case "else" part in l359 will be executed...I was talking
> about requirement of "else" part in l345
I did a sample test for this case, it did entered l345, I added \n manually at
the end of string, since it passes
On Mon, 11 Apr 2022 05:15:22 GMT, Tejesh R wrote:
> > If this is true, then I guess we can remove `if (array[counter - 1] ==
> > '\r')` check too as it is always true in windows.
>
> If user uses system line separator then it vll be '\r\n' and it vll enter
> this loop, but if user manually ent
On Mon, 11 Apr 2022 04:51:18 GMT, Prasanta Sadhukhan
wrote:
> If this is true, then I guess we can remove `if (array[counter - 1] == '\r')`
> check too as it is always true in windows.
If user uses system line separator then it vll be '\r\n' and it vll enter this
loop, but if user manually en
On Fri, 8 Apr 2022 12:37:36 GMT, Alexey Ivanov wrote:
> What happens if you add `\r` to an arbitrary location in text?
>
> What happens if you read in such a text?
It doesn't matter, since the data is appended only if '\n' is present when
EndofLine is '\r\n'..
-
PR: https://g
On Fri, 8 Apr 2022 12:06:06 GMT, Tejesh R wrote:
> Yes, the original issue was observed and raised in Windows alone.. In Mac
> and Linux the control wont even enters this logic -
>
> ```
> if (endOfLineProperty != null && !endOfLine.equals("\n")) {
> // There is an end of line
On Fri, 8 Apr 2022 17:57:42 GMT, Phil Race wrote:
>> Manukumar V S has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comment fixed: Removed unwanted directory
>
> test/jdk/javax/swing/JComponent/JComponentSetRequestFocusEnabledTest.
