Re: RFR: 8284884: Replace polling with waiting in javax/swing/text/html/parser/Parser/8078268/bug8078268.java [v2]

2022-04-14 Thread Prasanta Sadhukhan
On Thu, 14 Apr 2022 20:36:19 GMT, Alexey Ivanov wrote: >> A quick fix for the >> `javax/swing/text/html/parser/Parser/8078268/bug8078268.java` which replaces >> `Thread.sleep` in a loop with `CountDownLatch.await`. >> >> The code is shorter and clearer. >> >> The test fails on the builds with

Re: RFR: 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java

2022-04-14 Thread Sergey Bylokhov
On Thu, 14 Apr 2022 14:22:18 GMT, Alexander Zvegintsev wrote: > The SimpleWindowActivationTest test does not fail even without > modifications(multiple CI test runs are green). > So just remove it from ProblemList would be enough. > > However I did some clean up and added some delays for "ext

Re: RFR: 8284884: Replace polling with waiting in javax/swing/text/html/parser/Parser/8078268/bug8078268.java [v2]

2022-04-14 Thread Sergey Bylokhov
On Thu, 14 Apr 2022 20:36:19 GMT, Alexey Ivanov wrote: >> A quick fix for the >> `javax/swing/text/html/parser/Parser/8078268/bug8078268.java` which replaces >> `Thread.sleep` in a loop with `CountDownLatch.await`. >> >> The code is shorter and clearer. >> >> The test fails on the builds with

Re: RFR: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException

2022-04-14 Thread Sergey Bylokhov
On Fri, 15 Apr 2022 05:26:11 GMT, Prasanta Sadhukhan wrote: > This test used to fail in nightly testing few years back and it seems it > fails because we used to run in samevm mode at that time. > Several iterations of this test pass in CI testing in all platforms (link in > JBS) so removing f

RFR: 8042380: Test javax/swing/JFileChooser/4524490/bug4524490.java fails with InvocationTargetException

2022-04-14 Thread Prasanta Sadhukhan
This test used to fail in nightly testing few years back and it seems it fails because we used to run in samevm mode at that time. Several iterations of this test pass in CI testing in all platforms (link in JBS) so removing from Problemlist. - Commit messages: - 8042380: Test java

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v5]

2022-04-14 Thread Phil Race
On Fri, 8 Apr 2022 12:17:37 GMT, Tejesh R wrote: >> getText function returned extra endOfLine when appended. The reason was in >> `EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)` >> method, where translation happens from buffer to Out(Writer Object) if >> endOfLine

Integrated: 8223543: [TESTBUG] Regression test java/awt/Graphics2D/DrawString/LCDTextSrcEa.java has issues

2022-04-14 Thread Phil Race
On Wed, 13 Apr 2022 17:08:51 GMT, Phil Race wrote: > This test had problem described in the bug report, and most of it was related > to being headful. > But actually the test didn't need to be headful - it did the actual rendering > it wanted to test to > a software BufferedImage. So make it he

Re: RFR: 8284898 : Enhance PassFailJFrame [v7]

2022-04-14 Thread lawrence . andrews
> Fixed the following issue. > 1) Removed yes/no since test was failing due to "Parser error due to yesno in > @run main/manual=yesno" > 2) After removing yes/no test run( just shows the UI and gets dispose > immediately). User cannot interact with the test UI and mark the test pass or > failed.

Re: RFR: 8283803 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test [v6]

2022-04-14 Thread lawrence . andrews
> Fixed the following issue. > 1) Removed yes/no since test was failing due to "Parser error due to yesno in > @run main/manual=yesno" > 2) After removing yes/no test run( just shows the UI and gets dispose > immediately). User cannot interact with the test UI and mark the test pass or > failed.

Re: RFR: 8284884: Replace polling with waiting in javax/swing/text/html/parser/Parser/8078268/bug8078268.java [v2]

2022-04-14 Thread Alexey Ivanov
> A quick fix for the > `javax/swing/text/html/parser/Parser/8078268/bug8078268.java` which replaces > `Thread.sleep` in a loop with `CountDownLatch.await`. > > The code is shorter and clearer. > > The test fails on the builds without the fix for > [JDK-8078268](https://bugs.openjdk.java.net/b

RFR: 8284884: Replace polling with waiting in javax/swing/text/html/parser/Parser/8078268/bug8078268.java

2022-04-14 Thread Alexey Ivanov
A quick fix for the `javax/swing/text/html/parser/Parser/8078268/bug8078268.java` which replaces `Thread.sleep` in a loop with `CountDownLatch.await`. The code is shorter and clearer. The test fails on the builds without the fix for [JDK-8078268](https://bugs.openjdk.java.net/browse/JDK-807826

Integrated: 8284891: Fix typos in build system files

2022-04-14 Thread Magnus Ihse Bursie
On Thu, 14 Apr 2022 16:05:48 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on the `make` directory, and accepted those changes where > it indeed discovered real typos. > > (Due to false positives this can unfortunately not be run automatically) > > Most of the fixes are in comments. A fe

Integrated: 8284853: Fix various 'expected' typo

2022-04-14 Thread Andrey Turbanov
On Wed, 13 Apr 2022 20:36:48 GMT, Andrey Turbanov wrote: > Found various typos of expected: `exepected`, `exept`, `epectedly`, > `expeced`, `Unexpeted`, etc. This pull request has now been integrated. Changeset: 48c75498 Author:Andrey Turbanov URL: https://git.openjdk.java.net/jdk/

Re: RFR: 8284853: Fix various 'expected' typo [v2]

2022-04-14 Thread Andrey Turbanov
On Thu, 14 Apr 2022 10:38:33 GMT, Yi Yang wrote: >I found [yet another >typo](https://github.com/kelthuzadx/jdk/commit/acb9e15bc0bf5395d1c0875f36992f692734f948), > I wonder if you can merge this into your patch so that I do not need to >submit a new PR for it? Thanks. I think it deserves a sep

Re: RFR: 8274082 : Wrong test case name specified in jtreg run tag for java/awt/print/PrinterJob/SwingUIText.java [v2]

2022-04-14 Thread lawrence . andrews
> Following issues were fixed in this test > 1) Fixed - Parser error due to yesno in @run main/manual=yesno > 2) Fixed Wrong test name specified in @run jtreg > @run main/manual=yesno PrintTextTest . It should be @run main/manual=yesno > SwingUIText > 3) Instruction frame does not have 'Pass' or

Re: RFR: 8284891: Fix typos in build system files

2022-04-14 Thread Erik Joelsson
On Thu, 14 Apr 2022 16:05:48 GMT, Magnus Ihse Bursie wrote: > I ran `codespell` on the `make` directory, and accepted those changes where > it indeed discovered real typos. > > (Due to false positives this can unfortunately not be run automatically) > > Most of the fixes are in comments. A fe

RFR: 8284891: Fix typos in build system files

2022-04-14 Thread Magnus Ihse Bursie
I ran `codespell` on the `make` directory, and accepted those changes where it indeed discovered real typos. (Due to false positives this can unfortunately not be run automatically) Most of the fixes are in comments. A few are in messages aimed at the user. - Commit messages: - 8

RFR: 8159599: [TEST_BUG] java/awt/Modal/ModalInternalFrameTest/ModalInternalFrameTest.java

2022-04-14 Thread Alexander Zvegintsev
The SimpleWindowActivationTest test does not fail even without modifications(multiple CI test runs are green). So just remove it from ProblemList would be enough. However I did some clean up and added some delays for "extra safety". - Commit messages: - initial - initial Changes

Re: RFR: 8284853: Fix various 'expected' typo [v2]

2022-04-14 Thread Magnus Ihse Bursie
On Thu, 14 Apr 2022 09:28:17 GMT, Andrey Turbanov wrote: >> Found various typos of expected: `exepected`, `exept`, `epectedly`, >> `expeced`, `Unexpeted`, etc. > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8284853: Fi

Re: RFR: 8223543: [TESTBUG] Regression test java/awt/Graphics2D/DrawString/LCDTextSrcEa.java has issues

2022-04-14 Thread Alexey Ivanov
On Wed, 13 Apr 2022 17:08:51 GMT, Phil Race wrote: > This test had problem described in the bug report, and most of it was related > to being headful. > But actually the test didn't need to be headful - it did the actual rendering > it wanted to test to > a software BufferedImage. So make it he

Integrated: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-04-14 Thread Tejesh R
On Wed, 9 Mar 2022 10:04:09 GMT, Tejesh R wrote: > Removed the println() line from the Interrupted catch block. Since > waitForID() Interrupt indicates completion of Image Loading, println as > Interrupt handling was not required. This pull request has now been integrated. Changeset: f2640317

Re: RFR: 8223543: [TESTBUG] Regression test java/awt/Graphics2D/DrawString/LCDTextSrcEa.java has issues

2022-04-14 Thread Alexander Zvegintsev
On Wed, 13 Apr 2022 17:08:51 GMT, Phil Race wrote: > This test had problem described in the bug report, and most of it was related > to being headful. > But actually the test didn't need to be headful - it did the actual rendering > it wanted to test to > a software BufferedImage. So make it he

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v11]

2022-04-14 Thread Tejesh R
On Tue, 12 Apr 2022 20:50:48 GMT, Phil Race wrote: >> This is intentional, it makes sure the image is in `LOADING` state to verify >> that the newly added resets it to `ABORTED`. >> >> I don't expect the image to load, we don't care. If it succeeds, the status >> is `COMPLETE`; if it times out

Re: RFR: 8277816: Client tests fail on macos-Aarch64 host

2022-04-14 Thread Alexander Zvegintsev
On Wed, 13 Apr 2022 07:40:50 GMT, Prasanta Sadhukhan wrote: > This tests was failing on macos12 M1 systems due to wrong color profile > configurations set in CI systems. > If correct sRGB IEC61966-2.1 is set, then these test passed. Test job link in > JBS.. > > So, removing from Problem list.

Re: RFR: 8284853: Fix various 'expected' typo [v2]

2022-04-14 Thread Yi Yang
On Thu, 14 Apr 2022 09:28:17 GMT, Andrey Turbanov wrote: >> Found various typos of expected: `exepected`, `exept`, `epectedly`, >> `expeced`, `Unexpeted`, etc. > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8284853: Fi

Re: RFR: 8280468: Crashes in getConfigColormap, getConfigVisualId, XVisualIDFromVisual on Linux [v5]

2022-04-14 Thread Maxim Kartashev
On Fri, 8 Apr 2022 16:20:10 GMT, Phil Race wrote: >> Maxim Kartashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Restored the original code in X11GraphicsDevice.java that got >> auto-formatted > > src/java.desktop/unix/classes/sun/a

Re: RFR: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS

2022-04-14 Thread Prasanta Sadhukhan
On Thu, 14 Apr 2022 09:17:17 GMT, Sergey Bylokhov wrote: >> JDK-4517214 was fixed for Metal L&F where JComboBox having TitledBorder used >> to have double height compared to normal JComboBox. >> The issue is still observed for macos for Aqua L&F where still double height >> is seen. >> Fix is t

Re: RFR: 8284853: Fix various 'expected' typo [v2]

2022-04-14 Thread Andrey Turbanov
> Found various typos of expected: `exepected`, `exept`, `epectedly`, > `expeced`, `Unexpeted`, etc. Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8284853: Fix various 'expected' typo improve test log - Changes:

Re: RFR: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS

2022-04-14 Thread Sergey Bylokhov
On Thu, 14 Apr 2022 06:50:10 GMT, Prasanta Sadhukhan wrote: > JDK-4517214 was fixed for Metal L&F where JComboBox having TitledBorder used > to have double height compared to normal JComboBox. > The issue is still observed for macos for Aqua L&F where still double height > is seen. > Fix is to

Re: RFR: 8280468: Crashes in getConfigColormap, getConfigVisualId, XVisualIDFromVisual on Linux [v5]

2022-04-14 Thread Sergey Bylokhov
On Fri, 8 Apr 2022 06:49:09 GMT, Maxim Kartashev wrote: >> These crashes were not reproducible, so the fix is based on a hypothesis >> that there are two possible reasons for them: >> 1. `makeDefaultConfig()` returning `NULL`. >> 2. A race condition when the number of screens changes. >> The rac

Re: RFR: 8223543: [TESTBUG] Regression test java/awt/Graphics2D/DrawString/LCDTextSrcEa.java has issues

2022-04-14 Thread Sergey Bylokhov
On Wed, 13 Apr 2022 17:08:51 GMT, Phil Race wrote: > This test had problem described in the bug report, and most of it was related > to being headful. > But actually the test didn't need to be headful - it did the actual rendering > it wanted to test to > a software BufferedImage. So make it he

Re: RFR: 8144030: [macosx] test java/awt/Frame/ShapeNotSetSometimes/ShapeNotSetSometimes.java fails (again) [v2]

2022-04-14 Thread Sergey Bylokhov
On Wed, 13 Apr 2022 23:18:07 GMT, Alexander Zvegintsev wrote: >> This test has two undecorated frames: >> >> 1. background, 300x300 >> 2. shaped foreground, 200x200 >> >> After displaying this frames it tries to check color outside of shape but >> within frame 2 bounds. >> >> Unfortunately,

Integrated: 8159694: HiDPI, Unity, java/awt/dnd/DropTargetEnterExitTest/MissedDragExitTest.java

2022-04-14 Thread Alexander Zvegintsev
On Wed, 13 Apr 2022 11:27:44 GMT, Alexander Zvegintsev wrote: > Window's title height was increased in Gnome/Unity since it was written, so > the test tries to initiate drag on frame's header instead of its body. > Making the frame undecorated solves the issue. > Testing is green on all platf

Integrated: 6626492: Event time in future part 2, now on X

2022-04-14 Thread Alexander Zvegintsev
On Wed, 13 Apr 2022 20:51:41 GMT, Alexander Zvegintsev wrote: > This fix simply remove the test from ProblemList, since the issue is no > longer reproducible. > > Multiple CI test runs are green. This pull request has now been integrated. Changeset: 23c6817c Author:Alexander Zvegintsev

RFR: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS

2022-04-14 Thread Prasanta Sadhukhan
JDK-4517214 was fixed for Metal L&F where JComboBox having TitledBorder used to have double height compared to normal JComboBox. The issue is still observed for macos for Aqua L&F where still double height is seen. Fix is to prevent adding border insets height to combobox size as was done for [M