On Tue, 19 Apr 2022 09:10:30 GMT, Prasanta Sadhukhan
wrote:
> Few swing tests call System.exit() which might stop the test harness from
> executing further tests if any of the test fail. We should replace with
> RuntimeException.
This pull request has now been integrated.
Changeset: 80219a48
On Thu, 21 Apr 2022 16:30:20 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/swing/JTabbedPane/4209065/bug4209065.java line 51:
>>
>>> 49: tab height but this is OK and NOT a failure.
>>> 50: """;
>>> 51:
>>
>> looks ok in jtreg but standalone execution in my windows fai
Create an automated test for
[JDK-4702233](https://bugs.openjdk.java.net/browse/JDK-4702233)
Several new AccessibleRole and AccessibleRelation constants are needed in those
classes in the java.accessibility package. These new contants codify additions
made in the GNOME, Netscape, and UNO (StarO
Clean up imports;
Close and dispose frame before exiting the test;
-
Commit messages:
- Remove test from the ProblemList
- 8196367: java/awt/List/SingleModeDeselect/SingleModeDeselect.java times out
Changes: https://git.openjdk.java.net/jdk/pull/8351/files
Webrev: https://webrevs.
On Thu, 21 Apr 2022 07:58:39 GMT, Alexander Zvegintsev
wrote:
> The test was failing due to it tried to place windows too close to left top
> corner, so they got shifted from the dock and top panel on Gnome.
>
> Shifting all test windows fixes the issue.
>
>
> Testing is green on all platfor
On Tue, 19 Apr 2022 20:03:57 GMT, Alexander Zvegintsev
wrote:
> Test was written based on assumption that we will receive only one
> `mouseWheelMoved` event with `getWheelRotation() == 20` after
> `robot.mouseWheel(20)` call, but we can receive 20 events with
> `getWheelRotation == 1` instea
> Few swing tests call System.exit() which might stop the test harness from
> executing further tests if any of the test fail. We should replace with
> RuntimeException.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
whitespa
On Thu, 21 Apr 2022 09:14:14 GMT, Toshio Nakamura wrote:
> Japanese logical fonts are drawn with wrong size since Java 18.
> It's triggered by JEP 400, UTF-8 by Default. `sun.awt.FontConfiguration` (and
> `sun.awt.windows.WFontConfiguration`) seems to expect the native encoding
> instead of the
Japanese logical fonts are drawn with wrong size since Java 18.
It's triggered by JEP 400, UTF-8 by Default. `sun.awt.FontConfiguration` (and
`sun.awt.windows.WFontConfiguration`) seems to expect the native encoding
instead of the default encoding. This patch changes to use native encoding.
Test
> added EmbeddedFrame support for macosx in regtesthelpers
Alisen Chung has updated the pull request incrementally with two additional
commits since the last revision:
- Merge branch '7080150' of github.com:alisenchung/jdk into 7080150
- fixed merge conflict
-
Changes:
- all: h
added EmbeddedFrame support for macosx in regtesthelpers
-
Commit messages:
- Merge branch 'master' into 7080150
- removed from ProblemList.txt
- added macos EmbeddedFrame support to AWT regtesthelpers
Changes: https://git.openjdk.java.net/jdk/pull/8348/files
Webrev: https://webr
On Mon, 18 Apr 2022 16:31:15 GMT, Phil Race wrote:
> Note that even though API javadoc is touched all these typos fall well below
> the threshold for a CSR…
That was my understanding. Thank you for confirming it.
-
PR: https://git.openjdk.java.net/jdk/pull/8274
On Sat, 16 Apr 2022 17:45:16 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> I fixed a couple of other spelling mistakes.
>
> I also expanded wildcard imports.
This pull request has now been integrated.
Change
> Clear the kCGEventFlagMaskSecondaryFn flag if it is set before posting
> keyboard events to the system queue.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Adding test case.
-
Changes:
- all: https://git.openjdk
On Thu, 21 Apr 2022 15:23:31 GMT, Phil Race wrote:
>> test/jdk/java/awt/Frame/InvisibleOwner/InvisibleOwner.java line 135:
>>
>>> 133: ownedWindowBounds.y +
>>> ownedWindowBounds.height / 2);
>>> 134: robot.mousePress(InputEvent.BUTTON1_MASK);
>>> 135:
Looks like this test was written based on assumption that SystemTray is
supported on all platforms.
However on Linux it may not be true.
Availability of SystemTray is detected by getting owner of `_NET_SYSTEM_TRAY`
selection:
https://github.com/openjdk/jdk/blob/739769c8fc4b496f08a92225a12d074
> The exisiting manual test case tests different html styles of JTabbedPane tab
> title. The tab with "big" as title is seen to be clipped on Aqua LAF for
> larger font-size. In other LAFs it is observed that bigger font-size can be
> accommodated without clipping.
>
> The following approaches
This fix moves a closed test to open but updated to be more comprehensive in
testing multiple pipelines and with some stabilisation improvements.
-
Commit messages:
- 8284965
Changes: https://git.openjdk.java.net/jdk/pull/8345/files
Webrev: https://webrevs.openjdk.java.net/?repo=j
On Thu, 21 Apr 2022 16:28:53 GMT, Prasanta Sadhukhan
wrote:
>> @prsadhuk With the new changes a public method is added to AquaImageFactory,
>> does this require a CSR?
>
> If you are talking about getCellHighlightColorUIResource() then no. We don't
> have specs for this class.
> I have added s
On Thu, 21 Apr 2022 16:18:46 GMT, Prasanta Sadhukhan
wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changed test case to use PassFailJFrame instead of Applet
>
> test/jdk/javax/swing/JTabbedPane/4209065/bug420
On Thu, 21 Apr 2022 15:34:05 GMT, Harshitha Onkar wrote:
>> It seems KEYBOARD_FOCUS_COLOR via `focusRingColor` is also used for
>> menuSelectedBackgroundColor which is used for
>>
>> CheckBoxMenuItem.selectionBackground
>> ComboBox.selectionBackground
>> Menu.selectionBackground
>> MenuBar.sel
On Wed, 20 Apr 2022 23:55:05 GMT, Harshitha Onkar wrote:
>> The exisiting manual test case tests different html styles of JTabbedPane
>> tab title. The tab with "big" as title is seen to be clipped on Aqua LAF for
>> larger font-size. In other LAFs it is observed that bigger font-size can be
>
On Mon, 11 Apr 2022 07:06:59 GMT, Prasanta Sadhukhan
wrote:
>> @prsadhuk Update PR with the recommended changes. The "controlAccentColor"
>> changes works as expected in Mac 12.3 as well.
>> One thing that I wanted to clarify with the fix is - the focus ring color
>> ("Focus.ring") is used at
On Wed, 20 Apr 2022 19:30:49 GMT, Phil Race wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> test summary updated
>
> test/jdk/javax/swing/JTabbedPane/4209065/bug4209065.java line 55:
>
>> 53:
On Thu, 21 Apr 2022 08:45:14 GMT, Prasanta Sadhukhan
wrote:
> Maybe a Thread.sleep(1000) is also needed after frame.setVisible(true); and
> also frame.dispose() as test() is called 4 times so we will give time to
> setup test after frame is visible and frame is disposed at test completion.
I
On Thu, 21 Apr 2022 14:42:03 GMT, Alexander Zvegintsev
wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8285094
>
> test/jdk/java/awt/Frame/InvisibleOwner/InvisibleOwner.java line 135:
>
>> 133:
> As discussed in https://bugs.openjdk.java.net/browse/JDK-8285094 it seems
> that the test
> java/awt/Frame/GetGraphicsStressTest/GetGraphicsStressTest.java destabilises
> the Xserver.
> This causes java/awt/Frame/InvisibleOwner/InvisibleOwner.java to fail and
> even before that
> other tests w
On Wed, 20 Apr 2022 04:13:09 GMT, Phil Race wrote:
> As discussed in https://bugs.openjdk.java.net/browse/JDK-8285094 it seems
> that the test
> java/awt/Frame/GetGraphicsStressTest/GetGraphicsStressTest.java destabilises
> the Xserver.
> This causes java/awt/Frame/InvisibleOwner/InvisibleOwner
Those tests were failing on Solaris, which is no longer supported.
They pass as they are, but decreasing of delays reduce execution time
significantly:
e.g. proposed changes drops execution time from ~5min to ~2 min
for MouseButtonsAndKeyMasksTest on my machine.
Testing is green on all platfor
On Tue, 19 Apr 2022 11:48:10 GMT, Alexander Zvegintsev
wrote:
> Removing the test from problem list, since I am unable to reproduce the issue
> even with old Ubuntu distros with jdk8.
> Bug filed against Solaris initially, but I did not test on it, since it is no
> longer supported.
>
> Multi
On Wed, 20 Apr 2022 17:04:09 GMT, Alexander Zuev wrote:
> Clear the kCGEventFlagMaskSecondaryFn flag if it is set before posting
> keyboard events to the system queue.
I assumed that whatever keys we set on an event being posted using
`CGEventPost`, are delivered unchanged to the 'receiving' a
Create an automated test for
[JDK-4495286](https://bugs.openjdk.java.net/browse/JDK-4495286)
AccessibleJTable.setAccessibleSelction should select rows/cols when cell
selection.
When cell selection is not enabled, there is no way, using
accessibility, to select rows or columns. It seems logical t
On Thu, 21 Apr 2022 10:34:42 GMT, Jaikiran Pai wrote:
> Can I please get a review for this trivial fix to the copyright header?
Thank you David for the quick review.
(Given the trivial nature of this fix and the fact that tier1 testing failed
without this change, going ahead with the integrati
On Thu, 21 Apr 2022 10:34:42 GMT, Jaikiran Pai wrote:
> Can I please get a review for this trivial fix to the copyright header?
This pull request has now been integrated.
Changeset: 9a905ccc
Author:Jaikiran Pai
URL:
https://git.openjdk.java.net/jdk/commit/9a905ccc5e6411c3b68277b58e7
Can I please get a review for this trivial fix to the copyright header?
-
Commit messages:
- fix copyright header
Changes: https://git.openjdk.java.net/jdk/pull/8331/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8331&range=00
Issue: https://bugs.openjdk.java.net/bro
On Thu, 21 Apr 2022 10:34:42 GMT, Jaikiran Pai wrote:
> Can I please get a review for this trivial fix to the copyright header?
Thanks for fixing.
-
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8331
On Wed, 13 Apr 2022 07:40:50 GMT, Prasanta Sadhukhan
wrote:
> This tests was failing on macos12 M1 systems due to wrong color profile
> configurations set in CI systems.
> If correct sRGB IEC61966-2.1 is set, then these test passed. Test job link in
> JBS..
>
> So, removing from Problem list.
On Mon, 11 Apr 2022 08:38:43 GMT, Prasanta Sadhukhan
wrote:
> Few tests are seen to be failing in macos12 M1 system due to slight
> difference in color as mentioned in
> [JDK-8277816](https://bugs.openjdk.java.net/browse/JDK-8277816)
>
> It seems the color difference was around 6-7 for swing
On Tue, 29 Mar 2022 10:44:51 GMT, Alexey Ushakov wrote:
> Throwing InvalidPipeException for incompatible surfaces
This pull request has now been integrated.
Changeset: 90983431
Author:Alexey Ushakov
URL:
https://git.openjdk.java.net/jdk/commit/90983431c5493ea32a983bfe948ec8b32a9a28a
On Wed, 20 Apr 2022 16:14:12 GMT, Alexey Ushakov wrote:
>> Throwing InvalidPipeException for incompatible surfaces
>
> Alexey Ushakov has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - 8283794: CCE in XRTextRenderer.drawGlyphList and XRMaskF
On Wed, 20 Apr 2022 04:13:09 GMT, Phil Race wrote:
> As discussed in https://bugs.openjdk.java.net/browse/JDK-8285094 it seems
> that the test
> java/awt/Frame/GetGraphicsStressTest/GetGraphicsStressTest.java destabilises
> the Xserver.
> This causes java/awt/Frame/InvisibleOwner/InvisibleOwner
I ran `codespell` on the `src/java.desktop` directory, and accepted those
changes where it indeed discovered real typos.
I ignored typos in public methods and variables. Maybe they can be fixed later
on without much fanfare, if they are in internal classes. Typos in exposed APIs
are likely here
The test was failing due to it tried to place windows too close to left top
corner, so they got shifted from the dock and top panel on Gnome.
Shifting all test windows fixes the issue.
Testing is green on all platforms.
-
Commit messages:
- initial
Changes: https://git.openjdk.j
On Fri, 8 Apr 2022 16:20:10 GMT, Phil Race wrote:
>> Maxim Kartashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Restored the original code in X11GraphicsDevice.java that got
>> auto-formatted
>
> src/java.desktop/unix/classes/sun/a
44 matches
Mail list logo
