Re: RFR: 8284316 : Support accessibility ManualTestFrame.java for non SwingSet tests [v2]

2022-05-02 Thread Alexander Zuev
On Thu, 7 Apr 2022 22:59:33 GMT, lawrence.andrews wrote: >> 1) Modified ManualTestFrame.java to support non SwingSet2 and this include >> modification of SwingSetTest.java >> 2) Added new TestJProgressBarAccessibility.java testcase that uses >> ManualTestFrame >> 3) Added timeout support in ca

Re: RFR: 8284316 : Support accessibility ManualTestFrame.java for non SwingSet tests [v2]

2022-05-02 Thread Alexandre Iline
On Thu, 7 Apr 2022 22:59:33 GMT, lawrence.andrews wrote: >> 1) Modified ManualTestFrame.java to support non SwingSet2 and this include >> modification of SwingSetTest.java >> 2) Added new TestJProgressBarAccessibility.java testcase that uses >> ManualTestFrame >> 3) Added timeout support in ca

Re: RFR: 8282771 : Create test case for JDK-8262981 [v4]

2022-05-02 Thread Alexandre Iline
On Tue, 22 Mar 2022 15:14:34 GMT, lawrence.andrews wrote: >> Following methods are covered in this testcase >> getAccessibleAction() >> getAccessibleActionCount() >> doAccessibleAction(int direction) >> >> @shurymury > > lawrence.andrews has updated the pull request incrementally with one > a

Re: RFR: 8285308: Win: Japanese logical fonts are drawn with wrong size [v2]

2022-05-02 Thread Phil Race
On Mon, 25 Apr 2022 08:15:18 GMT, Toshio Nakamura wrote: >> Japanese logical fonts are drawn with wrong size since Java 18. >> It's triggered by JEP 400, UTF-8 by Default. `sun.awt.FontConfiguration` >> (and `sun.awt.windows.WFontConfiguration`) seems to expect the native >> encoding instead of

Re: RFR: 8285308: Win: Japanese logical fonts are drawn with wrong size [v2]

2022-05-02 Thread Naoto Sato
On Mon, 25 Apr 2022 08:15:18 GMT, Toshio Nakamura wrote: >> Japanese logical fonts are drawn with wrong size since Java 18. >> It's triggered by JEP 400, UTF-8 by Default. `sun.awt.FontConfiguration` >> (and `sun.awt.windows.WFontConfiguration`) seems to expect the native >> encoding instead of

RFR: JDK-8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"

2022-05-02 Thread Harshitha Onkar
This test case tests the functionality of `setAlwaysOnTop`. Documentation on `setAlwaysOnTop`: [Link](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/java/awt/Window.html#setAlwaysOnTop(boolean)) The following test case was seen to fail on windows and linux platforms. With the p

Re: RFR: 8285308: Win: Japanese logical fonts are drawn with wrong size [v2]

2022-05-02 Thread Phil Race
On Thu, 28 Apr 2022 23:11:20 GMT, Naoto Sato wrote: >> Toshio Nakamura has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Moved the fix to WFontConfiguration > > The following diff seems to choose the right font: > > --- a/src/java.desktop

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v7]

2022-05-02 Thread Alisen Chung
On Mon, 28 Mar 2022 20:43:47 GMT, Alexey Ivanov wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> scale stroke width at higher scalings > > What if we don't reset the scale to 1.0 and use a thicker stroke to draw >

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v10]

2022-05-02 Thread Alisen Chung
> Changed the drawing area to be increased by 0.5 on the left side to prevent > clipping Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: updated test - Changes: - all: https://git.openjdk.java.net/jdk/pull/7449/files

RFR: 8278367: JNI critical region violation in CTextPipe.m:363

2022-05-02 Thread Phil Race
This re-jigs some lines of code so that we do all the lookups of the arrays before calling the GetPrimitiveArrayCritical on both of them together. Thereby avoiding warnings about calling those other methods in that context. - Commit messages: - 8278367 Changes: https://git.openjdk

Re: RFR: 8285698: Create a test to check the focus stealing of JPopupMenu from JComboBox

2022-05-02 Thread Manukumar V S
On Wed, 27 Apr 2022 11:22:48 GMT, Manukumar V S wrote: > This test verifies that showing a JPopupMenu shouldn't steal the focus out of > current focused component.. > This fix moves an unstable closed test to open but updated to be more > comprehensive in testing multiple Look and Feels and wit

RFR: 8285962: NimbusDefaults has a typo in a L&F property

2022-05-02 Thread Prasanta Sadhukhan
BasicLookAndFeel, BasicProgressBarUI, GTKLookAndFeel tries to find property by "ProgressBar.verticalSize" but the property defined in NimbusDefaults has a typo "vertictalSize ". Rectified the typo. - Commit messages: - 8285962: NimbusDefaults has a typo in a L&F property Changes:

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v2]

2022-05-02 Thread Tejesh R
On Mon, 2 May 2022 03:21:25 GMT, Tejesh R wrote: >> In Button ToolTip, Mnemonic key string was shown only in Metal Look and >> Feel, since the feature is implemented in it. In other L&F especially >> Windows L&F the feature is not available. In order to make it available for >> other L&F's, th

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v2]

2022-05-02 Thread Tejesh R
On Mon, 2 May 2022 05:03:40 GMT, Prasanta Sadhukhan wrote: > I believe you can migrate the closed test to open and iterate through all > L&Fs and add that to the PR. Means to Iterate through all L&F's and wait for specific amount of time for user to validate and go on to next L&F...? Beca

RFR: 8134640 ( Left Insets Margin Test ) moved to open repo from closed

2022-05-02 Thread Tejesh R
The Test had been updated to use all Supported Look and Feel in closed repo. The same has been moved to open repo. - Commit messages: - Moved Test Case 4380543 from closed to open - Merge branch 'master' of github.com:TejeshR13/jdk - Merge branch 'openjdk:master' into master - Me

Withdrawn: 8134640 ( Left Insets Margin Test ) moved to open repo from closed

2022-05-02 Thread Tejesh R
On Mon, 2 May 2022 08:07:49 GMT, Tejesh R wrote: > The Test had been updated to use all Supported Look and Feel in closed repo. > The same has been moved to open repo. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/8497

Re: RFR: 8134640 ( Left Insets Margin Test ) moved to open repo from closed [v2]

2022-05-02 Thread Prasanta Sadhukhan
On Mon, 2 May 2022 08:23:15 GMT, Tejesh R wrote: >> The Test had been updated to use all Supported Look and Feel in closed repo. >> The same has been moved to open repo. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Copyrigh

Re: RFR: 8134640 ( Left Insets Margin Test ) moved to open repo from closed [v2]

2022-05-02 Thread Tejesh R
> The Test had been updated to use all Supported Look and Feel in closed repo. > The same has been moved to open repo. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Copyright Added - Changes: - all: https://git.openjdk.

RFR: 8134640 ( Left Insets Margin Test ) moved to open repo from closed

2022-05-02 Thread Tejesh R
The Test had been updated to use all Supported Look and Feel in closed repo. The same has been moved to open repo. - Commit messages: - Moved Test Case 4380543 from closed to open - Feature moved to ToolTipUI and updated MetalToolTipUI Accordingly - Feature moved to ToolTipUI and

Re: RFR: 8285397: JNI exception pending in CUPSfuncs.c:250

2022-05-02 Thread Prasanta Sadhukhan
On Sun, 1 May 2022 19:31:01 GMT, Phil Race wrote: > A tool checking for JNI errors complains that the call to > JNU_NewStringPlatform(..) > might throw an exception and subsequent JNI code isn't making sure of that. > Clear the exception so the error handling code can do its thing. src/java.des