On Wed, 4 May 2022 11:04:50 GMT, Prasanta Sadhukhan
wrote:
>> Test used to fail in specific CI macos M1 system owing to miniscule color
>> difference
>>
>>
>> x 0 y 0 red1 171 red2 171 green1 174 green2 175 blue1 184 blue2 184
>> x 0 y 1 red1 172 red2 173 green1 177 green2 177 blue1 185 blue
On Fri, 29 Apr 2022 22:39:28 GMT, lawrence.andrews
wrote:
> 1) Removed Applet dependent code and used Frame as top level.
> 2) Automated the manual test.
>
> @shurymury
test/jdk/java/awt/TextArea/SelectionVisible/SelectionVisible.java line 51:
> 49:
> 50: frame.add(ta);
> 51:
On Wed, 27 Apr 2022 07:54:18 GMT, Srinivas Mandalika
wrote:
> reate an automated test for
> [JDK-4702199](https://bugs.openjdk.java.net/browse/JDK-4702199)
>
> In order for spatial Braille to work and screen reader "review mode", we need
> bounding rectangle information for all text on the sc
On Wed, 27 Apr 2022 19:48:15 GMT, Alisen Chung wrote:
> Removed serial tag in method documentation
Marked as reviewed by prr (Reviewer).
doc-only - my review should be enough
-
PR: https://git.openjdk.java.net/jdk/pull/8432
On Thu, 28 Apr 2022 22:40:32 GMT, Sergey Bylokhov wrote:
> > Modified the test to not show the frame which cause the problem to go away
>
> Does it mean that setVisible(true) cause some memory leak since it prevents
> the window to be disposed?
Since 9 windows are freed .. I doubt it .. but wh
> This test case tests the functionality of `setAlwaysOnTop`.
> Documentation on `setAlwaysOnTop`:
> [Link](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/java/awt/Window.html#setAlwaysOnTop(boolean))
>
> The following test case was seen to fail on windows and linux platforms. W
> This test case tests the functionality of `setAlwaysOnTop`.
> Documentation on `setAlwaysOnTop`:
> [Link](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/java/awt/Window.html#setAlwaysOnTop(boolean))
>
> The following test case was seen to fail on windows and linux platforms. W
On Wed, 4 May 2022 18:15:10 GMT, Harshitha Onkar wrote:
>> I think that's a reasonable suggestion in general to bear in mind when
>> writing tests.
>> I've seen tests which bail at the first failure and you wish you knew how
>> the rest of it worked out ..
>> Like (say) a test that iterates ove
> A tool checking for JNI errors complains that the call to
> JNU_NewStringPlatform(..)
> might throw an exception and subsequent JNI code isn't making sure of that.
> Clear the exception so the error handling code can do its thing.
Phil Race has updated the pull request incrementally with one ad
On Mon, 2 May 2022 07:19:29 GMT, Prasanta Sadhukhan
wrote:
>> A tool checking for JNI errors complains that the call to
>> JNU_NewStringPlatform(..)
>> might throw an exception and subsequent JNI code isn't making sure of that.
>> Clear the exception so the error handling code can do its thing.
On Wed, 4 May 2022 18:10:03 GMT, Phil Race wrote:
>> @azuev-java Thank you for the suggestion. I can definitely add this
>> functionality to the test for better failure analysis.
>
> I think that's a reasonable suggestion in general to bear in mind when
> writing tests.
> I've seen tests which
On Wed, 4 May 2022 16:32:09 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on
> macosx-aarch64.
This would be why I pinged in https://github.com/openjdk/jdk/pull/8380 this
morning.
That PR has been under review f
On Wed, 4 May 2022 18:02:48 GMT, Harshitha Onkar wrote:
>> test/jdk/java/awt/Window/MultiWindowApp/ChildAlwaysOnTopTest.java line 165:
>>
>>> 163: throw new RuntimeException("Scenario 1: alwaysOnTop
>>> window is "+
>>> 164: "sent back by another child wi
On Wed, 4 May 2022 17:58:17 GMT, Alexander Zuev wrote:
>> This test case tests the functionality of `setAlwaysOnTop`.
>> Documentation on `setAlwaysOnTop`:
>> [Link](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/java/awt/Window.html#setAlwaysOnTop(boolean))
>>
>> The followin
On Mon, 2 May 2022 21:02:02 GMT, Harshitha Onkar wrote:
> This test case tests the functionality of `setAlwaysOnTop`.
> Documentation on `setAlwaysOnTop`:
> [Link](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/java/awt/Window.html#setAlwaysOnTop(boolean))
>
> The following te
On Wed, 4 May 2022 11:04:50 GMT, Prasanta Sadhukhan
wrote:
>> Test used to fail in specific CI macos M1 system owing to miniscule color
>> difference
>>
>>
>> x 0 y 0 red1 171 red2 171 green1 174 green2 175 blue1 184 blue2 184
>> x 0 y 1 red1 172 red2 173 green1 177 green2 177 blue1 185 blue
On Wed, 4 May 2022 11:00:43 GMT, Prasanta Sadhukhan
wrote:
> > This is occurring only on the M1 imac where despite having the right
> > profile we see "off by 1/255" errors sometimes. So why do we need a color
> > tolerance of 25 ? Why isn't it 1 ?
>
> It was there from start so did not tinke
On Wed, 4 May 2022 16:32:09 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on
> macosx-aarch64.
I didn't see the need to PL this. There's a fix under review !
-
PR: https://git.openjdk.java.net/jdk/p
On Wed, 4 May 2022 11:04:50 GMT, Prasanta Sadhukhan
wrote:
>> Test used to fail in specific CI macos M1 system owing to miniscule color
>> difference
>>
>>
>> x 0 y 0 red1 171 red2 171 green1 174 green2 175 blue1 184 blue2 184
>> x 0 y 1 red1 172 red2 173 green1 177 green2 177 blue1 185 blue
On Tue, 3 May 2022 21:42:35 GMT, Phil Race wrote:
>> Toshio Nakamura has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Moved the fix to WFontConfiguration
>
> It looks to me as if we specify a latin font as the text component font, some
>
On Wed, 4 May 2022 16:33:43 GMT, Brian Burkhalter wrote:
>> A trivial fix to ProblemList
>> javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on
>> macosx-aarch64.
>
> Marked as reviewed by bpb (Reviewer).
@bplb - Thanks for the lightning fast review!
-
PR: https://g
On Wed, 4 May 2022 16:32:09 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on
> macosx-aarch64.
This pull request has now been integrated.
Changeset: 497a94fe
Author:Daniel D. Daugherty
URL:
https://g
On Wed, 4 May 2022 16:32:09 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on
> macosx-aarch64.
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8538
A trivial fix to ProblemList
javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on
macosx-aarch64.
-
Commit messages:
- 8286138: ProblemList
javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java on macosx-aarch64
Changes: https://git.openjdk.java.net/jdk/pull
On Wed, 4 May 2022 11:04:50 GMT, Prasanta Sadhukhan
wrote:
>> Test used to fail in specific CI macos M1 system owing to miniscule color
>> difference
>>
>>
>> x 0 y 0 red1 171 red2 171 green1 174 green2 175 blue1 184 blue2 184
>> x 0 y 1 red1 172 red2 173 green1 177 green2 177 blue1 185 blue
On Mon, 2 May 2022 19:53:44 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> updated test
src/java.desktop
On Mon, 2 May 2022 19:53:44 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> updated test
I was worried th
On Tue, 3 May 2022 21:42:35 GMT, Phil Race wrote:
>> Toshio Nakamura has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Moved the fix to WFontConfiguration
>
> It looks to me as if we specify a latin font as the text component font, some
>
> Japanese logical fonts are drawn with wrong size since Java 18.
> It's triggered by JEP 400, UTF-8 by Default. `sun.awt.FontConfiguration` (and
> `sun.awt.windows.WFontConfiguration`) seems to expect the native encoding
> instead of the default encoding. This patch changes to use native encodin
On Wed, 20 Apr 2022 23:35:10 GMT, lukeu wrote:
> > Made a small change with the bottom line to match the left line of the
> > border
>
> Great, that looks like it'll fix it so I won't test again, I'll defer to the
> others now for the code review. (I'd be happy to chip in there too, but I'm
>
On Tue, 3 May 2022 21:31:18 GMT, Alexey Ivanov wrote:
> The test still verifies only one case out of four. You use image to render
> and check, the frame is not necessary in this case and the test can be made
> headless. However, I'd like to still have the option to create the frame for
> visu
On Wed, 4 May 2022 11:00:43 GMT, Prasanta Sadhukhan
wrote:
>> This is occurring only on the M1 imac where despite having the right profile
>> we see "off by 1/255" errors sometimes.
>> So why do we need a color tolerance of 25 ? Why isn't it 1 ?
>
>> This is occurring only on the M1 imac where
2 open tests were seen to be failing in macos12 which happen to have same root
cause as
8273506: java Robot API did the 'm' keypress and caused /awt/event/Ke
With that fix being committed, testing on intended macos12 systems are not able
to reproduce this failures so we can remove from Prob
On Tue, 3 May 2022 23:49:22 GMT, Phil Race wrote:
> This is occurring only on the M1 imac where despite having the right profile
> we see "off by 1/255" errors sometimes. So why do we need a color tolerance
> of 25 ? Why isn't it 1 ?
It was there from start so did not tinker although I tested
> Test used to fail in specific CI macos M1 system owing to miniscule color
> difference
>
>
> x 0 y 0 red1 171 red2 171 green1 174 green2 175 blue1 184 blue2 184
> x 0 y 1 red1 172 red2 173 green1 177 green2 177 blue1 185 blue2 185
> x 0 y 2 red1 173 red2 174 green1 177 green2 178 blue1 187 bl
On Wed, 4 May 2022 08:34:43 GMT, David Holmes wrote:
> I'm confused.
> `src\jdk.crypto.mscapi\windows\native\libsunmscapi\security.cpp` doesn't set
> _WIN32_WINNT so how is that later API being enabled? Does this mean that not
> setting _WIN32_WINNT means :any API is allowed" ?
I found this i
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft.com/en-us/windows/win32/win
On Wed, 4 May 2022 07:48:17 GMT, Dmitry Kulikov wrote:
>> Hello,
>> Please review this fix for JDK-8282863.
>>
>> The failing
>> `java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java` test
>> basically checks that full-screen window remains full-screen when a display
>> mode c
On Tue, 29 Mar 2022 22:19:26 GMT, Sergey Bylokhov wrote:
>> Dmitry Kulikov has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - 8282863:
>> java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java fails
>> on Windows 10 with H
> Currently we set _WIN32_WINNT at various places in the codebase; this is used
> to target a minimum Windows version we want to support. See also for more
> detailled information :
> https://docs.microsoft.com/en-us/windows/win32/winprog/using-the-windows-headers?redirectedfrom=MSDN#setting-winv
On Tue, 29 Mar 2022 11:03:37 GMT, Alexey Ivanov wrote:
>> Dmitry Kulikov has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - 8282863:
>> java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java fails
>> on Windows 10 with HiD
> Hello,
> Please review this fix for JDK-8282863.
>
> The failing
> `java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java` test
> basically checks that full-screen window remains full-screen when a display
> mode change occurs. It has been introduced in JDK-8211999, which also
On Wed, 4 May 2022 05:55:16 GMT, Tejesh R wrote:
>> The Test had been updated to use all Supported Look and Feel in closed repo.
>> The same has been moved to open repo.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Copyrigh
On Tue, 3 May 2022 13:27:41 GMT, David Holmes wrote:
> I agree with Erik - the source locations need to be modified to not define
> it. If we want to keep a record perhaps add an assertion that the value is
> what was expected?
>
> I still feel we have a disconnect between this and an actual c
On Tue, 3 May 2022 07:10:58 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft.com/en-us/windows/win32/win
45 matches
Mail list logo
