Re: RFR: JDK-8286348: incorrect use of `@serial`

2022-05-06 Thread Iris Clark
On Sat, 7 May 2022 01:04:03 GMT, Jonathan Gibbons wrote: > Please review a fix to remove incorrect use of the `@serial` tag from the doc > comments for methods such as `readObject` and `readResolve`. The tag has no > effect in this position other than to trigger warnings from the standard > do

RFR: JDK-8286348: incorrect use of `@serial`

2022-05-06 Thread Jonathan Gibbons
Please review a fix to remove incorrect use of the `@serial` tag from the doc comments for methods such as `readObject` and `readResolve`. The tag has no effect in this position other than to trigger warnings from the standard doclet when running javadoc. There is no change to the generated doc

Re: RFR: JDK-6725221 Standardize obtaining boolean properties with defaults

2022-05-06 Thread Bradford Wetmore
On Thu, 5 May 2022 16:49:07 GMT, Mark Powers wrote: > JDK-6725221 Standardize obtaining boolean properties with defaults Sorry for the confusion. The original intent of this bug 14 years ago was to standardize the seclibs code where simple getProperty calls were needed in the context of an Ac

Re: RFR: 8286271: [java.desktop] Replace ternary operators with java.lang.Math min/max

2022-05-06 Thread Phil Race
On Sat, 15 Jan 2022 04:23:33 GMT, SWinxy wrote: > Delete `sun.java2d.marlin.FloatMath` class in favor of methods in > `java.lang.Math`. The methods in `Math.java` are intrinsics and can gain from > significant speedups. Hand-written min/max operations are also replaced with > calls. 5 uses of

Re: RFR: 8286271: [java.desktop] Replace ternary operators with java.lang.Math min/max

2022-05-06 Thread SWinxy
On Fri, 6 May 2022 16:52:47 GMT, Laurent Bourgès wrote: >> Delete `sun.java2d.marlin.FloatMath` class in favor of methods in >> `java.lang.Math`. The methods in `Math.java` are intrinsics and can gain >> from significant speedups. Hand-written min/max operations are also replaced >> with calls

Re: RFR: JDK-8255439: System Tray icons get corrupted when windows scaling changes

2022-05-06 Thread Harshitha Onkar
On Fri, 29 Apr 2022 00:36:15 GMT, Sergey Bylokhov wrote: >> In Windows when desktop scaling was changed the tray icons was >> distorted/blurred a bit each time scaling changes. >> >> With the proposed fix, the tray icon scales according to on-the-fly DPI >> scale settings. A test case has been

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v11]

2022-05-06 Thread Alisen Chung
On Fri, 6 May 2022 11:53:03 GMT, Alexey Ivanov wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> saved translation values in EtchedBorder, updated test > > src/java.desktop/share/classes/javax/swing/border/EtchedBord

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v11]

2022-05-06 Thread Alisen Chung
On Thu, 5 May 2022 18:00:16 GMT, Alisen Chung wrote: >> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > saved translation values in Et

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v12]

2022-05-06 Thread Alisen Chung
> Changed the drawing area to be increased by 0.5 on the left side to prevent > clipping Alisen Chung has updated the pull request incrementally with three additional commits since the last revision: - changed error message for gap between highlight and shadow - fixed coordinate checks - fix

Re: RFR: 8286271: [java.desktop] Replace ternary operators with java.lang.Math min/max

2022-05-06 Thread Kevin Rushforth
On Sat, 15 Jan 2022 04:23:33 GMT, SWinxy wrote: > Delete `sun.java2d.marlin.FloatMath` class in favor of methods in > `java.lang.Math`. The methods in `Math.java` are intrinsics and can gain from > significant speedups. Hand-written min/max operations are also replaced with > calls. 5 uses of

Re: RFR: JDK-6725221 Standardize obtaining boolean properties with defaults

2022-05-06 Thread Phil Race
On Thu, 5 May 2022 16:49:07 GMT, Mark Powers wrote: > JDK-6725221 Standardize obtaining boolean properties with defaults The xtoolkit change is fine. I've not looked at anything else You'll clearly need multiple reviewers for this one. - Marked as reviewed by prr (Reviewer). PR: h

Re: RFR: JDK-6725221 Standardize obtaining boolean properties with defaults

2022-05-06 Thread Alan Bateman
On Thu, 5 May 2022 16:49:07 GMT, Mark Powers wrote: > JDK-6725221 Standardize obtaining boolean properties with defaults src/java.base/share/classes/java/lang/reflect/AccessibleObject.java line 777: > 775: if (!printStackPropertiesSet && VM.initLevel() >= 1) { > 776: printSt

Re: RFR: JDK-8255439: System Tray icons get corrupted when windows scaling changes [v2]

2022-05-06 Thread Harshitha Onkar
> In Windows when desktop scaling was changed the tray icons was > distorted/blurred a bit each time scaling changes. > > With the proposed fix, the tray icon scales according to on-the-fly DPI scale > settings. A test case has been added which adds a MRI icon to system tray, to > observe the i

RFR: JDK-6725221 Standardize obtaining boolean properties with defaults

2022-05-06 Thread Mark Powers
JDK-6725221 Standardize obtaining boolean properties with defaults - Commit messages: - Merge - first iteration Changes: https://git.openjdk.java.net/jdk/pull/8559/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8559&range=00 Issue: https://bugs.openjdk.java.net/brow

Re: RFR: 8286271: [java.desktop] Replace ternary operators with java.lang.Math min/max

2022-05-06 Thread Phil Race
On Sat, 15 Jan 2022 04:23:33 GMT, SWinxy wrote: > Delete `sun.java2d.marlin.FloatMath` class in favor of methods in > `java.lang.Math`. The methods in `Math.java` are intrinsics and can gain from > significant speedups. Hand-written min/max operations are also replaced with > calls. 5 uses of

Re: RFR: 8271846 a11y API lacks setSelectedIndex method

2022-05-06 Thread Phil Race
On Fri, 6 May 2022 16:10:35 GMT, Artem Semenov wrote: > A11Y implementation on macOS has to directly call the > 'JList.setSelectedIndex' method in order to request selection on an item (see > 'CAccessibility.requestSelection'). The reason is that a11y API lacks > appropriate method.There's onl

Re: RFR: 8286271: [java.desktop] Replace ternary operators with java.lang.Math min/max

2022-05-06 Thread Laurent Bourgès
On Sat, 15 Jan 2022 04:23:33 GMT, SWinxy wrote: > Delete `sun.java2d.marlin.FloatMath` class in favor of methods in > `java.lang.Math`. The methods in `Math.java` are intrinsics and can gain from > significant speedups. Hand-written min/max operations are also replaced with > calls. 5 uses of

RFR: 8271846 a11y API lacks setSelectedIndex method

2022-05-06 Thread Artem Semenov
A11Y implementation on macOS has to directly call the 'JList.setSelectedIndex' method in order to request selection on an item (see 'CAccessibility.requestSelection'). The reason is that a11y API lacks appropriate method.There's only 'javax.accessibility.AccessibleSelection#addAccessibleSelecti

Re: RFR: 8286271: [java.desktop] Replace ternary operators with java.lang.Math min/max

2022-05-06 Thread SWinxy
On Sat, 15 Jan 2022 04:23:33 GMT, SWinxy wrote: > Delete `sun.java2d.marlin.FloatMath` class in favor of methods in > `java.lang.Math`. The methods in `Math.java` are intrinsics and can gain from > significant speedups. Hand-written min/max operations are also replaced with > calls. 5 uses of

Re: RFR: 8286271: [java.desktop] Replace ternary operators with java.lang.Math min/max

2022-05-06 Thread Laurent Bourgès
On Sat, 15 Jan 2022 04:23:33 GMT, SWinxy wrote: > Delete `sun.java2d.marlin.FloatMath` class in favor of methods in > `java.lang.Math`. The methods in `Math.java` are intrinsics and can gain from > significant speedups. Hand-written min/max operations are also replaced with > calls. 5 uses of

Re: RFR: 8286271: [java.desktop] Replace ternary operators with java.lang.Math min/max

2022-05-06 Thread SWinxy
On Sat, 15 Jan 2022 04:23:33 GMT, SWinxy wrote: > Delete `sun.java2d.marlin.FloatMath` class in favor of methods in > `java.lang.Math`. The methods in `Math.java` are intrinsics and can gain from > significant speedups. Hand-written min/max operations are also replaced with > calls. 5 uses of

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v3]

2022-05-06 Thread Tejesh R
> In Button ToolTip, Mnemonic key string was shown only in Metal Look and Feel, > since the feature is implemented in it. In other L&F especially Windows L&F > the feature is not available. In order to make it available for other L&F's, > the getAcceleratedString method and calculateAcceleratedS

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings [v4]

2022-05-06 Thread Magnus Ihse Bursie
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote: >> Currently we set _WIN32_WINNT at various places in the codebase; this is >> used to target a minimum Windows version we want to support. See also for >> more detailled information : >> https://docs.microsoft.com/en-us/windows/win32/win

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings [v4]

2022-05-06 Thread Erik Joelsson
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote: >> Currently we set _WIN32_WINNT at various places in the codebase; this is >> used to target a minimum Windows version we want to support. See also for >> more detailled information : >> https://docs.microsoft.com/en-us/windows/win32/win

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v11]

2022-05-06 Thread Alexey Ivanov
On Thu, 5 May 2022 18:00:16 GMT, Alisen Chung wrote: >> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > saved translation values in Et

Re: RFR: 8030121: java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java fails

2022-05-06 Thread Manukumar V S
On Wed, 4 May 2022 07:59:41 GMT, Manukumar V S wrote: > Removing MissingDragExitEventTest.java from ProblemList as JDK-8274597 > already fixed the test and it's working fine now. > > Testing: > MissingDragExitEventTest.java test has been run 10 times on all 3 platforms > and got all Pass. >

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v8]

2022-05-06 Thread Alexey Ivanov
On Wed, 4 May 2022 15:16:20 GMT, Alexey Ivanov wrote: > > Made a small change with the bottom line to match the left line of the > > border > > Great, that looks like it'll fix it so I won't test again, I'll defer to the > others now for the code review. (I'd be happy to chip in there too, but

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings [v4]

2022-05-06 Thread Matthias Baesken
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote: >> Currently we set _WIN32_WINNT at various places in the codebase; this is >> used to target a minimum Windows version we want to support. See also for >> more detailled information : >> https://docs.microsoft.com/en-us/windows/win32/win

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings [v4]

2022-05-06 Thread David Holmes
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote: >> Currently we set _WIN32_WINNT at various places in the codebase; this is >> used to target a minimum Windows version we want to support. See also for >> more detailled information : >> https://docs.microsoft.com/en-us/windows/win32/win

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings [v4]

2022-05-06 Thread Matthias Baesken
On Wed, 4 May 2022 09:08:28 GMT, Matthias Baesken wrote: > Does this mean that not setting _WIN32_WINNT means :any API is allowed" ? Hi David , I did one more try with my current setup (VS2017 on a Win10 notebook). I did not set _WIN32_WINNT. My little test program #include #include int m

Re: RFR: 8286271: [java.desktop] Replace ternary operators with java.lang.Math min/max

2022-05-06 Thread Laurent Bourgès
On Sat, 15 Jan 2022 04:23:33 GMT, SWinxy wrote: > Delete `sun.java2d.marlin.FloatMath` class in favor of methods in > `java.lang.Math`. The methods in `Math.java` are intrinsics and can gain from > significant speedups. Hand-written min/max operations are also replaced with > calls. 5 uses of