On Wed, 27 Apr 2022 14:57:41 GMT, Matthias Baesken wrote:
> Currently we set _WIN32_WINNT at various places in the codebase; this is used
> to target a minimum Windows version we want to support. See also for more
> detailled information :
> https://docs.microsoft.com/en-us/windows/win32/winpro
On Thu, 10 Mar 2022 02:42:00 GMT, Harshitha Onkar wrote:
> Previously while tabbing through the JTable cell, the cell highlighter/focus
> ring was not visible against the selection background.
>
> Changes are made to Aqua LAF to derive a lighter focus ring color by changing
> saturation and s
On Mon, 9 May 2022 16:15:48 GMT, DamonGuy wrote:
>> The insets for buttons were incorrect for L&Fs except for Aqua when the text
>> is set to HTML. This was fixed in Aqua by adding a conditional to check for
>> the BasicHTML property key in the button component. This same logic can be
>> used
On Mon, 9 May 2022 21:04:51 GMT, Alexey Ivanov wrote:
>> Why can't this use the new PassFailJFrame ?
>
> It can. Yet the test had been written before `PassFailJFrame` was integrated.
>
> I'm fine with either way.
I thought it was only for applet/manual test conversion to normal manual.
Anyway,
> Issue was when printing a JTable which sits inside a JScrollPane and the
> table is scrolled down to the end to about 1000th row, only the first page is
> printed.
> This is because when the table is scrolled down to last page, the bounds.y
> becomes -ve
> [x=0,y=-15260,width=968,height=1600
> Issue was when printing a JTable which sits inside a JScrollPane and the
> table is scrolled down to the end to about 1000th row, only the first page is
> printed.
> This is because when the table is scrolled down to last page, the bounds.y
> becomes -ve
> [x=0,y=-15260,width=968,height=1600
> Issue was when printing a JTable which sits inside a JScrollPane and the
> table is scrolled down to the end to about 1000th row, only the first page is
> printed.
> This is because when the table is scrolled down to last page, the bounds.y
> becomes -ve
> [x=0,y=-15260,width=968,height=1600
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft.com/en-us/windows/win32/win
On Wed, 4 May 2022 07:59:41 GMT, Manukumar V S wrote:
> Removing MissingDragExitEventTest.java from ProblemList as JDK-8274597
> already fixed the test and it's working fine now.
>
> Testing:
> MissingDragExitEventTest.java test has been run 10 times on all 3 platforms
> and got all Pass.
Thi
On Mon, 9 May 2022 07:02:51 GMT, Ajit Ghaisas wrote:
> This is a trivial fix which adds more details about the constant
> MTLVC_MAX_INDEX.
> This had come up during the review of
> [JDK-8261632](https://bugs.openjdk.java.net/browse/JDK-8261632).
This pull request has now been integrated.
Chan
> Issue was when printing a JTable which sits inside a JScrollPane and the
> table is scrolled down to the end to about 1000th row, only the first page is
> printed.
> This is because when the table is scrolled down to last page, the bounds.y
> becomes -ve
> [x=0,y=-15260,width=968,height=1600
public class bam0 {
private static long parseLong(/*private **/String w)
{
long m = 1;
long i = 2;
long _q = 5;
long value = 0;
for(int p = w.length() - 1; p >= 0; --p) {
if( w.charAt(p) == '1' )
value = value + m;
> Changed the drawing area to be increased by 0.5 on the left side to prevent
> clipping
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
made suggested changes
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7
On Mon, 9 May 2022 21:02:11 GMT, Phil Race wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> formatting changes
>
> test/jdk/java/awt/TrayIcon/TrayIconScalingTest.java line 99:
>
>> 97: exitItem.addAction
On Mon, 9 May 2022 21:30:13 GMT, Harshitha Onkar wrote:
> So far, based on testing the message is received only for tray icon window.
That matches what I see as well.
-
PR: https://git.openjdk.java.net/jdk/pull/8441
On Mon, 9 May 2022 20:42:06 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> made changes according to comm
On Mon, 9 May 2022 20:50:56 GMT, Phil Race wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> formatting changes
>
> src/java.desktop/windows/native/libawt/windows/awt_TrayIcon.cpp line 262:
>
>> 260: //
On Mon, 9 May 2022 21:07:49 GMT, Phil Race wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> formatting changes
>
> Changes requested by prr (Reviewer).
@prrace @aivanov-jdk Thank you for all the feedback and sug
On Sun, 8 May 2022 19:36:33 GMT, Harshitha Onkar wrote:
>> In Windows, when desktop scaling is changed the tray icons was
>> distorted/blurred a bit each time scaling changes.
>>
>> With the proposed fix, the tray icon scales according to on-the-fly DPI
>> scale settings. A test case has been
On Mon, 9 May 2022 20:28:37 GMT, Phil Race wrote:
>> test/jdk/javax/swing/JTable/PrintAllPagesTest.java line 136:
>>
>>> 134:
>>> 135: dialog = new JDialog(f, "Instructions for Table Print Test");
>>> 136: dialog.setTitle("textselectionTest");
>>
>> I guess this line should be
On Sun, 8 May 2022 19:36:33 GMT, Harshitha Onkar wrote:
>> In Windows, when desktop scaling is changed the tray icons was
>> distorted/blurred a bit each time scaling changes.
>>
>> With the proposed fix, the tray icon scales according to on-the-fly DPI
>> scale settings. A test case has been
> Changed the drawing area to be increased by 0.5 on the left side to prevent
> clipping
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
made changes according to comments
-
Changes:
- all: https://git.openjdk.java.ne
On Sat, 7 May 2022 01:04:03 GMT, Jonathan Gibbons wrote:
> Please review a fix to remove incorrect use of the `@serial` tag from the doc
> comments for methods such as `readObject` and `readResolve`. The tag has no
> effect in this position other than to trigger warnings from the standard
> do
On Mon, 9 May 2022 17:09:10 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test updated
>
> test/jdk/javax/swing/JTable/PrintAllPagesTest.java line 136:
>
>> 134:
>> 135: dialog
On Sun, 8 May 2022 19:36:33 GMT, Harshitha Onkar wrote:
>> In Windows, when desktop scaling is changed the tray icons was
>> distorted/blurred a bit each time scaling changes.
>>
>> With the proposed fix, the tray icon scales according to on-the-fly DPI
>> scale settings. A test case has been
On Mon, 9 May 2022 15:56:35 GMT, Adam Sotona wrote:
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand o
On Sun, 8 May 2022 13:33:53 GMT, ExE Boss wrote:
> That’s not what happens, since XColors::lookupColor always calls new
> ColorUIResource(…) in both the old and new version.
You are correct. I over-looked the toColor() implementation.
Ok. this should be fine once the author tag is removed.
--
On Mon, 9 May 2022 20:19:45 GMT, Jonathan Gibbons wrote:
>> Please review a fix to remove incorrect use of the `@serial` tag from the
>> doc comments for methods such as `readObject` and `readResolve`. The tag has
>> no effect in this position other than to trigger warnings from the standard
>
> Please review a fix to remove incorrect use of the `@serial` tag from the doc
> comments for methods such as `readObject` and `readResolve`. The tag has no
> effect in this position other than to trigger warnings from the standard
> doclet when running javadoc.
>
> There is no change to the g
On Mon, 9 May 2022 19:45:49 GMT, Zhengyu Gu wrote:
>> Please review this small patch that releases temporary charsets to avoid
>> memory leak.
>>
>> Test:
>>
>> - [x] jdk_2d
>
> Zhengyu Gu has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Wed, 4 May 2022 01:39:49 GMT, Andrew John Hughes wrote:
> > >
> >
> >
> > Hmmm, you are right. Phil probably pointed out the same problem, but I
> > misunderstood it.
> > What's odd is that, I tested (made sure that `FcCharSetDestroy` indeed
> > called), it did not crash and `valgrind` sh
> Please review this small patch that releases temporary charsets to avoid
> memory leak.
>
> Test:
>
> - [x] jdk_2d
Zhengyu Gu has updated the pull request incrementally with one additional
commit since the last revision:
Cleanup at early return
-
Changes:
- all: https://gi
On Mon, 9 May 2022 19:16:46 GMT, Daniel D. Daugherty wrote:
> A trivial to solve JDK-8284316 caused validate-source to fail in Tier1.
This pull request has now been integrated.
Changeset: 02e5fc04
Author:Daniel D. Daugherty
URL:
https://git.openjdk.java.net/jdk/commit/02e5fc04ccd046
On Mon, 9 May 2022 19:18:23 GMT, Mikael Vidstedt wrote:
>> A trivial to solve JDK-8284316 caused validate-source to fail in Tier1.
>
> Marked as reviewed by mikael (Reviewer).
@vidmik - Thanks for the lightning fast review!
-
PR: https://git.openjdk.java.net/jdk/pull/8607
On Mon, 9 May 2022 19:16:46 GMT, Daniel D. Daugherty wrote:
> A trivial to solve JDK-8284316 caused validate-source to fail in Tier1.
Marked as reviewed by mikael (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8607
A trivial to solve JDK-8284316 caused validate-source to fail in Tier1.
-
Commit messages:
- 8286435: JDK-8284316 caused validate-source to fail in Tier1
Changes: https://git.openjdk.java.net/jdk/pull/8607/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8607&range=00
On Mon, 9 May 2022 18:57:57 GMT, Kevin Rushforth wrote:
> Thanks for the additional comments. As far as I'm concerned, the only
> remaining question is the fact that the manual test doesn't exit for me when
> run from the command line.
@kevinrushforth Thank you for the update Kevin. I'm curren
On Sun, 8 May 2022 19:36:33 GMT, Harshitha Onkar wrote:
>> In Windows, when desktop scaling is changed the tray icons was
>> distorted/blurred a bit each time scaling changes.
>>
>> With the proposed fix, the tray icon scales according to on-the-fly DPI
>> scale settings. A test case has been
On Mon, 9 May 2022 18:14:35 GMT, Jonathan Gibbons wrote:
>> Please review a fix to remove incorrect use of the `@serial` tag from the
>> doc comments for methods such as `readObject` and `readResolve`. The tag has
>> no effect in this position other than to trigger warnings from the standard
>
On Wed, 27 Apr 2022 04:36:27 GMT, Harshitha Onkar wrote:
>> Previously while tabbing through the JTable cell, the cell highlighter/focus
>> ring was not visible against the selection background.
>>
>> Changes are made to Aqua LAF to derive a lighter focus ring color by
>> changing saturation
On Fri, 25 Feb 2022 12:39:50 GMT, Emmanuel Bourg wrote:
>> When a list of icons is set on a window, the most appropiate icon is
>> selected depending on the graphics configuration. But if the graphics
>> configuration changes (because the window is moved to a different screen, or
>> because th
On Thu, 31 Mar 2022 08:03:23 GMT, Andrey Turbanov wrote:
>> Method `Class.isAssignableFrom` is often used in form of:
>>
>> if (clazz.isAssignableFrom(obj.getClass())) {
>> Such condition could be simplified to more shorter and performarnt code
>>
>> if (clazz.isInstance(obj)) {
>>
On Mon, 4 Apr 2022 23:39:33 GMT, lawrence.andrews wrote:
> 1) Modified ManualTestFrame.java to support non SwingSet2 and this include
> modification of SwingSetTest.java
> 2) Added new TestJProgressBarAccessibility.java testcase that uses
> ManualTestFrame
> 3) Added timeout support in case us
On Wed, 20 Apr 2022 05:10:23 GMT, Alexander Zuev wrote:
> Only check that insets of the fully expanded undecorated window is not bigger
> than device insets. They can be smaller, it is a normal situation.
Marked as reviewed by prr (Reviewer).
-
PR: https://git.openjdk.java.net/jdk
On Fri, 29 Apr 2022 12:43:41 GMT, Zhengyu Gu wrote:
>> Please review this small patch that releases temporary charsets to avoid
>> memory leak.
>>
>> Test:
>>
>> - [x] jdk_2d
>
> Zhengyu Gu has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Thu, 5 May 2022 09:16:04 GMT, Prasanta Sadhukhan
wrote:
>> Test used to fail in specific CI macos M1 system owing to miniscule color
>> difference
>>
>>
>> x 0 y 0 red1 171 red2 171 green1 174 green2 175 blue1 184 blue2 184
>> x 0 y 1 red1 172 red2 173 green1 177 green2 177 blue1 185 blue
> Please review a fix to remove incorrect use of the `@serial` tag from the doc
> comments for methods such as `readObject` and `readResolve`. The tag has no
> effect in this position other than to trigger warnings from the standard
> doclet when running javadoc.
>
> There is no change to the g
On Wed, 27 Apr 2022 11:22:48 GMT, Manukumar V S wrote:
> This test verifies that showing a JPopupMenu shouldn't steal the focus out of
> current focused component..
> This fix moves an unstable closed test to open but updated to be more
> comprehensive in testing multiple Look and Feels and wit
On Thu, 28 Apr 2022 23:55:28 GMT, lawrence.andrews
wrote:
>> 1) Removed yesno to eliminate parserException
>> 2) Added code to fit into manual framework so that timeout, pass & fail is
>> handled.
>> 3) Added code to mark the test as pass if printer service is not available
>> 4) Added code to
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft.com/en-us/windows/win32/win
On Mon, 9 May 2022 01:55:37 GMT, lawrence.andrews wrote:
>> 1) Removed Applet dependent code and used Frame as top level.
>> 2) Automated the manual test.
>>
>> @shurymury
>
> lawrence.andrews has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Wed, 4 May 2022 07:59:41 GMT, Manukumar V S wrote:
> Removing MissingDragExitEventTest.java from ProblemList as JDK-8274597
> already fixed the test and it's working fine now.
>
> Testing:
> MissingDragExitEventTest.java test has been run 10 times on all 3 platforms
> and got all Pass.
Mar
On Mon, 9 May 2022 15:56:35 GMT, Adam Sotona wrote:
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand o
On Mon, 9 May 2022 07:02:51 GMT, Ajit Ghaisas wrote:
> This is a trivial fix which adds more details about the constant
> MTLVC_MAX_INDEX.
> This had come up during the review of
> [JDK-8261632](https://bugs.openjdk.java.net/browse/JDK-8261632).
Marked as reviewed by prr (Reviewer).
-
On Mon, 2 May 2022 21:02:02 GMT, Harshitha Onkar wrote:
> This test case tests the functionality of `setAlwaysOnTop`.
> Documentation on `setAlwaysOnTop`:
> [Link](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/java/awt/Window.html#setAlwaysOnTop(boolean))
>
> The following te
On Mon, 9 May 2022 05:50:39 GMT, Prasanta Sadhukhan
wrote:
>> Issue was when printing a JTable which sits inside a JScrollPane and the
>> table is scrolled down to the end to about 1000th row, only the first page
>> is printed.
>> This is because when the table is scrolled down to last page,
On Sun, 8 May 2022 19:36:33 GMT, Harshitha Onkar wrote:
>> In Windows, when desktop scaling is changed the tray icons was
>> distorted/blurred a bit each time scaling changes.
>>
>> With the proposed fix, the tray icon scales according to on-the-fly DPI
>> scale settings. A test case has been
On Mon, 9 May 2022 15:56:35 GMT, Adam Sotona wrote:
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand o
On Mon, 14 Mar 2022 19:28:32 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added functions for drawing border, fixed translate
>
> src/java.desktop/share/classes/javax/swing/border/TitledBorder
On Fri, 6 May 2022 22:09:30 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - changed error message for
On Mon, 9 May 2022 06:04:05 GMT, Prasanta Sadhukhan
wrote:
>> DamonGuy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Changed approach to fix.
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java
> line 39
> The insets for buttons were incorrect for L&Fs except for Aqua when the text
> is set to HTML. This was fixed in Aqua by adding a conditional to check for
> the BasicHTML property key in the button component. This same logic can be
> used to fix Metal & Motif L&Fs in BasicButtonUI, but Nimbus
Please review this patch adding new lint option, **lossy-conversions**, to
javac to warn about type casts in compound assignments with possible lossy
conversions.
The new lint warning is shown if the type of the right-hand operand of a
compound assignment is not assignment compatible with the t
On Sat, 8 Jan 2022 18:13:45 GMT, SWinxy wrote:
> The old java.desktop package needs dusting off. It hasn't been kept up to
> pace with the Java language, but it should. The purpose of this PR is to
> replace most or all `instanceof` checks with the new `instanceof` with a
> variable. Some meth
On Sat, 7 May 2022 01:04:03 GMT, Jonathan Gibbons wrote:
> Please review a fix to remove incorrect use of the `@serial` tag from the doc
> comments for methods such as `readObject` and `readResolve`. The tag has no
> effect in this position other than to trigger warnings from the standard
> do
On Mon, 9 May 2022 07:02:51 GMT, Ajit Ghaisas wrote:
> This is a trivial fix which adds more details about the constant
> MTLVC_MAX_INDEX.
> This had come up during the review of
> [JDK-8261632](https://bugs.openjdk.java.net/browse/JDK-8261632).
Marked as reviewed by avu (Committer).
Looks go
On Mon, 9 May 2022 07:02:51 GMT, Ajit Ghaisas wrote:
> This is a trivial fix which adds more details about the constant
> MTLVC_MAX_INDEX.
> This had come up during the review of
> [JDK-8261632](https://bugs.openjdk.java.net/browse/JDK-8261632).
Marked as reviewed by jdv (Reviewer).
-
This is a trivial fix which adds more details about the constant
MTLVC_MAX_INDEX.
This had come up during the review of
[JDK-8261632](https://bugs.openjdk.java.net/browse/JDK-8261632).
-
Commit messages:
- Add details about MTLVC_MAX_INDEX
Changes: https://git.openjdk.java.net/jdk
68 matches
Mail list logo
