Re: RFR: 8286822: Write a test to check the DND functionality between two InternalFrames

2022-05-18 Thread Manukumar V S
On Thu, 19 May 2022 06:03:51 GMT, Jayathirth D V wrote: > I dont see an internal PR to remove the applet based closed test. Also why > https://bugs.openjdk.java.net/browse/JDK-8286822 is created as enhancement ? > > If this test is failing intermittently how many times we have seen this test >

Re: RFR: 8286822: Write a test to check the DND functionality between two InternalFrames

2022-05-18 Thread Jayathirth D V
On Tue, 17 May 2022 15:52:03 GMT, Manukumar V S wrote: > This test verifies that dragging from one InternalFrame and a drop target in > another InternalFrame functions properly. > This fix moves an unstable closed applet based test to open regression based > java test, but updated to be more co

Withdrawn: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF

2022-05-18 Thread Tejesh R
On Mon, 2 May 2022 02:56:01 GMT, Tejesh R wrote: > In Button ToolTip, Mnemonic key string was shown only in Metal Look and Feel, > since the feature is implemented in it. In other L&F especially Windows L&F > the feature is not available. In order to make it available for other L&F's, > the ge

Re: RFR: 8012675: Javadoc for javax.swing.text.html.parser.Parser.handleComment() needs to be updated

2022-05-18 Thread DamonGuy
On Fri, 11 Feb 2022 19:20:16 GMT, DamonGuy wrote: > Updated Parser class doc by appending to the doc regarding lack of support > for HTML script tags. Adding this information to the "parse" function did not > seem as consistent for formatting as adding it to the Parser class doc. I still belie

Re: RFR: 8286872: Refactor add/modify notification icon (TrayIcon) [v3]

2022-05-18 Thread openjdk-notifier[bot]
On Wed, 18 May 2022 17:54:30 GMT, Alexey Ivanov wrote: >> Encapsulate the logic of adding or modifying a notification icon aka tray >> icon. This is to avoid code duplication between >> [`AwtTrayIcon::WmTaskbarCreated`](https://github.com/openjdk/jdk/blob/7b988b31c661c6e3e58cf8ced81732e40a79d4f

Re: RFR: JDK-8255439: System Tray icons get corrupted when windows scaling changes [v12]

2022-05-18 Thread Phil Race
On Tue, 17 May 2022 18:29:44 GMT, Harshitha Onkar wrote: >> In Windows, when desktop scaling is changed the tray icons was >> distorted/blurred a bit each time scaling changes. >> >> With the proposed fix, the tray icon scales according to on-the-fly DPI >> scale settings. A test case has been

Integrated: JDK-8255439: System Tray icons get corrupted when windows scaling changes

2022-05-18 Thread Harshitha Onkar
On Thu, 28 Apr 2022 02:26:28 GMT, Harshitha Onkar wrote: > In Windows, when desktop scaling is changed the tray icons was > distorted/blurred a bit each time scaling changes. > > With the proposed fix, the tray icon scales according to on-the-fly DPI scale > settings. A test case has been adde

Re: RFR: 8286872: Refactor add/modify notification icon (TrayIcon) [v3]

2022-05-18 Thread Alexey Ivanov
On Wed, 18 May 2022 17:54:30 GMT, Alexey Ivanov wrote: >> Encapsulate the logic of adding or modifying a notification icon aka tray >> icon. This is to avoid code duplication between >> [`AwtTrayIcon::WmTaskbarCreated`](https://github.com/openjdk/jdk/blob/7b988b31c661c6e3e58cf8ced81732e40a79d4f

Re: RFR: 8286872: Refactor add/modify notification icon (TrayIcon) [v3]

2022-05-18 Thread Alexey Ivanov
> Encapsulate the logic of adding or modifying a notification icon aka tray > icon. This is to avoid code duplication between > [`AwtTrayIcon::WmTaskbarCreated`](https://github.com/openjdk/jdk/blob/7b988b31c661c6e3e58cf8ced81732e40a79d4f5/src/java.desktop/windows/native/libawt/windows/awt_TrayIco

Re: RFR: 8285687 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PageRangesDlgTest.java [v6]

2022-05-18 Thread Alexey Ivanov
On Wed, 18 May 2022 16:24:38 GMT, lawrence.andrews wrote: >> 1) Fixed Parser error by removing yesno from @run main/manual=yesno >> 2) Used PassFaileJFrame to show the test instruction to the user instead of >> printing the test instruction on the console or jtreg log file. >> 3) If printer

Integrated: 8283705: Make javax.sound.midi.Track a final class

2022-05-18 Thread Phil Race
On Sun, 1 May 2022 21:15:33 GMT, Phil Race wrote: > This is the straggler from several PRs which were around making JDK classes > sealed. > There's nothing to be sealed here, but the same query pointed out that this > class has > no public or protected constructor (as well as no sub-classes) an

Integrated: 8285397: JNI exception pending in CUPSfuncs.c:250

2022-05-18 Thread Phil Race
On Sun, 1 May 2022 19:31:01 GMT, Phil Race wrote: > A tool checking for JNI errors complains that the call to > JNU_NewStringPlatform(..) > might throw an exception and subsequent JNI code isn't making sure of that. > Clear the exception so the error handling code can do its thing. This pull re

Re: RFR: 8284213: Replace usages of 'a the' in xml

2022-05-18 Thread Joe Wang
On Wed, 18 May 2022 13:58:22 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > I tried to avoid changing external libraries, there are quite a few such > typos. > Let me know if I should revert any files. Marked

Re: RFR: 8285687 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PageRangesDlgTest.java [v6]

2022-05-18 Thread Phil Race
On Wed, 18 May 2022 16:24:38 GMT, lawrence.andrews wrote: >> 1) Fixed Parser error by removing yesno from @run main/manual=yesno >> 2) Used PassFaileJFrame to show the test instruction to the user instead of >> printing the test instruction on the console or jtreg log file. >> 3) If printer

Re: RFR: 8284213: Replace usages of 'a the' in xml

2022-05-18 Thread Phil Race
On Wed, 18 May 2022 13:58:22 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > I tried to avoid changing external libraries, there are quite a few such > typos. > Let me know if I should revert any files. Marked

Re: RFR: 8284213: Replace usages of 'a the' in xml

2022-05-18 Thread Iris Clark
On Wed, 18 May 2022 13:58:22 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > I tried to avoid changing external libraries, there are quite a few such > typos. > Let me know if I should revert any files. Marked

Re: RFR: 8285687 : Remove jtreg tag manual=yesno for ava/awt/print/PrinterJob/PageRangesDlgTest.java [v6]

2022-05-18 Thread lawrence . andrews
> 1) Fixed Parser error by removing yesno from @run main/manual=yesno > 2) Used PassFaileJFrame to show the test instruction to the user instead of > printing the test instruction on the console or jtreg log file. > 3) If printer is not configured then mark the test as passed. > > @shurymury

Re: RFR: 8284213: Replace usages of 'a the' in xml

2022-05-18 Thread Dmitry Markov
On Wed, 18 May 2022 13:58:22 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > I tried to avoid changing external libraries, there are quite a few such > typos. > Let me know if I should revert any files. Marked

Re: RFR: 8284213: Replace usages of 'a the' in xml

2022-05-18 Thread Lance Andersen
On Wed, 18 May 2022 13:58:22 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > I tried to avoid changing external libraries, there are quite a few such > typos. > Let me know if I should revert any files. Marked

RFR: 8284213: Replace usages of 'a the' in xml

2022-05-18 Thread Alexey Ivanov
Replaces usages of articles that follow each other in all combinations: a/the, an?/an?, the/the… I tried to avoid changing external libraries, there are quite a few such typos. Let me know if I should revert any files. - Commit messages: - 8284213: Replace usages of 'the a' in xml

Re: RFR: JDK-8255439: System Tray icons get corrupted when windows scaling changes [v12]

2022-05-18 Thread Kevin Rushforth
On Tue, 17 May 2022 18:29:44 GMT, Harshitha Onkar wrote: >> In Windows, when desktop scaling is changed the tray icons was >> distorted/blurred a bit each time scaling changes. >> >> With the proposed fix, the tray icon scales according to on-the-fly DPI >> scale settings. A test case has been

Re: RFR: 8286872: Refactor add/modify notification icon (TrayIcon) [v2]

2022-05-18 Thread Alexey Ivanov
> Encapsulate the logic of adding or modifying a notification icon aka tray > icon. This is to avoid code duplication between > [`AwtTrayIcon::WmTaskbarCreated`](https://github.com/openjdk/jdk/blob/7b988b31c661c6e3e58cf8ced81732e40a79d4f5/src/java.desktop/windows/native/libawt/windows/awt_TrayIco

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v15]

2022-05-18 Thread Alexey Ivanov
On Tue, 17 May 2022 20:59:37 GMT, Phil Race wrote: >> This could even use pattern matching: >> >> if (g instanceof Graphics2D g2d) { >> at = g2d.getTransform(); > > I thought about that but (1) couldn't remember off-hand if it was still > preview, (2) I was sure it would imp

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v15]

2022-05-18 Thread Phil Race
On Tue, 17 May 2022 20:38:07 GMT, Alexey Ivanov wrote: >> src/java.desktop/share/classes/javax/swing/border/EtchedBorder.java line 159: >> >>> 157: int stkWidth = 1; >>> 158: if (g instanceof Graphics2D) { >>> 159: at = ((Graphics2D) g).getTransform(); >> >> We more

Re: RFR: JDK-8282777: Create a Regression test for JDK-4515031 [v4]

2022-05-18 Thread Srinivas Mandalika
> Create a Regression test for > [JDK-4515031](https://bugs.openjdk.java.net/browse/JDK-4515031) > > The issue indicates the need for a a getAccessibleDescription being > implemented for the JFileChooser. > The test added verifies the same. > This review is for migrating tests from a closed test

Re: RFR: JDK-8282778: Create a regression test for JDK-4699544 [v5]

2022-05-18 Thread Srinivas Mandalika
> Create a regression test for JDK-4699544 > > The subclass of javax.swing.JRootPane (AccessibleJRootPane) that implements > the accessibility interface javax.accessibility.AccessibleComponent is > derived from java.awt.AccessibleAWTComponent, which returns null for > getAccessibleAt() because

Re: Unexpected EOFException in ImageReaderSpi.canDecodeInput

2022-05-18 Thread Martin Desruisseaux
Hello Philip Le 17/05/2022 à 20:36, Philip Race a écrit : Why is it unexpected ? The purpose of ImageReaderSpi.canDecodeInput(Object) is to tell if the source object seems to be supported by the reader. If the file is too small, it is not supported by the reader. So a return value of false i

Re: RFR: 8284524: Create an automated test for JDK-4422362 [v3]

2022-05-18 Thread Srinivas Mandalika
> Create an automated test for > [JDK-4422362](https://bugs.openjdk.java.net/browse/JDK-4422362) > > The BoundedRangeModel components (JScrollBar, JSlider, JProgressBar) return > BoundedRangeModel.getMaximum() from getMaximumAccessibleValue() in their > AccessibleValue implementation. > The real

Re: RFR: 8284767: Create an automated test for JDK-4422535 [v3]

2022-05-18 Thread Srinivas Mandalika
> Create an automated test for > [JDK-4422535](https://bugs.openjdk.java.net/browse/JDK-4422535) > AccessibleValue implementation only accept Integers > The AccessibleValue implementations of the following components: > > java.awt.Scrollbar > javax.swing.AbstractButton > javax.swing.JInternalFram

Re: RFR: 8285305: Create an automated test for JDK-4495286 [v3]

2022-05-18 Thread Srinivas Mandalika
> Create an automated test for > [JDK-4495286](https://bugs.openjdk.java.net/browse/JDK-4495286) > > AccessibleJTable.setAccessibleSelction should select rows/cols when cell > selection. > When cell selection is not enabled, there is no way, using > accessibility, to select rows or columns. It s

Re: RFR: 8285305: Create an automated test for JDK-4495286 [v2]

2022-05-18 Thread Srinivas Mandalika
On Wed, 27 Apr 2022 08:08:32 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4495286](https://bugs.openjdk.java.net/browse/JDK-4495286) >> >> AccessibleJTable.setAccessibleSelction should select rows/cols when cell >> selection. >> When cell selection is not enabled, th

Re: RFR: 8285305: Create an automated test for JDK-4495286 [v2]

2022-05-18 Thread Srinivas Mandalika
On Thu, 5 May 2022 23:58:01 GMT, Phil Race wrote: > Get rid of the useless extra directory level Done. - PR: https://git.openjdk.java.net/jdk/pull/8333

RE: Unexpected EOFException in ImageReaderSpi.canDecodeInput

2022-05-18 Thread Volodin, Vladislav
Hello Philip, I have never used this object, but according to JavaDocs it says that IOException is thrown "if an I/O error occurs while reading the stream". So in theory, if we can read the file, but its size is less than we expect (e.g. a magic number length), why cannot we simply return "fals