Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v3]

2022-05-30 Thread Tejesh R
On Mon, 30 May 2022 16:01:39 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removal of White space > > test/jdk/javax/swing/JTableHeader/TableRendererTest.java line 2: > >> 1: /* >> 2: * Copyright

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v3]

2022-05-30 Thread Alexey Ivanov
On Mon, 30 May 2022 06:04:03 GMT, Tejesh R wrote: >> _Header_ object not initialized/set when paint() method of >> `WindowTableHeaderUI` class is executed. The paint() event is executed >> through explicit call of `JTable.updateUI()` in the regression test. In >> order to set the _header_ to t

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v19]

2022-05-30 Thread Alexey Ivanov
On Wed, 25 May 2022 21:37:07 GMT, Alisen Chung wrote: >> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > changed test to headless `te

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v19]

2022-05-30 Thread Alexey Ivanov
On Wed, 25 May 2022 21:37:07 GMT, Alisen Chung wrote: >> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > changed test to headless Are

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v19]

2022-05-30 Thread Alexey Ivanov
On Wed, 25 May 2022 21:37:07 GMT, Alisen Chung wrote: >> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > changed test to headless Cha

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v18]

2022-05-30 Thread Alexey Ivanov
On Wed, 25 May 2022 20:32:54 GMT, Phil Race wrote: > so -showFrame is just for a person to use "standalone" to see the results, > never used by jtreg Yes, it is for stand-alone during debugging, not for jtreg. - PR: https://git.openjdk.java.net/jdk/pull/7449

Re: RFR: 8286846: test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on mac aarch64

2022-05-30 Thread Tejesh R
On Tue, 24 May 2022 08:28:57 GMT, Prasanta Sadhukhan wrote: > Test was failing intermiitently in iMac M1 system owing to minimalistic color > difference of 1 > > x 13 y 0 refRGB ffee customRGB ffef > x 0 y 0 refRGB ffefefef customRGB ffefeeef > > > so added color tolerance check. >

Re: RFR: 8286846: test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on mac aarch64

2022-05-30 Thread Tejesh R
On Mon, 30 May 2022 14:15:17 GMT, Prasanta Sadhukhan wrote: > Information is not needed for sleep interuption, it's not going to affect the > test much Ok. The PR is fine, I have tested in mac. - PR: https://git.openjdk.java.net/jdk/pull/8864

Re: RFR: 8286846: test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on mac aarch64

2022-05-30 Thread Prasanta Sadhukhan
On Tue, 24 May 2022 08:28:57 GMT, Prasanta Sadhukhan wrote: > Test was failing intermiitently in iMac M1 system owing to minimalistic color > difference of 1 > > x 13 y 0 refRGB ffee customRGB ffef > x 0 y 0 refRGB ffefefef customRGB ffefeeef > > > so added color tolerance check. >

Re: RFR: 8282863: java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java fails on Windows 10 with HiDPI screen [v4]

2022-05-30 Thread Alexey Ivanov
On Mon, 30 May 2022 05:55:38 GMT, Dmitry Kulikov wrote: >> Hello, >> Please review this fix for JDK-8282863. >> >> The failing >> `java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java` test >> basically checks that full-screen window remains full-screen when a display >> mode

Re: RFR: 8286846: test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on mac aarch64

2022-05-30 Thread Tejesh R
On Tue, 24 May 2022 08:28:57 GMT, Prasanta Sadhukhan wrote: > Test was failing intermiitently in iMac M1 system owing to minimalistic color > difference of 1 > > x 13 y 0 refRGB ffee customRGB ffef > x 0 y 0 refRGB ffefefef customRGB ffefeeef > > > so added color tolerance check. >

Re: RFR: 8286846: test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on mac aarch64

2022-05-30 Thread Prasanta Sadhukhan
On Wed, 25 May 2022 02:55:53 GMT, Prasanta Sadhukhan wrote: >> test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java line 64: >> >>> 62: >>> 63: public static void main(String[] args) throws Exception { >>> 64: if (!System.getProperty("os.name").toLowerCase().contains("os >>