On Tue, 31 May 2022 15:28:34 GMT, Alexey Ushakov wrote:
> > Is it only a test stabilization fix? or were you able to uncover any
> > performance issue (either with OpenGL or with Metal pipeline) with this
> > change? Can you please provide before/after numbers?
>
> Initially it was a stabiliza
On Tue, 24 May 2022 10:36:09 GMT, Alexey Ivanov wrote:
>>> Just an idea for discussion: I remember that we added some support for the
>>> manual tests, kind of framework or something. Probably it will be useful to
>>> reuse when we add "new" tests?
>>> https://bugs.openjdk.java.net/browse/JDK-
> Added test for checking setMargin() of JRadioButton.
Tejesh R has updated the pull request incrementally with one additional commit
since the last revision:
Updated based on review comments
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/8721/files
- new: https://gi
On Wed, 1 Jun 2022 05:30:23 GMT, Tejesh R wrote:
>> The tooltip displays accelerated string along with the toooltip string. The
>> feature is implemented and applicable for Metal Look and Feel only. Hence
>> the test is updated for Metal Look and Feel by hard wiring it in the code.
>> Updated
On Tue, 31 May 2022 11:15:25 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Updated based on review comments
>> - Added headful key
>
> test/jdk/javax/swing/JRadioButton/bug4380543.java line 106:
On Wed, 1 Jun 2022 04:45:12 GMT, Tejesh R wrote:
> > I wonder why the test is Windows-specific if it allows changing Look and
> > Feels.
> > The only Look and Feel which ignores the background is Nimbus, other L&Fs
> > on Windows at least paint the yellow and green background. As such, the
> >
On Wed, 1 Jun 2022 05:07:44 GMT, Prasanta Sadhukhan
wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed unused parameter isTooltipAdded
>
> test/jdk/javax/swing/JToolTip/bug5047379.java line 54:
>
>> 52:
>> 53:
> The tooltip displays accelerated string along with the toooltip string. The
> feature is implemented and applicable for Metal Look and Feel only. Hence the
> test is updated for Metal Look and Feel by hard wiring it in the code.
> Updated the test from manual to automatic.
Tejesh R has update
On Tue, 31 May 2022 08:14:14 GMT, Tejesh R wrote:
> The tooltip displays accelerated string along with the toooltip string. The
> feature is implemented and applicable for Metal Look and Feel only. Hence the
> test is updated for Metal Look and Feel by hard wiring it in the code.
> Updated the
On Tue, 31 May 2022 11:30:55 GMT, Alexey Ivanov wrote:
> I wonder why the test is Windows-specific if it allows changing Look and
> Feels.
>
> The only Look and Feel which ignores the background is Nimbus, other L&Fs on
> Windows at least paint the yellow and green background. As such, the tes
On Tue, 31 May 2022 23:39:09 GMT, Nikita Gubarkov wrote:
> `CTFontCopyAvailableTables` can return null, which causes subsequent call to
> `CFArrayGetCount` to crash with SEGFAULT, just added a null-check.
Where do you read it can return null ?
https://developer.apple.com/documentation/coretext
`CTFontCopyAvailableTables` can return null, which causes subsequent call to
`CFArrayGetCount` to crash with SEGFAULT, just added a null-check.
-
Commit messages:
- 8287609: Add null-check for tagsArray returned from CTFontCopyAvailableTables
Changes: https://git.openjdk.java.net/j
On Tue, 31 May 2022 20:03:25 GMT, Phil Race wrote:
>> Damon Nguyen has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Updated java doc for clarity. Added test to show behavior.
>> - Merge branch '8012675/htmlTagParserDocChange' of gith
> Updated Parser class doc by appending to the doc regarding lack of support
> for HTML script tags. Adding this information to the "parse" function did not
> seem as consistent for formatting as adding it to the Parser class doc.
Damon Nguyen has updated the pull request incrementally with one
On Wed, 25 May 2022 06:08:54 GMT, Phil Race wrote:
>> Removed stacktrace from WClipboard
>
> src/java.desktop/windows/classes/sun/awt/windows/WClipboard.java line 89:
>
>> 87: // javaJVMLocalObjectMimeType failed to serialize.
>> 88: // May remove this if-
The method
`javax.swing.plaf.nimbus.NimbusDefaults#getDerivedColor(String,String,float,float,float,int,boolean)`
could be improved by usage of Map.putIfAbsent instead of separate
`containsKey`/`get`/`put` calls. We known that HashMap
`javax.swing.plaf.nimbus.NimbusDefaults#derivedColors` can co
On Fri, 27 May 2022 18:58:12 GMT, Alexey Ushakov wrote:
> Improved RenderPerfTest:
> - removed RenderPerfLCD.java (we have LCD tests in RenderPerfTest.java)
> - corrected and simplified test logic
> - added timeout on low performant rendering
> - used several markers to recover from missi
On Mon, 23 May 2022 20:35:33 GMT, Phil Race wrote:
> If we don't store the memory allocated for graphicsConfigs because we
> failed/bail, we need to free it.
This pull request has now been integrated.
Changeset: 97bd4c25
Author:Phil Race
URL:
https://git.openjdk.java.net/jdk/commit
On Wed, 25 May 2022 21:37:07 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> changed test to headless
It
On Wed, 25 May 2022 19:11:47 GMT, Damon Nguyen wrote:
>> Updated Parser class doc by appending to the doc regarding lack of support
>> for HTML script tags. Adding this information to the "parse" function did
>> not seem as consistent for formatting as adding it to the Parser class doc.
>
> Dam
On Mon, 30 May 2022 15:51:14 GMT, Alexey Ivanov wrote:
> Are we going to address rotation under this issue or under a new one?
I can fix rotation/skews in a new issue
-
PR: https://git.openjdk.java.net/jdk/pull/7449
On Mon, 23 May 2022 20:35:33 GMT, Phil Race wrote:
> If we don't store the memory allocated for graphicsConfigs because we
> failed/bail, we need to free it.
Marked as reviewed by aivanov (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8857
On Tue, 8 Mar 2022 08:26:11 GMT, Srinivas Mandalika
wrote:
> Create a regression test for JDK-4699544
>
> The subclass of javax.swing.JRootPane (AccessibleJRootPane) that implements
> the accessibility interface javax.accessibility.AccessibleComponent is
> derived from java.awt.AccessibleAWTC
On Mon, 7 Mar 2022 23:31:54 GMT, lawrence.andrews wrote:
> Following methods are covered in this testcase
> getAccessibleAction()
> getAccessibleActionCount()
> doAccessibleAction(int direction)
>
> @shurymury
This pull request has now been integrated.
Changeset: 8db5247e
Author:lawrence.
On Wed, 25 May 2022 19:11:47 GMT, Damon Nguyen wrote:
>> Updated Parser class doc by appending to the doc regarding lack of support
>> for HTML script tags. Adding this information to the "parse" function did
>> not seem as consistent for formatting as adding it to the Parser class doc.
>
> Dam
On Wed, 9 Mar 2022 08:13:55 GMT, Srinivas Mandalika
wrote:
> Create a regression test for
> [JDK-4702690](https://bugs.openjdk.java.net/browse/JDK-4702690)
>
> In many cases in Swing it is possible to easily programatically determine
> that a JScrollBar (or two) is scrolling some JPanel (the
On Tue, 31 May 2022 10:06:51 GMT, Ajit Ghaisas wrote:
> Is it only a test stabilization fix? or were you able to uncover any
> performance issue (either with OpenGL or with Metal pipeline) with this
> change? Can you please provide before/after numbers?
Initially it was a stabilization fix. Ho
On Fri, 27 May 2022 17:21:29 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Updated based on review comments
> - Added headful key
I wonder why t
On Wed, 16 Mar 2022 07:39:21 GMT, Dmitry Kulikov wrote:
> Hello,
> Please review this fix for JDK-8282863.
>
> The failing
> `java/awt/FullScreen/FullscreenWindowProps/FullscreenWindowProps.java` test
> basically checks that full-screen window remains full-screen when a display
> mode change
On Fri, 27 May 2022 18:58:12 GMT, Alexey Ushakov wrote:
> Improved RenderPerfTest:
> - removed RenderPerfLCD.java (we have LCD tests in RenderPerfTest.java)
> - corrected and simplified test logic
> - added timeout on low performant rendering
> - used several markers to recover from missi
On Tue, 31 May 2022 09:57:36 GMT, Alexey Ivanov wrote:
>> Ok, then will try with the _bufferedImage paint_ logic, If I'm able to get
>> the exception without it been handled by internal code then it'll be really
>> helpful to make it automatic.
>
>> > _Actually if the current test executes then
On Tue, 31 May 2022 09:40:17 GMT, Tejesh R wrote:
>>> _Actually if the current test executes then its a pass right..?_ This
>>> means, if there is no NPE raised then its a pass case right...? Yeah to
>>> some extent it is automatic, I actually didn't get how to handle the caught
>>> NP
On Tue, 31 May 2022 09:37:57 GMT, Tejesh R wrote:
>>> Yeah, wanted to change to automatic, but wasn't sure about whether its ok
>>> for NPE check or not.
>>
>> What can be wrong with it? It's just a regular test. If you can automate the
>> test, you should.
>>
>>> Actually if the current test
On Tue, 31 May 2022 09:29:59 GMT, Alexey Ivanov wrote:
>>> Can't the test be automated?
>>>
>>> Can you paint the table to a BufferredImage and catch the NPE?
>>>
>>> Alternatively, if the above can't be done, you can use
>>> [Thread.setUncaughtExceptionHandler](https://docs.oracle.com/en/java
On Tue, 31 May 2022 03:58:04 GMT, Tejesh R wrote:
> Yeah, wanted to change to automatic, but wasn't sure about whether its ok for
> NPE check or not.
What can be wrong with it? It's just a regular test. If you can automate the
test, you should.
> Actually if the current test executes then its
On Mon, 23 May 2022 20:35:33 GMT, Phil Race wrote:
> If we don't store the memory allocated for graphicsConfigs because we
> failed/bail, we need to free it.
Marked as reviewed by psadhukhan (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8857
The tooltip displays accelerated string along with the toooltip string. The
feature is implemented and applicable for Metal Look and Feel only. Hence the
test is updated for Metal Look and Feel by hard wiring it in the code. Updated
the test from manual to automatic.
-
Commit messa
37 matches
Mail list logo
