Re: RFR: 8287609: macOS: SIGSEGV at [CoreFoundation] CFArrayGetCount / sun.font.CFont.getTableBytesNative

2022-06-04 Thread Nikita Gubarkov
On Fri, 3 Jun 2022 20:48:28 GMT, Phil Race wrote: >> `CTFontCopyAvailableTables` can return null, which causes subsequent call to >> `CFArrayGetCount` to crash with SEGFAULT, just added a null-check. > > oh my gosh .. it is a font designed for PRE-macOSX . meaning mac. so it is an > ATM font wi

Re: RFR: 8287824: The MTPerLineTransformValidation tests has a typo in the @run tag

2022-06-04 Thread Iris Clark
On Sat, 4 Jun 2022 07:59:59 GMT, Sergey Bylokhov wrote: > The typo in the `@run` tag is fixed. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/9030

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v7]

2022-06-04 Thread Justin Senseney
Please unsubscribe me from your mailing list On Sat, Jun 4, 2022, 20:01 Tejesh R wrote: > > Added test for checking setMargin() of JRadioButton. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Removed whitespaces > > ---

Re: RFR: 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed

2022-06-04 Thread Sergey Bylokhov
On Fri, 3 Jun 2022 09:46:11 GMT, Prasanta Sadhukhan wrote: > Test is failing in iMac CI systems owing to color difference of 1 > > `x 0 y 0 rgb1: fff0f0f0 rgb2: fff0eff0` > > Added minor color tolerance check. CI testing is green This test does not check the resulted color against the golden

Re: RFR: 8282578: AIOOBE in javax.sound.sampled.Clip

2022-06-04 Thread Sergey Bylokhov
On Sat, 4 Jun 2022 13:46:10 GMT, Alexander Zuev wrote: > No, because determining the correct length of the message will require > basically to parse it all, the correct length could be a 2 bytes or hundreds > of bytes - in order to determine we have to process the message completely. There are

RFR: 8287824: The MTPerLineTransformValidation tests has a typo in the @run tag

2022-06-04 Thread Sergey Bylokhov
The typo in the `@run` tag is fixed. - Commit messages: - 8287824: The MTPerLineTransformValidation tests has a typo in the @run tag Changes: https://git.openjdk.java.net/jdk/pull/9030/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=9030&range=00 Issue: https://bugs.

Re: RFR: 8282578: AIOOBE in javax.sound.sampled.Clip

2022-06-04 Thread Alexander Zuev
On Fri, 3 Jun 2022 21:15:21 GMT, Sergey Bylokhov wrote: > Probably it is better to check the data length for each sys message and > discard it if the data is too small? Ignoring all possible AIOOBE from this > large method which calls many other large methods from SoftVoice/SoftTuning > may hi