On Thu, 9 Jun 2022 02:16:45 GMT, Jeremy wrote:
>> Previously when you drew a line that moved exactly (+0, +0) with a miter
>> stroke the Stroker class acted like a horizontal miter was appropriate. Now
>> we abort instead, so no miter is applied.
>>
>> The new unit test tests the original step
On Thu, 9 Jun 2022 02:16:45 GMT, Jeremy wrote:
>> Previously when you drew a line that moved exactly (+0, +0) with a miter
>> stroke the Stroker class acted like a horizontal miter was appropriate. Now
>> we abort instead, so no miter is applied.
>>
>> The new unit test tests the original step
> Previously when you drew a line that moved exactly (+0, +0) with a miter
> stroke the Stroker class acted like a horizontal miter was appropriate. Now
> we abort instead, so no miter is applied.
>
> The new unit test tests the original steps plus several variations.
>
> I'm a little nervous a
On Wed, 8 Jun 2022 22:25:12 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> removed rendering hints, chang
On Wed, 8 Jun 2022 22:25:12 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> removed rendering hints, chang
> Changed the drawing area to be increased by 0.5 on the left side to prevent
> clipping
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
removed rendering hints, changed condition to reapply old transform
-
Changes:
-
On Wed, 8 Jun 2022 18:37:55 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed declarations
Changes re
Instead of pair HashMap.containsKey/HashMap.get method calls, we can use single
call HashMap.getOrDefault.
It's faster and clearer.
-
Commit messages:
- [PATCH] Avoid redundant HashMap.containsKey call in
Type1Font.expandAbbreviation
Changes: https://git.openjdk.java.net/jdk/pull/
On Wed, 8 Jun 2022 14:09:24 GMT, Tejesh R wrote:
>> _Header_ object not initialized/set when paint() method of
>> `WindowTableHeaderUI` class is executed. The paint() event is executed
>> through explicit call of `JTable.updateUI()` in the regression test. In
>> order to set the _header_ to th
On Wed, 8 Jun 2022 18:37:55 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed declarations
Marked as
> Changed the drawing area to be increased by 0.5 on the left side to prevent
> clipping
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
fixed declarations
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7449/
> Changed the drawing area to be increased by 0.5 on the left side to prevent
> clipping
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
fixed spacing
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7449/files
On Wed, 8 Jun 2022 18:17:06 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> made suggested changes
test/j
On Wed, 8 Jun 2022 18:10:21 GMT, Alexey Ivanov wrote:
>> I'll remove the button then as it's not necessary for the test. I mainly
>> added it to demonstrate that HTML contents are rendering correctly. I'll
>> make this change and update the doc for Parser to more explicitly explain
>> what hap
> Updated Parser class doc by appending to the doc regarding lack of support
> for HTML script tags. Adding this information to the "parse" function did not
> seem as consistent for formatting as adding it to the Parser class doc.
Damon Nguyen has updated the pull request incrementally with one
> Changed the drawing area to be increased by 0.5 on the left side to prevent
> clipping
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
made suggested changes
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7
On Wed, 8 Jun 2022 17:18:20 GMT, Damon Nguyen wrote:
>> No, it didn't occur with "embedded" HTML. It occurred with your original
>> version. I compiled the test and `PassFailJFrame` into `./build` directory
>> (`javac -d ./build ` and then ran it `java -cp ./build
>> HtmlTagParserTest`. Since
On Mon, 30 May 2022 01:15:01 GMT, Jeremy wrote:
> Previously when you drew a line that moved exactly (+0, +0) with a miter
> stroke the Stroker class acted like a horizontal miter was appropriate. Now
> we abort instead, so no miter is applied.
>
> The new unit test tests the original steps pl
On Thu, 28 Apr 2022 16:33:48 GMT, XenoAmess wrote:
>> I'm getting a bit tired of seeing these JDK wide changes with lots of files
>> touched.
>> Delete all changes in desktop from this PR and re-submit them as a separate
>> PR.
>>
>> Also do not change J2DBench. We deliberately avoid using new
> Updated Parser class doc by appending to the doc regarding lack of support
> for HTML script tags. Adding this information to the "parse" function did not
> seem as consistent for formatting as adding it to the Parser class doc.
Damon Nguyen has updated the pull request incrementally with one
On Wed, 8 Jun 2022 17:14:10 GMT, Alexey Ivanov wrote:
>> I can look into this as well. Does this exception occur with the current
>> version without the HTML file? I have no issues on my end.
>
> No, it didn't occur with "embedded" HTML. It occurred with your original
> version. I compiled the
On Wed, 8 Jun 2022 17:04:17 GMT, Damon Nguyen wrote:
>> At the same, I noticed a weird behaviour with the file. When I ran the test,
>> class file was located in another directory but the HTML file was in the
>> current directory. Calling `setPage` produced an exception. And
>> `PassFailJFrame
On Wed, 8 Jun 2022 17:01:23 GMT, Alexey Ivanov wrote:
>>> the reasoning for the test originally using a temporary file to create HTML
>>> was to have an HTML file that could be opened itself and compared towards.
>>> I see that it's not necessary for this test, but was useful at the time. I
>>
On Wed, 8 Jun 2022 16:59:52 GMT, Alexey Ivanov wrote:
>> Thanks for catching that. Also, the reasoning for the test originally using
>> a temporary file to create HTML was to have an HTML file that could be
>> opened itself and compared towards. I see that it's not necessary for this
>> test,
On Wed, 8 Jun 2022 16:32:30 GMT, Damon Nguyen wrote:
> the reasoning for the test originally using a temporary file to create HTML
> was to have an HTML file that could be opened itself and compared towards. I
> see that it's not necessary for this test, but was useful at the time. I
> thought
On Tue, 7 Jun 2022 18:41:25 GMT, Alexey Ivanov wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Changed doc text.
>
> test/jdk/javax/swing/text/html/HtmlTagParserTest.java line 83:
>
>> 81: }
>> 82:
>> 83:
On Tue, 7 Jun 2022 19:20:12 GMT, Alexey Ivanov wrote:
>> Added the header and moved the test to the HTML folder instead since I
>> believe the process involves classes beyond just the Parser. For example, I
>> found that the tags and unknown tags are located in the HTML class. I can
>> move it
> Updated Parser class doc by appending to the doc regarding lack of support
> for HTML script tags. Adding this information to the "parse" function did not
> seem as consistent for formatting as adding it to the Parser class doc.
Damon Nguyen has updated the pull request incrementally with one
> Updated Parser class doc by appending to the doc regarding lack of support
> for HTML script tags. Adding this information to the "parse" function did not
> seem as consistent for formatting as adding it to the Parser class doc.
Damon Nguyen has updated the pull request incrementally with one
On Mon, 23 May 2022 16:43:05 GMT, Alexey Ivanov wrote:
> **WTrayIconPeer**: removed duplicate call to `popupParent.dispose()` that
> might cause NPE (it looks `popupParent` cannot be `null`); organised imports.
>
> **SystemTray**: removed redundant initialisers; replaced sized array with
> emp
On Wed, 8 Jun 2022 14:09:24 GMT, Tejesh R wrote:
>> _Header_ object not initialized/set when paint() method of
>> `WindowTableHeaderUI` class is executed. The paint() event is executed
>> through explicit call of `JTable.updateUI()` in the regression test. In
>> order to set the _header_ to th
On Mon, 6 Jun 2022 22:14:40 GMT, Alexander Zuev wrote:
> Add the accessibilityValue implementation to the affected classes to return
> NULL value
> Reverse the default initialization of MenuItemAccessibility if no parent is
> specified
This pull request has now been integrated.
Changeset: b02
> _Header_ object not initialized/set when paint() method of
> `WindowTableHeaderUI` class is executed. The paint() event is executed
> through explicit call of `JTable.updateUI()` in the regression test. In order
> to set the _header_ to the _called_ JTable, it is set in the
> `getTableCellRen
On Mon, 6 Jun 2022 22:14:40 GMT, Alexander Zuev wrote:
> Add the accessibilityValue implementation to the affected classes to return
> NULL value
> Reverse the default initialization of MenuItemAccessibility if no parent is
> specified
Marked as reviewed by dmarkov (Reviewer).
-
On Wed, 8 Jun 2022 11:40:25 GMT, Tejesh R wrote:
>> _Header_ object not initialized/set when paint() method of
>> `WindowTableHeaderUI` class is executed. The paint() event is executed
>> through explicit call of `JTable.updateUI()` in the regression test. In
>> order to set the _header_ to th
> _Header_ object not initialized/set when paint() method of
> `WindowTableHeaderUI` class is executed. The paint() event is executed
> through explicit call of `JTable.updateUI()` in the regression test. In order
> to set the _header_ to the _called_ JTable, it is set in the
> `getTableCellRen
On Wed, 8 Jun 2022 11:11:44 GMT, Tejesh R wrote:
>> _Header_ object not initialized/set when paint() method of
>> `WindowTableHeaderUI` class is executed. The paint() event is executed
>> through explicit call of `JTable.updateUI()` in the regression test. In
>> order to set the _header_ to th
On Wed, 8 Jun 2022 11:20:56 GMT, Tejesh R wrote:
> > Looks good now.
> > Please update the copyright year WindowsTableHeaderUI and optionally
> > organise imports.
>
> Copyright year...?
Yes, currently the first line in `WindowsTableHeaderUI.java`: “Copyright (c)
1997, 2014…”. It should b
On Wed, 8 Jun 2022 11:23:49 GMT, Alexey Ivanov wrote:
> > > Looks good now.
> > > Please update the copyright year WindowsTableHeaderUI and optionally
> > > organise imports.
> >
> >
> > Copyright year...?
>
> Yes, currently the first line in `WindowsTableHeaderUI.java`: “Copyright (c)
>
On Wed, 8 Jun 2022 11:18:00 GMT, Alexey Ivanov wrote:
> Looks good now.
>
> Please update the copyright year WindowsTableHeaderUI and optionally organise
> imports.
Copyright year...? It's supposed to be 2022 only right...?
-
PR: https://git.openjdk.java.net/jdk/pull/8830
> _Header_ object not initialized/set when paint() method of
> `WindowTableHeaderUI` class is executed. The paint() event is executed
> through explicit call of `JTable.updateUI()` in the regression test. In order
> to set the _header_ to the _called_ JTable, it is set in the
> `getTableCellRen
On Wed, 8 Jun 2022 10:12:45 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated for multiple LookAndFeel
>
> test/jdk/javax/swing/JTableHeader/TableHeaderRendererTest.java line 52:
>
>> 50:
On Wed, 8 Jun 2022 07:01:08 GMT, Tejesh R wrote:
>> _Header_ object not initialized/set when paint() method of
>> `WindowTableHeaderUI` class is executed. The paint() event is executed
>> through explicit call of `JTable.updateUI()` in the regression test. In
>> order to set the _header_ to th
On Tue, 7 Jun 2022 12:37:15 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments and File name changed
>
> test/jdk/javax/swing/JTableHeader/TableHeaderRendererTest.java l
On Mon, 6 Jun 2022 22:14:40 GMT, Alexander Zuev wrote:
> Add the accessibilityValue implementation to the affected classes to return
> NULL value
> Reverse the default initialization of MenuItemAccessibility if no parent is
> specified
Looks good for me. It would be good to add a regression te
> _Header_ object not initialized/set when paint() method of
> `WindowTableHeaderUI` class is executed. The paint() event is executed
> through explicit call of `JTable.updateUI()` in the regression test. In order
> to set the _header_ to the _called_ JTable, it is set in the
> `getTableCellRen
46 matches
Mail list logo
