On Tue, 14 Jun 2022 08:42:11 GMT, Sergey Bylokhov wrote:
> That was the whole purpose of the initial 8182043 issue, to provide a
> HiDPI(or various DPI) icons for the user. If the user asks for the 16x16 we
> will provide them the MRI where the base image is 16x16, but that MRI could
> also pr
On Mon, 13 Jun 2022 21:16:05 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor changes
>
> Marked as reviewed by aivanov (Reviewer).
> @aivanov-jdk The
On Fri, 10 Jun 2022 23:21:24 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix typo
Please remove impor
On Fri, 10 Jun 2022 23:21:24 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix typo
Marked as reviewed
On Wed, 8 Jun 2022 22:25:12 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> removed rendering hints, chang
On Thu, 9 Jun 2022 18:45:15 GMT, Phil Race wrote:
>> src/java.desktop/share/classes/javax/swing/border/EtchedBorder.java line 158:
>>
>>> 156: AffineTransform at = new AffineTransform();
>>> 157: Stroke oldStk = new BasicStroke();
>>> 158: int stkWidth = 1;
>>
>> Now the
On Fri, 10 Jun 2022 13:11:14 GMT, Prasanta Sadhukhan
wrote:
>> Test is failing in iMac CI systems owing to color difference of 1
>>
>> `x 0 y 0 rgb1: fff0f0f0 rgb2: fff0eff0`
>>
>> Added minor color tolerance check. CI testing is green
>
> Prasanta Sadhukhan has updated the pull request increm
On Fri, 10 Jun 2022 12:49:08 GMT, Prasanta Sadhukhan
wrote:
>> Test is failing in iMac CI systems owing to color difference of 1
>>
>> `x 0 y 0 rgb1: fff0f0f0 rgb2: fff0eff0`
>>
>> Added minor color tolerance check. CI testing is green
>
> Prasanta Sadhukhan has updated the pull request increm
On Fri, 10 Jun 2022 09:29:01 GMT, Prasanta Sadhukhan
wrote:
>> Test is failing in iMac CI systems owing to color difference of 1
>>
>> `x 0 y 0 rgb1: fff0f0f0 rgb2: fff0eff0`
>>
>> Added minor color tolerance check. CI testing is green
>
> Prasanta Sadhukhan has updated the pull request increm
On Fri, 10 Jun 2022 09:25:29 GMT, Prasanta Sadhukhan
wrote:
>> Probably we can apply the defensive fix of color tolerance as per 1st
>> iteration ?
>
> It still fails once or twice with createMultiResolutionScreenCapture if the
> test iteration is increased, so I think color tolerance, even if
On Fri, 10 Jun 2022 05:45:27 GMT, Sergey Bylokhov wrote:
> This version look good, just one more thought. Can we extend this approach
> and do not request all sizes if the user wanted only one image? So if the
> user will request all images we request that list from the OS, otherwise only
> on
On Fri, 10 Jun 2022 05:55:35 GMT, Harshitha Onkar wrote:
> Due to incorrect AWT Frame inset values being returned from native code, few
> of the components in the frame were not being shown completely on Windows.
> With the proposed fix, correct insets are obtained which in turn sizes and
> di
On Tue, 7 Jun 2022 09:00:30 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/javax/swing/text/CSSBorder/6796710/bug6796710.java line 147:
>>
>>> 145: MultiResolutionImage img =
>>> robot.createMultiResolutionScreenCapture(rect);
>>> 146: return (BufferedImage)img.getResolutionVariant
On Thu, 9 Jun 2022 18:44:53 GMT, Phil Race wrote:
>> test/jdk/javax/swing/border/EtchedBorder/ScaledEtchedBorderTest.java line 44:
>>
>>> 42: * @bug 8279614
>>> 43: * @summary The left line of the TitledBorder is not painted on 150
>>> scale factor
>>> 44: * @requires (os.family == "windows"
On Thu, 9 Jun 2022 10:50:37 GMT, Alexey Ivanov wrote:
> Since `test.not` is for this test only, would
> `WindowsDefaultIconSizeTest.test.not` be a better name for the test file?
Better yet is to create the file dynamically in the test code?
-
PR: https://git.openjdk.java.n
On Mon, 6 Jun 2022 23:47:15 GMT, Alexander Zuev wrote:
>> Detect the situation where we do need to perform interpolation during
>> ImageIcon
>> painting and set a hint to the rendering to perform bicubic approximation so
>> image details are preserved during transition.
>
> Alexander Zuev has up
On Fri, 3 Jun 2022 21:48:46 GMT, Sergey Bylokhov wrote:
>>> Because for some files - and we can not predict which files these are -
>>> function will always return set of 16x16 and 32x32 icons - no matter what
>>> we request. For the icons that return proper sizes we do request exact
>>> sizes
On Thu, 2 Jun 2022 17:24:10 GMT, Alexander Zuev wrote:
> > Do we need to update the size value and take into account the low/hi sizes?
>
> Not exactly, the issue is that for some files (but just for some of them)
> this call ignores the high icon size parameter and always returns the set of
>
On Mon, 6 Jun 2022 23:47:15 GMT, Alexander Zuev wrote:
>> Detect the situation where we do need to perform interpolation during
>> ImageIcon
>> painting and set a hint to the rendering to perform bicubic approximation so
>> image details are preserved during transition.
>
> Alexander Zuev has up
On Mon, 6 Jun 2022 22:53:11 GMT, Alexander Zuev wrote:
> Here, in the name of resolving this issue finally i have reverted the
> ImageIcon changes, instead i added some code that creates the properly scaled
> version of icon when requested variant is not available.
This looks good!
> I am not
On Wed, 8 Jun 2022 22:25:12 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> removed rendering hints, chang
On Wed, 8 Jun 2022 22:25:12 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> removed rendering hints, chang
On Wed, 8 Jun 2022 18:37:55 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed declarations
Changes re
On Wed, 8 Jun 2022 17:18:20 GMT, Damon Nguyen wrote:
>> No, it didn't occur with "embedded" HTML. It occurred with your original
>> version. I compiled the test and `PassFailJFrame` into `./build` directory
>> (`javac -d ./build ` and then ran it `java -cp ./build
>> HtmlTagParserTest`. Since
On Wed, 8 Jun 2022 17:04:17 GMT, Damon Nguyen wrote:
>> At the same, I noticed a weird behaviour with the file. When I ran the test,
>> class file was located in another directory but the HTML file was in the
>> current directory. Calling `setPage` produced an exception. And
>> `PassFailJFrame
On Wed, 8 Jun 2022 16:59:52 GMT, Alexey Ivanov wrote:
>> Thanks for catching that. Also, the reasoning for the test originally using
>> a temporary file to create HTML was to have an HTML file that could be
>> opened itself and compared towards. I see that it's not nece
On Wed, 8 Jun 2022 16:32:30 GMT, Damon Nguyen wrote:
> the reasoning for the test originally using a temporary file to create HTML
> was to have an HTML file that could be opened itself and compared towards. I
> see that it's not necessary for this test, but was useful at the time. I
> thought
On Mon, 23 May 2022 16:43:05 GMT, Alexey Ivanov wrote:
> **WTrayIconPeer**: removed duplicate call to `popupParent.dispose()` that
> might cause NPE (it looks `popupParent` cannot be `null`); organised imports.
>
> **SystemTray**: removed redundant initialisers; replaced size
On Wed, 8 Jun 2022 14:09:24 GMT, Tejesh R wrote:
>> _Header_ object not initialized/set when paint() method of
>> `WindowTableHeaderUI` class is executed. The paint() event is executed
>> through explicit call of `JTable.updateUI()` in the regression test. In
>> order to set the _header_ to th
On Wed, 8 Jun 2022 11:40:25 GMT, Tejesh R wrote:
>> _Header_ object not initialized/set when paint() method of
>> `WindowTableHeaderUI` class is executed. The paint() event is executed
>> through explicit call of `JTable.updateUI()` in the regression test. In
>> order to set the _header_ to th
On Wed, 8 Jun 2022 11:11:44 GMT, Tejesh R wrote:
>> _Header_ object not initialized/set when paint() method of
>> `WindowTableHeaderUI` class is executed. The paint() event is executed
>> through explicit call of `JTable.updateUI()` in the regression test. In
>> order to set the _header_ to th
On Wed, 8 Jun 2022 11:20:56 GMT, Tejesh R wrote:
> > Looks good now.
> > Please update the copyright year WindowsTableHeaderUI and optionally
> > organise imports.
>
> Copyright year...?
Yes, currently the first line in `WindowsTableHeaderUI.java`: “Copyright (c)
1997, 2014…”. It should b
On Wed, 8 Jun 2022 07:01:08 GMT, Tejesh R wrote:
>> _Header_ object not initialized/set when paint() method of
>> `WindowTableHeaderUI` class is executed. The paint() event is executed
>> through explicit call of `JTable.updateUI()` in the regression test. In
>> order to set the _header_ to th
On Tue, 7 Jun 2022 12:37:15 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments and File name changed
>
> test/jdk/javax/swing/JTableHeade
On Mon, 6 Jun 2022 20:46:03 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> skip transform is m01 or m10 i
On Tue, 7 Jun 2022 20:33:43 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList
> java/awt/GraphicsDevice/DisplayModes/UnknownRefrshRateTest.java on
> macosx-aarch64.
>
> What I'd really like to is to ProblemList this test
> on Mac_OS_X_12.4 and Mac_OS_X_12.5, but two digit release
On Mon, 6 Jun 2022 16:19:18 GMT, Damon Nguyen wrote:
>> test/jdk/javax/swing/text/html/parser/HtmlTagParserTest.java line 1:
>>
>>> 1: import java.awt.Dimension;
>>
>> where's the GPL header on this test ?
>
> Added the header and moved the test to the HTML folder instead since I
> believe the
On Mon, 6 Jun 2022 20:45:46 GMT, Damon Nguyen wrote:
>> Updated Parser class doc by appending to the doc regarding lack of support
>> for HTML script tags. Adding this information to the "parse" function did
>> not seem as consistent for formatting as adding it to the Parser class doc.
>
> Damo
On Mon, 6 Jun 2022 16:28:22 GMT, Damon Nguyen wrote:
>> I see your points and agree that your points are valid. Parser has no part
>> in the display and is fact handled elsewhere.
>>
>> I initially had to look through and learn what each class for HTML parsing
>> is responsible for, and Parser
On Fri, 11 Mar 2022 23:19:19 GMT, Damon Nguyen wrote:
> So I wrote a test with a JEditorPane loading HTML from a file, but couldn't
> get HTML buttons to render properly in JEditorPane. I wanted HTML buttons to
> test a foo function encased in script tags in my HTML file to see if script
> tag
On Wed, 23 Feb 2022 21:34:29 GMT, Emmanuel Bourg wrote:
>> Emmanuel Bourg has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Test case for the window icon update on DPI change (Java generic font
>> names are usually capitalized)
>> - Te
On Tue, 7 Jun 2022 13:40:57 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
Marked as reviewed by aivanov (Reviewer)
On Tue, 7 Jun 2022 11:58:01 GMT, Tejesh R wrote:
>> _Header_ object not initialized/set when paint() method of
>> `WindowTableHeaderUI` class is executed. The paint() event is executed
>> through explicit call of `JTable.updateUI()` in the regression test. In
>> order to set the _header_ to th
On Tue, 7 Jun 2022 11:19:10 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
Marked as reviewed by aivanov (Reviewer)
On Mon, 6 Jun 2022 06:16:16 GMT, Tejesh R wrote:
>> _Header_ object not initialized/set when paint() method of
>> `WindowTableHeaderUI` class is executed. The paint() event is executed
>> through explicit call of `JTable.updateUI()` in the regression test. In
>> order to set the _header_ to th
On Tue, 7 Jun 2022 11:06:06 GMT, Tejesh R wrote:
>> test/jdk/javax/swing/JRadioButton/bug4380543.java line 72:
>>
>>> 70: //Adding the Test Frame to handle dispose
>>> 71: passFailJFrame.addTestFrame(testObj);
>>> 72: passFailJFrame.pos
On Mon, 6 Jun 2022 06:08:38 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
Changes requested by aivanov (Reviewer).
On Thu, 2 Jun 2022 21:48:07 GMT, Sergey Bylokhov wrote:
>>> BTW I think that the usage of
>>> `return icons.toArray(EMPTY_TRAY_ARRAY);`
>>> is slower than any of other cases: presized or zero. So if we would like to
>>> use a similar pattern the zero version is better.
>>
>> Why is it? It's the
On Thu, 2 Jun 2022 15:32:11 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed whitespaces
Except for the minor comments, it looks good now.
te
On Thu, 2 Jun 2022 06:03:16 GMT, Tejesh R wrote:
>> The tooltip displays accelerated string along with the toooltip string. The
>> feature is implemented and applicable for Metal Look and Feel only. Hence
>> the test is updated for Metal Look and Feel by hard wiring it in the code.
>> Updated
On Fri, 3 Jun 2022 15:21:02 GMT, Alexey Ivanov wrote:
> > I think that the rendering to the BufferedImage as suggested by
> > @aivanov-jdk should work as well.
>
> In theory only. I was unable to make the table paint with its header to
> `BufferedImage`. The component
On Fri, 3 Jun 2022 05:42:38 GMT, Tejesh R wrote:
> I see that the bug description has a test case which produce this exception.
> There are these lines on the stack:
>
> ```
> at
> sun.awt.SunGraphicsCallback.runComponents(SunGraphicsCallback.java:116)
> at java.awt.Container.paint
On Thu, 2 Jun 2022 09:14:30 GMT, Tejesh R wrote:
>> _Header_ object not initialized/set when paint() method of
>> `WindowTableHeaderUI` class is executed. The paint() event is executed
>> through explicit call of `JTable.updateUI()` in the regression test. In
>> order to set the _header_ to th
On Fri, 3 Jun 2022 10:27:20 GMT, Tejesh R wrote:
>> _Header_ object not initialized/set when paint() method of
>> `WindowTableHeaderUI` class is executed. The paint() event is executed
>> through explicit call of `JTable.updateUI()` in the regression test. In
>> order to set the _header_ to th
On Thu, 2 Jun 2022 00:36:28 GMT, Sergey Bylokhov wrote:
> BTW I think that the usage of
> `return icons.toArray(EMPTY_TRAY_ARRAY);`
> is slower than any of other cases: presized or zero. So if we would like to
> use a similar pattern the zero version is better.
Why is it? It's the same as `icon
On Thu, 2 Jun 2022 07:51:00 GMT, Alexey Ivanov wrote:
>>> > > > I wonder why the test is Windows-specific if it allows changing Look
>>> > > > and Feels.
>>> > > > The only Look and Feel which ignores the background is Nimbus, other
>>
On Thu, 2 Jun 2022 05:25:54 GMT, Tejesh R wrote:
> > I can see no reason why the test is for Windows only.
> >
> > The original bug
> > [JDK-4380543](https://bugs.openjdk.java.net/browse/JDK-4380543) lists all
> > the operating systems as affected. Then
> > [JDK-8134640](https://bugs.openjdk.j
On Wed, 1 Jun 2022 18:00:44 GMT, Phil Race wrote:
>>> > Shall the test be located in
>>> > `test/jdk/javax/swing/JRadioButton/4380543/bug4380543.java` instead of
>>> > `test/jdk/javax/swing/JRadioButton/bug4380543.java` ?
>>> > Usually, there's been a folder with bugid (`/4380543/`) for each te
On Wed, 1 Jun 2022 16:35:01 GMT, Harshitha Onkar wrote:
> > Shall the test be located in
> > `test/jdk/javax/swing/JRadioButton/4380543/bug4380543.java` instead of
> > `test/jdk/javax/swing/JRadioButton/bug4380543.java` ?
> > Usually, there's been a folder with bugid (`/4380543/`) for each test
On Wed, 1 Jun 2022 05:32:27 GMT, Tejesh R wrote:
> > > I wonder why the test is Windows-specific if it allows changing Look and
> > > Feels.
> > > The only Look and Feel which ignores the background is Nimbus, other L&Fs
> > > on Windows at least paint the yellow and green background. As such,
On Wed, 1 Jun 2022 06:00:34 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
Changes requested by aivanov (Reviewer).
On Mon, 23 May 2022 20:35:33 GMT, Phil Race wrote:
> If we don't store the memory allocated for graphicsConfigs because we
> failed/bail, we need to free it.
Marked as reviewed by aivanov (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8857
On Fri, 27 May 2022 17:21:29 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Updated based on review comments
> - Added headful key
I wonder why t
On Tue, 31 May 2022 09:40:17 GMT, Tejesh R wrote:
>>> _Actually if the current test executes then its a pass right..?_ This
>>> means, if there is no NPE raised then its a pass case right...? Yeah to
>>> some extent it is automatic, I actually didn't get how to handle the caught
>>> NP
On Tue, 31 May 2022 03:58:04 GMT, Tejesh R wrote:
> Yeah, wanted to change to automatic, but wasn't sure about whether its ok for
> NPE check or not.
What can be wrong with it? It's just a regular test. If you can automate the
test, you should.
> Actually if the current test executes then its
On Mon, 30 May 2022 06:04:03 GMT, Tejesh R wrote:
>> _Header_ object not initialized/set when paint() method of
>> `WindowTableHeaderUI` class is executed. The paint() event is executed
>> through explicit call of `JTable.updateUI()` in the regression test. In
>> order to set the _header_ to t
On Wed, 25 May 2022 21:37:07 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> changed test to headless
`te
On Wed, 25 May 2022 21:37:07 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> changed test to headless
Are
On Wed, 25 May 2022 21:37:07 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> changed test to headless
Cha
On Wed, 25 May 2022 20:32:54 GMT, Phil Race wrote:
> so -showFrame is just for a person to use "standalone" to see the results,
> never used by jtreg
Yes, it is for stand-alone during debugging, not for jtreg.
-
PR: https://git.openjdk.java.net/jdk/pull/7449
using a laptop with the
>> same settings that caused the issue (primary screen with 2160x1350
>> resolution and 150% scaling), and applying the fix did not introduce any new
>> test failures.
>
> Dmitry Kulikov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update src/java.desktop/windows/classes/sun/awt/Win32GraphicsDevice.java
>
> Comments clean-up
>
> Co-authored-by: Alexey Ivanov
> <70774172+aivanov-...@users.noreply.github.com>
Marked as reviewed by aivanov (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7835
ewValue != null` chained with
> `equals`.
Alexey Ivanov has updated the pull request incrementally with one additional
commit since the last revision:
Use method reference in setSystemTrayAccessor instead of anonymous class
-
Changes:
- all: https://git.openjdk.java.net/j
On Wed, 25 May 2022 17:53:31 GMT, Harshitha Onkar wrote:
> @aivanov-jdk In SystemTray.java the following line can be simplified using
> method reference or lambda expression.
>
> https://github.com/openjdk/jdk/blob/a2f8c9523438ca63380b0b7d4909d5e5e7fbf88a/src/java.desktop/share/classes/java/awt
On Wed, 25 May 2022 13:53:57 GMT, Prasanta Sadhukhan
wrote:
>> Issue was when printing a JTable which sits inside a JScrollPane and the
>> table is scrolled down to the end to about 1000th row, only the first page
>> is printed.
>> This is because when the table is scrolled down to last page,
On Wed, 25 May 2022 14:19:49 GMT, Prasanta Sadhukhan
wrote:
>> It is a problem for jtreg tests: `System.exit` shouldn't be called. We
>> should not use it for new tests even if there are tests which use it.
>>
>> `DISPOSE_ON_CLOSE` is fine: it disposes of the frame; once there are no
>> frame
On Wed, 25 May 2022 13:36:09 GMT, Prasanta Sadhukhan
wrote:
>> Good catch! Not really… It must not be `EXIT_ON_CLOSE`. The default value is
>> `HIDE_ON_CLOSE` and it would work well because the frame will be disposed of
>> after the latch is released.
>>
>> And here I see another problem: the
On Wed, 25 May 2022 13:06:50 GMT, Andrey Turbanov wrote:
>> _Header_ object not initialized/set when paint() method of
>> `WindowTableHeaderUI` class is executed. The paint() event is executed
>> through explicit call of `JTable.updateUI()` in the regression test. In
>> order to set the _heade
On Wed, 25 May 2022 12:30:12 GMT, Tejesh R wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test update
>
> test/jdk/javax/swing/JTable/PrintAllPagesTest.java line 115:
>
>> 113: f.add(scrollpane);
>>
On Wed, 18 May 2022 13:58:22 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> I tried to avoid changing external libraries, there are quite a few such
> typos.
> Let me know if I should rever
On Tue, 24 May 2022 00:03:54 GMT, Sergey Bylokhov wrote:
>> I'm sure I've used this pattern
>> return icons.toArray(EMPTY_TRAY_ARRAY);
>> in code that runs often and may be performance sensitive, so I don't see
>> anything weird about it.
>> OTOH I am not sure this code is anything that needs su
ewValue != null` chained with
> `equals`.
Alexey Ivanov has updated the pull request incrementally with three additional
commits since the last revision:
- toArray: new TrayIcon[0] -> EMPTY_TRAY_ARRAY - use existing empty array
- Drop explicit type argument
- Make popupParent final
-
On Fri, 20 May 2022 22:31:38 GMT, Phil Race wrote:
>> This fix adds "headful sound" keywords to a number of javax/sound jtreg tests
>>
>> The jtreg javax.sound tests are written in such a way that if a needed audio
>> device
>> or other platform resource is not available, they just exit with a
On Mon, 16 May 2022 06:45:04 GMT, Tejesh R wrote:
> Added test for checking setMargin() of JRadioButton.
test/jdk/javax/swing/JRadioButton/bug4380543.java line 143:
> 141: {
> 142: disposeUI();
> 143: if (res.toString() == "false")
This looks weird. Why can't you use `res.g
On Tue, 24 May 2022 05:29:43 GMT, Tejesh R wrote:
> > Just an idea for discussion: I remember that we added some support for the
> > manual tests, kind of framework or something. Probably it will be useful to
> > reuse when we add "new" tests?
> > https://bugs.openjdk.java.net/browse/JDK-82838
On Mon, 23 May 2022 20:24:52 GMT, Alexey Ivanov wrote:
>> ok ... why ?
>
> It's explained in Aleksey Shipilёv's article
> https://shipilev.net/blog/2016/arrays-wisdom-ancients/#_conclusion
In fact, there's no need to create zero-sized array, there's one alr
On Mon, 23 May 2022 20:23:08 GMT, Phil Race wrote:
>> It is not intuitive but the "zero version" is actually faster:
>
> ok ... why ?
It's explained in Aleksey Shipilёv's article
https://shipilev.net/blog/2016/arrays-wisdom-ancients/#_conclusion
-
PR: https://git.openjdk.java.net/j
**WTrayIconPeer**: removed duplicate call to `popupParent.dispose()` that might
cause NPE (it looks `popupParent` cannot be `null`); organised imports.
**SystemTray**: removed redundant initialisers; replaced sized array with empty
array in `toArray` call; dropped `newValue != null` chained with
On Fri, 20 May 2022 17:35:40 GMT, Phil Race wrote:
> The test should be under test/jdk/javax/swing/border/ not java/awt !
Good catch! I never noticed the wrong package, I just copied the path.
-
PR: https://git.openjdk.java.net/jdk/pull/7449
On Fri, 20 May 2022 16:55:43 GMT, Alisen Chung wrote:
>> Changed the drawing area to be increased by 0.5 on the left side to prevent
>> clipping
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> reverted copyright year
test
On Tue, 17 May 2022 20:05:45 GMT, Phil Race wrote:
> Actually I'm not sure why only Win L&F is tested .. it is cross-platform and
> cross L&F code being changed
It was exactly my point, we already [discussed it
above](https://github.com/openjdk/jdk/pull/7449#discussion_r836586231).
The update
On Tue, 10 May 2022 14:08:50 GMT, Alexey Ivanov wrote:
> One more thing: the test now uses `EtchedBorder` only, shall it be moved to
> `test/jdk/java/awt/EtchedBorder`? And adding the word _Scaled_ to the title —
> `ScaledEtchedBorderTest` — would clarify the purpose of the test.
>
On Fri, 20 May 2022 12:02:42 GMT, Alexey Ivanov wrote:
>> Right, JPanel isn't laid out without being added to a peered component.
>>
>> Maybe setting explicit positions to child panels will work, then the test
>> can be headless.
>
>> That looks odd. I
On Tue, 17 May 2022 20:43:00 GMT, Alexey Ivanov wrote:
>> Perhaps you are trying to get layout to happen ? That should be possible but
>> it might be tricky.
>> But I think if you are going so far as pack() and can't change that, then
>> show the frame regardless.
On Tue, 17 May 2022 13:02:49 GMT, Alexey Ivanov wrote:
> Encapsulate the logic of adding or modifying a notification icon aka tray
> icon. This is to avoid code duplication between
> [`AwtTrayIcon::WmTaskbarCreated`](https://github.com/openjdk/jdk/blob/7b988b31c661c6e3e58cf8ced81732e
Changing DPI of the main display updates the displayed icon as expected.
Alexey Ivanov has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 18 commits:
- Merge master
- Inline AddTrayIcon and ModifyTrayIcon
- Make SendTrayMessage private - i
On Wed, 18 May 2022 17:54:30 GMT, Alexey Ivanov wrote:
>> Encapsulate the logic of adding or modifying a notification icon aka tray
>> icon. This is to avoid code duplication between
>> [`AwtTrayIcon::WmTaskbarCreated`](https://github.co
Changing DPI of the main display updates the displayed icon as expected.
Alexey Ivanov has updated the pull request incrementally with two additional
commits since the last revision:
- Inline AddTrayIcon and ModifyTrayIcon
- Make SendTrayMessage private - it's used internally only
On Wed, 18 May 2022 16:24:38 GMT, lawrence.andrews
wrote:
>> 1) Fixed Parser error by removing yesno from @run main/manual=yesno
>> 2) Used PassFaileJFrame to show the test instruction to the user instead of
>> printing the test instruction on the console or jtreg log file.
>> 3) If printer
Replaces usages of articles that follow each other in all combinations: a/the,
an?/an?, the/the…
I tried to avoid changing external libraries, there are quite a few such typos.
Let me know if I should revert any files.
-
Commit messages:
- 8284213: Replace usages of 'the a' in xml
Changing DPI of the main display updates the displayed icon as expected.
Alexey Ivanov has updated the pull request incrementally with one additional
commit since the last revision:
8286872: Replace SendTrayMessage(NIM_MODIFY) with ModifyTrayIcon()
-
Changes:
- all: https://git.
1 - 100 of 588 matches
Mail list logo
