Re: RFR: 8284853: Fix varios 'expected' typo

2022-04-13 Thread Chris Plummer
On Wed, 13 Apr 2022 20:36:48 GMT, Andrey Turbanov wrote: > Found various typos of expected: `exepected`, `exept`, `epectedly`, > `expeced`, `Unexpeted`, etc. test/jdk/java/lang/StackWalker/StackStreamTest.java line 218: > 216: private static void equalsOrThrow(String label, List list, >

Re: RFR: 8280400: JDK 19 L10n resource files update - msgdrop 10 [v2]

2022-03-10 Thread Chris Plummer
On Thu, 10 Mar 2022 17:55:44 GMT, Alisen Chung wrote: >> msg drop for jdk19, Mar 9, 2022 > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > moved CurrencyNames changes to jdk.localedata src/jdk.jdi/share/classes/com/sun/tools

Re: RFR: 8276930: Update ProblemList [v2]

2021-11-10 Thread Chris Plummer
On Wed, 10 Nov 2021 10:41:56 GMT, Jesper Wilhelmsson wrote: >> Update a few entries in the problemlist that refer to bugs that have been >> closed as duplicates. > > Jesper Wilhelmsson has updated the pull request incrementally with one > additional commit since the last revision: > > Moved

Re: RFR: 8273684: Unnecessary Stack usage

2021-09-15 Thread Chris Plummer
On Sun, 29 Aug 2021 21:14:19 GMT, Andrey Turbanov wrote: > Usage of thread-safe collection Stack is unnecessary. It's recommended to use > ArrayDequeue if a thread-safe implementation is not needed. Marked as reviewed by cjplummer (Reviewer). - PR: https://git.openjdk.java.net/jd

Re: RFR: 8273684: Unnecessary Stack usage

2021-09-15 Thread Chris Plummer
On Wed, 15 Sep 2021 18:27:05 GMT, Andrey Turbanov wrote: >> I wonder if you are exporting CLASSPATH and that is causing `jhsdb` to pick >> up the wrong SA implementation. > > Rechecked again. > Now without involving IDEA. Just started small java program and then attached. > Then checkouted revi

Re: RFR: 8273684: Unnecessary Stack usage

2021-09-15 Thread Chris Plummer
On Wed, 15 Sep 2021 16:42:39 GMT, Chris Plummer wrote: >> I wondered about this too. Perhaps this messages coming from the _target >> JDK_ which I'm attached too? >> I attached to my IntelliJ IDEA process. It uses JDK 11. > > SA doesn't doesn't run any c

Re: RFR: 8273684: Unnecessary Stack usage

2021-09-15 Thread Chris Plummer
On Wed, 15 Sep 2021 16:34:51 GMT, Andrey Turbanov wrote: >> There is something wrong with the version of jhsdb you are running. It >> appears to be an old version, not the latest. You should not be seeing the >> following warning. The code that produces it is not even present in the >> latest

Re: RFR: 8273684: Unnecessary Stack usage

2021-09-15 Thread Chris Plummer
On Wed, 15 Sep 2021 10:53:47 GMT, Andrey Turbanov wrote: >> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java >> line 988: >> >>> 986: // Make sure the types are emitted in an order than >>> can be read back in >>> 987: HashSet emitted =

Re: RFR: 8273684: Unnecessary Stack usage

2021-09-14 Thread Chris Plummer
On Sun, 29 Aug 2021 21:14:19 GMT, Andrey Turbanov wrote: > Usage of thread-safe collection Stack is unnecessary. It's recommended to use > ArrayDequeue if a thread-safe implementation is not needed. src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/CommandProcessor.java line 988: > 986: