Re: RFR: JDK-8288094: cleanup old _MSC_VER handling

2022-06-10 Thread Christoph Langer
On Thu, 9 Jun 2022 11:37:21 GMT, Matthias Baesken wrote: > We still handle at a number of places ancient historic _MSC_VER versions of > Visual Studio releases e.g. pre VS2013 (VS2013 has _MSC_VER 1800). > This should be cleaned up, as long as it is not 3rd party code that we don't > want to ad

Re: RFR: JDK-8276809: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java shows JNI warning on Windows [v2]

2021-11-16 Thread Christoph Langer
On Tue, 16 Nov 2021 08:20:52 GMT, Matthias Baesken wrote: > > We have issues running in debug mode even in headful mode - > > https://bugs.openjdk.java.net/browse/JDK-8264773 I think this PR should be > > withdrawn. We need a holistic look at making sure we run properly in debug > > builds on

Re: RFR: JDK-8276809: java/awt/font/JNICheck/FreeTypeScalerJNICheck.java shows JNI warning on Windows

2021-11-09 Thread Christoph Langer
On Tue, 9 Nov 2021 07:57:55 GMT, Matthias Baesken wrote: > The new test java/awt/font/JNICheck/FreeTypeScalerJNICheck.java introduced > with https://bugs.openjdk.java.net/browse/JDK-8269223 adds -Xcheck:jni to an > awt related test, and shows on Windows server 2019 the following JNI warning >

Re: RFR: JDK-8273387: remove some unreferenced gtk-related functions [v3]

2021-09-08 Thread Christoph Langer
On Wed, 8 Sep 2021 11:56:39 GMT, Matthias Baesken wrote: >> Please review this small change. >> Looks like there are a few functions, like gtk2_paint_diamond, that are >> unreferenced and can be removed. >> >> Thanks, Matthias > > Matthias Baesken has updated the pull request incrementally with