On Wed, 11 May 2022 16:00:32 GMT, Maxim Kartashev
wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adjust API level to Windows 8 for security.cpp and do some cleanup
>
> This change seem to have made this group
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft.com/en-us/windows/win32/win
On Wed, 4 May 2022 08:00:08 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft.com/en-us/windows/win32/win
On Tue, 3 May 2022 07:10:58 GMT, Matthias Baesken wrote:
>> Currently we set _WIN32_WINNT at various places in the codebase; this is
>> used to target a minimum Windows version we want to support. See also for
>> more detailled information :
>> https://docs.microsoft.com/en-us/windows/win32/win
On Wed, 27 Apr 2022 14:57:41 GMT, Matthias Baesken wrote:
> Currently we set _WIN32_WINNT at various places in the codebase; this is used
> to target a minimum Windows version we want to support. See also for more
> detailled information :
> https://docs.microsoft.com/en-us/windows/win32/winpro
On Wed, 27 Apr 2022 14:57:41 GMT, Matthias Baesken wrote:
> Currently we set _WIN32_WINNT at various places in the codebase; this is used
> to target a minimum Windows version we want to support. See also for more
> detailled information :
> https://docs.microsoft.com/en-us/windows/win32/winpro
On Thu, 21 Apr 2022 10:34:42 GMT, Jaikiran Pai wrote:
> Can I please get a review for this trivial fix to the copyright header?
Thanks for fixing.
-
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8331
On Sun, 20 Mar 2022 13:30:01 GMT, Andrey Turbanov wrote:
> Fix repeated typo `exeption`
Looks good.
Thanks for cleaning this up.
-
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7879
On Tue, 8 Mar 2022 15:54:45 GMT, Zhengyu Gu wrote:
>> Please review this small patch that fixes a potential memory leak that
>> exception return fails to release allocated `cacheDirs`
>>
>> Test:
>>
>> - [x] jdk_desktop on Linux x86_64
>
> Zhengyu Gu has updated the pull request incrementally
On Tue, 8 Mar 2022 09:18:01 GMT, Sergey Bylokhov wrote:
>> Please review this small patch that fixes a potential memory leak that
>> exception return fails to release allocated `cacheDirs`
>>
>> Test:
>>
>> - [x] jdk_desktop on Linux x86_64
>
> src/java.desktop/unix/native/common/awt/fontpath.
On Tue, 8 Mar 2022 09:20:19 GMT, Sergey Bylokhov wrote:
>> Please review this small patch that fixes a potential memory leak that
>> exception return fails to release allocated `cacheDirs`
>>
>> Test:
>>
>> - [x] jdk_desktop on Linux x86_64
>
> src/java.desktop/unix/native/common/awt/fontpath.
On Mon, 7 Mar 2022 00:46:12 GMT, Masanori Yano wrote:
> I would like to fix the missing comma in the copyright of the test added in
> JDK-8275715.
> Could you please review the fix?
The actual build target is `validate-headers` but I have confirmed the fix.
Please integrate asap. Thanks.
On Mon, 7 Mar 2022 00:46:12 GMT, Masanori Yano wrote:
> I would like to fix the missing comma in the copyright of the test added in
> JDK-8275715.
> Could you please review the fix?
Just realized you can't run `validate-source`, so I will confirm fix.
-
PR: https://git.openjdk.jav
On Mon, 7 Mar 2022 00:46:12 GMT, Masanori Yano wrote:
> I would like to fix the missing comma in the copyright of the test added in
> JDK-8275715.
> Could you please review the fix?
Looks good and trivial. Did you verify it fixes the problem with the
`validate-source` target?
Thanks,
David
-
On Thu, 28 Oct 2021 08:27:44 GMT, Masanori Yano wrote:
>> Could you please review the 8275715 bug fixes?
>>
>> I think D3DScreenUpdateManager posts unnecessary PaintEvent during
>> processing PaintEvent. When the validate method is called from
>> createGraphics, repaintPeerTarget should not be
On Wed, 2 Mar 2022 06:21:15 GMT, Masanori Yano wrote:
>> Ok. Please confirm you have run all automated headful jtreg tests on a
>> system with D3D enabled
>> and that you have also done manual testing (using SwingSet2 and J2Ddemo) and
>> no problems are observed ?
>
> @prrace How long will it t
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
I eyeballed the diff file and all seems okay.
Thanks,
David
-
Marked as reviewed by dholmes (Reviewer).
PR: http
On Fri, 4 Mar 2022 21:54:57 GMT, Zhengyu Gu wrote:
> The macros are used to hide the different syntax of c and c++ to avoid
> polluting code here, it seems to be a common pattern in client code.
That's to allow for general use by C or C++ source files. But you are only
needing this in a C sour
On Fri, 4 Mar 2022 13:25:12 GMT, Zhengyu Gu wrote:
> Please review this small patch that fixes a potential memory leak that
> exception return fails to release allocated `cacheDirs`
>
> Test:
>
> - [x] jdk_desktop on Linux x86_64
I would have just inlined JNU_CHECK_EXCEPTION and added the cle
On Wed, 15 Dec 2021 17:59:54 GMT, Andrey Turbanov wrote:
> > @turbanoff Only [Committers](https://openjdk.java.net/bylaws#committer) are
> > allowed to sponsor changes.
>
> But I am a Committer 😢
You can't "sponsor" your own change. I suspect your Committer status changed
after the bot initia
On Wed, 10 Nov 2021 10:41:56 GMT, Jesper Wilhelmsson
wrote:
>> Update a few entries in the problemlist that refer to bugs that have been
>> closed as duplicates.
>
> Jesper Wilhelmsson has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Moved
On Tue, 26 Oct 2021 11:13:19 GMT, Jiřà Vaněk wrote:
>> Jiřà Vaněk has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> Attmept done. Looks like the summary is th
22 matches
Mail list logo
