On Tue, 14 Jun 2022 06:18:50 GMT, Alexander Zuev wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Window.cpp line 1407:
>>
>>> 1405: int extraPaddedBorderInsets = info.dwMajorVersion >= 6 ?
>>> 1406: ::GetSystemMetrics(SM_CXPADDEDBORDER) : 0;
>>> 1407:
>>
>> The OS version
On Fri, 10 Jun 2022 05:35:22 GMT, Tejesh R wrote:
> Fix history - #7422.
> The test is automatic and check if the last row is painted (Which was not
> happening before the fix, the last row appeared only after MouseClick
> operation) by capturing the last row before and after MouseClick Operati
On Sat, 11 Jun 2022 00:30:20 GMT, Harshitha Onkar wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Window.cpp line 1440:
>>
>>> 1438: ::GetSystemMetrics(SM_CXDLGFRAME);
>>> 1439: m_insets.to
On Fri, 10 Jun 2022 12:01:21 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> removed os version check, added review changes
>
> src/java.desktop/windows/native
redSize()), thus
> checking if frame.pack() works as expected.
>
> Following are before and after screenshots -
> 
Harshitha Onkar has updated the pull request incremental
On Fri, 10 Jun 2022 12:12:31 GMT, Alexey Ivanov wrote:
>> Due to incorrect AWT Frame inset values being returned from native code, few
>> of the components in the frame were not being shown completely on Windows.
>> With the proposed fix, correct insets are obtained which in turn sizes and
>>
Due to incorrect AWT Frame inset values being returned from native code, few of
the components in the frame were not being shown completely on Windows. With
the proposed fix, correct insets are obtained which in turn sizes and displays
the frame correctly.
The default insets obtained from the W
On Fri, 10 Jun 2022 05:55:35 GMT, Harshitha Onkar wrote:
> Due to incorrect AWT Frame inset values being returned from native code, few
> of the components in the frame were not being shown completely on Windows.
> With the proposed fix, correct insets are obtained which in turn
On Fri, 27 May 2022 20:48:30 GMT, Alexey Ivanov wrote:
>> **WTrayIconPeer**: removed duplicate call to `popupParent.dispose()` that
>> might cause NPE (it looks `popupParent` cannot be `null`); organised imports.
>>
>> **SystemTray**: removed redundant initialisers; replaced sized array with
>
On Thu, 2 Jun 2022 06:03:16 GMT, Tejesh R wrote:
>> The tooltip displays accelerated string along with the toooltip string. The
>> feature is implemented and applicable for Metal Look and Feel only. Hence
>> the test is updated for Metal Look and Feel by hard wiring it in the code.
>> Updated
On Thu, 2 Jun 2022 00:55:07 GMT, Sergey Bylokhov wrote:
> Can you please double check how the native applications/components look when
> the colors are "similar".
@mrserb There are different variations in the native applications -
On Reminders App the background color remains the same (light g
On Wed, 1 Jun 2022 05:30:23 GMT, Tejesh R wrote:
>> The tooltip displays accelerated string along with the toooltip string. The
>> feature is implemented and applicable for Metal Look and Feel only. Hence
>> the test is updated for Metal Look and Feel by hard wiring it in the code.
>> Updated
On Wed, 1 Jun 2022 05:30:23 GMT, Tejesh R wrote:
>> The tooltip displays accelerated string along with the toooltip string. The
>> feature is implemented and applicable for Metal Look and Feel only. Hence
>> the test is updated for Metal Look and Feel by hard wiring it in the code.
>> Updated
On Wed, 1 Jun 2022 16:54:43 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/swing/JTable/CellFocusRingTest.java line 85:
>>
>>> 83: }
>>> 84:
>>> 85: if (UIManager.getDefaults().get("CellFocus.color") != null
>>
>&g
> - Common test added - `CellFocusRingTest`, which tests for both cases -
> Tables & Lists.
>
> **Before and After screenshots of JList** _(Screenshots from SwingSet2 demo)_
>
>  for each test. Do we
On Fri, 27 May 2022 17:21:29 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Updated based on review comments
> - Added headful key
Marked as revi
On Wed, 25 May 2022 12:21:51 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pu
With the proposed fix, JList's focus ring color follows accent color changes.
Previously the focus ring for JList was not prominently visible and did not
follow accent color changes.
While investing a similar issue related to JTable
(https://github.com/openjdk/jdk/pull/7768#discussion_r83981351
On Tue, 24 May 2022 11:20:36 GMT, Alexey Ivanov wrote:
>> **WTrayIconPeer**: removed duplicate call to `popupParent.dispose()` that
>> might cause NPE (it looks `popupParent` cannot be `null`); organised imports.
>>
>> **SystemTray**: removed redundant initialisers; replaced sized array with
>
On Tue, 24 May 2022 08:28:57 GMT, Prasanta Sadhukhan
wrote:
> Test was failing intermiitently in iMac M1 system owing to minimalistic color
> difference of 1
>
> x 13 y 0 refRGB ffee customRGB ffef
> x 0 y 0 refRGB ffefefef customRGB ffefeeef
>
>
> so added color tolerance check.
>
On Tue, 24 May 2022 05:29:43 GMT, Tejesh R wrote:
>> Just an idea for discussion: I remember that we added some support for the
>> manual tests, kind of framework or something. Probably it will be useful to
>> reuse when we add "new" tests?
>> https://bugs.openjdk.java.net/browse/JDK-8283803
>
On Thu, 19 May 2022 08:23:16 GMT, Alexey Ivanov wrote:
>> Encapsulate the logic of adding or modifying a notification icon aka tray
>> icon. This is to avoid code duplication between
>> [`AwtTrayIcon::WmTaskbarCreated`](https://github.com/openjdk/jdk/blob/7b988b31c661c6e3e58cf8ced81732e40a79d4f
On Thu, 19 May 2022 08:23:16 GMT, Alexey Ivanov wrote:
>> Encapsulate the logic of adding or modifying a notification icon aka tray
>> icon. This is to avoid code duplication between
>> [`AwtTrayIcon::WmTaskbarCreated`](https://github.com/openjdk/jdk/blob/7b988b31c661c6e3e58cf8ced81732e40a79d4f
On Thu, 19 May 2022 08:23:16 GMT, Alexey Ivanov wrote:
>> Encapsulate the logic of adding or modifying a notification icon aka tray
>> icon. This is to avoid code duplication between
>> [`AwtTrayIcon::WmTaskbarCreated`](https://github.com/openjdk/jdk/blob/7b988b31c661c6e3e58cf8ced81732e40a79d4f
On Thu, 28 Apr 2022 02:26:28 GMT, Harshitha Onkar wrote:
> In Windows, when desktop scaling is changed the tray icons was
> distorted/blurred a bit each time scaling changes.
>
> With the proposed fix, the tray icon scales according to on-the-fly DPI scale
> settings. A tes
On Wed, 11 May 2022 18:57:00 GMT, Phil Race wrote:
>>> @aivanov-jdk were both windows 10 and windows 11 using the same pipeline ?
>>> (meaning GDI or D3D). Otherwise on our side I'd expect all the same code
>>> path ..
>>
>> Good question. The output from `WindowsFlags` is the same on both mac
n's Window Procedure. Triggering an update on WM_DPICHANGED was
> still causing the icons to be distorted, hence WMPOSCHANGING is being used as
> the message to trigger the update.
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the la
n's Window Procedure. Triggering an update on WM_DPICHANGED was
> still causing the icons to be distorted, hence WMPOSCHANGING is being used as
> the message to trigger the update.
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the last r
On Mon, 16 May 2022 20:53:45 GMT, Phil Race wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_TrayIcon.cpp line 73:
>>
>>> 71: jfieldID AwtTrayIcon::idID;
>>> 72: jfieldID AwtTrayIcon::actionCommandID;
>>> 73: jmethodID AwtTrayIcon::updateImageDpiID;
>>
>> I'd rather drop 'Dpi' from
n's Window Procedure. Triggering an update on WM_DPICHANGED was
> still causing the icons to be distorted, hence WMPOSCHANGING is being used as
> the message to trigger the update.
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the last re
On Mon, 9 May 2022 21:05:26 GMT, Phil Race wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> formatting changes
>
> test/jdk/java/awt/TrayIcon/TrayIconScalingTest.java
On Fri, 13 May 2022 22:09:08 GMT, Phil Race wrote:
>> test/jdk/java/awt/TrayIcon/TrayIconScalingTest.java line 73:
>>
>>> 71: System.out.println("SystemTray is not supported");
>>> 72: return;
>>> 73: }
>>
>> This should be the first statement in main. If icons a
On Fri, 13 May 2022 18:01:47 GMT, Harshitha Onkar wrote:
>> In Windows, when desktop scaling is changed the tray icons was
>> distorted/blurred a bit each time scaling changes.
>>
>> With the proposed fix, the tray icon scales according to on-the-fly DPI
>> s
n's Window Procedure. Triggering an update on WM_DPICHANGED was
> still causing the icons to be distorted, hence WMPOSCHANGING is being used as
> the message to trigger the update.
Harshitha Onkar has updated the pull request incrementally with one additional
commit since
On Fri, 13 May 2022 22:04:39 GMT, Phil Race wrote:
>> Harshitha Onkar has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 addi
On Fri, 13 May 2022 18:07:02 GMT, Kevin Rushforth wrote:
>> Harshitha Onkar has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
n's Window Procedure. Triggering an update on WM_DPICHANGED was
> still causing the icons to be distorted, hence WMPOSCHANGING is being used as
> the message to trigger the update.
Harshitha Onkar has updated the pull request with a new target base due to a
merge or a rebase. The incr
n's Window Procedure. Triggering an update on WM_DPICHANGED was
> still causing the icons to be distorted, hence WMPOSCHANGING is being used as
> the message to trigger the update.
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the last rev
On Thu, 12 May 2022 18:59:47 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> trayicon update triggered on taskbar reload
>
> Yeah, this version works correct
n's Window Procedure. Triggering an update on WM_DPICHANGED was
> still causing the icons to be distorted, hence WMPOSCHANGING is being used as
> the message to trigger the update.
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the last re
On Thu, 12 May 2022 18:59:47 GMT, Alexey Ivanov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> trayicon update triggered on taskbar reload
>
> Yeah, this version works correct
n's Window Procedure. Triggering an update on WM_DPICHANGED was
> still causing the icons to be distorted, hence WMPOSCHANGING is being used as
> the message to trigger the update.
Harshitha Onkar has updated the pull request incrementally with one additional
commit s
On Tue, 10 May 2022 23:17:36 GMT, Harshitha Onkar wrote:
>> In Windows, when desktop scaling is changed the tray icons was
>> distorted/blurred a bit each time scaling changes.
>>
>> With the proposed fix, the tray icon scales according to on-the-fly DPI
>> s
On Tue, 10 May 2022 17:43:51 GMT, Alexey Ivanov wrote:
> Unfortunately, the icon is distorted on Windows 11. When I tested on Windows
> 10, it updates correctly most of the time, but rarely the icon becomes
> distorted. When the icon is distorted, enabling taskbar auto-hide and
> disabling it
On Sun, 8 May 2022 19:36:33 GMT, Harshitha Onkar wrote:
>> In Windows, when desktop scaling is changed the tray icons was
>> distorted/blurred a bit each time scaling changes.
>>
>> With the proposed fix, the tray icon scales according to on-the-fly DPI
>> scale
n's Window Procedure. Triggering an update on WM_DPICHANGED was
> still causing the icons to be distorted, hence WMPOSCHANGING is being used as
> the message to trigger the update.
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the last
On Thu, 10 Mar 2022 02:42:00 GMT, Harshitha Onkar wrote:
> Previously while tabbing through the JTable cell, the cell highlighter/focus
> ring was not visible against the selection background.
>
> Changes are made to Aqua LAF to derive a lighter focus ring color by changing
>
On Mon, 9 May 2022 20:50:56 GMT, Phil Race wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> formatting changes
>
> src/java.desktop/windows/native/libawt/windows/awt_Tr
On Mon, 9 May 2022 21:07:49 GMT, Phil Race wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> formatting changes
>
> Changes requested by prr (Reviewer).
@prrace @aivanov-jdk Than
On Mon, 9 May 2022 18:57:57 GMT, Kevin Rushforth wrote:
> Thanks for the additional comments. As far as I'm concerned, the only
> remaining question is the fact that the manual test doesn't exit for me when
> run from the command line.
@kevinrushforth Thank you for the update Kevin. I'm curren
On Mon, 2 May 2022 21:02:02 GMT, Harshitha Onkar wrote:
> This test case tests the functionality of `setAlwaysOnTop`.
> Documentation on `setAlwaysOnTop`:
> [Link](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/java/awt/Window.html#setAlwaysOnTop(boolean))
>
>
On Sun, 8 May 2022 19:36:33 GMT, Harshitha Onkar wrote:
>> In Windows, when desktop scaling is changed the tray icons was
>> distorted/blurred a bit each time scaling changes.
>>
>> With the proposed fix, the tray icon scales according to on-the-fly DPI
>> scale
n's Window Procedure. Triggering an update on WM_DPICHANGED was
> still causing the icons to be distorted, hence WMPOSCHANGING is being used as
> the message to trigger the update.
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the last r
On Sat, 7 May 2022 13:01:53 GMT, Kevin Rushforth wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> resized instruction window and formatted line lengths
>
> The fix looks good to
On Fri, 29 Apr 2022 00:36:15 GMT, Sergey Bylokhov wrote:
>> In Windows when desktop scaling was changed the tray icons was
>> distorted/blurred a bit each time scaling changes.
>>
>> With the proposed fix, the tray icon scales according to on-the-fly DPI
>> scale settings. A test case has been
n's Window Procedure. Triggering an update on WM_DPICHANGED was
> still causing the icons to be distorted, hence WMPOSCHANGING is being used as
> the message to trigger the update.
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the l
On Fri, 29 Apr 2022 00:36:15 GMT, Sergey Bylokhov wrote:
>> In Windows when desktop scaling was changed the tray icons was
>> distorted/blurred a bit each time scaling changes.
>>
>> With the proposed fix, the tray icon scales according to on-the-fly DPI
>> scale settings. A test case has been
t;
> Each of the three cases mentioned above is tested under 3 scenarios:
> 
Harshitha Onkar has updated the pull request incrementally wit
t;
> Each of the three cases mentioned above is tested under 3 scenarios:
> 
Harshitha Onkar has updated the pull request incrementally with one addi
On Thu, 5 May 2022 15:54:33 GMT, Alexander Zuev wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added changes to continue testing and exception thrown at end in case of
>> failur
t;
> Each of the three cases mentioned above is tested under 3 scenarios:
> 
Harshitha Onkar has updated the pull request with a new target base due
t;
> Each of the three cases mentioned above is tested under 3 scenarios:
> 
Harshitha Onkar has updated the pull request incrementally with one addi
On Wed, 4 May 2022 18:15:10 GMT, Harshitha Onkar wrote:
>> I think that's a reasonable suggestion in general to bear in mind when
>> writing tests.
>> I've seen tests which bail at the first failure and you wish you knew how
>> the rest of it worked out ..
On Wed, 4 May 2022 18:10:03 GMT, Phil Race wrote:
>> @azuev-java Thank you for the suggestion. I can definitely add this
>> functionality to the test for better failure analysis.
>
> I think that's a reasonable suggestion in general to bear in mind when
> writing tests.
> I've seen tests which
On Wed, 4 May 2022 17:58:17 GMT, Alexander Zuev wrote:
>> This test case tests the functionality of `setAlwaysOnTop`.
>> Documentation on `setAlwaysOnTop`:
>> [Link](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/java/awt/Window.html#setAlwaysOnTop(boolean))
>>
>> The followin
This test case tests the functionality of `setAlwaysOnTop`.
Documentation on `setAlwaysOnTop`:
[Link](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/java/awt/Window.html#setAlwaysOnTop(boolean))
The following test case was seen to fail on windows and linux platforms. With
the p
On Fri, 29 Apr 2022 00:36:15 GMT, Sergey Bylokhov wrote:
> Did you have a chance to check why the WM_DPICHANGED does not work, any
> specific cases? It is used by checking the scale change for windows in AWT,
> and no issues were reported for that as far as I know.
When DPI gets changed, many
In Windows when desktop scaling was changed the tray icons was
distorted/blurred a bit each time scaling changes.
With the proposed fix, the tray icon scales according to on-the-fly DPI scale
settings. A test case has been added which adds a MRI icon to system tray, to
observe the icon scaling
. Since the background for Swing tables can be set by users and also
> overridden by subclassing `DefaultTableCellRenderer`, and to adhere to
> current implementation of Swing, the white cell background changes are not
> incorporated. Only the Focus Ring/ Cell Highlighter is made more
. Since the background for Swing tables can be set by users and also
> overridden by subclassing `DefaultTableCellRenderer`, and to adhere to
> current implementation of Swing, the white cell background changes are not
> incorporated. Only the Focus Ring/ Cell Highlighter
On Tue, 26 Apr 2022 05:57:32 GMT, Prasanta Sadhukhan
wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added new color to CSystemColors.m - CELL_HIGHLIGHT_COLOR
>
> src/java.deskto
On Tue, 19 Apr 2022 21:03:13 GMT, Harshitha Onkar wrote:
> The exisiting manual test case tests different html styles of JTabbedPane tab
> title. The tab with "big" as title is seen to be clipped on Aqua LAF for
> larger font-size. In other LAFs it is observed that bigg
On Tue, 26 Apr 2022 05:57:32 GMT, Prasanta Sadhukhan
wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> added new color to CSystemColors.m - CELL_HIGHLIGHT_COLOR
>
> src/java.deskto
On Fri, 22 Apr 2022 23:15:51 GMT, Sergey Bylokhov wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> formatted test instructions
>
> Probably we should think about care of th
On Tue, 5 Apr 2022 05:48:37 GMT, Prasanta Sadhukhan
wrote:
> Need more change
@prsadhuk Suggested changes have been incorporated. Needs to be re-reviewed.
PR requires second reviewer
-
PR: https://git.openjdk.java.net/jdk/pull/7768
On Fri, 22 Apr 2022 16:44:07 GMT, Harshitha Onkar wrote:
>> The exisiting manual test case tests different html styles of JTabbedPane
>> tab title. The tab with "big" as title is seen to be clipped on Aqua LAF for
>> larger font-size. In other LAFs it is observed
On Fri, 22 Apr 2022 23:56:05 GMT, Phil Race wrote:
> This is just to fix a complaint about the test. Whether we want to make that
> policy change of ignoring font sizes that are "too big" is a separate issue.
> And the best we could do is some estimate based on metrics of the font, which
> pro
On Fri, 22 Apr 2022 23:15:51 GMT, Sergey Bylokhov wrote:
> Probably we should think about care of the big font in the aqua L&F and
> decrease the size we know it is too big?
@mrserb since point size are estimates will this pose a problem while
decreasing the size of the text?
"to decrease the
list
>
> 
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the last revision:
formatted test instructions
-
Changes
On Fri, 22 Apr 2022 06:44:36 GMT, Prasanta Sadhukhan
wrote:
>> @prsadhuk Thanks for catching it. I'll make the required changes.
>
> SInce you are hardcoding PassFailFrame column to 35, it seems some word break
> is not perfect in the above instructions.
> Probably, you can put \n break at appr
list
>
> 
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the last revision:
removed triple quotes
-
Changes:
- a
On Thu, 21 Apr 2022 16:28:53 GMT, Prasanta Sadhukhan
wrote:
>> @prsadhuk With the new changes a public method is added to AquaImageFactory,
>> does this require a CSR?
>
> If you are talking about getCellHighlightColorUIResource() then no. We don't
> have specs for this class.
> I have added s
On Thu, 21 Apr 2022 16:18:46 GMT, Prasanta Sadhukhan
wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changed test case to use PassFailJFrame instead of Applet
>
> test/jdk/j
On Mon, 11 Apr 2022 07:06:59 GMT, Prasanta Sadhukhan
wrote:
>> @prsadhuk Update PR with the recommended changes. The "controlAccentColor"
>> changes works as expected in Mac 12.3 as well.
>> One thing that I wanted to clarify with the fix is - the focus ring color
>> ("Focus.ring") is used at
On Wed, 20 Apr 2022 19:30:49 GMT, Phil Race wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> test summary updated
>
> test/jdk/javax/swing/JTabbedPane/4209065/bug
list
>
> 
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the last revision:
changed test case to use PassFailJFrame instead of Applet
On Wed, 20 Apr 2022 21:25:26 GMT, Harshitha Onkar wrote:
>> The exisiting manual test case tests different html styles of JTabbedPane
>> tab title. The tab with "big" as title is seen to be clipped on Aqua LAF for
>> larger font-size. In other LAFs it is observed
list
>
> 
Harshitha Onkar has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by t
On Wed, 20 Apr 2022 19:30:49 GMT, Phil Race wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> test summary updated
>
> test/jdk/javax/swing/JTabbedPane/4209065/bug
On Wed, 20 Apr 2022 16:38:21 GMT, Prasanta Sadhukhan
wrote:
> looks ok. You should consider removing "The tab title may
>
> * not always fit within the tab." from the summary as it should be what
> the test is supposed to test. Intricate details are already put in the
> instructions.
>
list
>
> 
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the last revision:
test summary updated
-
Changes:
- a
list
>
> 
Harshitha Onkar has updated the pull request incrementally with one additional
commit since the last revision:
changed font-size to 3
-
Changes:
- a
On Wed, 20 Apr 2022 08:36:37 GMT, Prasanta Sadhukhan
wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changed font-size to 3
>
> test/jdk/javax/swing/JTabbedPane/4209065/bug
The exisiting manual test case tests different html styles of JTabbedPane tab
title. The tab with "big" as title is seen to be clipped on Aqua LAF for larger
font-size. In other LAFs it is observed that bigger font-size can be
accommodated without clipping.
The following approaches were evaluat
On Mon, 11 Apr 2022 07:06:59 GMT, Prasanta Sadhukhan
wrote:
>> @prsadhuk Update PR with the recommended changes. The "controlAccentColor"
>> changes works as expected in Mac 12.3 as well.
>> One thing that I wanted to clarify with the fix is - the focus ring color
>> ("Focus.ring") is used at
. Since the background for Swing tables can be set by users and also
> overridden by subclassing `DefaultTableCellRenderer`, and to adhere to
> current implementation of Swing, the white cell background changes are not
> incorporated. Only the Focus Ring/ Cell Highlighter is made more
. Since the background for Swing tables can be set by users and also
> overridden by subclassing `DefaultTableCellRenderer`, and to adhere to
> current implementation of Swing, the white cell background changes are not
> incorporated. Only the Focus Ring/ Cell Highlighter is made more
1 - 100 of 152 matches
Mail list logo
