Re: RFR: 8287824: The MTPerLineTransformValidation tests has a typo in the @run tag

On Sat, 4 Jun 2022 07:59:59 GMT, Sergey Bylokhov wrote: > The typo in the `@run` tag is fixed. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/9030

Re: RFR: 8284213: Replace usages of 'a the' in xml

On Wed, 18 May 2022 13:58:22 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > I tried to avoid changing external libraries, there are quite a few such > typos. > Let me know if I should revert any files. Marked

Re: RFR: JDK-8286348: incorrect use of `@serial`

On Sat, 7 May 2022 01:04:03 GMT, Jonathan Gibbons wrote: > Please review a fix to remove incorrect use of the `@serial` tag from the doc > comments for methods such as `readObject` and `readResolve`. The tag has no > effect in this position other than to trigger warnings from the standard > do

Re: RFR: 8283698: Refactor Locale constructors used in src/test

On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote: > This is a follow-on task after deprecating the Locale constructors > (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are > simple replacements to Locale constructors with `Locale.of()` or Locale > constants, such as `

Re: RFR: 8283608: Refactor 2d, beans classes javadoc to use @throws instead of @exception

On Thu, 24 Mar 2022 06:43:42 GMT, Prasanta Sadhukhan wrote: > Prevailing JDK coding practices use "@throws" rather than "@exception". > Need to refactor remaining 2d, beans,sound classes to use @throws Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/p

Re: RFR: 8283426: Fix 'exeption' typo

On Sun, 20 Mar 2022 13:30:01 GMT, Andrey Turbanov wrote: > Fix repeated type `exeption` Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7879

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo Nice tidy of the code. Is there anything that can be done to prevent re-introduction of this trivial problem? Perhaps a new S

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7189

Re: RFR: 8279796: Fix typo: Constucts -> Constructs

On Wed, 19 Jan 2022 22:18:32 GMT, Weijun Wang wrote: > Two edits. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7147

Re: RFR: 8274396: Suppress more warnings on non-serializable non-transient intance fields in client libs [v2]

On Mon, 27 Sep 2021 22:48:24 GMT, Joe Darcy wrote: >> Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial >> checking are out for review (#5709) and various client libraries would need >> some changes to pass under the expanded checks. >> >> The changes are to suppress wa

Re: RFR: 8273102: Delete deprecated for removal the empty finalize() in java.desktop module

On Sun, 29 Aug 2021 01:09:36 GMT, Sergey Bylokhov wrote: > The "java.desktop" module has a few implementations of the finalize() which > do nothing, deprecated since jdk9, and are marked "forRemoval = true" since > jdk16. > > This is a request to delete such empty methods. > > CSR: https://