Re: RFR: 8286822: Write a test to check the DND functionality between two InternalFrames

2022-05-19 Thread Jayathirth D V
On Thu, 19 May 2022 06:26:24 GMT, Manukumar V S wrote: > > I dont see an internal PR to remove the applet based closed test. Also why > > https://bugs.openjdk.java.net/browse/JDK-8286822 is created as enhancement ? > > If this test is failing intermittently how many times we have seen this > >

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton

2022-05-19 Thread Jayathirth D V
On Mon, 16 May 2022 06:45:04 GMT, Tejesh R wrote: > Added test for checking setMargin() of JRadioButton. Marked as reviewed by jdv (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8721

Re: RFR: 8286822: Write a test to check the DND functionality between two InternalFrames

2022-05-18 Thread Jayathirth D V
On Tue, 17 May 2022 15:52:03 GMT, Manukumar V S wrote: > This test verifies that dragging from one InternalFrame and a drop target in > another InternalFrame functions properly. > This fix moves an unstable closed applet based test to open regression based > java test, but updated to be more co

Re: RFR: 8261650: Add a comment with details for MTLVC_MAX_INDEX

2022-05-09 Thread Jayathirth D V
On Mon, 9 May 2022 07:02:51 GMT, Ajit Ghaisas wrote: > This is a trivial fix which adds more details about the constant > MTLVC_MAX_INDEX. > This had come up during the review of > [JDK-8261632](https://bugs.openjdk.java.net/browse/JDK-8261632). Marked as reviewed by jdv (Reviewer). -

Re: RFR: 8285686: Upgrade to FreeType 2.12.0

2022-04-28 Thread Jayathirth D V
On Thu, 28 Apr 2022 19:41:46 GMT, Phil Race wrote: > This upgrades the JDK from using freetype 2.10.4 to 2.12.0 > Automated tests pass, manual testing looks fine. > --with-freetype=bundled was used to make sure it is OK on Linux builds. Marked as reviewed by jdv (Reviewer). - PR: h

Re: RFR: 8208565: [TEST_BUG] javax\swing\PopupFactory\6276087\NonOpaquePopupMenuTest.java throws NPE

2022-04-26 Thread Jayathirth D V
On Mon, 18 Apr 2022 07:11:45 GMT, Prasanta Sadhukhan wrote: > Test was failing in the past owing to NPE while accessing JMenu probably > owing to fact the test did not wait for UI to be visible before starting the > test, so added a delay after the frame is made visible. Also, added disposal

Re: RFR: 8208565: [TEST_BUG] javax\swing\PopupFactory\6276087\NonOpaquePopupMenuTest.java throws NPE

2022-04-26 Thread Jayathirth D V
On Mon, 18 Apr 2022 07:11:45 GMT, Prasanta Sadhukhan wrote: > Test was failing in the past owing to NPE while accessing JMenu probably > owing to fact the test did not wait for UI to be visible before starting the > test, so added a delay after the frame is made visible. Also, added disposal

Re: RFR: 8198622: java/awt/Focus/TypeAhead/TestFocusFreeze.java fails on mac [v2]

2022-04-25 Thread Jayathirth D V
On Wed, 20 Apr 2022 18:05:04 GMT, Alisen Chung wrote: >> test passes, so removing from problem list > > Alisen Chung has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains two commits: > > - Merge master > - remove test from ProblemList

Re: RFR: 8284189: Replace usages of 'a the' in java.desktop [v2]

2022-04-18 Thread Jayathirth D V
On Mon, 18 Apr 2022 15:13:34 GMT, Alexey Ivanov wrote: >> Replaces usages of articles that follow each other in all combinations: >> a/the, an?/an?, the/the… >> >> I fixed a couple of other spelling mistakes. >> >> I also expanded wildcard imports. > > Alexey Ivanov has updated the pull reques

Re: RFR: 8284189: Replace usages of 'a the' in java.desktop

2022-04-18 Thread Jayathirth D V
On Mon, 18 Apr 2022 13:04:17 GMT, Alexey Ivanov wrote: > > This PR has a lot of other changes than just correcting spelling mistakes > > and a/an combinations. > > Expanding wildcard imports is not _a lot of other changes_. The build is > successful, expanding imports doesn't hinder reviewing

Re: RFR: 8284189: Replace usages of 'a the' in java.desktop

2022-04-18 Thread Jayathirth D V
On Sat, 16 Apr 2022 17:45:16 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > I fixed a couple of other spelling mistakes. > > I also expanded wildcard imports. test/jdk/javax/accessibility/manual/ComboBoxDemo.h

Re: RFR: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS

2022-04-18 Thread Jayathirth D V
On Mon, 18 Apr 2022 04:14:29 GMT, Prasanta Sadhukhan wrote: >> JDK-4517214 was fixed for Metal L&F where JComboBox having TitledBorder used >> to have double height compared to normal JComboBox. >> The issue is still observed for macos for Aqua L&F where still double height >> is seen. >> Fix

Re: RFR: 8198622: java/awt/Focus/TypeAhead/TestFocusFreeze.java fails on mac

2022-04-18 Thread Jayathirth D V
On Thu, 14 Apr 2022 21:12:07 GMT, Alisen Chung wrote: > test passes, so removing from problem list We should add https://bugs.openjdk.java.net/browse/JDK-6447537 also in the PR and decouple test/java/awt/KeyboardFocusmanager/TypeAhead/EnqueueWithDialogTest failure into new bug. https://bugs.op

Re: RFR: 8266246: Swing test PressedIconTest.java sometimes fails on macOS 11 ARM

2022-04-18 Thread Jayathirth D V
On Fri, 15 Apr 2022 09:57:53 GMT, Prasanta Sadhukhan wrote: > javax/swing/JButton/8151303/PressedIconTest.java was failing few times in > macos M1 system owing t color profile issue. > > java.lang.RuntimeException: Colors are different! > at PressedIconTest.main(PressedIconTest.java:88) > >

Re: RFR: 8266246: Swing test PressedIconTest.java sometimes fails on macOS 11 ARM

2022-04-18 Thread Jayathirth D V
On Mon, 18 Apr 2022 04:12:56 GMT, Prasanta Sadhukhan wrote: >> javax/swing/JButton/8151303/PressedIconTest.java was failing few times in >> macos M1 system owing t color profile issue. >> >> java.lang.RuntimeException: Colors are different! >> at PressedIconTest.main(PressedIconTest.java:88)

Re: RFR: 8284189: Replace usages of 'a the' in java.desktop

2022-04-17 Thread Jayathirth D V
On Sat, 16 Apr 2022 17:45:16 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > I fixed a couple of other spelling mistakes. This PR has a lot of other changes than just correcting spelling mistakes and a/an combi

Re: RFR: 8284189: Replace usages of 'a the' in java.desktop

2022-04-17 Thread Jayathirth D V
On Sat, 16 Apr 2022 17:45:16 GMT, Alexey Ivanov wrote: > Replaces usages of articles that follow each other in all combinations: > a/the, an?/an?, the/the… > > I fixed a couple of other spelling mistakes. src/java.desktop/share/classes/java/awt/Graphics.java line 29: > 27: import java.io.*; >

Re: RFR: 8284378: Make Metal the default Java 2D rendering pipeline for macOS

2022-04-07 Thread Jayathirth D V
On Wed, 6 Apr 2022 09:48:13 GMT, Ajit Ghaisas wrote: > This PR makes Metal rendering pipeline as the default Java 2D rendering > pipeline for macOS. > > Please refer "JBS Description" for more details. Marked as reviewed by jdv (Reviewer). - PR: https://git.openjdk.java.net/jdk/p

Re: RFR: 7017094: ParsedSynthStyle: parameter name "direction" should be changed to "tabIndex"

2022-02-22 Thread Jayathirth D V
On Mon, 21 Feb 2022 04:59:34 GMT, Prasanta Sadhukhan wrote: > [SynthPainter](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthPainter.java#L1759) > and > [SynthPainterImpl](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/cla

Re: RFR: 8282150: Drop redundant elements from tables in java.desktop HTML files [v3]

2022-02-22 Thread Jayathirth D V
On Tue, 22 Feb 2022 15:03:28 GMT, Alexey Ivanov wrote: >> Drops the redundant `` elements from tables and lists in java.desktop >> HTML files. > > Alexey Ivanov has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated change

Re: CFV: New Client Libraries Group Member : Dmitry Markov (dmarkov)

2022-02-21 Thread Jayathirth D V
Vote : Yes Thanks, Jay > On 10-Feb-2022, at 1:36 AM, Philip Race wrote: > > I hereby nominate Dmitry Markov (dmarkov) to Membership in the Client > Libraries Group. > > Dmitry has worked in the client libraries sustaining team at Oracle since > 2013 and in that time > has contributed 61 clie

Re: CFV: New Client Libraries Group Member : Alexey Ivanov (aivanov)

2022-02-21 Thread Jayathirth D V
Vote : Yes Thanks, Jay > On 10-Feb-2022, at 1:36 AM, Philip Race wrote: > > I hereby nominate Alexey Ivanov (aivanov) to Membership in the Client > Libraries Group. > > Alexey has worked in the client libraries sustaining team at Oracle since > 2014 and in that time > has contributed 60 clie

Re: RFR: 8281738: Create a regression test for checking the 'Space' key activation of focused Button [v2]

2022-02-17 Thread Jayathirth D V
On Thu, 17 Feb 2022 02:12:01 GMT, Manukumar V S wrote: >> test/jdk/javax/swing/JButton/SpaceKeyActivatesButton.java line 39: >> >>> 37: >>> 38: /* >>> 39: * @test >> >> @bug ? >> >> And I presume you've verified this using mach 5? >> >> Also do we actually specify that Space generates an Ac

Re: RFR: 8037573: Typo in DefaultTreeModel docs: askAllowsChildren instead of asksAllowsChildren

2022-02-17 Thread Jayathirth D V
On Wed, 16 Feb 2022 07:15:20 GMT, Prasanta Sadhukhan wrote: > [DefaultTreeModel.html#isLeaf](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/tree/DefaultTreeModel.html#isLeaf(java.lang.Object)) > to an "askAllowsChildren" attribute that doesn't exist. The real attrib

Re: RFR: 8012675: Javadoc for javax.swing.text.html.parser.Parser.handleComment() needs to be updated

2022-02-17 Thread Jayathirth D V
On Fri, 11 Feb 2022 19:20:16 GMT, DamonGuy wrote: > Updated Parser class doc by appending to the doc regarding lack of support > for HTML script tags. Adding this information to the "parse" function did not > seem as consistent for formatting as adding it to the Parser class doc. I just traced

Re: RFR: 8241192: [macosx] Wrong letter typed after ´ symbol when using Finnish layout

2022-02-08 Thread Jayathirth D V
On Fri, 28 Jan 2022 09:38:35 GMT, Prasanta Sadhukhan wrote: > If we press " ´ " (on U.S. keyboard layout it is the [+] button just before > the [delete] button), and then press "s" , 2 "´" characters are entered in a > text field instead of "´s" with "Finish" keyboard layout. > This is because

Re: RFR: 8278937: JCK test for java_awt/geom/Line2D.Float fails after 8277868

2021-12-16 Thread Jayathirth D V
On Fri, 17 Dec 2021 02:40:04 GMT, Phil Race wrote: > This reverts the uses of Float.compare() and Double.compare() made by the fix > for 8277868 > since it appears clear that for better or worse they are not 100% compatible > with the previous code. > These uses are all in the desktop module >

Re: RFR: 8278580: ProblemList javax/swing/JTree/4908142/bug4908142.java on macosx-x64

2021-12-11 Thread Jayathirth D V
On Sat, 11 Dec 2021 14:56:23 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList javax/swing/JTree/4908142/bug4908142.java on > macosx-x64. Marked as reviewed by jdv (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6805

Re: RFR: 8272392 Lanai: SwingSet2. Black background on expanding tree node [v2]

2021-12-07 Thread Jayathirth D V
On Fri, 3 Dec 2021 15:39:12 GMT, Alexey Ushakov wrote: > > I used test case present in > > https://bugs.openjdk.java.net/browse/JDK-8267963 to check how it behaves > > with this PR and noticed that it is causes regresssion related to how ruler > > text looks and also if we move Ruler between m

Re: RFR: 8272392 Lanai: SwingSet2. Black background on expanding tree node [v2]

2021-12-01 Thread Jayathirth D V
On Fri, 26 Nov 2021 09:02:37 GMT, Alexey Ushakov wrote: >> Removed creation of the separate encoder depending on destination properties >> as we don't use this info to customize the encoder properties > > Alexey Ushakov has updated the pull request incrementally with one additional > commit sin

Integrated: 8266435: WBMPImageReader.read() should not truncate the input stream

2021-12-01 Thread Jayathirth D V
On Tue, 23 Nov 2021 11:05:27 GMT, Jayathirth D V wrote: > If we use a custom stream and specify limit on stream.read() length, > WBMPImageReader.read() doesnt verify whether we are decoded complete data or > not. We can check the length of data decoded and rerun the stream.read()

Re: RFR: 8278047: Few javax/imageio test regressed after JDK-8262297 fix

2021-12-01 Thread Jayathirth D V
On Wed, 1 Dec 2021 10:19:24 GMT, Thomas Schatzl wrote: > Lgtm, is a clean backout. It would be nice to link the old changes directly > for easier comparison in the PR text next time. Thanks Thomas. Sure will do. - PR: https://git.openjdk.java.net/jdk/pull/6631

Integrated: 8278047: Few javax/imageio test regressed after JDK-8262297 fix

2021-12-01 Thread Jayathirth D V
On Wed, 1 Dec 2021 10:07:30 GMT, Jayathirth D V wrote: > Looks like we have 8 test cases where we are trying to write 15bpp BMP images > and after JDK-8262297 all of them are failing. > We need to update these test cases to not encode 15bpp BMP images or > supporting 15bpp BMP ima

RFR: 8278047: Few javax/imageio test regressed after JDK-8262297 fix

2021-12-01 Thread Jayathirth D V
Looks like we have 8 test cases where we are trying to write 15bpp BMP images and after JDK-8262297 all of them are failing. We need to update these test cases to not encode 15bpp BMP images or supporting 15bpp BMP images is valid use case. This needs more investigation. I am backing out changes

Re: RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException [v5]

2021-12-01 Thread Jayathirth D V
On Wed, 24 Nov 2021 11:09:42 GMT, Masanori Yano wrote: >> Could you please review the 8262297 bug fixes? >> >> In this case, ImageIO.write() should throw java.io.IOException rather than >> java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and >> wrapped in IIOException i

Re: RFR: 8272392 Lanai: SwingSet2. Black background on expanding tree node [v2]

2021-11-30 Thread Jayathirth D V
On Fri, 26 Nov 2021 09:02:37 GMT, Alexey Ushakov wrote: >> Removed creation of the separate encoder depending on destination properties >> as we don't use this info to customize the encoder properties > > Alexey Ushakov has updated the pull request incrementally with one additional > commit sin

Re: RFR: 8272392 Lanai: SwingSet2. Black background on expanding tree node [v2]

2021-11-30 Thread Jayathirth D V
On Fri, 26 Nov 2021 09:02:37 GMT, Alexey Ushakov wrote: >> Removed creation of the separate encoder depending on destination properties >> as we don't use this info to customize the encoder properties > > Alexey Ushakov has updated the pull request incrementally with one additional > commit sin

Re: RFR: 8272392 Lanai: SwingSet2. Black background on expanding tree node [v2]

2021-11-30 Thread Jayathirth D V
On Fri, 26 Nov 2021 09:02:37 GMT, Alexey Ushakov wrote: >> Removed creation of the separate encoder depending on destination properties >> as we don't use this info to customize the encoder properties > > Alexey Ushakov has updated the pull request incrementally with one additional > commit sin

Re: RFR: 8266435: WBMPImageReader.read() should not truncate the input stream

2021-11-30 Thread Jayathirth D V
On Thu, 25 Nov 2021 03:56:32 GMT, Sergey Bylokhov wrote: >> If we use a custom stream and specify limit on stream.read() length, >> WBMPImageReader.read() doesnt verify whether we are decoded complete data or >> not. We can check the length of data decoded and rerun the stream.read() or >> use

Re: RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException [v5]

2021-11-24 Thread Jayathirth D V
On Wed, 24 Nov 2021 11:09:42 GMT, Masanori Yano wrote: >> Could you please review the 8262297 bug fixes? >> >> In this case, ImageIO.write() should throw java.io.IOException rather than >> java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and >> wrapped in IIOException i

Re: RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException [v4]

2021-11-23 Thread Jayathirth D V
On Tue, 23 Nov 2021 11:14:09 GMT, Jayathirth D V wrote: >> Masanori Yano has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8262297: ImageIO.write() method will throw IndexOutOfBoundsException >> - 826229

Re: RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException [v4]

2021-11-23 Thread Jayathirth D V
On Fri, 19 Nov 2021 09:04:22 GMT, Masanori Yano wrote: >> Could you please review the 8262297 bug fixes? >> >> In this case, ImageIO.write() should throw java.io.IOException rather than >> java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and >> wrapped in IIOException i

Re: RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException [v4]

2021-11-23 Thread Jayathirth D V
On Fri, 19 Nov 2021 09:04:22 GMT, Masanori Yano wrote: >> Could you please review the 8262297 bug fixes? >> >> In this case, ImageIO.write() should throw java.io.IOException rather than >> java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and >> wrapped in IIOException i

RFR: 8266435: WBMPImageReader.read() should not truncate the input stream

2021-11-23 Thread Jayathirth D V
If we use a custom stream and specify limit on stream.read() length, WBMPImageReader.read() doesnt verify whether we are decoded complete data or not. We can check the length of data decoded and rerun the stream.read() or use readFully(). In case of other decoders like BMP we are using readFully

Re: RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException [v4]

2021-11-21 Thread Jayathirth D V
On Fri, 19 Nov 2021 09:04:22 GMT, Masanori Yano wrote: >> Could you please review the 8262297 bug fixes? >> >> In this case, ImageIO.write() should throw java.io.IOException rather than >> java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and >> wrapped in IIOException i

Re: RFR: 8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor

2021-11-16 Thread Jayathirth D V
On Wed, 10 Nov 2021 18:45:12 GMT, Sergey Bylokhov wrote: > The bug occurs more often if initially the window is moved partly outside of > the first screen(let's name this part as the invisible part), and then slowly > moved to the second screen where that invisible part became visible on the >

Re: RFR: 8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor

2021-11-16 Thread Jayathirth D V
On Tue, 16 Nov 2021 07:53:46 GMT, Sergey Bylokhov wrote: > > Please correct my understanding. Does this refined repaint logic apply even > > for overlapping Windows? What happens when 2 windows are overlapping and we > > move top window slowly? Any performance/power impact? > > Initially, this

Integrated: 8276905: Use appropriate macosx_version_minimum value while compiling metal shaders

2021-11-16 Thread Jayathirth D V
On Thu, 11 Nov 2021 05:52:18 GMT, Jayathirth D V wrote: > When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in > macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set > any deployment target when when we use xcrun to create .air file and t

Re: RFR: 8276905: Use appropriate macosx_version_minimum value while compiling metal shaders [v4]

2021-11-15 Thread Jayathirth D V
On Mon, 15 Nov 2021 14:33:21 GMT, Magnus Ihse Bursie wrote: > Looks good to me also. Please let Phil have a say as well before integrating. Thanks Magnus for the review. Yes i have already Re-Requested review from Phil on latest patch. Also i am waiting on Vitaly(JBS submitter) to verify the la

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v2]

2021-11-15 Thread Jayathirth D V
On Mon, 15 Nov 2021 13:28:30 GMT, Kevin Rushforth wrote: > The JDK itself has a minimum version of 11.0 on macOS aarch64 systems > (because apple only supports it on macOS >= 11), so it probably doesn't > matter much. You might wish to file a low-priority follow-up issue to change > the runtim

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v3]

2021-11-15 Thread Jayathirth D V
On Mon, 15 Nov 2021 13:46:29 GMT, Kevin Rushforth wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use 10.14 macOS version > > make/modules/java.desktop/lib/Awt2dLibraries.gmk line

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v4]

2021-11-15 Thread Jayathirth D V
ther we should keep 10.12.00 or 10.13/14 is open to discussion for metal > pipeline. > > SwingSet2, J2DDemo & JCK/jtreg runs in CI are green. Also Vitaly(Submitter) > has confirmed that patch resolves the issue. Jayathirth D V has updated the pull request incrementally wit

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v3]

2021-11-15 Thread Jayathirth D V
ther we should keep 10.12.00 or 10.13/14 is open to discussion for metal > pipeline. > > SwingSet2, J2DDemo & JCK/jtreg runs in CI are green. Also Vitaly(Submitter) > has confirmed that patch resolves the issue. Jayathirth D V has updated the pull request incrementally with one

Re: RFR: 8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor

2021-11-15 Thread Jayathirth D V
On Wed, 10 Nov 2021 18:45:12 GMT, Sergey Bylokhov wrote: > The bug occurs more often if initially the window is moved partly outside of > the first screen(let's name this part as the invisible part), and then slowly > moved to the second screen where that invisible part became visible on the >

Re: RFR: 8233568: [TESTBUG] AWT event tests failing on MacOS

2021-11-15 Thread Jayathirth D V
On Thu, 21 Oct 2021 15:47:36 GMT, Alisen Chung wrote: > Tests passing on macos, so removing from ProblemList Are these tests verified to pass on CI or local machine? If CI please add the link in JBS. Also it looks all these tests are related to java/awt/event. It is possible that these tests w

Re: RFR: 8262297: ImageIO.write() method will throw IndexOutOfBoundsException [v3]

2021-11-15 Thread Jayathirth D V
On Fri, 12 Nov 2021 09:12:07 GMT, Masanori Yano wrote: >> Could you please review the 8262297 bug fixes? >> >> In this case, ImageIO.write() should throw java.io.IOException rather than >> java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and >> wrapped in IIOException i

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v2]

2021-11-14 Thread Jayathirth D V
On Mon, 15 Nov 2021 05:46:30 GMT, Jayathirth D V wrote: > " Also note that on aarch64 the global value is 11.00.00, and in that case we > should use the global value." > > I have no idea what happens if you specify 10.14 to the metal compiler on > aarch64 Somethi

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v2]

2021-11-14 Thread Jayathirth D V
On Fri, 12 Nov 2021 20:27:32 GMT, Phil Race wrote: > " Also note that on aarch64 the global value is 11.00.00, and in that case we > should use the global value." > > I have no idea what happens if you specify 10.14 to the metal compiler on > aarch64 Something else to check although probably t

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v2]

2021-11-14 Thread Jayathirth D V
On Fri, 12 Nov 2021 03:59:52 GMT, Phil Race wrote: >> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 850: >> >>> 848: COMMAND := $(METAL) -c -std=osx-metal2.0 \ >>> 849: -mmacosx-version-min=$(MACOSX_VERSION_MIN) \ >>> 850: -o $(SHADERS_AIR) $(SHADERS_SRC), \ >>

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS

2021-11-11 Thread Jayathirth D V
On Thu, 11 Nov 2021 13:53:05 GMT, Magnus Ihse Bursie wrote: > Also, if you did not create this patch yourself, please make sure to use > `/contributor` to give proper credits. Or maybe you mean that Vitaly > submitted the bug report, not the patch? By Submitter i meant submitter of bug in JBS.

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v2]

2021-11-11 Thread Jayathirth D V
On Thu, 11 Nov 2021 13:52:13 GMT, Magnus Ihse Bursie wrote: > We should not hard-code version numbers like that. > > Fortunately for you, there already exists a variable $(MACOSX_VERSION_MIN) > that you can use. Thanks for the review i have updated code to use the Macro. - PR: ht

Re: RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS [v2]

2021-11-11 Thread Jayathirth D V
ther we should keep 10.12.00 or 10.13/14 is open to discussion for metal > pipeline. > > SwingSet2, J2DDemo & JCK/jtreg runs in CI are green. Also Vitaly(Submitter) > has confirmed that patch resolves the issue. Jayathirth D V has updated the pull request incrementally with one

RFR: 8276905: Function frag_col has a deployment target which is incompatible with this OS

2021-11-10 Thread Jayathirth D V
When JDK is built on BigSur with Xcode12.5 and used to run jtreg tests in macOS10.15 with Xcode <=12.4 we are getting compilation error. We dont set any deployment target when when we use xcrun to create .air file and this issue looks similar to https://developer.apple.com/forums/thread/105719.

Integrated: 8275689: [TESTBUG] Use color tolerance only for XRender in BlitRotateClippedArea test

2021-10-27 Thread Jayathirth D V
On Tue, 26 Oct 2021 16:24:35 GMT, Jayathirth D V wrote: > This is follow up change after : > https://bugs.openjdk.java.net/browse/JDK-8255724 > > Now color tolerance is only added for Linux(XRender is default pipeline in > Linux and Solaris is not supported anymore)

Integrated: 8213120: java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java fails on mac10.13

2021-10-27 Thread Jayathirth D V
On Tue, 26 Oct 2021 09:41:50 GMT, Jayathirth D V wrote: > Looks like this test was failing in one local system in JDK12 and it was > problemlisted. > I ran this test multiple times in our CI systems it doesnt fail. > Made modifications to move test window to the middle of the scre

Re: RFR: 8213120: java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java fails on mac10.13 [v2]

2021-10-27 Thread Jayathirth D V
CI systems with modifications and test run > is green. Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision: Use BUTTON1_DOWN_MASK - Changes: - all: https://git.openjdk.java.net/jdk/pull/6116/files - new: https://git.op

Re: RFR: 8213120: java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java fails on mac10.13 [v2]

2021-10-27 Thread Jayathirth D V
On Wed, 27 Oct 2021 08:05:01 GMT, Prasanta Sadhukhan wrote: > It will be better to dispose frame in finally block. Also, better to use > BUTTON1_DOWN_MASK instead of deprecated BUTTON1_MASK @prsadhuk we explicitly call dispose() if any of test cases fail. So test should not leave unwanted win

Re: RFR: 8275689: [TESTBUG] Use color tolerance only for XRender in BlitRotateClippedArea test [v2]

2021-10-27 Thread Jayathirth D V
On Tue, 26 Oct 2021 19:13:42 GMT, Sergey Bylokhov wrote: >> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use class name to verify Graphics configuration > > test/jdk/java/awt/image/DrawIm

Re: RFR: 8275689: [TESTBUG] Use color tolerance only for XRender in BlitRotateClippedArea test [v2]

2021-10-27 Thread Jayathirth D V
are running on. CI run on all > platforms is green. Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision: Use class name to verify Graphics configuration - Changes: - all: https://git.openjdk.java.net/jdk/pull/6119

Re: RFR: 8275689: [TESTBUG] Use color tolerance only for XRender in BlitRotateClippedArea test

2021-10-26 Thread Jayathirth D V
On Tue, 26 Oct 2021 16:24:35 GMT, Jayathirth D V wrote: > This is follow up change after : > https://bugs.openjdk.java.net/browse/JDK-8255724 > > Now color tolerance is only added for Linux(XRender is default pipeline in > Linux and Solaris is not supported anymore)

RFR: 8275689: [TESTBUG] Use color tolerance only for XRender in BlitRotateClippedArea test

2021-10-26 Thread Jayathirth D V
This is follow up change after : https://bugs.openjdk.java.net/browse/JDK-8255724 Now color tolerance is only added for Linux(XRender is default pipeline in Linux and Solaris is not supported anymore). So I am using jdk.test.lib.Platform to determine which OS we are running on. CI run on all p

RFR: 8213120: java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java fails on mac10.13

2021-10-26 Thread Jayathirth D V
Looks like this test was failing in one local system in JDK12 and it was problemlisted. I ran this test multiple times in our CI systems it doesnt fail. Made modifications to move test window to the middle of the screen and added autodelay for robot. Tested in our CI systems with modifications an

Re: RFR: 8255724: [XRender] the BlitRotateClippedArea test fails on Linux in the XR pipeline

2021-10-20 Thread Jayathirth D V
On Wed, 20 Oct 2021 07:18:06 GMT, Sergey Bylokhov wrote: >> This test was added under https://bugs.openjdk.java.net/browse/JDK-8255722 >> to verify rotated blit operation. But it started failing XRender pipeline >> because of pixel color mismatch. Looks like we have minor difference in >> pixe

Re: RFR: 8255724: [XRender] the BlitRotateClippedArea test fails on Linux in the XR pipeline

2021-10-19 Thread Jayathirth D V
On Wed, 20 Oct 2021 01:43:22 GMT, Sergey Bylokhov wrote: > Why it does not check for the xrender usage? As far as I remember all other > pipelines work fine. @mrserb Yes i ran this test without fix on all platforms and it does pass in all pipelines except XRender. Since adding tolerance doesnt

Integrated: 8255724: [XRender] the BlitRotateClippedArea test fails on Linux in the XR pipeline

2021-10-19 Thread Jayathirth D V
On Tue, 19 Oct 2021 09:56:07 GMT, Jayathirth D V wrote: > This test was added under https://bugs.openjdk.java.net/browse/JDK-8255722 to > verify rotated blit operation. But it started failing XRender pipeline > because of pixel color mismatch. Looks like we have minor difference

RFR: 8255724: [XRender] the BlitRotateClippedArea test fails on Linux in the XR pipeline

2021-10-19 Thread Jayathirth D V
This test was added under https://bugs.openjdk.java.net/browse/JDK-8255722 to verify rotated blit operation. But it started failing XRender pipeline because of pixel color mismatch. Looks like we have minor difference in pixel color because of arithmetic precision differences in transformations.

Re: RFR: 8192931: Regression test java/awt/font/TextLayout/CombiningPerf.java fails

2021-10-18 Thread Jayathirth D V
On Mon, 18 Oct 2021 23:06:34 GMT, Phil Race wrote: > As described in the bug evaluation, this test was only useful when it had > Lucida Sans as a font in the JDK and > the ICU layout engine. > > I don't think it can be made reliable any more given unknown fonts and the > difference in the lay

Integrated: 8255898: Test java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java fails on Mac OS

2021-10-18 Thread Jayathirth D V
On Mon, 18 Oct 2021 12:58:20 GMT, Jayathirth D V wrote: > Root cause for this test failure in our CI systems was macOS regression in > specific version of Catalina. > This issue is fixed in macOS 10.12 Catalina Beta7 (19A546d) and it is no > longer failing after multiple individu

Re: RFR: 8255898: Test java/awt/FileDialog/FilenameFilterTest/FilenameFilterst.java fails on Mac OS

2021-10-18 Thread Jayathirth D V
On Mon, 18 Oct 2021 12:58:20 GMT, Jayathirth D V wrote: > Root cause for this test failure in our CI systems was macOS regression in > specific version of Catalina. > This issue is fixed in macOS 10.12 Catalina Beta7 (19A546d) and it is no > longer failing after multiple individu

RFR: 8255898: Test java/awt/FileDialog/FilenameFilterTest/FilenameFilterst.java fails on Mac OS

2021-10-18 Thread Jayathirth D V
Root cause for this test failure in our CI systems was macOS regression in specific version of Catalina. This issue is fixed in macOS 10.12 Catalina Beta7 (19A546d) and it is no longer failing after multiple individual test runs as well as multiple FileDialog jtreg test bunch run in our CI syste

Re: RFR: 8272229: BasicSplitPaneDivider:oneTouchExpandableChanged() returns leftButton and rightButton as null with GTKLookAndFeel [v5]

2021-10-08 Thread Jayathirth D V
On Fri, 8 Oct 2021 13:05:34 GMT, Pankaj Bansal wrote: >> The function documentation for oneTouchExpandableChanged states that the >> function does couple of things, but in reality it only does those things if >> the Look and Feel supports the supportsOneTouchButtons. In case the Look and >> F

Re: RFR: 8272756: Remove unnecessary explicit initialization of volatile variables in java.desktop [v3]

2021-10-08 Thread Jayathirth D V
On Sat, 25 Sep 2021 19:30:31 GMT, Сергей Цыпанов wrote: >> This is a continuation of >> >> - https://bugs.openjdk.java.net/browse/JDK-6736490 >> - https://bugs.openjdk.java.net/browse/JDK-8035284 >> - https://bugs.openjdk.java.net/browse/JDK-8145680 >> - https://bugs.openjdk.java.net/browse/JDK

Re: RFR: 8274945: Cleanup unnecessary calls to Throwable.initCause() in java.desktop

2021-10-08 Thread Jayathirth D V
On Thu, 7 Oct 2021 12:39:10 GMT, Andrey Turbanov wrote: > Pass cause exception as constructor parameter is shorter and easier to read. Marked as reviewed by jdv (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5847

Re: RFR: 8272229: BasicSplitPaneDivider:oneTouchExpandableChanged() returns leftButton and rightButton as null with GTKLookAndFeel [v3]

2021-10-05 Thread Jayathirth D V
On Tue, 5 Oct 2021 09:26:00 GMT, Prasanta Sadhukhan wrote: >> Pankaj Bansal has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Changes according to JBS discussion > > src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSplitPaneDivi

Re: RFR: 8274680: Remove unnecessary conversion to String in java.desktop [v2]

2021-10-05 Thread Jayathirth D V
On Mon, 4 Oct 2021 09:05:30 GMT, Andrey Turbanov wrote: >> Cleanup unnecessary String.valueOf calls (and similar) when conversion will >> happen implicitly anyway > > Andrey Turbanov has updated the pull request incrementally with one > additional commit since the last revision: > > 8274680

Re: RFR: 8273102: Delete deprecated for removal the empty finalize() in java.desktop module

2021-10-05 Thread Jayathirth D V
On Sun, 29 Aug 2021 01:09:36 GMT, Sergey Bylokhov wrote: > The "java.desktop" module has a few implementations of the finalize() which > do nothing, deprecated since jdk9, and are marked "forRemoval = true" since > jdk16. > > This is a request to delete such empty methods. > > CSR: https://

Re: CFV: New Client Libraries Group Member : Prasanta Sadhukhan (psadhukhan)

2021-09-30 Thread Jayathirth D V
Vote : Yes Thanks, Jay > On 01-Oct-2021, at 4:33 AM, Philip Race wrote: > > I hereby nominate Prasanta Sadhukhan (psadhukhan) to Membership in the Client > Libraries Group. > > Prasanta has worked in the client team at Oracle since 2015 and in that time > has contributed approximately 460 fi

Re: CFV: New Client Libraries Group Member : Pankaj Bansal (pbansal)

2021-09-30 Thread Jayathirth D V
Vote : Yes Thanks, Jay > On 01-Oct-2021, at 4:33 AM, Philip Race wrote: > > I hereby nominate Pankaj Bansal (pbansal) to Membership in the Client > Libraries Group. > > Pankaj has worked in the client team at Oracle since 2017 and in that time > has contributed approximately 70-80 fixes [1],

Re: RFR: 8274296: Update or Problem List tests which may fail with uiScale=2 on macOS

2021-09-24 Thread Jayathirth D V
On Fri, 24 Sep 2021 16:28:51 GMT, Phil Race wrote: > As described in https://bugs.openjdk.java.net/browse/JDK-8274106 a number of > tests fail due to some inaccuracy in pixels copied from the screen when > scaling down from device space to user space. > The subject of most of these tests is suc

Re: RFR: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12 [v2]

2021-09-22 Thread Jayathirth D V
On Thu, 23 Sep 2021 05:08:26 GMT, Prasanta Sadhukhan wrote: >> The test sometimes fail on macos12 citing "Action has not been received". >> Seems like some key events sometimes are not received reliably. >> Proposed fix is to apply mach5 stability fixes which is to set autodelay to >> 100ms,

Re: RFR: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12

2021-09-22 Thread Jayathirth D V
On Fri, 17 Sep 2021 12:24:40 GMT, Prasanta Sadhukhan wrote: > The test sometimes fail on macos12 citing "Action has not been received". > Seems like some key events sometimes are not received reliably. > Proposed fix is to apply mach5 stability fixes which is to set autodelay to > 100ms, move

Re: RFR: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12

2021-09-22 Thread Jayathirth D V
On Fri, 17 Sep 2021 12:24:40 GMT, Prasanta Sadhukhan wrote: > The test sometimes fail on macos12 citing "Action has not been received". > Seems like some key events sometimes are not received reliably. > Proposed fix is to apply mach5 stability fixes which is to set autodelay to > 100ms, move

Re: RFR: 8268084: [macos] Disabled JMenuItem arrow is not disabled [v7]

2021-09-21 Thread Jayathirth D V
On Mon, 13 Sep 2021 08:41:28 GMT, Prasanta Sadhukhan wrote: >> It is seen in macos disabled JMenuItem arrow is not disabled even though >> JMenuItem itself is disabled. >> In native app, same menuitem arrow is disabled for disabled menuitem. >> >> Issue is when AquaMenuPainter#paintMenuItem()