On Mon, 7 Mar 2022 00:46:12 GMT, Masanori Yano wrote:
> I would like to fix the missing comma in the copyright of the test added in
> JDK-8275715.
> Could you please review the fix?
This pull request has now been integrated.
Changeset: 894ffb09
Author: Masanori Yano
URL:
On Mon, 7 Mar 2022 00:46:12 GMT, Masanori Yano wrote:
> I would like to fix the missing comma in the copyright of the test added in
> JDK-8275715.
> Could you please review the fix?
I was in trouble because it turned out to be "No rule to make target". Please
confirm.
On Thu, 28 Oct 2021 08:27:44 GMT, Masanori Yano wrote:
>> Could you please review the 8275715 bug fixes?
>>
>> I think D3DScreenUpdateManager posts unnecessary PaintEvent during
>> processing PaintEvent. When the validate method is called from
>> createGraphics
I would like to fix the missing comma in the copyright of the test added in
JDK-8275715.
Could you please review the fix?
-
Commit messages:
- 8282713: Invalid copyright notice in new test added by JDK-8275715
Changes: https://git.openjdk.java.net/jdk/pull/7716/files
Webrev: https
On Mon, 7 Mar 2022 00:12:41 GMT, David Holmes wrote:
>> @prrace How long will it take for you to reply to the comment?
>
> @masyano the new test has an invalid copyright notice: missing comma after
> 2021, which is causing a tier 1 build failure in our CI.
@dholmes-ora Thank you for notice. Sho
On Thu, 21 Oct 2021 12:19:43 GMT, Masanori Yano wrote:
> Could you please review the 8275715 bug fixes?
>
> I think D3DScreenUpdateManager posts unnecessary PaintEvent during processing
> PaintEvent. When the validate method is called from createGraphics,
> repaintPeerTarge
On Mon, 14 Feb 2022 20:12:39 GMT, Phil Race wrote:
>> Masanori Yano has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8275715: D3D pipeline processes multiple PaintEvent at initial drawing
>
> Ok. Please conf
On Mon, 14 Feb 2022 20:12:39 GMT, Phil Race wrote:
>> Masanori Yano has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8275715: D3D pipeline processes multiple PaintEvent at initial drawing
>
> Ok. Please conf
On Thu, 28 Oct 2021 08:27:44 GMT, Masanori Yano wrote:
>> Could you please review the 8275715 bug fixes?
>>
>> I think D3DScreenUpdateManager posts unnecessary PaintEvent during
>> processing PaintEvent. When the validate method is called from
>> createGraphics
On Sun, 6 Feb 2022 21:46:37 GMT, Phil Race wrote:
>> Masanori Yano has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8275715: D3D pipeline processes multiple PaintEvent at initial drawing
>
> The problem
On Thu, 28 Oct 2021 08:27:44 GMT, Masanori Yano wrote:
>> Could you please review the 8275715 bug fixes?
>>
>> I think D3DScreenUpdateManager posts unnecessary PaintEvent during
>> processing PaintEvent. When the validate method is called from
>> createGraphics
On Thu, 28 Oct 2021 08:27:44 GMT, Masanori Yano wrote:
>> Could you please review the 8275715 bug fixes?
>>
>> I think D3DScreenUpdateManager posts unnecessary PaintEvent during
>> processing PaintEvent. When the validate method is called from
>> createGraphics
On Thu, 28 Oct 2021 08:27:44 GMT, Masanori Yano wrote:
>> Could you please review the 8275715 bug fixes?
>>
>> I think D3DScreenUpdateManager posts unnecessary PaintEvent during
>> processing PaintEvent. When the validate method is called from
>> createGraphics
On Mon, 13 Sep 2021 11:32:37 GMT, Masanori Yano wrote:
> Could you please review the 7001973 fixes?
>
> On Windows, CopyAreaOOB.java fails with a blank window. The cause of this
> problem is that paint() works one time only. Painting area is not guaranteed
> when showing a
On Fri, 10 Dec 2021 08:59:55 GMT, Masanori Yano wrote:
> I would like to fix the bug reported in JDK-8277463.
>
> As reporter's investigation, ShellFolder.getNormalizedFile() returns
> incorrect value for non-canonical Windows UNC path. getNormalizedFile() is
> used fo
On Thu, 28 Oct 2021 08:27:44 GMT, Masanori Yano wrote:
>> Could you please review the 8275715 bug fixes?
>>
>> I think D3DScreenUpdateManager posts unnecessary PaintEvent during
>> processing PaintEvent. When the validate method is called from
>> createGraphics
On Tue, 26 Oct 2021 04:52:37 GMT, Sergey Bylokhov wrote:
>> Masanori Yano has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Tue, 21 Dec 2021 05:28:17 GMT, Sergey Bylokhov wrote:
>> I fixed the test as it was pointed out to me.
>
> Now it cannot be compiled due to "unreported exception
> java.lang.ClassNotFoundException; must be caught or declared to be thrown"
> from the setLookAndFeel(); Note that the new versio
On Thu, 28 Oct 2021 08:27:44 GMT, Masanori Yano wrote:
>> Could you please review the 8275715 bug fixes?
>>
>> I think D3DScreenUpdateManager posts unnecessary PaintEvent during
>> processing PaintEvent. When the validate method is called from
>> createGraphics
On Tue, 21 Dec 2021 05:28:17 GMT, Sergey Bylokhov wrote:
>> I fixed the test as it was pointed out to me.
>
> Now it cannot be compiled due to "unreported exception
> java.lang.ClassNotFoundException; must be caught or declared to be thrown"
> from the setLookAndFeel(); Note that the new versio
dle symbolic
> link. And, getCanonicalFile() returns correct path for a directory link in
> Windows which is made with `mklink` command. So getNormalizedFile() should
> perform to return getCanonicalFile() like WindowsFileChooserUI.addItem() at
> Windows environment.
Masanori Y
On Thu, 18 Nov 2021 00:02:30 GMT, Sergey Bylokhov wrote:
>> @mrserb Can I hope this fix will be integrated after JDK-8270874 is fixed?
>
> Yes.
@mrserb @prrace Could you please review the above comments?
-
PR: https://git.openjdk.java.net/jdk/pull/6064
On Tue, 26 Oct 2021 04:52:37 GMT, Sergey Bylokhov wrote:
>> Masanori Yano has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Wed, 15 Dec 2021 22:58:39 GMT, Sergey Bylokhov wrote:
>> I would like to fix the bug reported in JDK-8277463.
>>
>> As reporter's investigation, ShellFolder.getNormalizedFile() returns
>> incorrect value for non-canonical Windows UNC path. getNormalizedFile() is
>> used for symbolic link pa
On Wed, 15 Dec 2021 03:50:11 GMT, Sergey Bylokhov wrote:
>> Masanori Yano has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8277463: JFileChooser with Metal L&F doesn't show non-canonical UNC path
>>
dle symbolic
> link. And, getCanonicalFile() returns correct path for a directory link in
> Windows which is made with `mklink` command. So getNormalizedFile() should
> perform to return getCanonicalFile() like WindowsFileChooserUI.addItem() at
> Windows environment.
Masanori Y
On Thu, 18 Nov 2021 00:02:30 GMT, Sergey Bylokhov wrote:
>> @mrserb Can I hope this fix will be integrated after JDK-8270874 is fixed?
>
> Yes.
@mrserb @prrace JDK 18 has been forked, so please resume the review of this fix.
-
PR: https://git.openjdk.java.net/jdk/pull/6064
On Tue, 26 Oct 2021 04:52:37 GMT, Sergey Bylokhov wrote:
>> Masanori Yano has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Fri, 10 Dec 2021 10:05:04 GMT, Prasanta Sadhukhan
wrote:
>> I would like to fix the bug reported in JDK-8277463.
>>
>> As reporter's investigation, ShellFolder.getNormalizedFile() returns
>> incorrect value for non-canonical Windows UNC path. getNormalizedFile() is
>> used for symbolic lin
I would like to fix the bug reported in JDK-8277463.
As reporter's investigation, ShellFolder.getNormalizedFile() returns incorrect
value for non-canonical Windows UNC path. getNormalizedFile() is used for
symbolic link path, but Windows environment does not handle symbolic link. And,
getCanoni
On Thu, 18 Nov 2021 00:02:30 GMT, Sergey Bylokhov wrote:
>> @mrserb Can I hope this fix will be integrated after JDK-8270874 is fixed?
>
> Yes.
@mrserb Could you please check this pull request?
-
PR: https://git.openjdk.java.net/jdk/pull/6064
On Thu, 28 Oct 2021 08:27:44 GMT, Masanori Yano wrote:
>> Could you please review the 8275715 bug fixes?
>>
>> I think D3DScreenUpdateManager posts unnecessary PaintEvent during
>> processing PaintEvent. When the validate method is called from
>> createGraphics
On Thu, 28 Oct 2021 09:29:13 GMT, Masanori Yano wrote:
> Could you please review the 8262297 bug fixes?
>
> In this case, ImageIO.write() should throw java.io.IOException rather than
> java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and
> wrapped in
On Thu, 28 Oct 2021 08:27:44 GMT, Masanori Yano wrote:
>> Could you please review the 8275715 bug fixes?
>>
>> I think D3DScreenUpdateManager posts unnecessary PaintEvent during
>> processing PaintEvent. When the validate method is called from
>> createGraphics
On Tue, 23 Nov 2021 11:30:40 GMT, Jayathirth D V wrote:
>> test/jdk/javax/imageio/plugins/bmp/BMPBitsPerPixelTest.java line 62:
>>
>>> 60: }
>>> 61: BufferedImage img = new BufferedImage(10, 10, imageType,
>>> (IndexColorModel)cm);
>>> 62: ImageIO.write(img,
ix. In addition,
> IndexOutOfBoundsException is not expected to throw by
> RandomAccessFile#write() according to its API specification. So it should be
> fixed.
Masanori Yano has updated the pull request incrementally with one additional
commit since the last revision:
8262297: ImageIO.w
On Tue, 26 Oct 2021 04:52:37 GMT, Sergey Bylokhov wrote:
>> Masanori Yano has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Thu, 28 Oct 2021 08:27:44 GMT, Masanori Yano wrote:
>> Could you please review the 8275715 bug fixes?
>>
>> I think D3DScreenUpdateManager posts unnecessary PaintEvent during
>> processing PaintEvent. When the validate method is called from
>> createGraphics
On Mon, 15 Nov 2021 08:02:19 GMT, Jayathirth D V wrote:
>> Masanori Yano has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8262297: ImageIO.write() method will throw IndexOutOfBoundsException
>> - 826229
On Tue, 16 Nov 2021 00:40:35 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/share/classes/com/sun/imageio/plugins/bmp/BMPImageWriter.java
>> line 1459:
>>
>>> 1457: int biType = imgType.getBufferedImageType();
>>> 1458: int bpp = imgType.getColorModel().getPixelSize();
>>> 1459
ix. In addition,
> IndexOutOfBoundsException is not expected to throw by
> RandomAccessFile#write() according to its API specification. So it should be
> fixed.
Masanori Yano has updated the pull request incrementally with two additional
commits since the last revision:
- 8262297: ImageIO.w
On Sun, 14 Nov 2021 05:55:35 GMT, Sergey Bylokhov wrote:
>> @mrserb How long will it take to review this fix?
>
> I suggest leaving it as is for some time, since it is known that could
> workaround another bug, linked below.
@mrserb Can I hope this fix will be integrated after JDK-8270874 is fi
On Tue, 26 Oct 2021 04:52:37 GMT, Sergey Bylokhov wrote:
>> Masanori Yano has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Fri, 29 Oct 2021 09:36:37 GMT, Masanori Yano wrote:
>> Could you please review the 8262297 bug fixes?
>>
>> In this case, ImageIO.write() should throw java.io.IOException rather than
>> java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and
&g
ix. In addition,
> IndexOutOfBoundsException is not expected to throw by
> RandomAccessFile#write() according to its API specification. So it should be
> fixed.
Masanori Yano has updated the pull request incrementally with two additional
commits since the last revision:
- 8262297: ImageIO.w
On Thu, 28 Oct 2021 09:03:55 GMT, Sergey Bylokhov wrote:
>> Yes, this run() is called on "D3D Screen Updater" thread. It is reasonable
>> that a new PaintEvent is posted when SurfaceData is replaced on this thread.
>> I would limit posting new PaintEvent via createGraphics() only.
>
> Probably
On Tue, 26 Oct 2021 04:52:37 GMT, Sergey Bylokhov wrote:
>> Masanori Yano has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Thu, 28 Oct 2021 09:03:55 GMT, Sergey Bylokhov wrote:
>> Yes, this run() is called on "D3D Screen Updater" thread. It is reasonable
>> that a new PaintEvent is posted when SurfaceData is replaced on this thread.
>> I would limit posting new PaintEvent via createGraphics() only.
>
> Probably
On Tue, 26 Oct 2021 04:52:37 GMT, Sergey Bylokhov wrote:
>> Masanori Yano has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Tue, 26 Oct 2021 04:52:37 GMT, Sergey Bylokhov wrote:
>> Masanori Yano has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
On Thu, 28 Oct 2021 09:03:55 GMT, Sergey Bylokhov wrote:
>> Yes, this run() is called on "D3D Screen Updater" thread. It is reasonable
>> that a new PaintEvent is posted when SurfaceData is replaced on this thread.
>> I would limit posting new PaintEvent via createGraphics() only.
>
> Probably
ix. In addition,
> IndexOutOfBoundsException is not expected to throw by
> RandomAccessFile#write() according to its API specification. So it should be
> fixed.
Masanori Yano has updated the pull request incrementally with one additional
commit since the last revision:
8262297: ImageIO.w
On Fri, 29 Oct 2021 07:13:32 GMT, Alan Bateman wrote:
>> Unfortunately the parent class does not specify this exception via javadoc
>> tags like "@throws IndexOutOfBoundsException", but instead just describe it
>> in the method description
>>
>> should we fix it separately from the imageio fix
Could you please review the 8262297 bug fixes?
In this case, ImageIO.write() should throw java.io.IOException rather than
java.lang.IndexOutOfBoundsException. IndexOutOfBoundsException is caught and
wrapped in IIOException in ImageIO.write() with this fix. In addition,
IndexOutOfBoundsException
On Sat, 23 Oct 2021 19:40:59 GMT, Sergey Bylokhov wrote:
>> Masanori Yano has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8275715: D3D pipeline processes multiple PaintEvent at initial drawing
>
> src/ja
> Could you please review the 8275715 bug fixes?
>
> I think D3DScreenUpdateManager posts unnecessary PaintEvent during processing
> PaintEvent. When the validate method is called from createGraphics,
> repaintPeerTarget should not be called.
Masanori Yano has updated t
On Sat, 23 Oct 2021 19:34:06 GMT, Sergey Bylokhov wrote:
>> Masanori Yano has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contai
Could you please review the 8275715 bug fixes?
I think D3DScreenUpdateManager posts unnecessary PaintEvent during processing
PaintEvent. When the validate method is called from createGraphics,
repaintPeerTarget should not be called.
-
Commit messages:
- 8275715: D3D pipeline proce
On Tue, 12 Oct 2021 06:27:14 GMT, Sergey Bylokhov wrote:
>> Could you please review the 7001973 fixes?
>>
>> On Windows, CopyAreaOOB.java fails with a blank window. The cause of this
>> problem is that paint() works one time only. Painting area is not guaranteed
>> when showing a window.
>>
>
On Mon, 13 Sep 2021 11:32:37 GMT, Masanori Yano wrote:
> Could you please review the 7001973 fixes?
>
> On Windows, CopyAreaOOB.java fails with a blank window. The cause of this
> problem is that paint() works one time only. Painting area is not guaranteed
> when showing a
gt; ProblemList.txt. I don't have a Mac environment, so can someone please
> confirm that this fix will work on Mac?
Masanori Yano has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/re
On Mon, 13 Sep 2021 11:32:37 GMT, Masanori Yano wrote:
> Could you please review the 7001973 fixes?
>
> On Windows, CopyAreaOOB.java fails with a blank window. The cause of this
> problem is that paint() works one time only. Painting area is not guaranteed
> when showing a
On Wed, 29 Sep 2021 00:42:01 GMT, Sergey Bylokhov wrote:
> Do you know why we post it twice? It does not seem right, since we repaint
> all content in the apps like Netbeans/Idea and it is quite a heavyweight
> operation.
Because SurfaceData is judged to be lost when 1st getGraphics() is calle
On Fri, 24 Sep 2021 19:57:50 GMT, Sergey Bylokhov wrote:
> So the "sun.awt.noerasebackground" property may fix the problem?
Yes. With `-Dsun.awt.noerasebackground=true`, original CopyAreaOOB.java is
Passed. But it is just a workaround.
paint() is called twice with default settings on Windows,
On Fri, 17 Sep 2021 08:15:54 GMT, Sergey Bylokhov wrote:
> my question was why the first CopyArea is ignored?
This is a RepaintArea's behavior. clearRect() is called before paint() because
shouldClearRectBeforePaint is true for Canvas. Then, if 2nd paint() is called
and paint() does nothing,
On Mon, 13 Sep 2021 11:32:37 GMT, Masanori Yano wrote:
> Could you please review the 7001973 fixes?
>
> On Windows, CopyAreaOOB.java fails with a blank window. The cause of this
> problem is that paint() works one time only. Painting area is not guaranteed
> when showing a
On Mon, 13 Sep 2021 11:32:37 GMT, Masanori Yano wrote:
> Could you please review the 7001973 fixes?
>
> On Windows, CopyAreaOOB.java fails with a blank window. The cause of this
> problem is that paint() works one time only. Painting area is not guaranteed
> when showing a
Could you please review the 7001973 fixes?
On Windows, CopyAreaOOB.java fails with a blank window. The cause of this
problem is that paint() works one time only. Painting area is not guaranteed
when showing a window.
I think this behavior should be removed for purpose of this test (`@summary:
68 matches
Mail list logo
