Integrated: 8287609: macOS: SIGSEGV at [CoreFoundation] CFArrayGetCount / sun.font.CFont.getTableBytesNative

2022-06-05 Thread Nikita Gubarkov
On Tue, 31 May 2022 23:39:09 GMT, Nikita Gubarkov wrote: > `CTFontCopyAvailableTables` can return null, which causes subsequent call to > `CFArrayGetCount` to crash with SEGFAULT, just added a null-check. This pull request has now been integrated. Changeset: 8c460b04 Author:

Re: RFR: 8287609: macOS: SIGSEGV at [CoreFoundation] CFArrayGetCount / sun.font.CFont.getTableBytesNative

2022-06-04 Thread Nikita Gubarkov
On Fri, 3 Jun 2022 20:48:28 GMT, Phil Race wrote: >> `CTFontCopyAvailableTables` can return null, which causes subsequent call to >> `CFArrayGetCount` to crash with SEGFAULT, just added a null-check. > > oh my gosh .. it is a font designed for PRE-macOSX . meaning mac. so it is an > ATM font wi

Re: RFR: 8287609: macOS: SIGSEGV at [CoreFoundation] CFArrayGetCount / sun.font.CFont.getTableBytesNative

2022-06-03 Thread Nikita Gubarkov
On Tue, 31 May 2022 23:39:09 GMT, Nikita Gubarkov wrote: > `CTFontCopyAvailableTables` can return null, which causes subsequent call to > `CFArrayGetCount` to crash with SEGFAULT, just added a null-check. Sorry for the confusion, "maxp" being absent was only my assumption:

Re: RFR: 8287609: macOS: SIGSEGV at [CoreFoundation] CFArrayGetCount / sun.font.CFont.getTableBytesNative

2022-06-01 Thread Nikita Gubarkov
On Tue, 31 May 2022 23:39:09 GMT, Nikita Gubarkov wrote: > `CTFontCopyAvailableTables` can return null, which causes subsequent call to > `CFArrayGetCount` to crash with SEGFAULT, just added a null-check. https://user-images.githubusercontent.com/9004656/171468848-58612bb1-6432-4c7

Re: RFR: 8287609: Add null-check for tagsArray returned from CTFontCopyAvailableTables

2022-06-01 Thread Nikita Gubarkov
On Tue, 31 May 2022 23:39:09 GMT, Nikita Gubarkov wrote: > `CTFontCopyAvailableTables` can return null, which causes subsequent call to > `CFArrayGetCount` to crash with SEGFAULT, just added a null-check. I didn't find anything in documentation too, but it does return null, I chec

RFR: 8287609: Add null-check for tagsArray returned from CTFontCopyAvailableTables

2022-05-31 Thread Nikita Gubarkov
`CTFontCopyAvailableTables` can return null, which causes subsequent call to `CFArrayGetCount` to crash with SEGFAULT, just added a null-check. - Commit messages: - 8287609: Add null-check for tagsArray returned from CTFontCopyAvailableTables Changes: https://git.openjdk.java.net/j

Re: RFR: 8269806: Emoji rendering on Linux [v3]

2022-05-05 Thread Nikita Gubarkov
On Wed, 30 Mar 2022 17:08:37 GMT, Nikita Gubarkov wrote: >> It was implemented in JetBrains Runtime a year ago and was ported & >> refactored for this PR >> It includes: >> - Bitmap glyph loading via Freetype >> - Manual scaling & transformation of

Re: RFR: 8269806: Emoji rendering on Linux [v3]

2022-03-30 Thread Nikita Gubarkov
g on the text antialiasing hint > - Storing BGRA glyphs in glyph cache & rendering them as plain images, as > currently used XRender text drawing functions doesn't support colored glyphs > - Small fixes in related code like null-checks which could cause NPE & > comment

Re: RFR: 8269806: Emoji rendering on Linux [v2]

2022-03-30 Thread Nikita Gubarkov
On Tue, 29 Mar 2022 17:11:54 GMT, Alexey Ushakov wrote: >> Nikita Gubarkov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8269806: Fix builds with old Freetype (before 2.5) > > I was able to reproduc

Re: RFR: 8269806: Emoji rendering on Linux [v2]

2022-03-25 Thread Nikita Gubarkov
On Thu, 24 Mar 2022 22:36:28 GMT, Nikita Gubarkov wrote: >> It was implemented in JetBrains Runtime a year ago and was ported & >> refactored for this PR >> It includes: >> - Bitmap glyph loading via Freetype >> - Manual scaling & transformation of

Re: RFR: 8269806: Emoji rendering on Linux [v2]

2022-03-24 Thread Nikita Gubarkov
On Thu, 24 Mar 2022 22:36:28 GMT, Nikita Gubarkov wrote: >> It was implemented in JetBrains Runtime a year ago and was ported & >> refactored for this PR >> It includes: >> - Bitmap glyph loading via Freetype >> - Manual scaling & transformation of

Re: RFR: 8269806: Emoji rendering on Linux

2022-03-24 Thread Nikita Gubarkov
On Thu, 24 Mar 2022 02:32:31 GMT, Phil Race wrote: >> It was implemented in JetBrains Runtime a year ago and was ported & >> refactored for this PR >> It includes: >> - Bitmap glyph loading via Freetype >> - Manual scaling & transformation of bitmap glyphs with nearest-neighbor or >> bilinear-m

Re: RFR: 8269806: Emoji rendering on Linux [v2]

2022-03-24 Thread Nikita Gubarkov
On Thu, 24 Mar 2022 22:36:28 GMT, Nikita Gubarkov wrote: >> It was implemented in JetBrains Runtime a year ago and was ported & >> refactored for this PR >> It includes: >> - Bitmap glyph loading via Freetype >> - Manual scaling & transformation of

Re: RFR: 8269806: Emoji rendering on Linux [v2]

2022-03-24 Thread Nikita Gubarkov
g on the text antialiasing hint > - Storing BGRA glyphs in glyph cache & rendering them as plain images, as > currently used XRender text drawing functions doesn't support colored glyphs > - Small fixes in related code like null-checks which could cause NPE & > comment

Re: RFR: 8269806: Emoji rendering on Linux

2021-12-29 Thread Nikita Gubarkov
On Sat, 30 Oct 2021 20:12:00 GMT, Phil Race wrote: >> @prrace could you take a look, please? > > @YaaZ nothing has really happened here in > 2 months. When can we expect an > update ? Hi @prrace! By X11 pipeline, do you mean `-Dsun.java2d.xrender=false`? Because I wasn't able to reproduce this

Re: RFR: 8269806: Emoji rendering on Linux

2021-11-08 Thread Nikita Gubarkov
On Thu, 15 Jul 2021 17:29:01 GMT, Nikita Gubarkov wrote: > It was implemented in JetBrains Runtime a year ago and was ported & > refactored for this PR > It includes: > - Bitmap glyph loading via Freetype > - Manual scaling & transformation of bitmap glyphs with nearest-