Integrated: 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed

2022-06-10 Thread Prasanta Sadhukhan
On Fri, 3 Jun 2022 09:46:11 GMT, Prasanta Sadhukhan wrote: > Test is failing in iMac CI systems owing to color difference of 1 > > `x 0 y 0 rgb1: fff0f0f0 rgb2: fff0eff0` > > Added minor color tolerance check. CI testing is green This pull request has now been integra

Re: RFR: 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed [v4]

2022-06-10 Thread Prasanta Sadhukhan
On Fri, 10 Jun 2022 12:54:23 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Fix review comments >> - Fix review comments > > test/jdk/javax/swing/te

Re: RFR: 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed [v5]

2022-06-10 Thread Prasanta Sadhukhan
> Test is failing in iMac CI systems owing to color difference of 1 > > `x 0 y 0 rgb1: fff0f0f0 rgb2: fff0eff0` > > Added minor color tolerance check. CI testing is green Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last r

Re: RFR: 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed [v4]

2022-06-10 Thread Prasanta Sadhukhan
> Test is failing in iMac CI systems owing to color difference of 1 > > `x 0 y 0 rgb1: fff0f0f0 rgb2: fff0eff0` > > Added minor color tolerance check. CI testing is green Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last re

Re: RFR: 8284619: javax/swing/JTable/8236907/LastVisibleRow.java failed with "Test Case Failed!!, Last Row not Visible!!!"

2022-06-10 Thread Prasanta Sadhukhan
On Fri, 10 Jun 2022 10:30:54 GMT, Tejesh R wrote: > > > > Was there any reason of calling table.setFocusable(false) in > > > > clearSelect()? We have some focus related mach5 issues in macos that > > > > crops out intermittently so maybe we should get rid of that if it's not > > > > needed. I

Re: RFR: 8284619: javax/swing/JTable/8236907/LastVisibleRow.java failed with "Test Case Failed!!, Last Row not Visible!!!"

2022-06-10 Thread Prasanta Sadhukhan
On Fri, 10 Jun 2022 05:35:22 GMT, Tejesh R wrote: > Fix history - #7422. > The test is automatic and check if the last row is painted (Which was not > happening before the fix, the last row appeared only after MouseClick > operation) by capturing the last row before and after MouseClick Operati

Re: RFR: 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed [v3]

2022-06-10 Thread Prasanta Sadhukhan
> Test is failing in iMac CI systems owing to color difference of 1 > > `x 0 y 0 rgb1: fff0f0f0 rgb2: fff0eff0` > > Added minor color tolerance check. CI testing is green Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last r

Re: RFR: 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed [v2]

2022-06-10 Thread Prasanta Sadhukhan
On Fri, 10 Jun 2022 07:16:46 GMT, Prasanta Sadhukhan wrote: >> How to find those 2 bufferedimages returned by >> `createMultiResolutionScreenCapture `and `createScreenCapture `are same or >> not apart from pixel check (which shows obviously they are not same and &g

Re: RFR: 8284619: javax/swing/JTable/8236907/LastVisibleRow.java failed with "Test Case Failed!!, Last Row not Visible!!!"

2022-06-10 Thread Prasanta Sadhukhan
On Fri, 10 Jun 2022 08:46:06 GMT, Tejesh R wrote: > > Was there any reason of calling table.setFocusable(false) in clearSelect()? > > We have some focus related mach5 issues in macos that crops out > > intermittently so maybe we should get rid of that if it's not needed. I > > think just calli

Re: RFR: 8284619: javax/swing/JTable/8236907/LastVisibleRow.java failed with "Test Case Failed!!, Last Row not Visible!!!"

2022-06-10 Thread Prasanta Sadhukhan
On Fri, 10 Jun 2022 05:35:22 GMT, Tejesh R wrote: > Fix history - #7422. > The test is automatic and check if the last row is painted (Which was not > happening before the fix, the last row appeared only after MouseClick > operation) by capturing the last row before and after MouseClick Operati

Re: RFR: 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed [v2]

2022-06-10 Thread Prasanta Sadhukhan
On Fri, 10 Jun 2022 07:11:05 GMT, Prasanta Sadhukhan wrote: >> On the HiDPI screen that MRI will have two images, and my expectation is >> that the image requested by the updated test and the image used before the >> fix should be the same. > > How to find those 2 bu

Re: RFR: 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed [v2]

2022-06-10 Thread Prasanta Sadhukhan
On Fri, 10 Jun 2022 05:42:11 GMT, Sergey Bylokhov wrote: >> If I remember correctly, MRI will contain only one image captured by Robot, >> so it would return the only image it stores, which would not be scaled down >> if High DPI is in effect. >> >> However, the test is supposed to run with `U

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v6]

2022-06-07 Thread Prasanta Sadhukhan
On Mon, 6 Jun 2022 09:48:47 GMT, Prasanta Sadhukhan wrote: > I see even `Gulimche `and `Batang `are not visible without -Dfile.encoding=ko > so maybe it's what is expected. Malgun Gothic is visible without user.language=ko and user.country=KR in command line (of cou

Re: RFR: 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed [v2]

2022-06-07 Thread Prasanta Sadhukhan
On Mon, 6 Jun 2022 21:11:03 GMT, Sergey Bylokhov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use RObot.createMultiResoutionCapture > > test/jdk/javax/swing/text/CSSBorder/67

Re: RFR: 8287876: The recently de-problemlisted TestTitledBorderLeak test is unstable

2022-06-07 Thread Prasanta Sadhukhan
On Tue, 7 Jun 2022 04:15:49 GMT, Sergey Bylokhov wrote: > This is an update of the test which was de-problemlisted > [here](https://github.com/openjdk/jdk/pull/8450). > > Looks like the initial root cause of the issue was related to the last > disposed frame which for some reason was not delet

Re: RFR: 8273573: [macos12] ActionListenerCalledTwiceTest.java fails on macOS 12 [v2]

2022-06-07 Thread Prasanta Sadhukhan
On Fri, 3 Jun 2022 10:06:21 GMT, Alexander Zvegintsev wrote: >> This test was failing consistently on same machines and at the same time as >> #8532. >> >> Test failure is also no longer reproducible after #8320 fix. >> >> This is macOS only test, so corresponding `@requires os.family` tag wa

Re: RFR: 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed [v2]

2022-06-06 Thread Prasanta Sadhukhan
> Test is failing in iMac CI systems owing to color difference of 1 > > `x 0 y 0 rgb1: fff0f0f0 rgb2: fff0eff0` > > Added minor color tolerance check. CI testing is green Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last r

Re: RFR: 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed

2022-06-06 Thread Prasanta Sadhukhan
On Fri, 3 Jun 2022 09:46:11 GMT, Prasanta Sadhukhan wrote: > Test is failing in iMac CI systems owing to color difference of 1 > > `x 0 y 0 rgb1: fff0f0f0 rgb2: fff0eff0` > > Added minor color tolerance check. CI testing is green Used `Robot.createMultiResolutionScreenCapt

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v6]

2022-06-06 Thread Prasanta Sadhukhan
On Sat, 28 May 2022 03:41:29 GMT, Prasanta Sadhukhan wrote: >> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced >> Gulim korean font so it needs to be updated to show korean fonts > > Prasanta Sadhukhan has updated the pull request incrementally with

Re: RFR: JDK-8287261: [macos] JList Focus Ring color doesn't follow Accent color changes on macOS [v2]

2022-06-05 Thread Prasanta Sadhukhan
On Wed, 1 Jun 2022 19:40:34 GMT, Harshitha Onkar wrote: >> With the proposed fix, JList's focus ring color follows accent color >> changes. Previously the focus ring for JList was not prominently visible and >> did not follow accent color changes. >> >> While investing a similar issue related

RFR: 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed

2022-06-03 Thread Prasanta Sadhukhan
Test is failing in iMac CI systems owing to color difference of 1 `x 0 y 0 rgb1: fff0f0f0 rgb2: fff0eff0` Added minor color tolerance check. CI testing is green - Commit messages: - 8287743: javax/swing/text/CSSBorder/6796710/bug6796710.java failed Changes: https://git.openjdk.jav

Re: RFR: 8273573: [macos12] ActionListenerCalledTwiceTest.java fails on macOS 12

2022-06-02 Thread Prasanta Sadhukhan
On Thu, 2 Jun 2022 20:12:01 GMT, Alexander Zvegintsev wrote: > This test was failing consistently on same machines and at the same time as > #8532. > > Test failure is also no longer reproducible after #8320 fix. > > This is macOS only test, so corresponding `@requires os.family` tag was > a

Re: RFR: 8273573: [macos12] ActionListenerCalledTwiceTest.java fails on macOS 12

2022-06-02 Thread Prasanta Sadhukhan
On Thu, 2 Jun 2022 20:12:01 GMT, Alexander Zvegintsev wrote: > This test was failing consistently on same machines and at the same time as > #8532. > > Test failure is also no longer reproducible after #8320 fix. > > This is macOS only test, so corresponding `@requires os.family` tag was > a

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v6]

2022-06-02 Thread Prasanta Sadhukhan
On Wed, 1 Jun 2022 20:50:47 GMT, Phil Race wrote: > Malgun is now not appearing in the font menu of Font2DTest when I use ko + > UTF-8 !? > It appears if I use -Dfile.encoding=ko instead Are you implying it used to appear earlier? with what configuration or patch? It is same for me but I haven'

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v4]

2022-06-01 Thread Prasanta Sadhukhan
On Thu, 2 Jun 2022 04:48:09 GMT, Tejesh R wrote: > > > > > Shall the test be located in > > > > > `test/jdk/javax/swing/JRadioButton/4380543/bug4380543.java` instead > > > > > of `test/jdk/javax/swing/JRadioButton/bug4380543.java` ? > > > > > Usually, there's been a folder with bugid (`/4380543

Re: RFR: 8213531: Test javax/swing/border/TestTitledBorderLeak.java fails [v3]

2022-06-01 Thread Prasanta Sadhukhan
On Sat, 28 May 2022 08:41:35 GMT, Prasanta Sadhukhan wrote: >> Test was failing in linux citing `java.lang.RuntimeException: Expected Total >> TitledBorder to be freed : 10 Freed 9 ` >> As per the fix done in JDK-8204963 >> http://hg.openjdk.java.net/jdk/jdk/rev/cd7d

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v6]

2022-06-01 Thread Prasanta Sadhukhan
On Wed, 1 Jun 2022 20:50:47 GMT, Phil Race wrote: > Also can you attach the source of your test to JBS ! I have attached. - PR: https://git.openjdk.java.net/jdk/pull/7643

Integrated: 8286846: test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on mac aarch64

2022-06-01 Thread Prasanta Sadhukhan
On Tue, 24 May 2022 08:28:57 GMT, Prasanta Sadhukhan wrote: > Test was failing intermiitently in iMac M1 system owing to minimalistic color > difference of 1 > > x 13 y 0 refRGB ffee customRGB ffef > x 0 y 0 refRGB ffefefef customRGB ffefeeef > > > so add

Integrated: 8213531: Test javax/swing/border/TestTitledBorderLeak.java fails

2022-06-01 Thread Prasanta Sadhukhan
On Thu, 28 Apr 2022 11:59:45 GMT, Prasanta Sadhukhan wrote: > Test was failing in linux citing `java.lang.RuntimeException: Expected Total > TitledBorder to be freed : 10 Freed 9 ` > As per the fix done in JDK-8204963 > http://hg.openjdk.java.net/jdk/jdk/rev/cd7d2f9154fd &g

Re: RFR: 8233477: : [Win LAF]The tooltip doesn't display correctly in Win LAF [v2]

2022-05-31 Thread Prasanta Sadhukhan
On Wed, 1 Jun 2022 05:30:23 GMT, Tejesh R wrote: >> The tooltip displays accelerated string along with the toooltip string. The >> feature is implemented and applicable for Metal Look and Feel only. Hence >> the test is updated for Metal Look and Feel by hard wiring it in the code. >> Updated

Re: RFR: 8233477: : [Win LAF]The tooltip doesn't display correctly in Win LAF

2022-05-31 Thread Prasanta Sadhukhan
On Tue, 31 May 2022 08:14:14 GMT, Tejesh R wrote: > The tooltip displays accelerated string along with the toooltip string. The > feature is implemented and applicable for Metal Look and Feel only. Hence the > test is updated for Metal Look and Feel by hard wiring it in the code. > Updated the

Re: RFR: 8286159: Memory leak in getAllConfigs of awt_GraphicsEnv.c:585

2022-05-31 Thread Prasanta Sadhukhan
On Mon, 23 May 2022 20:35:33 GMT, Phil Race wrote: > If we don't store the memory allocated for graphicsConfigs because we > failed/bail, we need to free it. Marked as reviewed by psadhukhan (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8857

Re: RFR: 8286846: test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on mac aarch64

2022-05-30 Thread Prasanta Sadhukhan
On Tue, 24 May 2022 08:28:57 GMT, Prasanta Sadhukhan wrote: > Test was failing intermiitently in iMac M1 system owing to minimalistic color > difference of 1 > > x 13 y 0 refRGB ffee customRGB ffef > x 0 y 0 refRGB ffefefef customRGB ffefeeef > > > so add

Re: RFR: 8286846: test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on mac aarch64

2022-05-30 Thread Prasanta Sadhukhan
On Wed, 25 May 2022 02:55:53 GMT, Prasanta Sadhukhan wrote: >> test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java line 64: >> >>> 62: >>> 63: public static void main(String[] args) throws Exception { >>> 64: if (!System.getPropert

Re: RFR: 8213531: Test javax/swing/border/TestTitledBorderLeak.java fails [v2]

2022-05-28 Thread Prasanta Sadhukhan
On Fri, 27 May 2022 20:31:08 GMT, Phil Race wrote: > Can you confirm we still need the Frame ? I mean when does the > used-to-be-leaky listener get installed ? If it is sufficient to add it to > the panel and the panel doesn't need to be added to the frame then the test > can be headless. But

Re: RFR: 8213531: Test javax/swing/border/TestTitledBorderLeak.java fails [v3]

2022-05-28 Thread Prasanta Sadhukhan
and also it can still be used as 8204963 regression test as it still fails > without the fix and pass with it. Modified test has passed in all platforms > for several iterations. > > Also removed the deprecated `System.runFinalization` Prasanta Sadhukhan has updated the pull request in

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v6]

2022-05-27 Thread Prasanta Sadhukhan
> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced Gulim > korean font so it needs to be updated to show korean fonts Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision: Added UTF-8 korean fa

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v5]

2022-05-27 Thread Prasanta Sadhukhan
On Fri, 27 May 2022 17:51:45 GMT, Phil Race wrote: > Good to know. I still believe we should add > sequence.allfonts.UTF-8.ko=alphabetic,korean,dingbats,symbol since UTF-8 is > now the default encoding. Added UTF-8 korean fallback. I get the same above rendering with the same commandline as a

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v5]

2022-05-26 Thread Prasanta Sadhukhan
On Thu, 26 May 2022 08:49:42 GMT, Prasanta Sadhukhan wrote: >> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced >> Gulim korean font so it needs to be updated to show korean fonts > > Prasanta Sadhukhan has updated the pull request with a new targe

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v4]

2022-05-26 Thread Prasanta Sadhukhan
On Fri, 13 May 2022 22:19:12 GMT, Phil Race wrote: > I still don't understand why they are the same for you .. I added > korean-fallback to my local fontconfig and ran in the Korean locale (changed > my windows region to Korea and rebooted) and they are different for me. > > What I do seem to

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v5]

2022-05-26 Thread Prasanta Sadhukhan
> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced Gulim > korean font so it needs to be updated to show korean fonts Prasanta Sadhukhan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated c

Re: RFR: 8213531: Test javax/swing/border/TestTitledBorderLeak.java fails [v2]

2022-05-26 Thread Prasanta Sadhukhan
On Mon, 16 May 2022 05:33:24 GMT, Sergey Bylokhov wrote: > > > Does it mean that setVisible(true) cause some memory leak since it > > > prevents the window to be disposed? > > > > > > Since 9 windows are freed .. I doubt it .. but what's the hold up with #10 > > ? I wonder if you need an extr

Integrated: 8257810: Only First page are printed in JTable.scrollRectToVisible

2022-05-25 Thread Prasanta Sadhukhan
On Thu, 7 Apr 2022 09:17:02 GMT, Prasanta Sadhukhan wrote: > Issue was when printing a JTable which sits inside a JScrollPane and the > table is scrolled down to the end to about 1000th row, only the first page is > printed. > This is because when the table is scrolled down to la

Re: RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible [v12]

2022-05-25 Thread Prasanta Sadhukhan
On Wed, 25 May 2022 13:48:26 GMT, Alexey Ivanov wrote: >> There are many swing tests that has EXIT_ON_CLOSE so not sure if it's a >> problem .There are couple which have DISPOSE_ON_CLOSE which I can changed to >> but not sure if it will have any effect.. > > It is a problem for jtreg tests: `Sy

Re: RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible [v13]

2022-05-25 Thread Prasanta Sadhukhan
resetted bounds for this intersection calculation too > as was done for JDK-8236907 > > Tested against JDK-8081491, 8170349, JDK-8236907 testcases along with other > regression tests and all are OK (link in JBS) Prasanta Sadhukhan has updated the pull request incrementa

Re: RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible [v12]

2022-05-25 Thread Prasanta Sadhukhan
On Wed, 25 May 2022 12:45:53 GMT, Alexey Ivanov wrote: >> test/jdk/javax/swing/JTable/PrintAllPagesTest.java line 115: >> >>> 113: f.add(scrollpane); >>> 114: f.setSize(1000, 800); >>> 115: f.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE); >> >> setDefaultCloseO

Re: RFR: 8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver

2022-05-25 Thread Prasanta Sadhukhan
On Thu, 19 May 2022 23:46:48 GMT, Phil Race wrote: > This adds the Microsoft Basic Render Driver to our "bad hardware" list so > that we don't use that pipeline there. > We have at least the one test that fails there and I am not sure we get any > benefit from this. > I'm sure Microsoft need to

Re: RFR: 8286846: test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on mac aarch64

2022-05-24 Thread Prasanta Sadhukhan
On Tue, 24 May 2022 17:51:27 GMT, Harshitha Onkar wrote: >> Test was failing intermiitently in iMac M1 system owing to minimalistic >> color difference of 1 >> >> x 13 y 0 refRGB ffee customRGB ffef >> x 0 y 0 refRGB ffefefef customRGB ffefeeef >> >> >> so added color tolerance check

RFR: 8286846: test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on mac aarch64

2022-05-24 Thread Prasanta Sadhukhan
Test was failing intermiitently in iMac M1 system owing to minimalistic color difference of 1 x 13 y 0 refRGB ffee customRGB ffef x 0 y 0 refRGB ffefefef customRGB ffefeeef so added color tolerance check. Also, added other stability fixes.. Several iteration of test passed in intended

Integrated: 8286786: [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java still fails

2022-05-23 Thread Prasanta Sadhukhan
On Fri, 20 May 2022 09:07:29 GMT, Prasanta Sadhukhan wrote: > In PR#[8380](https://github.com/openjdk/jdk/pull/8380) we have reduced the > error tolerance from 25 to 1 so no need of exact color check which is causing > failure in specific M1 iMac system because of minimalis

Re: RFR: 8286266: [macos] Voice over moving JTable column to be the first column JVM crashes [v2]

2022-05-20 Thread Prasanta Sadhukhan
On Wed, 11 May 2022 16:36:26 GMT, Artem Semenov wrote: >>> It seems to me that here it is necessary to release the cache. >> >> I am not so sure. Why would we do that? I mean - we removed all the records >> from the cache and even if we would release it we would have to immediately >> re-creat

RFR: 8286786: [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java still fails

2022-05-20 Thread Prasanta Sadhukhan
In PR#[8380](https://github.com/openjdk/jdk/pull/8380) we have reduced the error tolerance from 25 to 1 so no need of exact color check which is causing failure in specific M1 iMac system because of minimalistic color difference of "1" x 0 y 0 red1 171 red2 171 green1 174 green2 175 blue1 184

Integrated: 8285962: NimbusDefaults has a typo in a L&F property

2022-05-20 Thread Prasanta Sadhukhan
On Mon, 2 May 2022 16:01:02 GMT, Prasanta Sadhukhan wrote: > BasicLookAndFeel, BasicProgressBarUI, GTKLookAndFeel tries to find property > by "ProgressBar.verticalSize" but the property defined in NimbusDefaults has > a typo "vertictalSize ". > Rectified the

Re: RFR: 8190907: Windows 10 default Korean Font Malgun Gothic available not used by GUI elements even though available without Korean Language Pack [v4]

2022-05-12 Thread Prasanta Sadhukhan
On Thu, 12 May 2022 23:54:47 GMT, Phil Race wrote: > I'm confused since your images with and without the font pack look the same > yet they should be using different fonts - ie Gulimche should be used for > monospaced when you have the font pack - although maybe it is always > installed, but a

Integrated: 8278348: [macos12] javax/swing/JTree/4908142/bug4908142.java fails in macos12

2022-05-12 Thread Prasanta Sadhukhan
On Wed, 4 May 2022 11:16:17 GMT, Prasanta Sadhukhan wrote: > 2 open tests were seen to be failing in macos12 which happen to have same > root cause as > 8273506: java Robot API did the 'm' keypress and caused /awt/event/Ke > > With that fix being committed, te

Integrated: 8284888 : [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "NimbusLookAndFeel] : ERROR: icon and imageIcon not same."

2022-05-12 Thread Prasanta Sadhukhan
On Mon, 25 Apr 2022 09:37:10 GMT, Prasanta Sadhukhan wrote: > Test used to fail in specific CI macos M1 system owing to miniscule color > difference > > > x 0 y 0 red1 171 red2 171 green1 174 green2 175 blue1 184 blue2 184 > x 0 y 1 red1 172 red2 173 green1 177 green2 1

Re: RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible [v12]

2022-05-11 Thread Prasanta Sadhukhan
resetted bounds for this intersection calculation too > as was done for JDK-8236907 > > Tested against JDK-8081491, 8170349, JDK-8236907 testcases along with other > regression tests and all are OK (link in JBS) Prasanta Sadhukhan has updated the pull request incrementally w

Re: RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible [v11]

2022-05-11 Thread Prasanta Sadhukhan
On Wed, 11 May 2022 18:01:27 GMT, Alexey Ivanov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Test updated > > test/jdk/javax/swing/JTable/PrintAllPa

Re: RFR: JDK-8282772: JButton text set as HTML content has unwanted padding [v4]

2022-05-10 Thread Prasanta Sadhukhan
On Tue, 10 May 2022 19:03:23 GMT, DamonGuy wrote: >> The insets for buttons were incorrect for L&Fs except for Aqua when the text >> is set to HTML. This was fixed in Aqua by adding a conditional to check for >> the BasicHTML property key in the button component. This same logic can be >> used

Re: RFR: 8283705: Make javax.sound.midi.Track a final class

2022-05-10 Thread Prasanta Sadhukhan
On Sun, 1 May 2022 21:15:33 GMT, Phil Race wrote: > This is the straggler from several PRs which were around making JDK classes > sealed. > There's nothing to be sealed here, but the same query pointed out that this > class has > no public or protected constructor (as well as no sub-classes) an

Re: RFR: JDK-8282772: JButton text set as HTML content has unwanted padding [v3]

2022-05-09 Thread Prasanta Sadhukhan
On Mon, 9 May 2022 16:15:48 GMT, DamonGuy wrote: >> The insets for buttons were incorrect for L&Fs except for Aqua when the text >> is set to HTML. This was fixed in Aqua by adding a conditional to check for >> the BasicHTML property key in the button component. This same logic can be >> used

Re: RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible [v7]

2022-05-09 Thread Prasanta Sadhukhan
On Mon, 9 May 2022 21:04:51 GMT, Alexey Ivanov wrote: >> Why can't this use the new PassFailJFrame ? > > It can. Yet the test had been written before `PassFailJFrame` was integrated. > > I'm fine with either way. I thought it was only for applet/manual test conversion to normal manual. Anyway,

Re: RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible [v11]

2022-05-09 Thread Prasanta Sadhukhan
resetted bounds for this intersection calculation too > as was done for JDK-8236907 > > Tested against JDK-8081491, 8170349, JDK-8236907 testcases along with other > regression tests and all are OK (link in JBS) Prasanta Sadhukhan has updated the pull request incrementally wi

Re: RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible [v10]

2022-05-09 Thread Prasanta Sadhukhan
resetted bounds for this intersection calculation too > as was done for JDK-8236907 > > Tested against JDK-8081491, 8170349, JDK-8236907 testcases along with other > regression tests and all are OK (link in JBS) Prasanta Sadhukhan has updated the pull request incrementally wi

Re: RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible [v9]

2022-05-09 Thread Prasanta Sadhukhan
resetted bounds for this intersection calculation too > as was done for JDK-8236907 > > Tested against JDK-8081491, 8170349, JDK-8236907 testcases along with other > regression tests and all are OK (link in JBS) Prasanta Sadhukhan has updated the pull request incrementally with one

Re: RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible [v8]

2022-05-09 Thread Prasanta Sadhukhan
resetted bounds for this intersection calculation too > as was done for JDK-8236907 > > Tested against JDK-8081491, 8170349, JDK-8236907 testcases along with other > regression tests and all are OK (link in JBS) Prasanta Sadhukhan has updated the pull request with a new target bas

Re: RFR: JDK-8282772: JButton text set as HTML content has unwanted padding [v2]

2022-05-08 Thread Prasanta Sadhukhan
On Wed, 27 Apr 2022 18:52:46 GMT, DamonGuy wrote: >> The insets for buttons were incorrect for L&Fs except for Aqua when the text >> is set to HTML. This was fixed in Aqua by adding a conditional to check for >> the BasicHTML property key in the button component. This same logic can be >> used

Re: RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible [v6]

2022-05-08 Thread Prasanta Sadhukhan
On Fri, 8 Apr 2022 12:41:29 GMT, Prasanta Sadhukhan wrote: >> Issue was when printing a JTable which sits inside a JScrollPane and the >> table is scrolled down to the end to about 1000th row, only the first page >> is printed. >> This is because when the table is sc

Re: RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible [v7]

2022-05-08 Thread Prasanta Sadhukhan
resetted bounds for this intersection calculation too > as was done for JDK-8236907 > > Tested against JDK-8081491, 8170349, JDK-8236907 testcases along with other > regression tests and all are OK (link in JBS) Prasanta Sadhukhan has updated the pull request incrementally wi

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v3]

2022-05-08 Thread Prasanta Sadhukhan
On Fri, 6 May 2022 14:47:39 GMT, Tejesh R wrote: >> In Button ToolTip, Mnemonic key string was shown only in Metal Look and >> Feel, since the feature is implemented in it. In other L&F especially >> Windows L&F the feature is not available. In order to make it available for >> other L&F's, th

Re: RFR: 8284888 : [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "NimbusLookAndFeel] : ERROR: icon and imageIcon not same." [v2]

2022-05-05 Thread Prasanta Sadhukhan
On Thu, 5 May 2022 09:06:02 GMT, Prasanta Sadhukhan wrote: > > I am not sure if there is an y deterministic way to find out the location > > of the icon > > Modified to use the capture area as used in the original webrev for Aqua > which will capture the title bar wit

Re: RFR: 8285397: JNI exception pending in CUPSfuncs.c:250 [v2]

2022-05-05 Thread Prasanta Sadhukhan
On Wed, 4 May 2022 20:14:35 GMT, Phil Race wrote: >> A tool checking for JNI errors complains that the call to >> JNU_NewStringPlatform(..) >> might throw an exception and subsequent JNI code isn't making sure of that. >> Clear the exception so the error handling code can do its thing. > > Phil

Re: RFR: 8284888 : [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "NimbusLookAndFeel] : ERROR: icon and imageIcon not same." [v5]

2022-05-05 Thread Prasanta Sadhukhan
me undecorated and remove unneeded library being built. > Several iterations of the test passed in the same system (where it used to > fail 4/10) along with other platforms (link in JBS) Prasanta Sadhukhan has updated the pull request with a new target base due to a merge or a rebase. The i

Re: RFR: 8284888 : [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "NimbusLookAndFeel] : ERROR: icon and imageIcon not same." [v2]

2022-05-05 Thread Prasanta Sadhukhan
On Thu, 5 May 2022 04:06:46 GMT, Prasanta Sadhukhan wrote: > I am not sure if there is an y deterministic way to find out the location of > the icon Modified to use the capture area as used in the original webrev for Aqua which will capture the title bar with icon ![iconImage-fail]

Re: RFR: 8284888 : [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "NimbusLookAndFeel] : ERROR: icon and imageIcon not same." [v4]

2022-05-05 Thread Prasanta Sadhukhan
me undecorated and remove unneeded library being built. > Several iterations of the test passed in the same system (where it used to > fail 4/10) along with other platforms (link in JBS) Prasanta Sadhukhan has updated the pull request incrementally with one additional commit sinc

Re: RFR: 8284888 : [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "NimbusLookAndFeel] : ERROR: icon and imageIcon not same." [v3]

2022-05-05 Thread Prasanta Sadhukhan
me undecorated and remove unneeded library being built. > Several iterations of the test passed in the same system (where it used to > fail 4/10) along with other platforms (link in JBS) Prasanta Sadhukhan has updated the pull request incrementally with one additional commit sinc

Integrated: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS

2022-05-05 Thread Prasanta Sadhukhan
On Thu, 14 Apr 2022 06:50:10 GMT, Prasanta Sadhukhan wrote: > JDK-4517214 was fixed for Metal L&F where JComboBox having TitledBorder used > to have double height compared to normal JComboBox. > The issue is still observed for macos for Aqua L&F where still double height &g

Re: RFR: 8284888 : [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "NimbusLookAndFeel] : ERROR: icon and imageIcon not same." [v2]

2022-05-04 Thread Prasanta Sadhukhan
On Wed, 4 May 2022 11:04:50 GMT, Prasanta Sadhukhan wrote: >> Test used to fail in specific CI macos M1 system owing to miniscule color >> difference >> >> >> x 0 y 0 red1 171 red2 171 green1 174 green2 175 blue1 184 blue2 184 >> x 0 y 1 red1 172 red2

RFR: 8278348: [macos12] javax/swing/JTree/4908142/bug4908142.java fails in macos12

2022-05-04 Thread Prasanta Sadhukhan
2 open tests were seen to be failing in macos12 which happen to have same root cause as 8273506: java Robot API did the 'm' keypress and caused /awt/event/Ke With that fix being committed, testing on intended macos12 systems are not able to reproduce this failures so we can remove from Prob

Re: RFR: 8284888 : [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "NimbusLookAndFeel] : ERROR: icon and imageIcon not same."

2022-05-04 Thread Prasanta Sadhukhan
On Tue, 3 May 2022 23:49:22 GMT, Phil Race wrote: > This is occurring only on the M1 imac where despite having the right profile > we see "off by 1/255" errors sometimes. So why do we need a color tolerance > of 25 ? Why isn't it 1 ? It was there from start so did not tinker although I tested

Re: RFR: 8284888 : [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "NimbusLookAndFeel] : ERROR: icon and imageIcon not same." [v2]

2022-05-04 Thread Prasanta Sadhukhan
me undecorated and remove unneeded library being built. > Several iterations of the test passed in the same system (where it used to > fail 4/10) along with other platforms (link in JBS) Prasanta Sadhukhan has updated the pull request incrementally with one additional commit si

Re: RFR: 8134640 ( Left Insets Margin Test ) moved to open repo from closed [v2]

2022-05-04 Thread Prasanta Sadhukhan
On Wed, 4 May 2022 05:55:16 GMT, Tejesh R wrote: >> The Test had been updated to use all Supported Look and Feel in closed repo. >> The same has been moved to open repo. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Copyrigh

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v2]

2022-05-03 Thread Prasanta Sadhukhan
On Mon, 2 May 2022 03:21:25 GMT, Tejesh R wrote: >> In Button ToolTip, Mnemonic key string was shown only in Metal Look and >> Feel, since the feature is implemented in it. In other L&F especially >> Windows L&F the feature is not available. In order to make it available for >> other L&F's, th

RFR: 8285962: NimbusDefaults has a typo in a L&F property

2022-05-02 Thread Prasanta Sadhukhan
BasicLookAndFeel, BasicProgressBarUI, GTKLookAndFeel tries to find property by "ProgressBar.verticalSize" but the property defined in NimbusDefaults has a typo "vertictalSize ". Rectified the typo. - Commit messages: - 8285962: NimbusDefaults has a typo in a L&F property Changes:

Re: RFR: 8134640 ( Left Insets Margin Test ) moved to open repo from closed [v2]

2022-05-02 Thread Prasanta Sadhukhan
On Mon, 2 May 2022 08:23:15 GMT, Tejesh R wrote: >> The Test had been updated to use all Supported Look and Feel in closed repo. >> The same has been moved to open repo. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Copyrigh

Re: RFR: 8285397: JNI exception pending in CUPSfuncs.c:250

2022-05-02 Thread Prasanta Sadhukhan
On Sun, 1 May 2022 19:31:01 GMT, Phil Race wrote: > A tool checking for JNI errors complains that the call to > JNU_NewStringPlatform(..) > might throw an exception and subsequent JNI code isn't making sure of that. > Clear the exception so the error handling code can do its thing. src/java.des

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v2]

2022-05-01 Thread Prasanta Sadhukhan
On Mon, 2 May 2022 03:21:25 GMT, Tejesh R wrote: >> In Button ToolTip, Mnemonic key string was shown only in Metal Look and >> Feel, since the feature is implemented in it. In other L&F especially >> Windows L&F the feature is not available. In order to make it available for >> other L&F's, th

Re: RFR: 8285094: Test java/awt/Frame/InvisibleOwner/InvisibleOwner.java failing on Linux [v2]

2022-04-28 Thread Prasanta Sadhukhan
On Thu, 21 Apr 2022 15:23:31 GMT, Phil Race wrote: >> As discussed in https://bugs.openjdk.java.net/browse/JDK-8285094 it seems >> that the test >> java/awt/Frame/GetGraphicsStressTest/GetGraphicsStressTest.java destabilises >> the Xserver. >> This causes java/awt/Frame/InvisibleOwner/Invisible

Re: RFR: 8213531: Test javax/swing/border/TestTitledBorderLeak.java fails [v2]

2022-04-28 Thread Prasanta Sadhukhan
and also it can still be used as 8204963 regression test as it still fails > without the fix and pass with it. Modified test has passed in all platforms > for several iterations. > > Also removed the deprecated `System.runFinalization` Prasanta Sadhukhan has updated the pull request in

RFR: 8213531: Test javax/swing/border/TestTitledBorderLeak.java fails

2022-04-28 Thread Prasanta Sadhukhan
Test was failing in linux citing `java.lang.RuntimeException: Expected Total TitledBorder to be freed : 10 Freed 9 ` As per the fix done in JDK-8204963 http://hg.openjdk.java.net/jdk/jdk/rev/cd7d2f9154fd there was no platform specific code done for the fix and logs in `TitledBorder.installProper

Re: RFR: 8276266: Clean up incorrect client-libs ProblemList.txt entries

2022-04-27 Thread Prasanta Sadhukhan
On Tue, 2 Nov 2021 16:10:43 GMT, Phil Race wrote: > > I am not sure why the macOS-specific JDK-8203047 was closed as a duplicate > > of x11 specific JDK-8072110? > > The HandleExceptionOnEDT from the JDK-8203047 is not even mentioned in the > > JDK-8072110. > > I don't know. This was done by @

Re: RFR: 8285617 : Fix java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java manual test

2022-04-27 Thread Prasanta Sadhukhan
On Tue, 26 Apr 2022 01:44:45 GMT, lawrence.andrews wrote: > 1) Removed yesno since test was failing with parser error due to @run > main/manual=yesno > 2) User can't decide whether it as pass or fail after looking into the > printout so add the PassFailJFrame support > > @shurymury > @aivan

Re: RFR: 8284888 : [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "NimbusLookAndFeel] : ERROR: icon and imageIcon not same."

2022-04-27 Thread Prasanta Sadhukhan
On Wed, 27 Apr 2022 07:11:28 GMT, Sergey Bylokhov wrote: > > The bug is made public. The images looks alike visually. I could not find > > anything wrong with rendering or robot which otherwise could have caused > > issue in other systems and platforms but it's only failing in this CI > > syst

Integrated: 8208565: [TEST_BUG] javax\swing\PopupFactory\6276087\NonOpaquePopupMenuTest.java throws NPE

2022-04-27 Thread Prasanta Sadhukhan
On Mon, 18 Apr 2022 07:11:45 GMT, Prasanta Sadhukhan wrote: > Test was failing in the past owing to NPE while accessing JMenu probably > owing to fact the test did not wait for UI to be visible before starting the > test, so added a delay after the frame is made visible. Also, added

Re: RFR: 7124282: [macosx] Can't see table cell highlighter when the highlight border is the same color as the cell. [v13]

2022-04-26 Thread Prasanta Sadhukhan
On Wed, 27 Apr 2022 04:36:27 GMT, Harshitha Onkar wrote: >> Previously while tabbing through the JTable cell, the cell highlighter/focus >> ring was not visible against the selection background. >> >> Changes are made to Aqua LAF to derive a lighter focus ring color by >> changing saturation

Re: RFR: 7124282: [macosx] Can't see table cell highlighter when the highlight border is the same color as the cell. [v11]

2022-04-25 Thread Prasanta Sadhukhan
On Tue, 12 Apr 2022 00:22:31 GMT, Harshitha Onkar wrote: >> Previously while tabbing through the JTable cell, the cell highlighter/focus >> ring was not visible against the selection background. >> >> Changes are made to Aqua LAF to derive a lighter focus ring color by >> changing saturation

Re: RFR: 7080150: [TEST_BUG][macosx] No mac os x EmbeddedFrame support in regression regtesthelpers [v2]

2022-04-25 Thread Prasanta Sadhukhan
On Mon, 25 Apr 2022 17:20:39 GMT, Alisen Chung wrote: >> Are you sure that CEmbeddedFrame is used in the embedding functionality? We >> have another one on macOS CViewEmbeddedFrame. One of them was used for >> applets another one was used by the JAWT and SWT. Please double-check that >> the co

Re: RFR: 8208565: [TEST_BUG] javax\swing\PopupFactory\6276087\NonOpaquePopupMenuTest.java throws NPE

2022-04-25 Thread Prasanta Sadhukhan
On Mon, 18 Apr 2022 07:11:45 GMT, Prasanta Sadhukhan wrote: > Test was failing in the past owing to NPE while accessing JMenu probably > owing to fact the test did not wait for UI to be visible before starting the > test, so added a delay after the frame is made visible. Also, added

Re: RFR: 8284888 : [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "NimbusLookAndFeel] : ERROR: icon and imageIcon not same."

2022-04-25 Thread Prasanta Sadhukhan
On Mon, 25 Apr 2022 09:37:10 GMT, Prasanta Sadhukhan wrote: > Test used to fail in specific CI macos M1 system owing to miniscule color > difference > > > x 0 y 0 red1 171 red2 171 green1 174 green2 175 blue1 184 blue2 184 > x 0 y 1 red1 172 red2 173 green1 177 green2 1

RFR: 8284888 : [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java failed with "NimbusLookAndFeel] : ERROR: icon and imageIcon not same."

2022-04-25 Thread Prasanta Sadhukhan
Test used to fail in specific CI macos M1 system owing to miniscule color difference x 0 y 0 red1 171 red2 171 green1 174 green2 175 blue1 184 blue2 184 x 0 y 1 red1 172 red2 173 green1 177 green2 177 blue1 185 blue2 185 x 0 y 2 red1 173 red2 174 green1 177 green2 178 blue1 187 blue2 187 x 0 y

  1   2   3   4   5   >