Re: RFR: 8284767: Create an automated test for JDK-4422535 [v3]

2022-06-09 Thread Srinivas Mandalika
On Wed, 18 May 2022 08:37:03 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4422535](https://bugs.openjdk.java.net/browse/JDK-4422535) >> AccessibleValue implementation only accept Integers >> The AccessibleValue implementations of

Re: RFR: 8284524: Create an automated test for JDK-4422362 [v3]

2022-06-09 Thread Srinivas Mandalika
On Wed, 18 May 2022 08:38:49 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4422362](https://bugs.openjdk.java.net/browse/JDK-4422362) >> >> The BoundedRangeModel components (JScrollBar, JSlider, JProgressBar) return >> Bound

Re: RFR: JDK-8282777: Create a Regression test for JDK-4515031 [v4]

2022-06-09 Thread Srinivas Mandalika
On Mon, 23 May 2022 17:11:24 GMT, Alexander Zuev wrote: >> Srinivas Mandalika has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review Comments Fixed: Fixed File location path. > >

Re: RFR: 8286172: Create an automated test for JDK-4516019 [v2]

2022-06-09 Thread Srinivas Mandalika
On Mon, 23 May 2022 17:20:38 GMT, Alisen Chung wrote: >> Srinivas Mandalika has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Review comments fixed: Fixed file path, removed redundant sleep call etc. >> -

Re: RFR: 8286172: Create an automated test for JDK-4516019 [v4]

2022-06-09 Thread Srinivas Mandalika
t; > This review is for migrating tests from a closed test suite to open. > > Testing: > The test ran successfully on Mach5 with multiple runs (30) on windows-x64, > linux-x64 and macos-x64. Srinivas Mandalika has updated the pull request incrementally with one additional commit sinc

Re: RFR: 8286172: Create an automated test for JDK-4516019 [v3]

2022-06-09 Thread Srinivas Mandalika
t; > This review is for migrating tests from a closed test suite to open. > > Testing: > The test ran successfully on Mach5 with multiple runs (30) on windows-x64, > linux-x64 and macos-x64. Srinivas Mandalika has updated the pull request incrementally with one additional commit sinc

Integrated: 8285305: Create an automated test for JDK-4495286

2022-06-03 Thread Srinivas Mandalika
On Thu, 21 Apr 2022 10:51:18 GMT, Srinivas Mandalika wrote: > Create an automated test for > [JDK-4495286](https://bugs.openjdk.java.net/browse/JDK-4495286) > > AccessibleJTable.setAccessibleSelction should select rows/cols when cell > selection. > When cell selection is

Integrated: 8285373: Create an automated test for JDK-4702233

2022-06-03 Thread Srinivas Mandalika
On Thu, 21 Apr 2022 15:54:02 GMT, Srinivas Mandalika wrote: > Create an automated test for > [JDK-4702233](https://bugs.openjdk.java.net/browse/JDK-4702233) > > Several new AccessibleRole and AccessibleRelation constants are needed in > those classes in the java.accessibility

Re: RFR: JDK-8282777: Create a Regression test for JDK-4515031 [v6]

2022-06-02 Thread Srinivas Mandalika
g tests from a closed test suite to open. Srinivas Mandalika has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revisi

Re: RFR: JDK-8282777: Create a Regression test for JDK-4515031 [v5]

2022-06-02 Thread Srinivas Mandalika
g tests from a closed test suite to open. Srinivas Mandalika has updated the pull request incrementally with one additional commit since the last revision: Review comment fixed: removed redundant rbot code. - Changes: - all: https://git.openjdk.java.net/jdk/pull/7738

Re: RFR: 8285373: Create an automated test for JDK-4702233 [v2]

2022-06-01 Thread Srinivas Mandalika
On Fri, 29 Apr 2022 14:11:41 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4702233](https://bugs.openjdk.java.net/browse/JDK-4702233) >> >> Several new AccessibleRole and AccessibleRelation constants are needed in >> those classes in

Re: RFR: 8284767: Create an automated test for JDK-4422535 [v3]

2022-06-01 Thread Srinivas Mandalika
On Wed, 18 May 2022 08:37:03 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4422535](https://bugs.openjdk.java.net/browse/JDK-4422535) >> AccessibleValue implementation only accept Integers >> The AccessibleValue implementations of

Re: RFR: 8284524: Create an automated test for JDK-4422362 [v3]

2022-06-01 Thread Srinivas Mandalika
On Wed, 18 May 2022 08:38:49 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4422362](https://bugs.openjdk.java.net/browse/JDK-4422362) >> >> The BoundedRangeModel components (JScrollBar, JSlider, JProgressBar) return >> Bound

Re: RFR: 8285305: Create an automated test for JDK-4495286 [v3]

2022-06-01 Thread Srinivas Mandalika
On Wed, 18 May 2022 08:20:47 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4495286](https://bugs.openjdk.java.net/browse/JDK-4495286) >> >> AccessibleJTable.setAccessibleSelction should select rows/cols when cell >> selection. >>

Integrated: JDK-8282778: Create a regression test for JDK-4699544

2022-05-31 Thread Srinivas Mandalika
On Tue, 8 Mar 2022 08:26:11 GMT, Srinivas Mandalika wrote: > Create a regression test for JDK-4699544 > > The subclass of javax.swing.JRootPane (AccessibleJRootPane) that implements > the accessibility interface javax.accessibility.AccessibleComponent is &g

Integrated: 8282857: Create a regression test for JDK-4702690

2022-05-31 Thread Srinivas Mandalika
On Wed, 9 Mar 2022 08:13:55 GMT, Srinivas Mandalika wrote: > Create a regression test for > [JDK-4702690](https://bugs.openjdk.java.net/browse/JDK-4702690) > > In many cases in Swing it is possible to easily programatically determine > that a JScrollBar (or two) is scrolling s

Re: RFR: JDK-8282777: Create a Regression test for JDK-4515031 [v4]

2022-05-18 Thread Srinivas Mandalika
g tests from a closed test suite to open. Srinivas Mandalika has updated the pull request incrementally with one additional commit since the last revision: Review Comments Fixed: Fixed File location path. - Changes: - all: https://git.openjdk.java.net/jdk/pull/7738

Re: RFR: JDK-8282778: Create a regression test for JDK-4699544 [v5]

2022-05-18 Thread Srinivas Mandalika
ssibleAt() because a component does not necessarily have childs. > > The root pane always has a content pane child, so getAccessibleAt() should be > overwritten by AccessibleJRootPane appropriately. > The test added verifies the same. > This review is for migrating tests from a clo

Re: RFR: 8284524: Create an automated test for JDK-4422362 [v3]

2022-05-18 Thread Srinivas Mandalika
> The test ran successfully on Mach5 with multiple runs (30) on windows-x64, > linux-x64 and macos-x64. Srinivas Mandalika has updated the pull request incrementally with one additional commit since the last revision: Review Comments Fixed: Fixed File location path. - Ch

Re: RFR: 8284767: Create an automated test for JDK-4422535 [v3]

2022-05-18 Thread Srinivas Mandalika
t; his review is for migrating tests from a closed test suite to open. > > Testing: > The test ran successfully on Mach5 with multiple runs (30) on windows-x64, > linux-x64 and macos-x64. Srinivas Mandalika has updated the pull request incrementally with one additional c

Re: RFR: 8285305: Create an automated test for JDK-4495286 [v3]

2022-05-18 Thread Srinivas Mandalika
roposed test verifies that the above behavior is fixed. > > This review is for migrating tests from a closed test suite to open. > > Testing: > The test ran successfully on Mach5 with multiple runs (40) on windows-x64, > linux-x64 and macos-x64. Srinivas Mandalika has updat

Re: RFR: 8285305: Create an automated test for JDK-4495286 [v2]

2022-05-18 Thread Srinivas Mandalika
On Wed, 27 Apr 2022 08:08:32 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4495286](https://bugs.openjdk.java.net/browse/JDK-4495286) >> >> AccessibleJTable.setAccessibleSelction should select rows/cols when cell >> selection. >>

Re: RFR: 8285305: Create an automated test for JDK-4495286 [v2]

2022-05-18 Thread Srinivas Mandalika
On Thu, 5 May 2022 23:58:01 GMT, Phil Race wrote: > Get rid of the useless extra directory level Done. - PR: https://git.openjdk.java.net/jdk/pull/8333

Re: RFR: 8282857: Create a regression test for JDK-4702690 [v4]

2022-05-17 Thread Srinivas Mandalika
On Tue, 17 May 2022 12:33:43 GMT, Srinivas Mandalika wrote: >> Create a regression test for >> [JDK-4702690](https://bugs.openjdk.java.net/browse/JDK-4702690) >> >> In many cases in Swing it is possible to easily programatically determine >> that a JScroll

Re: RFR: 8286172: Create an automated test for JDK-4516019 [v2]

2022-05-17 Thread Srinivas Mandalika
t; > This review is for migrating tests from a closed test suite to open. > > Testing: > The test ran successfully on Mach5 with multiple runs (30) on windows-x64, > linux-x64 and macos-x64. Srinivas Mandalika has updated the pull request incrementally with two additional comm

Re: RFR: 8282857: Create a regression test for JDK-4702690 [v4]

2022-05-17 Thread Srinivas Mandalika
Pane and JScrollBar. > This review is for migrating tests from a closed test suite to open. Srinivas Mandalika has updated the pull request incrementally with two additional commits since the last revision: - Review comments fixed: Added Test without 'bug id' folder structure

Re: RFR: 8286172: Create an automated test for JDK-4516019

2022-05-17 Thread Srinivas Mandalika
On Thu, 5 May 2022 23:55:42 GMT, Phil Race wrote: > Also you are doing the same thing I've told others not to - look at the path > name > > test/jdk/javax/swing/4516019/JSpinnerFocusTest.java > > what is the point of 4516019 ? Do NOT create an extra directory for no > reason. especially one j

RFR: 8286172: Create an automated test for JDK-4516019

2022-05-05 Thread Srinivas Mandalika
Create an automated test for [JDK-4516019](https://bugs.openjdk.java.net/browse/JDK-4516019) Clicking on the increment/decrement buttons of the spinner does not install focus on the spinner or one of its focusable children. The test validates the same. This review is for migrating tests from a

Integrated: 8285693: Create an automated test for JDK-4702199

2022-05-04 Thread Srinivas Mandalika
On Wed, 27 Apr 2022 07:54:18 GMT, Srinivas Mandalika wrote: > reate an automated test for > [JDK-4702199](https://bugs.openjdk.java.net/browse/JDK-4702199) > > In order for spatial Braille to work and screen reader "review mode", we need > bounding rectangle inform

Re: RFR: 8285693: Create an automated test for JDK-4702199

2022-05-01 Thread Srinivas Mandalika
On Fri, 29 Apr 2022 00:40:02 GMT, Sergey Bylokhov wrote: >> reate an automated test for >> [JDK-4702199](https://bugs.openjdk.java.net/browse/JDK-4702199) >> >> In order for spatial Braille to work and screen reader "review mode", we >> need bounding rectangle information for all text on the s

Re: RFR: 8285373: Create an automated test for JDK-4702233 [v2]

2022-05-01 Thread Srinivas Mandalika
On Fri, 29 Apr 2022 14:11:41 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4702233](https://bugs.openjdk.java.net/browse/JDK-4702233) >> >> Several new AccessibleRole and AccessibleRelation constants are needed in >> those classes in

Re: RFR: 8284767: Create an automated test for JDK-4422535 [v2]

2022-05-01 Thread Srinivas Mandalika
On Tue, 26 Apr 2022 09:28:28 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4422535](https://bugs.openjdk.java.net/browse/JDK-4422535) >> AccessibleValue implementation only accept Integers >> The AccessibleValue implementations of

Re: RFR: 8284524: Create an automated test for JDK-4422362 [v2]

2022-05-01 Thread Srinivas Mandalika
On Tue, 12 Apr 2022 09:19:33 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4422362](https://bugs.openjdk.java.net/browse/JDK-4422362) >> >> The BoundedRangeModel components (JScrollBar, JSlider, JProgressBar) return >> Bound

Re: RFR: 8285373: Create an automated test for JDK-4702233 [v2]

2022-04-29 Thread Srinivas Mandalika
above AccessibleConstants. > > This review is for migrating tests from a closed test suite to open. > > Testing: > The test ran successfully on Mach5 with multiple runs (30) on windows-x64, > linux-x64 and macos-x64. Srinivas Mandalika has updated the pull request increment

Integrated: 8284077: Create an automated test for JDK-4170173

2022-04-27 Thread Srinivas Mandalika
On Thu, 7 Apr 2022 07:40:18 GMT, Srinivas Mandalika wrote: > Create an automated test for > [JDK-4170173](https://bugs.openjdk.java.net/browse/JDK-4170173) > > Issue > JTextComponent.AccessibleJTextComponent.getAfterIndex(int part, int index) > works incorrectly, when &

Integrated: JDK-8282933: Create a test for JDK-4529616

2022-04-27 Thread Srinivas Mandalika
On Fri, 11 Mar 2022 06:30:04 GMT, Srinivas Mandalika wrote: > JDK-8282933: Create a test for JDK-4529616 > AccessibleJTableCell.isShowing() returns false when the cell is actually on > the screen. > The test validates the fix for the above issue by verifying that the > isShowi

Re: RFR: JDK-8282933: Create a test for JDK-4529616 [v4]

2022-04-27 Thread Srinivas Mandalika
On Thu, 7 Apr 2022 07:02:18 GMT, Srinivas Mandalika wrote: >> JDK-8282933: Create a test for JDK-4529616 >> AccessibleJTableCell.isShowing() returns false when the cell is actually on >> the screen. >> The test validates the fix for the above issue by verifying tha

Re: RFR: 8282857: Create a regression test for JDK-4702690 [v3]

2022-04-27 Thread Srinivas Mandalika
On Wed, 6 Apr 2022 07:02:25 GMT, Srinivas Mandalika wrote: >> Create a regression test for >> [JDK-4702690](https://bugs.openjdk.java.net/browse/JDK-4702690) >> >> In many cases in Swing it is possible to easily programatically determine >> that a JScrollBar (or

Re: RFR: JDK-8282777: Create a Regression test for JDK-4515031 [v3]

2022-04-27 Thread Srinivas Mandalika
On Wed, 30 Mar 2022 10:05:22 GMT, Srinivas Mandalika wrote: >> Create a Regression test for >> [JDK-4515031](https://bugs.openjdk.java.net/browse/JDK-4515031) >> >> The issue indicates the need for a a getAccessibleDescription being >> implemented for the J

Re: RFR: JDK-8282778: Create a regression test for JDK-4699544 [v4]

2022-04-27 Thread Srinivas Mandalika
On Tue, 12 Apr 2022 09:05:56 GMT, Srinivas Mandalika wrote: >> Create a regression test for JDK-4699544 >> >> The subclass of javax.swing.JRootPane (AccessibleJRootPane) that implements >> the accessibility interface javax.accessibility.AccessibleCompo

Re: RFR: 8285305: Create an automated test for JDK-4495286 [v2]

2022-04-27 Thread Srinivas Mandalika
On Wed, 27 Apr 2022 07:13:24 GMT, Sergey Bylokhov wrote: >> Srinivas Mandalika has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review comments fixed: Typo in Copyright Header > > test/j

Re: RFR: JDK-8282777: Create a Regression test for JDK-4515031 [v3]

2022-04-27 Thread Srinivas Mandalika
On Wed, 30 Mar 2022 10:05:22 GMT, Srinivas Mandalika wrote: >> Create a Regression test for >> [JDK-4515031](https://bugs.openjdk.java.net/browse/JDK-4515031) >> >> The issue indicates the need for a a getAccessibleDescription being >> implemented for the J

Re: RFR: 8285305: Create an automated test for JDK-4495286 [v2]

2022-04-27 Thread Srinivas Mandalika
roposed test verifies that the above behavior is fixed. > > This review is for migrating tests from a closed test suite to open. > > Testing: > The test ran successfully on Mach5 with multiple runs (40) on windows-x64, > linux-x64 and macos-x64. Srinivas Mandalika has updat

Re: RFR: 8284077: Create an automated test for JDK-4170173 [v2]

2022-04-27 Thread Srinivas Mandalika
On Wed, 27 Apr 2022 07:36:24 GMT, Sergey Bylokhov wrote: >> Srinivas Mandalika has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review Comments Fixed: Simplied test > > Marked as reviewed by serb (Revi

Re: RFR: JDK-8282933: Create a test for JDK-4529616 [v4]

2022-04-27 Thread Srinivas Mandalika
On Wed, 27 Apr 2022 07:41:21 GMT, Sergey Bylokhov wrote: >> Srinivas Mandalika has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8282933: Whitespace issue fixed > > Marked as reviewed by serb (Reviewer).

RFR: 8285693: Create an automated test for JDK-4702199

2022-04-27 Thread Srinivas Mandalika
reate an automated test for [JDK-4702199](https://bugs.openjdk.java.net/browse/JDK-4702199) In order for spatial Braille to work and screen reader "review mode", we need bounding rectangle information for all text on the screen, and also the ability to get text substrings. StarOffice 6.1, Netsc

Re: RFR: 8284767: Create an automated test for JDK-4422535 [v2]

2022-04-26 Thread Srinivas Mandalika
On Fri, 22 Apr 2022 18:02:47 GMT, Alisen Chung wrote: >> Srinivas Mandalika has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review Comments Fixed: Simplified test code with a loop over the >> JCompone

Re: RFR: 8284767: Create an automated test for JDK-4422535 [v2]

2022-04-26 Thread Srinivas Mandalika
t; his review is for migrating tests from a closed test suite to open. > > Testing: > The test ran successfully on Mach5 with multiple runs (30) on windows-x64, > linux-x64 and macos-x64. Srinivas Mandalika has updated the pull request incrementally with one additional commit since t

Re: RFR: 8285305: Create an automated test for JDK-4495286

2022-04-25 Thread Srinivas Mandalika
On Thu, 21 Apr 2022 10:51:18 GMT, Srinivas Mandalika wrote: > Create an automated test for > [JDK-4495286](https://bugs.openjdk.java.net/browse/JDK-4495286) > > AccessibleJTable.setAccessibleSelction should select rows/cols when cell > selection. > When cell selection is

Re: RFR: 8285373: Create an automated test for JDK-4702233

2022-04-25 Thread Srinivas Mandalika
On Thu, 21 Apr 2022 15:54:02 GMT, Srinivas Mandalika wrote: > Create an automated test for > [JDK-4702233](https://bugs.openjdk.java.net/browse/JDK-4702233) > > Several new AccessibleRole and AccessibleRelation constants are needed in > those classes in the java.accessibility

Re: RFR: 8284524: Create an automated test for JDK-4422362 [v2]

2022-04-25 Thread Srinivas Mandalika
On Tue, 12 Apr 2022 09:19:33 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4422362](https://bugs.openjdk.java.net/browse/JDK-4422362) >> >> The BoundedRangeModel components (JScrollBar, JSlider, JProgressBar) return >> Bound

Re: RFR: 8284077: Create an automated test for JDK-4170173 [v2]

2022-04-25 Thread Srinivas Mandalika
On Tue, 12 Apr 2022 06:09:35 GMT, Srinivas Mandalika wrote: >> Create an automated test for >> [JDK-4170173](https://bugs.openjdk.java.net/browse/JDK-4170173) >> >> Issue >> JTextComponent.AccessibleJTextComponent.getAfterIndex(int part, int index) >> work

Re: RFR: JDK-8282777: Create a Regression test for JDK-4515031 [v3]

2022-04-25 Thread Srinivas Mandalika
On Wed, 30 Mar 2022 10:05:22 GMT, Srinivas Mandalika wrote: >> Create a Regression test for >> [JDK-4515031](https://bugs.openjdk.java.net/browse/JDK-4515031) >> >> The issue indicates the need for a a getAccessibleDescription being >> implemented for the J

Re: RFR: JDK-8282933: Create a test for JDK-4529616 [v4]

2022-04-25 Thread Srinivas Mandalika
On Thu, 7 Apr 2022 07:02:18 GMT, Srinivas Mandalika wrote: >> JDK-8282933: Create a test for JDK-4529616 >> AccessibleJTableCell.isShowing() returns false when the cell is actually on >> the screen. >> The test validates the fix for the above issue by verifying tha

Re: RFR: JDK-8282778: Create a regression test for JDK-4699544 [v4]

2022-04-25 Thread Srinivas Mandalika
On Tue, 12 Apr 2022 09:05:56 GMT, Srinivas Mandalika wrote: >> Create a regression test for JDK-4699544 >> >> The subclass of javax.swing.JRootPane (AccessibleJRootPane) that implements >> the accessibility interface javax.accessibility.AccessibleCompo

Re: RFR: 8282857: Create a regression test for JDK-4702690 [v3]

2022-04-25 Thread Srinivas Mandalika
On Wed, 6 Apr 2022 07:02:25 GMT, Srinivas Mandalika wrote: >> Create a regression test for >> [JDK-4702690](https://bugs.openjdk.java.net/browse/JDK-4702690) >> >> In many cases in Swing it is possible to easily programatically determine >> that a JScrollBar (or

RFR: 8285373: Create an automated test for JDK-4702233

2022-04-21 Thread Srinivas Mandalika
Create an automated test for [JDK-4702233](https://bugs.openjdk.java.net/browse/JDK-4702233) Several new AccessibleRole and AccessibleRelation constants are needed in those classes in the java.accessibility package. These new contants codify additions made in the GNOME, Netscape, and UNO (StarO

RFR: 8285305: Create an automated test for JDK-4495286

2022-04-21 Thread Srinivas Mandalika
Create an automated test for [JDK-4495286](https://bugs.openjdk.java.net/browse/JDK-4495286) AccessibleJTable.setAccessibleSelction should select rows/cols when cell selection. When cell selection is not enabled, there is no way, using accessibility, to select rows or columns. It seems logical t

RFR: 8284767: Create an automated test for JDK-4422535

2022-04-13 Thread Srinivas Mandalika
Create an automated test for [JDK-4422535](https://bugs.openjdk.java.net/browse/JDK-4422535) AccessibleValue implementation only accept Integers The AccessibleValue implementations of the following components: java.awt.Scrollbar javax.swing.AbstractButton javax.swing.JInternalFrame javax.swing.JS

Re: RFR: 8284524: Create an automated test for JDK-4422362 [v2]

2022-04-12 Thread Srinivas Mandalika
> The test ran successfully on Mach5 with multiple runs (30) on windows-x64, > linux-x64 and macos-x64. Srinivas Mandalika has updated the pull request incrementally with one additional commit since the last revision: 8284524: Create an automated test for JDK-4422362 - Ch

Re: RFR: JDK-8282778: Create a regression test for JDK-4699544 [v3]

2022-04-12 Thread Srinivas Mandalika
On Tue, 12 Apr 2022 01:26:15 GMT, Sergey Bylokhov wrote: >> Srinivas Mandalika has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review Comments Fixed: Frame on EDT, Line length <= 80 characters > > tes

Re: RFR: JDK-8282778: Create a regression test for JDK-4699544 [v4]

2022-04-12 Thread Srinivas Mandalika
ssibleAt() because a component does not necessarily have childs. > > The root pane always has a content pane child, so getAccessibleAt() should be > overwritten by AccessibleJRootPane appropriately. > The test added verifies the same. > This review is for migrating tests from a clo

Re: RFR: 8284077: Create an automated test for JDK-4170173 [v2]

2022-04-11 Thread Srinivas Mandalika
On Sat, 9 Apr 2022 05:32:02 GMT, Sergey Bylokhov wrote: >> Srinivas Mandalika has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review Comments Fixed: Simplied test > > test/j

Re: RFR: 8284077: Create an automated test for JDK-4170173 [v2]

2022-04-11 Thread Srinivas Mandalika
tional flow of the code > and the functionality they are testing as well - hence they have been clubbed > into a single review. > This review is for migrating tests from a closed test suite to open. > > Testing: > The tests ran successfully on Mach5 with multiple runs (30) on windo

Integrated: 8283245: Create a test for JDK-4670319

2022-04-11 Thread Srinivas Mandalika
On Tue, 29 Mar 2022 08:04:42 GMT, Srinivas Mandalika wrote: > Write an automated regression test for JDK-4670319 > > Issue > When a JTree node is expanded or collapsed, an Accessibility PropertyChange > event is fired with the old state of "collapsed" and new state

Integrated: 8282640: Create a test for JDK-4740761

2022-04-11 Thread Srinivas Mandalika
On Fri, 4 Mar 2022 05:35:38 GMT, Srinivas Mandalika wrote: > Create a test for > [JDK-4740761](https://bugs.openjdk.java.net/browse/JDK-4740761) > > The issue observed is in a JFrame with a JTextField and a JScrollPane which > contains focused component. When the JScrollPane w

Re: RFR: 8283245: Create a test for JDK-4670319 [v2]

2022-04-09 Thread Srinivas Mandalika
On Sat, 9 Apr 2022 05:41:26 GMT, Sergey Bylokhov wrote: >> Srinivas Mandalika has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Review Comments Fixed: 80 characters line fixed, typo in File Name fixed >>

Re: RFR: 8282640: Create a test for JDK-4740761 [v4]

2022-04-09 Thread Srinivas Mandalika
On Sat, 9 Apr 2022 05:43:26 GMT, Sergey Bylokhov wrote: >> Srinivas Mandalika has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review Comment Fixed: Line Length fixed to < 80 characters. > > Mar

RFR: 8284524: Create an automated test for JDK-4422362

2022-04-08 Thread Srinivas Mandalika
Create an automated test for [JDK-4422362](https://bugs.openjdk.java.net/browse/JDK-4422362) The BoundedRangeModel components (JScrollBar, JSlider, JProgressBar) return BoundedRangeModel.getMaximum() from getMaximumAccessibleValue() in their AccessibleValue implementation. The real maximum value

Re: RFR: 8283245: Create a test for JDK-4670319 [v2]

2022-04-07 Thread Srinivas Mandalika
ting: > The test ran successfully on Mach5 with multiple runs (30) on windows-x64, > linux-x64 and macos-x64. Srinivas Mandalika has updated the pull request incrementally with two additional commits since the last revision: - Review Comments Fixed: 80 characters line fixed, typo in File Nam

RFR: 8284077: Create an automated test for JDK-4170173

2022-04-07 Thread Srinivas Mandalika
Create an automated test for [JDK-4170173](https://bugs.openjdk.java.net/browse/JDK-4170173) Issue JTextComponent.AccessibleJTextComponent.getAfterIndex(int part, int index) works incorrectly, when 'part' parameter is AccessibleText.WORD. It returns a space (" ") instead of the correct word. Th

Re: RFR: JDK-8282933: Create a test for JDK-4529616 [v4]

2022-04-07 Thread Srinivas Mandalika
. > This review is for migrating tests from a closed test suite to open. Srinivas Mandalika has updated the pull request incrementally with one additional commit since the last revision: 8282933: Whitespace issue fixed - Changes: - all: https://git.openjdk.java.net/jdk/pull/

Re: RFR: JDK-8282933: Create a test for JDK-4529616 [v3]

2022-04-06 Thread Srinivas Mandalika
. > This review is for migrating tests from a closed test suite to open. Srinivas Mandalika has updated the pull request incrementally with one additional commit since the last revision: JTable access on EDT, 80 chars line - Changes: - all: https://git.openjdk.java.net/j

Re: RFR: 8282857: Create a regression test for JDK-4702690 [v3]

2022-04-06 Thread Srinivas Mandalika
Pane and JScrollBar. > This review is for migrating tests from a closed test suite to open. Srinivas Mandalika has updated the pull request incrementally with two additional commits since the last revision: - Review Comments Fixed: Swing Components on EDT, 80 chars lines - Review C

Integrated: JDK-8282046: Create a regression test for JDK-8000326

2022-03-30 Thread Srinivas Mandalika
On Thu, 17 Feb 2022 09:56:45 GMT, Srinivas Mandalika wrote: > Create a regression test for CCC8000326 > > Issue is identified by > [JDK-8000326](https://bugs.openjdk.java.net/browse/JDK-8000326), which > identifies that after focus moves into JMenuBar, whose focus t

Re: RFR: JDK-8282778: Create a regression test for JDK-4699544 [v2]

2022-03-30 Thread Srinivas Mandalika
On Tue, 29 Mar 2022 22:37:27 GMT, Sergey Bylokhov wrote: >> Srinivas Mandalika has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added @bug keyword > > test/jdk/javax/accessibility/4699544/JRootPaneAccessib

Re: RFR: JDK-8282778: Create a regression test for JDK-4699544 [v3]

2022-03-30 Thread Srinivas Mandalika
ssibleAt() because a component does not necessarily have childs. > > The root pane always has a content pane child, so getAccessibleAt() should be > overwritten by AccessibleJRootPane appropriately. > The test added verifies the same. > This review is for migrating tests from a clo

Re: RFR: 8282640: Create a test for JDK-4740761 [v4]

2022-03-30 Thread Srinivas Mandalika
scroller > of the removed JScrollPane, instead of moving to the TextField. > > The test verifies the same - i.e. it verifies that the removal of the > scrollpane moves the focus to the JTextField present in the JFrame. > This review is for migrating tests from a closed test suite

Re: RFR: JDK-8282777: Create a Regression test for JDK-4515031 [v3]

2022-03-30 Thread Srinivas Mandalika
g tests from a closed test suite to open. Srinivas Mandalika has updated the pull request incrementally with one additional commit since the last revision: Review Comments Fixed: Button on EDT, split long lines, volatile description string - Changes: - all: https://git.openjdk.j

Re: RFR: 8282640: Create a test for JDK-4740761 [v3]

2022-03-29 Thread Srinivas Mandalika
scroller > of the removed JScrollPane, instead of moving to the TextField. > > The test verifies the same - i.e. it verifies that the removal of the > scrollpane moves the focus to the JTextField present in the JFrame. > This review is for migrating tests from a closed test suite

Re: RFR: JDK-8282046: Create a regression test for JDK-8000326 [v2]

2022-03-29 Thread Srinivas Mandalika
On Tue, 22 Mar 2022 13:19:37 GMT, Alexey Ivanov wrote: >> This review is for migrating tests from a closed test suite to open. > >> This review is for migrating tests from a closed test suite to open. > > If you know when the test was first introduced, please update the copyright > year to incl

Integrated: JDK-8283015: Create a test for JDK-4715496

2022-03-29 Thread Srinivas Mandalika
On Fri, 11 Mar 2022 14:17:01 GMT, Srinivas Mandalika wrote: > Create a test for JDK-4715496 > > Issue observed in the above bug is that the > JTable.AccessibleJTableCell.getAccessible name returns the cell instance > string instead of the cell text. > The test is being a

RFR: 8283245: Create a test for JDK-4670319

2022-03-29 Thread Srinivas Mandalika
Write an automated regression test for JDK-4670319 Issue When a JTree node is expanded or collapsed, an Accessibility PropertyChange event is fired with the old state of "collapsed" and new state of "expanded" (or vice versa). The problem is that the source of the event is the AccessibeJTree,

Re: RFR: JDK-8283015: Create a test for JDK-4715496 [v5]

2022-03-24 Thread Srinivas Mandalika
On Thu, 24 Mar 2022 07:54:17 GMT, Sergey Bylokhov wrote: >> Srinivas Mandalika has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review Comment Fixed: JTable accessed on EDT > > Marked as reviewed by ser

Re: RFR: JDK-8282046: Create a regression test for JDK-8000326 [v7]

2022-03-23 Thread Srinivas Mandalika
resolve this, you should call the JMenuBar.setFocusTraversalKeysEnabled(true) > method. > > The test verifies focus traversal for the above described scenario. > This review is for migrating tests from a closed test suite to open. Srinivas Mandalika has updated the pull request incrementally with one additional commi

Re: RFR: JDK-8283015: Create a test for JDK-4715496 [v5]

2022-03-23 Thread Srinivas Mandalika
On Wed, 23 Mar 2022 10:12:26 GMT, Srinivas Mandalika wrote: >> Create a test for JDK-4715496 >> >> Issue observed in the above bug is that the >> JTable.AccessibleJTableCell.getAccessible name returns the cell instance >> string instead of the cell text. >&g

Re: RFR: 8282640: Create a test for JDK-4740761 [v2]

2022-03-23 Thread Srinivas Mandalika
On Fri, 11 Mar 2022 14:44:25 GMT, Srinivas Mandalika wrote: >> Create a test for >> [JDK-4740761](https://bugs.openjdk.java.net/browse/JDK-4740761) >> >> The issue observed is in a JFrame with a JTextField and a JScrollPane which >> contains focused component.

Re: RFR: 8282640: Create a test for JDK-4740761 [v2]

2022-03-23 Thread Srinivas Mandalika
On Thu, 24 Mar 2022 03:29:45 GMT, Phil Race wrote: >> Srinivas Mandalika has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added @bug keyword > > test/jdk/java/awt/Focus/8282640/ScrollPaneFocusBu

Re: RFR: JDK-8283015: Create a test for JDK-4715496 [v5]

2022-03-23 Thread Srinivas Mandalika
ts from a closed test suite to open. Srinivas Mandalika has updated the pull request incrementally with one additional commit since the last revision: Review Comment Fixed: JTable accessed on EDT - Changes: - all: https://git.openjdk.java.net/jdk/pull/7787/files - new: https://git

Re: RFR: JDK-8283015: Create a test for JDK-4715496 [v4]

2022-03-23 Thread Srinivas Mandalika
ts from a closed test suite to open. Srinivas Mandalika has updated the pull request incrementally with one additional commit since the last revision: Review Comment Fixed: JTable accessed on EDT - Changes: - all: https://git.openjdk.java.net/jdk/pull/7787/files - new: https://git

Re: RFR: JDK-8283015: Create a test for JDK-4715496 [v3]

2022-03-23 Thread Srinivas Mandalika
ts from a closed test suite to open. Srinivas Mandalika has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision

Re: RFR: JDK-8282046: Create a regression test for JDK-8000326 [v6]

2022-03-22 Thread Srinivas Mandalika
resolve this, you should call the JMenuBar.setFocusTraversalKeysEnabled(true) > method. > > The test verifies focus traversal for the above described scenario. > This review is for migrating tests from a closed test suite to open. Srinivas Mandalika has updated the pull request incrementally with one additional commi

Integrated: JDK-8283087: Create a test or JDK-4715503

2022-03-22 Thread Srinivas Mandalika
On Mon, 14 Mar 2022 09:28:50 GMT, Srinivas Mandalika wrote: > Create a test or > [JDK-4715503](https://bugs.openjdk.java.net/browse/JDK-4715503) > > The getAccessibleContext method for JTable column header cells returns an > AccessibleContext which cannot get the Bounding Rect

Re: RFR: JDK-8283087: Create a test or JDK-4715503 [v2]

2022-03-21 Thread Srinivas Mandalika
On Tue, 22 Mar 2022 01:26:38 GMT, Sergey Bylokhov wrote: >> @mrserb Can you please sponsor my changes? > > @srmandal please confirm that the test works fine in the mach5. @mrserb Yes The test ran successfully on Mach5 with multiple runs (30) on windows-x64, linux-x64 and macos-x64. ---

Re: RFR: JDK-8282046: Create a regression test for JDK-8000326 [v5]

2022-03-17 Thread Srinivas Mandalika
resolve this, you should call the JMenuBar.setFocusTraversalKeysEnabled(true) > method. > > The test verifies focus traversal for the above described scenario. > This review is for migrating tests from a closed test suite to open. Srinivas Mandalika has updated the pull request incrementally with one additional commi

Re: RFR: JDK-8282046: Create a regression test for JDK-8000326 [v3]

2022-03-17 Thread Srinivas Mandalika
On Wed, 16 Mar 2022 14:47:48 GMT, Alexey Ivanov wrote: > You copied the test into the new folder but the old folder still remains. You > have to remove it. We don't want two identical tests in different locations. I have now deleted the duplicate file. - PR: https://git.openjdk.ja

Re: RFR: JDK-8282046: Create a regression test for JDK-8000326 [v4]

2022-03-17 Thread Srinivas Mandalika
resolve this, you should call the JMenuBar.setFocusTraversalKeysEnabled(true) > method. > > The test verifies focus traversal for the above described scenario. > This review is for migrating tests from a closed test suite to open. Srinivas Mandalika has updated the pull request incrementally with one additional comm

Re: RFR: JDK-8282046: Create a regression test for JDK-8000326 [v3]

2022-03-17 Thread Srinivas Mandalika
On Fri, 11 Mar 2022 14:38:28 GMT, Srinivas Mandalika wrote: >> Create a regression test for CCC8000326 >> >> Issue is identified by >> [JDK-8000326](https://bugs.openjdk.java.net/browse/JDK-8000326), which >> identifies that after focus moves into JMenuBar, wh

Re: RFR: JDK-8283087: Create a test or JDK-4715503 [v2]

2022-03-16 Thread Srinivas Mandalika
On Wed, 16 Mar 2022 20:12:55 GMT, Sergey Bylokhov wrote: >> Srinivas Mandalika has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review comments fixed: null check added for Bounding Rectangles Returned. > &

Re: RFR: JDK-8283087: Create a test or JDK-4715503 [v2]

2022-03-16 Thread Srinivas Mandalika
On Wed, 16 Mar 2022 06:00:10 GMT, Sergey Bylokhov wrote: >> Srinivas Mandalika has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review comments fixed: null check added for Bounding Rectangles Returned. > >

  1   2   >