Re: RFR: 8284619: javax/swing/JTable/8236907/LastVisibleRow.java failed with "Test Case Failed!!, Last Row not Visible!!!"

2022-06-13 Thread Tejesh R
On Mon, 13 Jun 2022 22:59:41 GMT, Harshitha Onkar wrote: > In getCellClickPoint() method, you could simplify the code by returning point > variable , instead of using extra result variable. > > https://github.com/openjdk/jdk/blob/8722b1b020f30d54e2eab2122c2b1777a6e5182a/test/jdk/javax/swing/JTa

Re: RFR: 8284619: javax/swing/JTable/8236907/LastVisibleRow.java failed with "Test Case Failed!!, Last Row not Visible!!!" [v2]

2022-06-13 Thread Tejesh R
reduce for > ubuntu failure and Delay is added between ClearSelection of focus and Image > Capture for macos failure Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Updated based on review comments - Changes: - all

Re: RFR: 8284619: javax/swing/JTable/8236907/LastVisibleRow.java failed with "Test Case Failed!!, Last Row not Visible!!!"

2022-06-13 Thread Tejesh R
On Tue, 14 Jun 2022 00:20:18 GMT, Harshitha Onkar wrote: > If the test criteria is to check if the last row is visible, then the > following suggestion might help to make the test more stable on different > platforms. > > This is similar to one of the issues I'm working on and > @[azuev-java]

Re: RFR: 8284619: javax/swing/JTable/8236907/LastVisibleRow.java failed with "Test Case Failed!!, Last Row not Visible!!!"

2022-06-13 Thread Tejesh R
On Mon, 13 Jun 2022 22:35:41 GMT, Harshitha Onkar wrote: >> Fix history - #7422. >> The test is automatic and check if the last row is painted (Which was not >> happening before the fix, the last row appeared only after MouseClick >> operation) by capturing the last row before and after MouseCl

Re: RFR: 8284619: javax/swing/JTable/8236907/LastVisibleRow.java failed with "Test Case Failed!!, Last Row not Visible!!!"

2022-06-10 Thread Tejesh R
On Fri, 10 Jun 2022 09:15:15 GMT, Prasanta Sadhukhan wrote: > > > Was there any reason of calling table.setFocusable(false) in > > > clearSelect()? We have some focus related mach5 issues in macos that > > > crops out intermittently so maybe we should get rid of that if it's not > > > needed.

Re: RFR: 8284619: javax/swing/JTable/8236907/LastVisibleRow.java failed with "Test Case Failed!!, Last Row not Visible!!!"

2022-06-10 Thread Tejesh R
On Fri, 10 Jun 2022 07:50:42 GMT, Prasanta Sadhukhan wrote: > Was there any reason of calling table.setFocusable(false) in clearSelect()? > We have some focus related mach5 issues in macos that crops out > intermittently so maybe we should get rid of that if it's not needed. I think > just ca

RFR: 8284619: javax/swing/JTable/8236907/LastVisibleRow.java failed with "Test Case Failed!!, Last Row not Visible!!!"

2022-06-09 Thread Tejesh R
Fix history - #7422. The test is automatic and check if the last row is painted (Which was not happening before the fix, the last row appeared only after MouseClick operation) by capturing the last row before and after MouseClick Operation.If the both the captured images are same, then the test

client-libs-dev@openjdk.java.net

2022-06-09 Thread Tejesh R
On Mon, 23 May 2022 07:03:03 GMT, Tejesh R wrote: > _Header_ object not initialized/set when paint() method of > `WindowTableHeaderUI` class is executed. The paint() event is executed > through explicit call of `JTable.updateUI()` in the regression test. In order > to set the _he

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v12]

2022-06-08 Thread Tejesh R
s set in the > `getTableCellRendererComponent()` method, which in turn makes the _header_ > object available during paint event without causing NPE. Tejesh R has updated the pull request incrementally with two additional commits since the last revision: - Updated Copyright - Revertin

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v11]

2022-06-08 Thread Tejesh R
s set in the > `getTableCellRendererComponent()` method, which in turn makes the _header_ > object available during paint event without causing NPE. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Updated based on review comments -

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v10]

2022-06-08 Thread Tejesh R
On Wed, 8 Jun 2022 11:23:49 GMT, Alexey Ivanov wrote: > > > Looks good now. > > > Please update the copyright year WindowsTableHeaderUI and optionally > > > organise imports. > > > > > > Copyright year...? > > Yes, currently the first line in `WindowsTableHeaderUI.java`: “Copyright (c) >

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v10]

2022-06-08 Thread Tejesh R
On Wed, 8 Jun 2022 11:18:00 GMT, Alexey Ivanov wrote: > Looks good now. > > Please update the copyright year WindowsTableHeaderUI and optionally organise > imports. Copyright year...? It's supposed to be 2022 only right...? - PR: https://git.openjdk.java.net/jdk/pull/8830

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v10]

2022-06-08 Thread Tejesh R
s set in the > `getTableCellRendererComponent()` method, which in turn makes the _header_ > object available during paint event without causing NPE. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Updated based on review comments -

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v9]

2022-06-08 Thread Tejesh R
On Wed, 8 Jun 2022 10:12:45 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated for multiple LookAndFeel > > test/jdk/javax/swing/JTableHeader/TableHeaderRende

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v9]

2022-06-08 Thread Tejesh R
s set in the > `getTableCellRendererComponent()` method, which in turn makes the _header_ > object available during paint event without causing NPE. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Updated for multiple LookAndFeel -

Integrated: 8286620: Create regression test for verifying setMargin() of JRadioButton

2022-06-07 Thread Tejesh R
On Mon, 16 May 2022 06:45:04 GMT, Tejesh R wrote: > Added test for checking setMargin() of JRadioButton. This pull request has now been integrated. Changeset: 67f1bd7f Author: Tejesh R Committer: Alexey Ivanov URL: https://git.openjdk.java.net/jdk/com

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v10]

2022-06-07 Thread Tejesh R
On Tue, 7 Jun 2022 12:27:51 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > test/jdk/javax/swing/JRadioButton/bug

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v11]

2022-06-07 Thread Tejesh R
> Added test for checking setMargin() of JRadioButton. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Updated based on review comments - Changes: - all: https://git.openjdk.java.net/jdk/pull/8721/files - new: ht

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v8]

2022-06-07 Thread Tejesh R
On Tue, 7 Jun 2022 12:44:43 GMT, Alexey Ivanov wrote: > It looks good now. > > What's left is to ensure it passes when run headless. It should just work on > Windows. > > Can we address @mrserb's concern and extend the test be run on other > platforms and with all L&Fs? Yeah sure. -

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v7]

2022-06-07 Thread Tejesh R
On Tue, 7 Jun 2022 11:42:38 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > test/jdk/javax/swing/JTableHeader/TableRende

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v8]

2022-06-07 Thread Tejesh R
s set in the > `getTableCellRendererComponent()` method, which in turn makes the _header_ > object available during paint event without causing NPE. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Updated based on review comments and

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v9]

2022-06-07 Thread Tejesh R
On Tue, 7 Jun 2022 11:11:24 GMT, Alexey Ivanov wrote: >> I think it wouldn't make any difference calling static methods via an >> instance variable or directly with class name. > > Yes, the same method would be called. Yet the difference is in the semantics: > the instance variable isn't used w

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v9]

2022-06-07 Thread Tejesh R
On Tue, 7 Jun 2022 10:46:15 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > test/jdk/javax/swing/JRadioButton/bug4380543.java line

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v10]

2022-06-07 Thread Tejesh R
> Added test for checking setMargin() of JRadioButton. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Updated based on review comments - Changes: - all: https://git.openjdk.java.net/jdk/pull/8721/files - new: ht

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v9]

2022-06-07 Thread Tejesh R
On Tue, 7 Jun 2022 10:47:25 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated based on review comments > > test/jdk/javax/swing/JRadioButton/bug

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v7]

2022-06-05 Thread Tejesh R
s set in the > `getTableCellRendererComponent()` method, which in turn makes the _header_ > object available during paint event without causing NPE. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Updated based on review comments -

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v9]

2022-06-05 Thread Tejesh R
> Added test for checking setMargin() of JRadioButton. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Updated based on review comments - Changes: - all: https://git.openjdk.java.net/jdk/pull/8721/files - new: ht

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v7]

2022-06-05 Thread Tejesh R
On Fri, 3 Jun 2022 18:48:51 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed whitespaces > > test/jdk/javax/swing/JRadioButton/bug4380543.java line 59: > >

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v8]

2022-06-05 Thread Tejesh R
> Added test for checking setMargin() of JRadioButton. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Updated based on review comments - Changes: - all: https://git.openjdk.java.net/jdk/pull/8721/files - new: ht

Re: RFR: 8286772: java/awt/dnd/DropTargetInInternalFrameTest/DropTargetInInternalFrameTest.html times out and fails in Windows [v2]

2022-06-03 Thread Tejesh R
On Thu, 2 Jun 2022 08:11:20 GMT, Manukumar V S wrote: >> test/jdk/java/awt/dnd/DropTargetInInternalFrameTest.java line 244: >> >>> 242: private final Dimension preferredDimension = new >>> Dimension(200, 100); >>> 243: private final CountDownLatch dropLatch; >>> 244: pri

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v6]

2022-06-03 Thread Tejesh R
s set in the > `getTableCellRendererComponent()` method, which in turn makes the _header_ > object available during paint event without causing NPE. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Simplified the Test - Chang

Integrated: 8233477: : [Win LAF]The tooltip doesn't display correctly in Win LAF

2022-06-03 Thread Tejesh R
On Tue, 31 May 2022 08:14:14 GMT, Tejesh R wrote: > The tooltip displays accelerated string along with the toooltip string. The > feature is implemented and applicable for Metal Look and Feel only. Hence the > test is updated for Metal Look and Feel by hard wiring it in the code.

Re: RFR: 8233477: : [Win LAF]The tooltip doesn't display correctly in Win LAF [v5]

2022-06-03 Thread Tejesh R
On Thu, 2 Jun 2022 06:03:16 GMT, Tejesh R wrote: >> The tooltip displays accelerated string along with the toooltip string. The >> feature is implemented and applicable for Metal Look and Feel only. Hence >> the test is updated for Metal Look and Feel by hard wiring it in the

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v5]

2022-06-02 Thread Tejesh R
On Fri, 3 Jun 2022 05:38:42 GMT, Tejesh R wrote: > > I see that the bug description has a test case which produce this > > exception. There are these lines on the stack: > > ``` > > at > > sun.awt.SunGraphicsCallback.runComponents(SunGraphic

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v5]

2022-06-02 Thread Tejesh R
On Thu, 2 Jun 2022 22:29:50 GMT, Sergey Bylokhov wrote: > I see that the bug description has a test case which produce this exception. > There are these lines on the stack: > > ``` > at > sun.awt.SunGraphicsCallback.runComponents(SunGraphicsCallback.java:116) > at java.awt.Containe

Re: RFR: JDK-8287261: [macos] JList Focus Ring color doesn't follow Accent color changes on macOS [v2]

2022-06-02 Thread Tejesh R
On Wed, 1 Jun 2022 19:40:34 GMT, Harshitha Onkar wrote: >> With the proposed fix, JList's focus ring color follows accent color >> changes. Previously the focus ring for JList was not prominently visible and >> did not follow accent color changes. >> >> While investing a similar issue related

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v7]

2022-06-02 Thread Tejesh R
> Added test for checking setMargin() of JRadioButton. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Removed whitespaces - Changes: - all: https://git.openjdk.java.net/jdk/pull/8721/files - new: ht

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v6]

2022-06-02 Thread Tejesh R
> Added test for checking setMargin() of JRadioButton. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Updated based on review comments - Changes: - all: https://git.openjdk.java.net/jdk/pull/8721/files - new: ht

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v5]

2022-06-02 Thread Tejesh R
s set in the > `getTableCellRendererComponent()` method, which in turn makes the _header_ > object available during paint event without causing NPE. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Changed from manual to Automatic Test -

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v5]

2022-06-02 Thread Tejesh R
> Added test for checking setMargin() of JRadioButton. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Removed windows specific jtreg - Changes: - all: https://git.openjdk.java.net/jdk/pull/8721/files - new: ht

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v3]

2022-06-02 Thread Tejesh R
On Thu, 2 Jun 2022 07:51:00 GMT, Alexey Ivanov wrote: > > > I can see no reason why the test is for Windows only. > > > The original bug > > > [JDK-4380543](https://bugs.openjdk.java.net/browse/JDK-4380543) lists all > > > the operating systems as affected. Then > > > [JDK-8134640](https://bug

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v4]

2022-06-02 Thread Tejesh R
s set in the > `getTableCellRendererComponent()` method, which in turn makes the _header_ > object available during paint event without causing NPE. Tejesh R has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by

Re: RFR: 8233477: : [Win LAF]The tooltip doesn't display correctly in Win LAF [v5]

2022-06-01 Thread Tejesh R
> The tooltip displays accelerated string along with the toooltip string. The > feature is implemented and applicable for Metal Look and Feel only. Hence the > test is updated for Metal Look and Feel by hard wiring it in the code. > Updated the test from manual to automatic.

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v3]

2022-06-01 Thread Tejesh R
On Wed, 1 Jun 2022 17:09:37 GMT, Alexey Ivanov wrote: > > > > I wonder why the test is Windows-specific if it allows changing Look > > > > and Feels. > > > > The only Look and Feel which ignores the background is Nimbus, other > > > > L&Fs on Windows at least paint the yellow and green backgrou

Re: RFR: 8233477: : [Win LAF]The tooltip doesn't display correctly in Win LAF [v4]

2022-06-01 Thread Tejesh R
> The tooltip displays accelerated string along with the toooltip string. The > feature is implemented and applicable for Metal Look and Feel only. Hence the > test is updated for Metal Look and Feel by hard wiring it in the code. > Updated the test from manual to automatic.

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v4]

2022-06-01 Thread Tejesh R
On Wed, 1 Jun 2022 18:00:44 GMT, Phil Race wrote: > > > > Shall the test be located in > > > > `test/jdk/javax/swing/JRadioButton/4380543/bug4380543.java` instead of > > > > `test/jdk/javax/swing/JRadioButton/bug4380543.java` ? > > > > Usually, there's been a folder with bugid (`/4380543/`) for

Re: RFR: 8233477: : [Win LAF]The tooltip doesn't display correctly in Win LAF [v3]

2022-06-01 Thread Tejesh R
> The tooltip displays accelerated string along with the toooltip string. The > feature is implemented and applicable for Metal Look and Feel only. Hence the > test is updated for Metal Look and Feel by hard wiring it in the code. > Updated the test from manual to automatic.

Re: RFR: 8233477: : [Win LAF]The tooltip doesn't display correctly in Win LAF [v2]

2022-06-01 Thread Tejesh R
On Wed, 1 Jun 2022 17:17:34 GMT, Phil Race wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed unused parameter isTooltipAdded > > test/jdk/javax/swing/JToolTip/bug5047379.java lin

Re: RFR: 8233477: : [Win LAF]The tooltip doesn't display correctly in Win LAF [v2]

2022-06-01 Thread Tejesh R
On Thu, 2 Jun 2022 01:02:43 GMT, Harshitha Onkar wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed unused parameter isTooltipAdded > > test/jdk/javax/swing/JToolTip/bug5047379.java

Re: RFR: 8233477: : [Win LAF]The tooltip doesn't display correctly in Win LAF [v2]

2022-06-01 Thread Tejesh R
On Thu, 2 Jun 2022 00:51:22 GMT, Sergey Bylokhov wrote: > > I think this feature was implemented someday for some L&Fs and then > > deleted. please double-check the history of releated bugs/files. > > Hmm, I thought this is a produce fix since it has a CSR in the description. > The test for me

Re: RFR: JDK-8287261: [macos] JList Focus Ring color doesn't follow Accent color changes on macOS

2022-06-01 Thread Tejesh R
On Wed, 25 May 2022 23:40:59 GMT, Harshitha Onkar wrote: > With the proposed fix, JList's focus ring color follows accent color changes. > Previously the focus ring for JList was not prominently visible and did not > follow accent color changes. > > While investing a similar issue related to J

Re: RFR: JDK-8287261: [macos] JList Focus Ring color doesn't follow Accent color changes on macOS

2022-06-01 Thread Tejesh R
On Wed, 25 May 2022 23:40:59 GMT, Harshitha Onkar wrote: > With the proposed fix, JList's focus ring color follows accent color changes. > Previously the focus ring for JList was not prominently visible and did not > follow accent color changes. > > While investing a similar issue related to J

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton

2022-05-31 Thread Tejesh R
On Tue, 24 May 2022 10:36:09 GMT, Alexey Ivanov wrote: >>> Just an idea for discussion: I remember that we added some support for the >>> manual tests, kind of framework or something. Probably it will be useful to >>> reuse when we add "new" tests? >>> https://bugs.openjdk.java.net/browse/JDK-

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v4]

2022-05-31 Thread Tejesh R
> Added test for checking setMargin() of JRadioButton. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Updated based on review comments - Changes: - all: https://git.openjdk.java.net/jdk/pull/8721/files - new: ht

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v3]

2022-05-31 Thread Tejesh R
On Tue, 31 May 2022 11:15:25 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Updated based on review comments >> - Added headful key > > test/jdk/javax/swing/J

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v3]

2022-05-31 Thread Tejesh R
On Wed, 1 Jun 2022 04:45:12 GMT, Tejesh R wrote: > > I wonder why the test is Windows-specific if it allows changing Look and > > Feels. > > The only Look and Feel which ignores the background is Nimbus, other L&Fs > > on Windows at least paint the yellow and gr

Re: RFR: 8233477: : [Win LAF]The tooltip doesn't display correctly in Win LAF [v2]

2022-05-31 Thread Tejesh R
On Wed, 1 Jun 2022 05:07:44 GMT, Prasanta Sadhukhan wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed unused parameter isTooltipAdded > > test/jdk/javax/swing/JToolTip/bug5047379.

Re: RFR: 8233477: : [Win LAF]The tooltip doesn't display correctly in Win LAF [v2]

2022-05-31 Thread Tejesh R
> The tooltip displays accelerated string along with the toooltip string. The > feature is implemented and applicable for Metal Look and Feel only. Hence the > test is updated for Metal Look and Feel by hard wiring it in the code. > Updated the test from manual to automatic.

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v3]

2022-05-31 Thread Tejesh R
On Tue, 31 May 2022 11:30:55 GMT, Alexey Ivanov wrote: > I wonder why the test is Windows-specific if it allows changing Look and > Feels. > > The only Look and Feel which ignores the background is Nimbus, other L&Fs on > Windows at least paint the yellow and green background. As such, the tes

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v3]

2022-05-31 Thread Tejesh R
On Tue, 31 May 2022 09:57:36 GMT, Alexey Ivanov wrote: >> Ok, then will try with the _bufferedImage paint_ logic, If I'm able to get >> the exception without it been handled by internal code then it'll be really >> helpful to make it automatic. > >> > _Actually if the current test executes then

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v3]

2022-05-31 Thread Tejesh R
On Tue, 31 May 2022 09:37:57 GMT, Tejesh R wrote: >>> Yeah, wanted to change to automatic, but wasn't sure about whether its ok >>> for NPE check or not. >> >> What can be wrong with it? It's just a regular test. If you can automate the >> tes

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v3]

2022-05-31 Thread Tejesh R
On Tue, 31 May 2022 09:29:59 GMT, Alexey Ivanov wrote: >>> Can't the test be automated? >>> >>> Can you paint the table to a BufferredImage and catch the NPE? >>> >>> Alternatively, if the above can't be done, you can use >>> [Thread.setUncaughtExceptionHandler](https://docs.oracle.com/en/java

RFR: 8233477: : [Win LAF]The tooltip doesn't display correctly in Win LAF

2022-05-31 Thread Tejesh R
The tooltip displays accelerated string along with the toooltip string. The feature is implemented and applicable for Metal Look and Feel only. Hence the test is updated for Metal Look and Feel by hard wiring it in the code. Updated the test from manual to automatic. - Commit messa

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v3]

2022-05-30 Thread Tejesh R
On Mon, 30 May 2022 16:01:39 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removal of White space > > test/jdk/javax/swing/JTableHeader/TableRendererTest

Re: RFR: 8286846: test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on mac aarch64

2022-05-30 Thread Tejesh R
On Tue, 24 May 2022 08:28:57 GMT, Prasanta Sadhukhan wrote: > Test was failing intermiitently in iMac M1 system owing to minimalistic color > difference of 1 > > x 13 y 0 refRGB ffee customRGB ffef > x 0 y 0 refRGB ffefefef customRGB ffefeeef > > > so added color tolerance check. >

Re: RFR: 8286846: test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on mac aarch64

2022-05-30 Thread Tejesh R
On Mon, 30 May 2022 14:15:17 GMT, Prasanta Sadhukhan wrote: > Information is not needed for sleep interuption, it's not going to affect the > test much Ok. The PR is fine, I have tested in mac. - PR: https://git.openjdk.java.net/jdk/pull/8864

Re: RFR: 8286846: test/jdk/javax/swing/plaf/aqua/CustomComboBoxFocusTest.java fails on mac aarch64

2022-05-30 Thread Tejesh R
On Tue, 24 May 2022 08:28:57 GMT, Prasanta Sadhukhan wrote: > Test was failing intermiitently in iMac M1 system owing to minimalistic color > difference of 1 > > x 13 y 0 refRGB ffee customRGB ffef > x 0 y 0 refRGB ffefefef customRGB ffefeeef > > > so added color tolerance check. >

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v3]

2022-05-29 Thread Tejesh R
s set in the > `getTableCellRendererComponent()` method, which in turn makes the _header_ > object available during paint event without causing NPE. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Removal of White space - Chang

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v2]

2022-05-27 Thread Tejesh R
On Fri, 27 May 2022 17:03:08 GMT, Harshitha Onkar wrote: >> Tejesh R has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains ten

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v3]

2022-05-27 Thread Tejesh R
> Added test for checking setMargin() of JRadioButton. Tejesh R has updated the pull request incrementally with two additional commits since the last revision: - Updated based on review comments - Added headful key - Changes: - all: https://git.openjdk.java.net/jdk/pull/8

Re: RFR: 6429812: NPE after calling JTable.updateUI() when using a header renderer + XP L&F [v2]

2022-05-26 Thread Tejesh R
s set in the > `getTableCellRendererComponent()` method, which in turn makes the _header_ > object available during paint event without causing NPE. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Updated based on review comments a

Re: RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible [v13]

2022-05-25 Thread Tejesh R
On Wed, 25 May 2022 13:53:57 GMT, Prasanta Sadhukhan wrote: >> Issue was when printing a JTable which sits inside a JScrollPane and the >> table is scrolled down to the end to about 1000th row, only the first page >> is printed. >> This is because when the table is scrolled down to last page,

Re: RFR: 8257810: Only First page are printed in JTable.scrollRectToVisible [v12]

2022-05-25 Thread Tejesh R
On Thu, 12 May 2022 04:09:29 GMT, Prasanta Sadhukhan wrote: >> Issue was when printing a JTable which sits inside a JScrollPane and the >> table is scrolled down to the end to about 1000th row, only the first page >> is printed. >> This is because when the table is scrolled down to last page,

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v2]

2022-05-25 Thread Tejesh R
On Tue, 24 May 2022 10:42:34 GMT, Alexey Ivanov wrote: >> Tejesh R has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains ten

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton

2022-05-25 Thread Tejesh R
On Tue, 24 May 2022 10:36:09 GMT, Alexey Ivanov wrote: > Just an idea for discussion: I remember that we added some support for the > manual tests, kind of framework or something. Probably it will be useful to > reuse when we add "new" tests? > https://bugs.openjdk.java.net/browse/JDK-8283803

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton [v2]

2022-05-25 Thread Tejesh R
> Added test for checking setMargin() of JRadioButton. Tejesh R has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the l

Re: RFR: 8286620: Create regression test for verifying setMargin() of JRadioButton

2022-05-23 Thread Tejesh R
On Tue, 24 May 2022 00:46:21 GMT, Sergey Bylokhov wrote: > Just an idea for discussion: I remember that we added some support for the > manual tests, kind of framework or something. Probably it will be useful to > reuse when we add "new" tests? > https://bugs.openjdk.java.net/browse/JDK-828380

client-libs-dev@openjdk.java.net

2022-05-23 Thread Tejesh R
On Tue, 24 May 2022 00:10:34 GMT, Sergey Bylokhov wrote: > Is it possible to create a new test case for this patch, or can we add @bug > to some existed one? I don't think there exist a bug for this fix, I will create a new test case for this patch. - PR: https://git.openjdk.java

client-libs-dev@openjdk.java.net

2022-05-23 Thread Tejesh R
_Header_ object not initialized/set when paint() method of `WindowTableHeaderUI` class is executed. The paint() event is executed through explicit call of `JTable.updateUI()` in the regression test. In order to set the _header_ to the _called_ JTable, it is set in the `getTableCellRendererCompo

Re: RFR: 8286822: Write a test to check the DND functionality between two InternalFrames

2022-05-20 Thread Tejesh R
On Tue, 17 May 2022 15:52:03 GMT, Manukumar V S wrote: > This test verifies that dragging from one InternalFrame and a drop target in > another InternalFrame functions properly. > This fix moves an unstable closed applet based test to open regression based > java test, but updated to be more co

Withdrawn: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF

2022-05-18 Thread Tejesh R
On Mon, 2 May 2022 02:56:01 GMT, Tejesh R wrote: > In Button ToolTip, Mnemonic key string was shown only in Metal Look and Feel, > since the feature is implemented in it. In other L&F especially Windows L&F > the feature is not available. In order to make it available for ot

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v4]

2022-05-16 Thread Tejesh R
On Fri, 13 May 2022 22:39:55 GMT, Phil Race wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed the test from open, updated in closed > > I find it very strange that https://bu

RFR: 8286620: Move bug4380543 from closed to open

2022-05-15 Thread Tejesh R
Moving bug4380543.java from closed repo to open repo. - Commit messages: - Moving bug4380543.java from closed to open - Merge branch 'master' of github.com:TejeshR13/jdk - Merge branch 'openjdk:master' into master - Merge remote-tracking branch 'upstream/master' - Merge remote-tr

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v4]

2022-05-12 Thread Tejesh R
On Mon, 9 May 2022 05:27:54 GMT, Prasanta Sadhukhan wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed the test from open, updated in closed > > src/java.desktop/share/

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v4]

2022-05-12 Thread Tejesh R
t > BasicToolTipUI can make use of the feature available in ToolTipUI. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Removed the test from open, updated in closed - Changes: - all: https://git.openjdk.java.net/jdk/pull/84

Withdrawn: 8134640 ( Left Insets Margin Test ) moved to open repo from closed

2022-05-11 Thread Tejesh R
On Mon, 2 May 2022 11:31:17 GMT, Tejesh R wrote: > The Test had been updated to use all Supported Look and Feel in closed repo. > The same has been moved to open repo. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/8500

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v3]

2022-05-06 Thread Tejesh R
t > BasicToolTipUI can make use of the feature available in ToolTipUI. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Added Regression Test JToolTip/5047379/bug5047379.java - Changes: - all: https://git.o

Re: RFR: 8134640 ( Left Insets Margin Test ) moved to open repo from closed [v2]

2022-05-03 Thread Tejesh R
> The Test had been updated to use all Supported Look and Feel in closed repo. > The same has been moved to open repo. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Copyright Year updated - Changes: - all:

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v2]

2022-05-02 Thread Tejesh R
On Mon, 2 May 2022 03:21:25 GMT, Tejesh R wrote: >> In Button ToolTip, Mnemonic key string was shown only in Metal Look and >> Feel, since the feature is implemented in it. In other L&F especially >> Windows L&F the feature is not available. In order to make it ava

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v2]

2022-05-02 Thread Tejesh R
On Mon, 2 May 2022 05:03:40 GMT, Prasanta Sadhukhan wrote: > I believe you can migrate the closed test to open and iterate through all > L&Fs and add that to the PR. Means to Iterate through all L&F's and wait for specific amount of time for user to validate and go on to next L&F...? Beca

RFR: 8134640 ( Left Insets Margin Test ) moved to open repo from closed

2022-05-02 Thread Tejesh R
The Test had been updated to use all Supported Look and Feel in closed repo. The same has been moved to open repo. - Commit messages: - Moved Test Case 4380543 from closed to open - Merge branch 'master' of github.com:TejeshR13/jdk - Merge branch 'openjdk:master' into master - Me

Withdrawn: 8134640 ( Left Insets Margin Test ) moved to open repo from closed

2022-05-02 Thread Tejesh R
On Mon, 2 May 2022 08:07:49 GMT, Tejesh R wrote: > The Test had been updated to use all Supported Look and Feel in closed repo. > The same has been moved to open repo. This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/8497

Re: RFR: 8134640 ( Left Insets Margin Test ) moved to open repo from closed [v2]

2022-05-02 Thread Tejesh R
> The Test had been updated to use all Supported Look and Feel in closed repo. > The same has been moved to open repo. Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Copyright Added - Changes: - all:

RFR: 8134640 ( Left Insets Margin Test ) moved to open repo from closed

2022-05-02 Thread Tejesh R
The Test had been updated to use all Supported Look and Feel in closed repo. The same has been moved to open repo. - Commit messages: - Moved Test Case 4380543 from closed to open - Feature moved to ToolTipUI and updated MetalToolTipUI Accordingly - Feature moved to ToolTipUI and

Re: RFR: 8233477 [Win LAF]The tooltip doesn't display correctly in Win LAF [v2]

2022-05-01 Thread Tejesh R
t > BasicToolTipUI can make use of the feature available in ToolTipUI. Tejesh R has updated the pull request incrementally with two additional commits since the last revision: - Feature moved to ToolTipUI and updated MetalToolTipUI Accordingly - Feature moved to ToolTipUI and updated MetalTool

RFR: 8233477: [Win LAF]The tooltip doesn't display correctly in Win LAF

2022-05-01 Thread Tejesh R
In Button ToolTip Mnemonic key string was shown only in Metal Look and Feel, since the feature is implemented in it. In other L&F especially Windows L&F the feature is not available. In order to make it available for other L&F's, the getAcceleratedString method and calculateAcceleratedStringSpac

Withdrawn: 8180276: JTextPane getText return extra when mixed with methods of Document

2022-04-17 Thread Tejesh R
On Wed, 6 Apr 2022 10:02:10 GMT, Tejesh R wrote: > getText function returned extra endOfLine when appended. The reason was in > `EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)` > method, where translation happens from buffer to Out(Writer Object) if >

Integrated: 8236987: Remove call to System.out.println from ImageIcon.loadImage

2022-04-14 Thread Tejesh R
On Wed, 9 Mar 2022 10:04:09 GMT, Tejesh R wrote: > Removed the println() line from the Interrupted catch block. Since > waitForID() Interrupt indicates completion of Image Loading, println as > Interrupt handling was not required. This pull request has now been integrated.

Re: RFR: 8236987: Remove call to System.out.println from ImageIcon.loadImage [v11]

2022-04-14 Thread Tejesh R
On Tue, 12 Apr 2022 20:50:48 GMT, Phil Race wrote: >> This is intentional, it makes sure the image is in `LOADING` state to verify >> that the newly added resets it to `ABORTED`. >> >> I don't expect the image to load, we don't care. If it succeeds, the status >> is `COMPLETE`; if it times out

Re: RFR: 8180276: JTextPane getText return extra when mixed with methods of Document [v5]

2022-04-11 Thread Tejesh R
On Fri, 8 Apr 2022 12:17:37 GMT, Tejesh R wrote: >> getText function returned extra endOfLine when appended. The reason was in >> `EditorEditorKit` class, `write(Writer out, Document doc, int pos, int len)` >> method, where translation happens from buffer to Out(Writer Object

  1   2   >