Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v19]

2022-05-26 Thread lukeu
On Wed, 25 May 2022 21:37:07 GMT, Alisen Chung wrote: >> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > changed test to headless Hi,

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v8]

2022-05-22 Thread lukeu
On Wed, 20 Apr 2022 23:35:10 GMT, lukeu wrote: >> Made a small change with the bottom line to match the left line of the border > >> Made a small change with the bottom line to match the left line of the border > > Great, that looks like it'll fix it so I won'

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v8]

2022-04-20 Thread lukeu
On Wed, 20 Apr 2022 17:53:24 GMT, Alisen Chung wrote: > Made a small change with the bottom line to match the left line of the border Great, that looks like it'll fix it so I won't test again, I'll defer to the others now for the code review. (I'd be happy to chip in there too, but I'm not sur

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v8]

2022-04-11 Thread lukeu
On Thu, 7 Apr 2022 20:24:29 GMT, Alisen Chung wrote: >> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > fixed 1.25 scaling overdraw, f

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v7]

2022-03-28 Thread lukeu
On Sun, 27 Mar 2022 03:02:55 GMT, Phil Race wrote: > So perhaps, this needs real printer testing printing to a real printer. Or > may be more than one. I have an HP OfficeJet Pro, and happy to print the odd test manually if it would help increase coverage. If so, just let me know when the code

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v7]

2022-03-24 Thread lukeu
On Thu, 24 Mar 2022 03:07:28 GMT, Phil Race wrote: > 2. What I need here is a nice little statement of what we are INTENDING to > draw. I mean what the UX person sketched out on their paper at infinite > resolution. Just my 2c: I'd say the main goal here is to enhance the fidelity of `EtchedB

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v6]

2022-03-23 Thread lukeu
On Wed, 23 Mar 2022 18:25:31 GMT, Alisen Chung wrote: > Can you try the recent change to see if it works at 200+%? Sure, if it still helps here's a screenshot at 250% scaling. It shows `TitledBorder` constructed with: * top: The JDK's `EtchedBorder` with the latest commit * bottom: a custom

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v6]

2022-03-21 Thread lukeu
On Thu, 17 Mar 2022 23:50:21 GMT, Alisen Chung wrote: >> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > fixed apostrophe in comment o

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v6]

2022-03-17 Thread lukeu
On Thu, 17 Mar 2022 23:50:21 GMT, Alisen Chung wrote: >> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > fixed apostrophe in comment o

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v3]

2022-03-15 Thread lukeu
On Mon, 14 Mar 2022 16:15:47 GMT, Alisen Chung wrote: >> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > added functions for drawing b

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v3]

2022-03-15 Thread lukeu
On Mon, 14 Mar 2022 16:15:47 GMT, Alisen Chung wrote: >> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > added functions for drawing b