Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components [v2]

2022-05-16 Thread Dmitry Batrak
On Tue, 1 Feb 2022 21:40:53 GMT, Dmitry Batrak wrote: >> The proposed fix makes fonts with and without fallback components >> distinguishable (in terms of `equals` method), so that >> font metrics cache (and other similar code) can handle them separately. This >> is achieved by adding a new boo

Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components [v2]

2022-04-18 Thread Dmitry Batrak
On Tue, 1 Feb 2022 21:40:53 GMT, Dmitry Batrak wrote: >> The proposed fix makes fonts with and without fallback components >> distinguishable (in terms of `equals` method), so that >> font metrics cache (and other similar code) can handle them separately. This >> is achieved by adding a new boo

Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components [v2]

2022-03-28 Thread Dmitry Batrak
On Thu, 24 Mar 2022 02:49:49 GMT, Phil Race wrote: >> Dmitry Batrak has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove 'headful' requirement from test case > > I know .. I know .. I just (a) don't like it, and (b) don't have a good

Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components [v2]

2022-03-23 Thread Phil Race
On Tue, 1 Feb 2022 21:40:53 GMT, Dmitry Batrak wrote: >> The proposed fix makes fonts with and without fallback components >> distinguishable (in terms of `equals` method), so that >> font metrics cache (and other similar code) can handle them separately. This >> is achieved by adding a new boo

Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components [v2]

2022-03-09 Thread Dmitry Batrak
On Tue, 1 Feb 2022 21:40:53 GMT, Dmitry Batrak wrote: >> The proposed fix makes fonts with and without fallback components >> distinguishable (in terms of `equals` method), so that >> font metrics cache (and other similar code) can handle them separately. This >> is achieved by adding a new boo

Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components [v2]

2022-02-21 Thread Dmitry Batrak
On Sun, 6 Feb 2022 19:53:45 GMT, Phil Race wrote: >> Dmitry Batrak has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove 'headful' requirement from test case > >> As you say, one could possibly also try to compare font2DHandle-s instead

Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components [v2]

2022-02-07 Thread Dmitry Batrak
On Tue, 1 Feb 2022 21:40:53 GMT, Dmitry Batrak wrote: >> The proposed fix makes fonts with and without fallback components >> distinguishable (in terms of `equals` method), so that >> font metrics cache (and other similar code) can handle them separately. This >> is achieved by adding a new boo

Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components [v2]

2022-02-06 Thread Phil Race
On Tue, 1 Feb 2022 21:40:53 GMT, Dmitry Batrak wrote: >> The proposed fix makes fonts with and without fallback components >> distinguishable (in terms of `equals` method), so that >> font metrics cache (and other similar code) can handle them separately. This >> is achieved by adding a new boo

Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components [v2]

2022-02-03 Thread Dmitry Batrak
On Wed, 2 Feb 2022 21:29:28 GMT, Sergey Bylokhov wrote: >> src/java.desktop/share/classes/java/awt/Font.java line 1861: >> >>> 1859: pointSize == font.pointSize && >>> 1860: withFallback == font.withFallback && >>> 1861: name.equals(font.name)) { >

Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components [v2]

2022-02-02 Thread Sergey Bylokhov
On Wed, 2 Feb 2022 18:32:10 GMT, Phil Race wrote: > Serialization of Font objects is just serializing the fields liek name and > style and size but there's no guarantee that it will behave the same .. I > mean if I serialize Segoe UI on WIndows and try to deserialize it on Linux > nothing in t

Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components [v2]

2022-02-02 Thread Phil Race
On Tue, 1 Feb 2022 21:40:53 GMT, Dmitry Batrak wrote: >> The proposed fix makes fonts with and without fallback components >> distinguishable (in terms of `equals` method), so that >> font metrics cache (and other similar code) can handle them separately. This >> is achieved by adding a new boo

Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components [v2]

2022-02-01 Thread Dmitry Batrak
> The proposed fix makes fonts with and without fallback components > distinguishable (in terms of `equals` method), so that > font metrics cache (and other similar code) can handle them separately. This > is achieved by adding a new boolean field > to `Font` class, specifically denoting fonts wi

Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components

2022-02-01 Thread Dmitry Batrak
On Tue, 1 Feb 2022 19:50:47 GMT, Sergey Bylokhov wrote: >> The proposed fix makes fonts with and without fallback components >> distinguishable (in terms of `equals` method), so that >> font metrics cache (and other similar code) can handle them separately. This >> is achieved by adding a new b

Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components

2022-02-01 Thread Dmitry Batrak
On Tue, 1 Feb 2022 19:47:59 GMT, Sergey Bylokhov wrote: >> The proposed fix makes fonts with and without fallback components >> distinguishable (in terms of `equals` method), so that >> font metrics cache (and other similar code) can handle them separately. This >> is achieved by adding a new b

Re: RFR: 8185261: Font fallback sometimes doesn't work in Swing text components

2022-02-01 Thread Sergey Bylokhov
On Tue, 1 Feb 2022 18:38:39 GMT, Dmitry Batrak wrote: > The proposed fix makes fonts with and without fallback components > distinguishable (in terms of `equals` method), so that > font metrics cache (and other similar code) can handle them separately. This > is achieved by adding a new boolean

RFR: 8185261: Font fallback sometimes doesn't work in Swing text components

2022-02-01 Thread Dmitry Batrak
The proposed fix makes fonts with and without fallback components distinguishable (in terms of `equals` method), so that font metrics cache (and other similar code) can handle them separately. This is achieved by adding a new boolean field to `Font` class, specifically denoting fonts with fallbac