Re: RFR: 8276794: Change nested classes in java.desktop to static nested classes [v2]

2021-11-17 Thread Andrey Turbanov
On Wed, 17 Nov 2021 19:25:15 GMT, Andrey Turbanov wrote: >> Non-static classes hold a link to their parent classes, which in many cases >> can be avoided. >> I updated only private and package-private classes. Didn't touch >> public/protected to not break external code. >> Similar cleanup in ja

Re: RFR: 8276794: Change nested classes in java.desktop to static nested classes [v3]

2021-11-17 Thread Andrey Turbanov
> Non-static classes hold a link to their parent classes, which in many cases > can be avoided. > I updated only private and package-private classes. Didn't touch > public/protected to not break external code. > Similar cleanup in java.base - > [JDK-8261880](https://bugs.openjdk.java.net/browse/

Re: RFR: 8276794: Change nested classes in java.desktop to static nested classes [v2]

2021-11-17 Thread Andrey Turbanov
On Wed, 17 Nov 2021 14:32:16 GMT, Alexey Ivanov wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> [PATCH] Change nested classes in java.desktop to static nested classes >> fix review comments > > src/java.deskto

Re: RFR: 8276794: Change nested classes in java.desktop to static nested classes [v2]

2021-11-17 Thread Andrey Turbanov
> Non-static classes hold a link to their parent classes, which in many cases > can be avoided. > I updated only private and package-private classes. Didn't touch > public/protected to not break external code. > Similar cleanup in java.base - > [JDK-8261880](https://bugs.openjdk.java.net/browse/

Re: RFR: 8276794: Change nested classes in java.desktop to static nested classes [v2]

2021-11-17 Thread Alexey Ivanov
On Wed, 17 Nov 2021 19:21:49 GMT, Andrey Turbanov wrote: >> Non-static classes hold a link to their parent classes, which in many cases >> can be avoided. >> I updated only private and package-private classes. Didn't touch >> public/protected to not break external code. >> Similar cleanup in ja

Re: RFR: 8276794: Change nested classes in java.desktop to static nested classes

2021-11-17 Thread Alexey Ivanov
On Thu, 14 Oct 2021 07:47:33 GMT, Andrey Turbanov wrote: > Non-static classes hold a link to their parent classes, which in many cases > can be avoided. > I updated only private and package-private classes. Didn't touch > public/protected to not break external code. > Similar cleanup in java.ba

Re: RFR: 8276794: Change nested classes in java.desktop to static nested classes

2021-11-15 Thread Sergey Bylokhov
On Thu, 14 Oct 2021 07:47:33 GMT, Andrey Turbanov wrote: > Non-static classes hold a link to their parent classes, which in many cases > can be avoided. > I updated only private and package-private classes. Didn't touch > public/protected to not break external code. > Similar cleanup in java.ba

RFR: 8276794: Change nested classes in java.desktop to static nested classes

2021-11-07 Thread Andrey Turbanov
Non-static classes hold a link to their parent classes, which in many cases can be avoided. I updated only private and package-private classes. Didn't touch public/protected to not break external code. Similar cleanup in java.base - [JDK-8261880](https://bugs.openjdk.java.net/browse/JDK-8261880)

Re: RFR: 8276794: Change nested classes in java.desktop to static nested classes

2021-11-07 Thread Sergey Bylokhov
On Thu, 14 Oct 2021 07:47:33 GMT, Andrey Turbanov wrote: > Non-static classes hold a link to their parent classes, which in many cases > can be avoided. > I updated only private and package-private classes. Didn't touch > public/protected to not break external code. > Similar cleanup in java.ba