Re: RFR: JDK-8273387: remove some unreferenced gtk-related functions [v3]

2021-09-08 Thread Christoph Langer
On Wed, 8 Sep 2021 11:56:39 GMT, Matthias Baesken wrote: >> Please review this small change. >> Looks like there are a few functions, like gtk2_paint_diamond, that are >> unreferenced and can be removed. >> >> Thanks, Matthias > > Matthias Baesken has updated the pull request incrementally with

Re: RFR: JDK-8273387: remove some unreferenced gtk-related functions [v3]

2021-09-08 Thread Pankaj Bansal
On Wed, 8 Sep 2021 11:56:39 GMT, Matthias Baesken wrote: >> Please review this small change. >> Looks like there are a few functions, like gtk2_paint_diamond, that are >> unreferenced and can be removed. >> >> Thanks, Matthias > > Matthias Baesken has updated the pull request incrementally with

Re: RFR: JDK-8273387: remove some unreferenced gtk-related functions [v3]

2021-09-08 Thread Matthias Baesken
> Please review this small change. > Looks like there are a few functions, like gtk2_paint_diamond, that are > unreferenced and can be removed. > > Thanks, Matthias Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: remove declarat

Re: RFR: JDK-8273387: remove some unreferenced gtk-related functions [v3]

2021-09-08 Thread Matthias Baesken
On Wed, 8 Sep 2021 11:34:48 GMT, Pankaj Bansal wrote: >> Thanks for the hint , I removed the initialization you mentioned. >> >> Best regards, Matthias > > I think the declaration of function pointer should also be removed. So > following should be removed from line no 150 > static void (*fp_gt

Re: RFR: JDK-8273387: remove some unreferenced gtk-related functions [v2]

2021-09-08 Thread Pankaj Bansal
On Wed, 8 Sep 2021 07:00:08 GMT, Matthias Baesken wrote: >> src/java.desktop/unix/native/libawt_xawt/awt/gtk2_interface.c line 1853: >> >>> 1851: } >>> 1852: >>> 1853: static void gtk2_paint_diamond(WidgetType widget_type, GtkStateType >>> state_type, >> >> I think the function pointer initia

Re: RFR: JDK-8273387: remove some unreferenced gtk-related functions [v2]

2021-09-08 Thread Matthias Baesken
On Wed, 8 Sep 2021 04:17:10 GMT, Pankaj Bansal wrote: >> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove fp_gtk_paint_diamond function pointer init > > src/java.desktop/unix/native/libawt_xawt/awt/gtk2_interface.c

Re: RFR: JDK-8273387: remove some unreferenced gtk-related functions [v2]

2021-09-08 Thread Matthias Baesken
> Please review this small change. > Looks like there are a few functions, like gtk2_paint_diamond, that are > unreferenced and can be removed. > > Thanks, Matthias Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: remove fp_gtk_p

Re: RFR: JDK-8273387: remove some unreferenced gtk-related functions

2021-09-07 Thread Pankaj Bansal
On Tue, 7 Sep 2021 07:29:19 GMT, Matthias Baesken wrote: > Please review this small change. > Looks like there are a few functions, like gtk2_paint_diamond, that are > unreferenced and can be removed. > > Thanks, Matthias src/java.desktop/unix/native/libawt_xawt/awt/gtk2_interface.c line 1853: