Re: RFR: JDK-8274977: Remove expandPacked and extendEdge from awt_ImagingLib.c

2021-11-03 Thread Phil Race
On Fri, 8 Oct 2021 14:25:18 GMT, Matthias Baesken wrote: > Please review this small cleanup change. > Looks like expandPacked and extendEdge from awt_ImagingLib.c are > unreferenced/unused and can be removed. > > Thanks, Matthias There's unresolved discussion here so it needs review and approv

Re: RFR: JDK-8274977: Remove expandPacked and extendEdge from awt_ImagingLib.c

2021-11-03 Thread Martin Doerr
On Fri, 8 Oct 2021 14:25:18 GMT, Matthias Baesken wrote: > Please review this small cleanup change. > Looks like expandPacked and extendEdge from awt_ImagingLib.c are > unreferenced/unused and can be removed. > > Thanks, Matthias Looks good and trivial. - Marked as reviewed by md

Re: RFR: JDK-8274977: Remove expandPacked and extendEdge from awt_ImagingLib.c

2021-10-12 Thread Sergey Bylokhov
On Fri, 8 Oct 2021 14:25:18 GMT, Matthias Baesken wrote: > Please review this small cleanup change. > Looks like expandPacked and extendEdge from awt_ImagingLib.c are > unreferenced/unused and can be removed. > > Thanks, Matthias You do not need to search the names of two functions it is unlik

Re: RFR: JDK-8274977: Remove expandPacked and extendEdge from awt_ImagingLib.c

2021-10-12 Thread Matthias Baesken
On Tue, 12 Oct 2021 06:10:17 GMT, Sergey Bylokhov wrote: > > both functions expandPacked and extendEdge are already unused/unreferenced > > in jdk11u. So I wonder what usages are planned for them and when. > > It is necessary to dig into the history of this file, and related bugs in JBS > to s

Re: RFR: JDK-8274977: Remove expandPacked and extendEdge from awt_ImagingLib.c

2021-10-11 Thread Sergey Bylokhov
On Mon, 11 Oct 2021 06:51:58 GMT, Matthias Baesken wrote: > both functions expandPacked and extendEdge are already unused/unreferenced in > jdk11u. So I wonder what usages are planned for them and when. It is necessary to dig into the history of this file, and related bugs in JBS to say how th

Re: RFR: JDK-8274977: Remove expandPacked and extendEdge from awt_ImagingLib.c

2021-10-10 Thread Matthias Baesken
On Fri, 8 Oct 2021 14:25:18 GMT, Matthias Baesken wrote: > Please review this small cleanup change. > Looks like expandPacked and extendEdge from awt_ImagingLib.c are > unreferenced/unused and can be removed. > > Thanks, Matthias Hi Sergey, >Are you sure that these library methods are dead co

Re: RFR: JDK-8274977: Remove expandPacked and extendEdge from awt_ImagingLib.c

2021-10-10 Thread Sergey Bylokhov
On Fri, 8 Oct 2021 14:25:18 GMT, Matthias Baesken wrote: > Please review this small cleanup change. > Looks like expandPacked and extendEdge from awt_ImagingLib.c are > unreferenced/unused and can be removed. > > Thanks, Matthias Are you sure that these library methods are dead code and cannot

RFR: JDK-8274977: Remove expandPacked and extendEdge from awt_ImagingLib.c

2021-10-08 Thread Matthias Baesken
Please review this small cleanup change. Looks like expandPacked and extendEdge from awt_ImagingLib.c are unreferenced/unused and can be removed. Thanks, Matthias - Commit messages: - JDK-8274977 Changes: https://git.openjdk.java.net/jdk/pull/5866/files Webrev: https://webrevs.op