Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html [v4]

2021-11-11 Thread Ludvig Janiuk
On Wed, 10 Nov 2021 17:41:08 GMT, Ludvig Janiuk wrote: >> This change introduces no visual difference, but improves a11y. >> EDIT: There is a slight visual change regarding centering in a few cells. > > Ludvig Janiuk has updated the pull request incrementally with one additional > commit since t

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html [v4]

2021-11-10 Thread Alexey Ivanov
On Wed, 10 Nov 2021 17:41:08 GMT, Ludvig Janiuk wrote: >> This change introduces no visual difference, but improves a11y. > > Ludvig Janiuk has updated the pull request incrementally with one additional > commit since the last revision: > > remove ids, reintroduce two tbodies As expected, th

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html [v4]

2021-11-10 Thread Alexey Ivanov
On Wed, 10 Nov 2021 17:41:08 GMT, Ludvig Janiuk wrote: >> This change introduces no visual difference, but improves a11y. > > Ludvig Janiuk has updated the pull request incrementally with one additional > commit since the last revision: > > remove ids, reintroduce two tbodies Not ideal, but

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html [v4]

2021-11-10 Thread Ludvig Janiuk
> This change introduces no visual difference, but improves a11y. Ludvig Janiuk has updated the pull request incrementally with one additional commit since the last revision: remove ids, reintroduce two tbodies - Changes: - all: https://git.openjdk.java.net/jdk/pull/6291/files

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html [v3]

2021-11-10 Thread Ludvig Janiuk
On Wed, 10 Nov 2021 10:58:08 GMT, Ludvig Janiuk wrote: >> This change introduces no visual difference, but improves a11y. > > Ludvig Janiuk has updated the pull request incrementally with one additional > commit since the last revision: > > Most idiomatic version so far Ah, I see. In that ca

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html [v2]

2021-11-10 Thread Alexey Ivanov
On Wed, 10 Nov 2021 11:04:54 GMT, Ludvig Janiuk wrote: >> src/java.desktop/share/classes/java/awt/font/NumericShaper.java line 117: >> >>> 115: * Unicode Range >>> 116: * {@code NumericShaper} Constants >>> 117: * Precedence >> >> Shall we use more descriptive ids? >> Suggestion:

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html

2021-11-10 Thread Alexey Ivanov
On Wed, 10 Nov 2021 11:03:23 GMT, Ludvig Janiuk wrote: > Concerning ``, quote (emphasis mine): > > > As your tables get a bit more complex in structure, it is useful to give > > them more structural definition. One clear way to do this is by using > > ``, ``, and ``, which allow you to mark up

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html [v3]

2021-11-10 Thread Ludvig Janiuk
On Tue, 9 Nov 2021 19:30:39 GMT, Alexey Ivanov wrote: >> Ludvig Janiuk has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Most idiomatic version so far > > src/java.desktop/share/classes/java/awt/font/NumericShaper.java line 133: > >> 131:

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html [v2]

2021-11-10 Thread Ludvig Janiuk
On Tue, 9 Nov 2021 19:35:41 GMT, Alexey Ivanov wrote: >> Ludvig Janiuk has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Achieve correct row headers without header change > > src/java.desktop/share/classes/java/awt/font/NumericShaper.java

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html

2021-11-10 Thread Ludvig Janiuk
On Tue, 9 Nov 2021 12:30:19 GMT, Alexey Ivanov wrote: >> This change introduces no visual difference, but improves a11y. > >> To me, the table looks correct currently: _Arabic_ Unicode range serves as >> the title for both rows. I wonder how it's read by a screen reader: the >> original version

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html [v3]

2021-11-10 Thread Ludvig Janiuk
> This change introduces no visual difference, but improves a11y. Ludvig Janiuk has updated the pull request incrementally with one additional commit since the last revision: Most idiomatic version so far - Changes: - all: https://git.openjdk.java.net/jdk/pull/6291/files - ne

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html [v2]

2021-11-09 Thread Alexey Ivanov
On Tue, 9 Nov 2021 17:49:04 GMT, Ludvig Janiuk wrote: >> This change introduces no visual difference, but improves a11y. > > Ludvig Janiuk has updated the pull request incrementally with one additional > commit since the last revision: > > Achieve correct row headers without header change I'

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html [v2]

2021-11-09 Thread Ludvig Janiuk
> This change introduces no visual difference, but improves a11y. Ludvig Janiuk has updated the pull request incrementally with one additional commit since the last revision: Achieve correct row headers without header change - Changes: - all: https://git.openjdk.java.net/jdk/pu

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html

2021-11-09 Thread Ludvig Janiuk
On Mon, 8 Nov 2021 09:13:35 GMT, Ludvig Janiuk wrote: > This change introduces no visual difference, but improves a11y. I've pushed a change which "ticks the boxes without introducing so much change". I keep the first column as the row header, and simply specify it explicitly on the `td` eleme

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html

2021-11-09 Thread Ludvig Janiuk
On Tue, 9 Nov 2021 12:30:19 GMT, Alexey Ivanov wrote: >> This change introduces no visual difference, but improves a11y. > >> To me, the table looks correct currently: _Arabic_ Unicode range serves as >> the title for both rows. I wonder how it's read by a screen reader: the >> original version

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html

2021-11-09 Thread Alexey Ivanov
On Mon, 8 Nov 2021 09:13:35 GMT, Ludvig Janiuk wrote: > This change introduces no visual difference, but improves a11y. > To me, the table looks correct currently: _Arabic_ Unicode range serves as > the title for both rows. I wonder how it's read by a screen reader: the > original version and

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html

2021-11-09 Thread Alexey Ivanov
On Tue, 9 Nov 2021 11:42:26 GMT, Alexey Ivanov wrote: >> This change introduces no visual difference, but improves a11y. > >> /integrate > > I believe this is preliminary as our discussion isn't over yet. > @aivanov-jdk Gladly. > [Doccheck](https://openjdk.java.net/projects/code-tools/doccheck

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html

2021-11-09 Thread Alexey Ivanov
On Mon, 8 Nov 2021 09:13:35 GMT, Ludvig Janiuk wrote: > This change introduces no visual difference, but improves a11y. > /integrate I believe this is preliminary as our discussion isn't over yet. - PR: https://git.openjdk.java.net/jdk/pull/6291

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html

2021-11-09 Thread Ludvig Janiuk
On Mon, 8 Nov 2021 18:25:01 GMT, Alexey Ivanov wrote: >> This change introduces no visual difference, but improves a11y. > > Ludvig, could you please elaborate on how this change improves accessibility? @aivanov-jdk Gladly. [Doccheck](https://openjdk.java.net/projects/code-tools/doccheck/) flag

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html

2021-11-08 Thread Naoto Sato
On Mon, 8 Nov 2021 09:13:35 GMT, Ludvig Janiuk wrote: > This change introduces no visual difference, but improves a11y. Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6291

Re: RFR: JDK-8276800 Fix table headers in NumericShaper.html

2021-11-08 Thread Alexey Ivanov
On Mon, 8 Nov 2021 09:13:35 GMT, Ludvig Janiuk wrote: > This change introduces no visual difference, but improves a11y. Ludvig, could you please elaborate on how this change improves accessibility? - PR: https://git.openjdk.java.net/jdk/pull/6291

RFR: JDK-8276800 Fix table headers in NumericShaper.html

2021-11-08 Thread Ludvig Janiuk
This change introduces no visual difference, but improves a11y. - Commit messages: - Fix table headers in NumericShaper.html Changes: https://git.openjdk.java.net/jdk/pull/6291/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6291&range=00 Issue: https://bugs.openjdk.j