Re: RFR: 8275715: D3D pipeline processes multiple PaintEvent at initial drawing [v2]

2022-01-05 Thread Masanori Yano
On Thu, 28 Oct 2021 08:27:44 GMT, Masanori Yano wrote: >> Could you please review the 8275715 bug fixes? >> >> I think D3DScreenUpdateManager posts unnecessary PaintEvent during >> processing PaintEvent. When the validate method is called from >> createGraphics, repaintPeerTarget should not be

Re: RFR: 8277463: JFileChooser with Metal L&F doesn't show non-canonical UNC path in - Look in [v3]

2022-01-05 Thread Masanori Yano
On Tue, 21 Dec 2021 05:28:17 GMT, Sergey Bylokhov wrote: >> I fixed the test as it was pointed out to me. > > Now it cannot be compiled due to "unreported exception > java.lang.ClassNotFoundException; must be caught or declared to be thrown" > from the setLookAndFeel(); Note that the new versio

Re: RFR: 8277463: JFileChooser with Metal L&F doesn't show non-canonical UNC path in - Look in [v3]

2022-01-05 Thread Prasanta Sadhukhan
On Thu, 23 Dec 2021 09:39:59 GMT, Masanori Yano wrote: >> I would like to fix the bug reported in JDK-8277463. >> >> As reporter's investigation, ShellFolder.getNormalizedFile() returns >> incorrect value for non-canonical Windows UNC path. getNormalizedFile() is >> used for symbolic link path

Re: RFR: 8225122: Test AncestorResized.java fails when Windows desktop is scaled.

2022-01-05 Thread Alexey Ivanov
On Mon, 27 Sep 2021 03:33:52 GMT, Sergey Bylokhov wrote: > This test depends on the next windows UI performance option: > “Show window contents while dragging”, see > https://answers.microsoft.com/en-us/windows/forum/all/in-windows-7-how-do-i-show-window-contents-while/18e3aee2-bcc7-4005-a45d-c5

[jdk18] RFR: 8279525: ProblemList java/awt/GraphicsDevice/CheckDisplayModes.java on macosx-aarch64

2022-01-05 Thread Daniel D . Daugherty
A trivial fix to ProblemList java/awt/GraphicsDevice/CheckDisplayModes.java on macosx-aarch64. - Commit messages: - 8279525: ProblemList java/awt/GraphicsDevice/CheckDisplayModes.java on macosx-aarch64 Changes: https://git.openjdk.java.net/jdk18/pull/81/files Webrev: https://webr

Re: [jdk18] RFR: 8279525: ProblemList java/awt/GraphicsDevice/CheckDisplayModes.java on macosx-aarch64

2022-01-05 Thread Calvin Cheung
On Wed, 5 Jan 2022 16:22:53 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/awt/GraphicsDevice/CheckDisplayModes.java > on macosx-aarch64. Looks good and trivial. - Marked as reviewed by ccheung (Reviewer). PR: https://git.openjdk.java.net/jdk18/pull/81

Re: [jdk18] RFR: 8279525: ProblemList java/awt/GraphicsDevice/CheckDisplayModes.java on macosx-aarch64

2022-01-05 Thread Daniel D . Daugherty
On Wed, 5 Jan 2022 16:32:11 GMT, Calvin Cheung wrote: >> A trivial fix to ProblemList java/awt/GraphicsDevice/CheckDisplayModes.java >> on macosx-aarch64. > > Looks good and trivial. @calvinccheung - Thanks for the fast review! - PR: https://git.openjdk.java.net/jdk18/pull/81

[jdk18] Integrated: 8279525: ProblemList java/awt/GraphicsDevice/CheckDisplayModes.java on macosx-aarch64

2022-01-05 Thread Daniel D . Daugherty
On Wed, 5 Jan 2022 16:22:53 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList java/awt/GraphicsDevice/CheckDisplayModes.java > on macosx-aarch64. This pull request has now been integrated. Changeset: 5cd95153 Author:Daniel D. Daugherty URL: https://git.openjdk.java.net

Re: RFR: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel [v11]

2022-01-05 Thread Alisen Chung
> Adjusted the AquaLF scrollbar to account for border inset settings when > dragging the thumb and clicking on the track. Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: added check for other L&Fs, added newline to test

Re: RFR: 8190264: JScrollBar ignores its border when using macOS Mac OS X Aqua look and feel [v11]

2022-01-05 Thread Victor Dyakov
On Wed, 5 Jan 2022 16:58:53 GMT, Alisen Chung wrote: >> Adjusted the AquaLF scrollbar to account for border inset settings when >> dragging the thumb and clicking on the track. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control points in bounding box [v10]

2022-01-05 Thread Laurent Bourgès
On Wed, 15 Dec 2021 23:49:24 GMT, Phil Race wrote: >> Jeremy has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control >> points in bounding box >> >> Addressing code re

[jdk18] Integrated: 8278612: [macos] test/jdk/java/awt/dnd/RemoveDropTargetCrashTest crashes with VoiceOver on macOS

2022-01-05 Thread Anton Tarasov
On Wed, 22 Dec 2021 12:42:30 GMT, Anton Tarasov wrote: > 8278612: [macos] test/jdk/java/awt/dnd/RemoveDropTargetCrashTest crashes with > VoiceOver on macOS This pull request has now been integrated. Changeset: 590fa9d8 Author:Anton Tarasov URL: https://git.openjdk.java.net/jdk18/co

Re: RFR: 4884570: StreamPrintService.isAttributeValueSupported does not work properly for SheetCollate [v2]

2022-01-05 Thread Phil Race
> This fixes a longstanding consistency issue where the Postscript > StreamPrintService would report SheetCollate.UNCOLLATED in a list of > supported values then report it was not supported under the same conditions. Phil Race has updated the pull request incrementally with one additional commit

Re: RFR: 4884570: StreamPrintService.isAttributeValueSupported does not work properly for SheetCollate [v2]

2022-01-05 Thread Phil Race
On Wed, 5 Jan 2022 03:43:53 GMT, Sergey Bylokhov wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >>4884570: StreamPrintService.isAttributeValueSupported does not work >> properly for SheetCollate > > test/jdk/javax/pr

Re: RFR: 4884570: StreamPrintService.isAttributeValueSupported does not work properly for SheetCollate [v3]

2022-01-05 Thread Phil Race
> This fixes a longstanding consistency issue where the Postscript > StreamPrintService would report SheetCollate.UNCOLLATED in a list of > supported values then report it was not supported under the same conditions. Phil Race has updated the pull request incrementally with one additional commit

Re: RFR: 8176501: Method Shape.getBounds2D() incorrectly includes Bezier control points in bounding box [v12]

2022-01-05 Thread Phil Race
On Thu, 16 Dec 2021 18:33:37 GMT, Jeremy wrote: >> This removes code that relied on consulting the Bezier control points to >> calculate the Rectangle2D bounding box. Instead it's pretty straight-forward >> to convert the Bezier control points into the x & y parametric equations. At >> their m

Re: RFR: 8276849: Refresh the window icon on graphics configuration changes

2022-01-05 Thread Phil Race
On Sun, 31 Oct 2021 08:21:58 GMT, Emmanuel Bourg wrote: > When a list of icons is set on a window, the most appropiate icon is selected > depending on the graphics configuration. But if the graphics configuration > changes (because the window is moved to a different screen, or because the > DP

RFR: Merge jdk18

2022-01-05 Thread Jesper Wilhelmsson
Forwardport JDK 18 -> JDK 19 - Commit messages: - Merge remote-tracking branch 'jdk18/master' into Merge_jdk18 - 8279529: ProblemList java/nio/channels/DatagramChannel/ManySourcesAndTargets.java on macosx-aarch64 - 8278612: [macos] test/jdk/java/awt/dnd/RemoveDropTargetCrashTest c

Integrated: Merge jdk18

2022-01-05 Thread Jesper Wilhelmsson
On Thu, 6 Jan 2022 00:42:14 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 18 -> JDK 19 This pull request has now been integrated. Changeset: 844dfb3a Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/844dfb3ab6a1d8b68ccdcc73726ee0f73cfcb3c8 Stats: 750 li

Re: RFR: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled [v4]

2022-01-05 Thread Toshio Nakamura
> Hi, > > Could you review the fix? > When non-English characters were printed from JTable on MacOS, > CTextPipe.doDrawGlyphs was called by OSXSurfaceData.drawGlyphs. However, > CTextPipe seems not support glyph with slot number of composite fonts. > > The slot data mask of GlyphVector is 0xff0

Re: RFR: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled [v3]

2022-01-05 Thread Toshio Nakamura
On Tue, 4 Jan 2022 02:12:41 GMT, Phil Race wrote: >> Toshio Nakamura has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >> commits

Re: RFR: 4884570: StreamPrintService.isAttributeValueSupported does not work properly for SheetCollate [v3]

2022-01-05 Thread Prasanta Sadhukhan
On Wed, 5 Jan 2022 20:21:07 GMT, Phil Race wrote: >> This fixes a longstanding consistency issue where the Postscript >> StreamPrintService would report SheetCollate.UNCOLLATED in a list of >> supported values then report it was not supported under the same conditions. > > Phil Race has updated

Re: RFR: 6496103: isFileHidingEnabled return false by default [v3]

2022-01-05 Thread Sergey Bylokhov
On Mon, 20 Dec 2021 06:54:56 GMT, Tejesh R wrote: >> The default value of this property is derived from native platform. The same >> is updated in the documentation. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > 6496103: isF

Re: RFR: 4884570: StreamPrintService.isAttributeValueSupported does not work properly for SheetCollate [v3]

2022-01-05 Thread Sergey Bylokhov
On Wed, 5 Jan 2022 20:21:07 GMT, Phil Race wrote: >> This fixes a longstanding consistency issue where the Postscript >> StreamPrintService would report SheetCollate.UNCOLLATED in a list of >> supported values then report it was not supported under the same conditions. > > Phil Race has updated