Re: RFR: 8286822: Write a test to check the DND functionality between two InternalFrames

2022-05-20 Thread Tejesh R
On Tue, 17 May 2022 15:52:03 GMT, Manukumar V S wrote: > This test verifies that dragging from one InternalFrame and a drop target in > another InternalFrame functions properly. > This fix moves an unstable closed applet based test to open regression based > java test, but updated to be more co

Integrated: 8285962: NimbusDefaults has a typo in a L&F property

2022-05-20 Thread Prasanta Sadhukhan
On Mon, 2 May 2022 16:01:02 GMT, Prasanta Sadhukhan wrote: > BasicLookAndFeel, BasicProgressBarUI, GTKLookAndFeel tries to find property > by "ProgressBar.verticalSize" but the property defined in NimbusDefaults has > a typo "vertictalSize ". > Rectified the typo. This pull request has now be

RFR: 8286786: [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java still fails

2022-05-20 Thread Prasanta Sadhukhan
In PR#[8380](https://github.com/openjdk/jdk/pull/8380) we have reduced the error tolerance from 25 to 1 so no need of exact color check which is causing failure in specific M1 iMac system because of minimalistic color difference of "1" x 0 y 0 red1 171 red2 171 green1 174 green2 175 blue1 184

Re: RFR: 8286266: [macos] Voice over moving JTable column to be the first column JVM crashes [v2]

2022-05-20 Thread Prasanta Sadhukhan
On Wed, 11 May 2022 16:36:26 GMT, Artem Semenov wrote: >>> It seems to me that here it is necessary to release the cache. >> >> I am not so sure. Why would we do that? I mean - we removed all the records >> from the cache and even if we would release it we would have to immediately >> re-creat

Re: RFR: 8286270: [java.desktop] Replace color search in XColors with a switch statement [v3]

2022-05-20 Thread Alexander Zvegintsev
On Fri, 20 May 2022 00:53:27 GMT, SWinxy wrote: >> The current implementation creates ~750 new objects on load, and uses a >> binary array search with a Comparable implementation. This implementation is >> probably bad. Instead, we can use the enhanced switch feature to possibly >> save time,

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v15]

2022-05-20 Thread Alexey Ivanov
On Tue, 17 May 2022 20:43:00 GMT, Alexey Ivanov wrote: >> Perhaps you are trying to get layout to happen ? That should be possible but >> it might be tricky. >> But I think if you are going so far as pack() and can't change that, then >> show the frame regardless. > > Right, JPanel isn't laid o

Re: JDK-8274735, JPEG compression in a TIFF container, openjdk/jdk/pull/7849

2022-05-20 Thread Michal Karm
I stepped the flow in a debugger and I narrowed down the reproducer to a more focused, simpler description and test data: https://github.com/Karm/dev-null/blob/main/jpegtiff/README.md TL;DR: JPEG compressed RGB image in TIFF with transparency makes the TIFF decoder to push 4 components data to

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v15]

2022-05-20 Thread Alexey Ivanov
On Fri, 20 May 2022 12:02:42 GMT, Alexey Ivanov wrote: >> Right, JPanel isn't laid out without being added to a peered component. >> >> Maybe setting explicit positions to child panels will work, then the test >> can be headless. > >> That looks odd. I mean if you show the frame, how is it disp

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v14]

2022-05-20 Thread Alexey Ivanov
On Tue, 10 May 2022 14:08:50 GMT, Alexey Ivanov wrote: > One more thing: the test now uses `EtchedBorder` only, shall it be moved to > `test/jdk/java/awt/EtchedBorder`? And adding the word _Scaled_ to the title — > `ScaledEtchedBorderTest` — would clarify the purpose of the test. > > What do y

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v15]

2022-05-20 Thread Alexey Ivanov
On Tue, 17 May 2022 20:05:45 GMT, Phil Race wrote: > Actually I'm not sure why only Win L&F is tested .. it is cross-platform and > cross L&F code being changed It was exactly my point, we already [discussed it above](https://github.com/openjdk/jdk/pull/7449#discussion_r836586231). The update

Re: JDK-8274735, JPEG compression in a TIFF container, openjdk/jdk/pull/7849

2022-05-20 Thread Brett Okken
JPEG support for RGB with transparency/alpha channel is pretty spotty. https://stackoverflow.com/a/57626892/676877 On Fri, May 20, 2022 at 8:12 AM Michal Karm wrote: > I stepped the flow in a debugger and I narrowed > down the reproducer to a more focused, simpler > description and test data: >

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v16]

2022-05-20 Thread Alisen Chung
> Changed the drawing area to be increased by 0.5 on the left side to prevent > clipping Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: made suggested changes - Changes: - all: https://git.openjdk.java.net/jdk/pull/7

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v15]

2022-05-20 Thread Alisen Chung
On Tue, 17 May 2022 20:29:16 GMT, Phil Race wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> renamed test, renamed some methods, updated error messages, updated test > > src/java.desktop/share/classes/javax/swing/bo

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v17]

2022-05-20 Thread Alisen Chung
> Changed the drawing area to be increased by 0.5 on the left side to prevent > clipping Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: reverted copyright year - Changes: - all: https://git.openjdk.java.net/jdk/pull/

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v14]

2022-05-20 Thread Phil Race
On Fri, 20 May 2022 13:34:43 GMT, Alexey Ivanov wrote: > > One more thing: the test now uses `EtchedBorder` only, shall it be moved to > > `test/jdk/java/awt/EtchedBorder`? And adding the word _Scaled_ to the title > > — `ScaledEtchedBorderTest` — would clarify the purpose of the test. > > What

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v17]

2022-05-20 Thread Phil Race
On Fri, 20 May 2022 16:55:43 GMT, Alisen Chung wrote: >> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > reverted copyright year test

Re: JDK-8274735, JPEG compression in a TIFF container, openjdk/jdk/pull/7849

2022-05-20 Thread Philip Race
Identifying the intended color space of a JPEG is so much guesswork .. and we've not had support for ARGB since JDK 10 which was the last release to contain the Sun/Oracle "closed" support for that (from Kodak!) and OpenJDK NEVER had it. See https://docs.oracle.com/en/java/javase/17/docs/api/j

Re: Unexpected EOFException in ImageReaderSpi.canDecodeInput

2022-05-20 Thread Philip Race
OK .. we can probably take the proposed change, but there's no guarantee it won't still happen with 3rd party external plugins. I've filed the bug for you : https://bugs.openjdk.java.net/browse/JDK-8287102 -phil. On 5/18/22 2:47 AM, Martin Desruisseaux wrote: Hello Philip Le 17/05/2022 à 2

Re: RFR: 8286270: [java.desktop] Replace color search in XColors with a switch statement [v3]

2022-05-20 Thread Phil Race
On Fri, 20 May 2022 00:53:27 GMT, SWinxy wrote: >> The current implementation creates ~750 new objects on load, and uses a >> binary array search with a Comparable implementation. This implementation is >> probably bad. Instead, we can use the enhanced switch feature to possibly >> save time,

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v17]

2022-05-20 Thread Alexey Ivanov
On Fri, 20 May 2022 16:55:43 GMT, Alisen Chung wrote: >> Changed the drawing area to be increased by 0.5 on the left side to prevent >> clipping > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > reverted copyright year test

Re: RFR: 8279614: The left line of the TitledBorder is not painted on 150 scale factor [v14]

2022-05-20 Thread Alexey Ivanov
On Fri, 20 May 2022 17:35:40 GMT, Phil Race wrote: > The test should be under test/jdk/javax/swing/border/ not java/awt ! Good catch! I never noticed the wrong package, I just copied the path. - PR: https://git.openjdk.java.net/jdk/pull/7449

Re: RFR: 8275170: Some jtreg sound tests should be marked with sound keyword [v2]

2022-05-20 Thread Phil Race
> This fix adds "headful sound" keywords to a number of javax/sound jtreg tests > > The jtreg javax.sound tests are written in such a way that if a needed audio > device > or other platform resource is not available, they just exit with a "pass" for > the test. > It is as if headful tests just s

RFR: 8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox

2022-05-20 Thread Alexander Zuev
Check for the available range on the document model and adjust text range request accordingly. - Commit messages: - 8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox Changes: https://git.openjdk.java.net/jdk/pull/88

Re: RFR: 8286266: [macos] Voice over moving JTable column to be the first column JVM crashes [v3]

2022-05-20 Thread Alexander Zuev
> Moving cache invalidation from the clearCache method to a createRowWithIndex > method > eliminating race condition that causes crash. Now clearCache just notifies > that cache > is invalid and should be regenerated next time it is being accessed. Alexander Zuev has updated the pull request inc

Re: RFR: 8286266: [macos] Voice over moving JTable column to be the first column JVM crashes [v2]

2022-05-20 Thread Alexander Zuev
On Thu, 19 May 2022 19:29:42 GMT, Phil Race wrote: >> Alexander Zuev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add a test case. > > test/jdk/java/awt/a11y/AccessibleJTableTest.java line 81: > >> 79: public void createUIDragga

Integrated: 8286266: [macos] Voice over moving JTable column to be the first column JVM crashes

2022-05-20 Thread Alexander Zuev
On Tue, 10 May 2022 17:34:34 GMT, Alexander Zuev wrote: > Moving cache invalidation from the clearCache method to a createRowWithIndex > method > eliminating race condition that causes crash. Now clearCache just notifies > that cache > is invalid and should be regenerated next time it is being

Re: RFR: 8275170: Some jtreg sound tests should be marked with sound keyword [v2]

2022-05-20 Thread Alexander Zuev
On Fri, 20 May 2022 19:25:57 GMT, Phil Race wrote: >> This fix adds "headful sound" keywords to a number of javax/sound jtreg tests >> >> The jtreg javax.sound tests are written in such a way that if a needed audio >> device >> or other platform resource is not available, they just exit with a

Re: RFR: 8275170: Some jtreg sound tests should be marked with sound keyword [v3]

2022-05-20 Thread Phil Race
> This fix adds "headful sound" keywords to a number of javax/sound jtreg tests > > The jtreg javax.sound tests are written in such a way that if a needed audio > device > or other platform resource is not available, they just exit with a "pass" for > the test. > It is as if headful tests just s

Re: RFR: 8275170: Some jtreg sound tests should be marked with sound keyword [v2]

2022-05-20 Thread Phil Race
On Fri, 20 May 2022 19:25:57 GMT, Phil Race wrote: >> This fix adds "headful sound" keywords to a number of javax/sound jtreg tests >> >> The jtreg javax.sound tests are written in such a way that if a needed audio >> device >> or other platform resource is not available, they just exit with a

Re: RFR: 8285399: JNI exception pending in awt_GraphicsEnv.c:1432 [v2]

2022-05-20 Thread Sergey Bylokhov
On Thu, 19 May 2022 18:34:57 GMT, Phil Race wrote: >> This is a theoretical/potential case of calling JNI methods with a possible >> execption pending. >> As noted in the eval of the bug report, we no longer follow the practice >> that AWT_LOCK is >> called only at the start of a native method

Re: RFR: 8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox

2022-05-20 Thread Sergey Bylokhov
On Fri, 20 May 2022 21:13:35 GMT, Alexander Zuev wrote: > Check for the available range on the document model and adjust text range > request accordingly. src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessibleText.java line 293: > 291: int currentLength = aet.getCharCount

Re: RFR: 8286786: [macos] javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java still fails

2022-05-20 Thread Sergey Bylokhov
On Fri, 20 May 2022 09:07:29 GMT, Prasanta Sadhukhan wrote: > In PR#[8380](https://github.com/openjdk/jdk/pull/8380) we have reduced the > error tolerance from 25 to 1 so no need of exact color check which is causing > failure in specific M1 iMac system because of minimalistic color difference

Re: RFR: 8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver

2022-05-20 Thread Sergey Bylokhov
On Thu, 19 May 2022 23:46:48 GMT, Phil Race wrote: > This adds the Microsoft Basic Render Driver to our "bad hardware" list so > that we don't use that pipeline there. > We have at least the one test that fails there and I am not sure we get any > benefit from this. > I'm sure Microsoft need to