RFR: 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTexTAndGraphicsState.java

2021-09-13 Thread lawrence . andrews
Problem : 1) Test case was failing with following exception test result: Error. Parse Exception: Arguments to `manual' option not supported: yes 2) After removing =yes/no Parser exception is not seen but test UI will show and closes immediately where the user cannot see what is on the frame.

Re: RFR: 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTexTAndGraphicsState.java [v2]

2021-09-13 Thread lawrence . andrews
> Problem : > 1) Test case was failing with following exception > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yes > 2) After removing =yes/no Parser exception is not seen but test UI will show > and closes immediately where the user cannot see what is on

Re: RFR: 8270609: [TESTBUG] java/awt/print/Dialog/DialogCopies.java does not show instruction

2021-09-14 Thread lawrence . andrews
On Tue, 20 Jul 2021 23:54:20 GMT, lawrence.andrews wrote: > 1) When the test is executed via jtreg user can see only print dialog with no > instruction to the user. User has to see the test case to see the instruction > and perform the test . > 2) With this fix User is instructed what he/she

Re: RFR: 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTexTAndGraphicsState.java [v2]

2021-09-14 Thread lawrence . andrews
On Tue, 14 Sep 2021 16:38:34 GMT, Pankaj Bansal wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed minor issue > > test/jdk/java/awt/Graphics/LCDTextAndGraphicsState.java line 126: > >> 124: instruc

Re: RFR: 8270609: [TESTBUG] java/awt/print/Dialog/DialogCopies.java does not show instruction

2021-09-15 Thread lawrence . andrews
On Tue, 20 Jul 2021 23:54:20 GMT, lawrence.andrews wrote: > 1) When the test is executed via jtreg user can see only print dialog with no > instruction to the user. User has to see the test case to see the instruction > and perform the test . > 2) With this fix User is instructed what he/she

Re: RFR: 8270609: [TESTBUG] java/awt/print/Dialog/DialogCopies.java does not show instruction [v2]

2021-09-15 Thread lawrence . andrews
> 1) When the test is executed via jtreg user can see only print dialog with no > instruction to the user. User has to see the test case to see the instruction > and perform the test . > 2) With this fix User is instructed what he/she has to do with the print > dialog. > 3) I have added both su

Re: RFR: 8270609: [TESTBUG] java/awt/print/Dialog/DialogCopies.java does not show instruction [v2]

2021-09-16 Thread lawrence . andrews
On Thu, 16 Sep 2021 19:44:48 GMT, Alexey Ivanov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Close instruction frame if OK/Cancel button is pressed > > test/jdk/java/awt/print/Dialog/DialogCopies.java line 5

Re: RFR: 8270609: [TESTBUG] java/awt/print/Dialog/DialogCopies.java does not show instruction [v3]

2021-09-16 Thread lawrence . andrews
> 1) When the test is executed via jtreg user can see only print dialog with no > instruction to the user. User has to see the test case to see the instruction > and perform the test . > 2) With this fix User is instructed what he/she has to do with the print > dialog. > 3) I have added both su

Re: RFR: 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction [v2]

2021-09-17 Thread lawrence . andrews
On Wed, 15 Sep 2021 15:14:36 GMT, Alexey Ivanov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed minor issue > > test/jdk/java/awt/Graphics/LCDTextAndGraphicsState.java line 60: > >> 58: private stati

Re: RFR: 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction [v3]

2021-09-17 Thread lawrence . andrews
> Problem : > 1) Test case was failing with following exception > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yes > 2) After removing =yes/no Parser exception is not seen but test UI will show > and closes immediately where the user cannot see what is on

Re: RFR: 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction [v4]

2021-09-17 Thread lawrence . andrews
> Problem : > 1) Test case was failing with following exception > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yes > 2) After removing =yes/no Parser exception is not seen but test UI will show > and closes immediately where the user cannot see what is on

Re: RFR: 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction [v3]

2021-09-17 Thread lawrence . andrews
On Fri, 17 Sep 2021 14:05:45 GMT, Alexey Ivanov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Simplified test UI > > test/jdk/java/awt/Graphics/LCDTextAndGraphicsState.java line 49: > >> 47: import java.awt.

Re: RFR: 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction [v2]

2021-09-17 Thread lawrence . andrews
On Wed, 15 Sep 2021 15:15:15 GMT, Alexey Ivanov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed minor issue > > test/jdk/java/awt/Graphics/LCDTextAndGraphicsState.java line 59: > >> 57: >> 58: priva

Re: RFR: 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction [v3]

2021-09-17 Thread lawrence . andrews
On Fri, 17 Sep 2021 13:15:44 GMT, Alexey Ivanov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Simplified test UI > > test/jdk/java/awt/Graphics/LCDTextAndGraphicsState.java line 120: > >> 118: >> 119:

Re: RFR: 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction [v2]

2021-09-17 Thread lawrence . andrews
On Wed, 15 Sep 2021 15:21:12 GMT, Alexey Ivanov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed minor issue > > test/jdk/java/awt/Graphics/LCDTextAndGraphicsState.java line 79: > >> 77: Graphics2

Integrated: 8273685 : Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction

2021-09-17 Thread lawrence . andrews
On Mon, 13 Sep 2021 21:22:36 GMT, lawrence.andrews wrote: > Problem : > 1) Test case was failing with following exception > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yes > 2) After removing =yes/no Parser exception is not seen but test UI will show >

Re: RFR: 8270609: [TESTBUG] java/awt/print/Dialog/DialogCopies.java does not show instruction [v4]

2021-09-17 Thread lawrence . andrews
> 1) When the test is executed via jtreg user can see only print dialog with no > instruction to the user. User has to see the test case to see the instruction > and perform the test . > 2) With this fix User is instructed what he/she has to do with the print > dialog. > 3) I have added both su

Re: RFR: 8270609: [TESTBUG] java/awt/print/Dialog/DialogCopies.java does not show instruction [v3]

2021-09-17 Thread lawrence . andrews
On Fri, 17 Sep 2021 18:01:06 GMT, Alexey Ivanov wrote: >> lawrence.andrews has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - removed unwanted textarea.setText >> - minor change >> - Close instruction frame after clicking OK/Cancel bu

Integrated: 8270609: [TESTBUG] java/awt/print/Dialog/DialogCopies.java does not show instruction

2021-09-20 Thread lawrence . andrews
On Tue, 20 Jul 2021 23:54:20 GMT, lawrence.andrews wrote: > 1) When the test is executed via jtreg user can see only print dialog with no > instruction to the user. User has to see the test case to see the instruction > and perform the test . > 2) With this fix User is instructed what he/she

Re: RFR: 8273887: [macos] java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java timed out

2021-09-20 Thread lawrence . andrews
On Mon, 20 Sep 2021 19:29:10 GMT, Sergey Bylokhov wrote: > This testcase creates two threads for each tag, one thread continuously > change the profiles, the second thread use that profiles for color > conversion. The first thread executed no more than 15 seconds, and the second > thread shoul

RFR: 8274029 : Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java

2021-09-20 Thread lawrence . andrews
Problem : Testcase was failing with parser exception test result: Error. Parse Exception: Arguments to `manual' option not supported: yesno Fix : Removed =yesno and run the testcase and Test UI ( instruction and print dialog ) is visible @shurymury - Commit messages: - 8274029 :

RFR: 8274032 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI

2021-09-20 Thread lawrence . andrews
Problem : 1) Testcase was failing due to parse exception yesno 2) After removing yesno tag test frame and immediately get disposed Fix : 1) Removed yesno tag 2) Show the test frame with pass, fail button. Now user can click on the `print' button to show the print dialog and take the print out

Re: RFR: 8274032 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI

2021-09-21 Thread lawrence . andrews
On Tue, 21 Sep 2021 08:13:41 GMT, Pankaj Bansal wrote: >> Problem : >> 1) Testcase was failing due to parse exception yesno >> 2) After removing yesno tag test frame and immediately get disposed >> >> Fix : >> 1) Removed yesno tag >> 2) Show the test frame with pass, fail button. Now user can

Re: RFR: 8274032 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI [v2]

2021-09-21 Thread lawrence . andrews
> Problem : > 1) Testcase was failing due to parse exception yesno > 2) After removing yesno tag test frame and immediately get disposed > > Fix : > 1) Removed yesno tag > 2) Show the test frame with pass, fail button. Now user can click on the > `print' button to show the print dialog and tak

Re: RFR: 8274032 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI [v2]

2021-09-21 Thread lawrence . andrews
On Tue, 21 Sep 2021 11:56:07 GMT, lawrence.andrews wrote: >> test/jdk/java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java line 83: >> >>> 81: import static java.awt.image.BufferedImage.TYPE_INT_RGB; >>> 82: import static java.awt.image.BufferedImage.TYPE_USHORT_555_RGB; >>> 83: import stati

RFR: 8274456 : Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java

2021-10-01 Thread lawrence . andrews
1) Removed =yesno 2) After running the test case, test UI will close immediately. Where the user cannot interact so rewrote the test case. a) Toolkit Modal Dialog will be shown after clicking the show button. b) Added timeout & tested c) Step by step instruction what the user has to perform @shu

Re: RFR: 8274032 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI [v3]

2021-10-04 Thread lawrence . andrews
> Problem : > 1) Testcase was failing due to parse exception yesno > 2) After removing yesno tag test frame and immediately get disposed > > Fix : > 1) Removed yesno tag > 2) Show the test frame with pass, fail button. Now user can click on the > `print' button to show the print dialog and tak

Re: RFR: 8274456 : Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java [v2]

2021-10-05 Thread lawrence . andrews
> 1) Removed =yesno > 2) After running the test case, test UI will close immediately. Where the > user cannot interact so rewrote the test case. > a) Toolkit Modal Dialog will be shown after clicking the show button. > b) Added timeout & tested > c) Step by step instruction what the user has to p

Re: RFR: 8274456 : Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java

2021-10-05 Thread lawrence . andrews
On Tue, 5 Oct 2021 07:08:18 GMT, Sergey Bylokhov wrote: >> 1) Removed =yesno >> 2) After running the test case, test UI will close immediately. Where the >> user cannot interact so rewrote the test case. >> a) Toolkit Modal Dialog will be shown after clicking the show button. >> b) Added timeou

Integrated: 8274456 : Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java

2021-10-06 Thread lawrence . andrews
On Fri, 1 Oct 2021 18:27:21 GMT, lawrence.andrews wrote: > 1) Removed =yesno > 2) After running the test case, test UI will close immediately. Where the > user cannot interact so rewrote the test case. > a) Toolkit Modal Dialog will be shown after clicking the show button. > b) Added timeout &

Integrated: 8274029 : Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java

2021-10-10 Thread lawrence . andrews
On Mon, 20 Sep 2021 21:36:34 GMT, lawrence.andrews wrote: > Problem : Testcase was failing with parser exception > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yesno > Fix : Removed =yesno and run the testcase and Test UI ( instruction and print > dialog

RFR: 8275234 : java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in ProblemList

2021-10-13 Thread lawrence . andrews
java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in the problemList.txt jtreg always picks the second entry not the first one and user expects that test should be executed on the first entry platform but it executes. @shurymury - Commit messages: - 8275234

Integrated: 8275234 : java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in ProblemList

2021-10-13 Thread lawrence . andrews
On Wed, 13 Oct 2021 18:37:40 GMT, lawrence.andrews wrote: > java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in > the problemList.txt > jtreg always picks the second entry not the first one and user expects that > test should be executed on the first entry platform but

Integrated: 8274032 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI

2021-10-13 Thread lawrence . andrews
On Tue, 21 Sep 2021 03:24:24 GMT, lawrence.andrews wrote: > Problem : > 1) Testcase was failing due to parse exception yesno > 2) After removing yesno tag test frame and immediately get disposed > > Fix : > 1) Removed yesno tag > 2) Show the test frame with pass, fail button. Now user can cl

RFR: 8275165 : ProblemList InterpolationQualityTest.java

2021-10-14 Thread lawrence . andrews
InterpolationQualityTest.java test fails consistently on windows 10 hence adding it in the problemList. @shurymury - Commit messages: - Added the right test case failure bugid - 8275165 : ProblemList InterpolationQualityTest.java Changes: https://git.openjdk.java.net/jdk/pull/593

Re: RFR: 8275165 : ProblemList InterpolationQualityTest.java

2021-10-14 Thread lawrence . andrews
On Wed, 13 Oct 2021 18:10:43 GMT, Sergey Bylokhov wrote: >> InterpolationQualityTest.java test fails consistently on windows 10 hence >> adding it in the problemList. >> >> @shurymury > > I remember this test was(and is) quite stable, did you check what is the > reason of the failure. Is it po

Re: RFR: 8275165 : ProblemList InterpolationQualityTest.java

2021-10-14 Thread lawrence . andrews
On Wed, 13 Oct 2021 17:02:03 GMT, lawrence.andrews wrote: > InterpolationQualityTest.java test fails consistently on windows 10 hence > adding it in the problemList. > > @shurymury Its a latest window on a new VM. Checking the VM's graphic system configuration. I checked the VM graphics con

RFR: 8278828 : java/awt/a11y/AccessibleTextTest.java's createTextArea() just shows instructions on the UI

2021-12-14 Thread lawrence . andrews
1) Test scenario was just showing test instruction with JTextArea. So added the JTextArea as the instruction and method says. 2) JTextArea is filled with contents so that and an Emoji character making sure that screen reader can read Emoji also. 3) Now user can user arrow keys to navigate the JT

Re: RFR: 8278828 : java/awt/a11y/AccessibleTextTest.java's createTextArea() just shows instructions on the UI

2021-12-16 Thread lawrence . andrews
On Thu, 16 Dec 2021 08:32:40 GMT, Artem Semenov wrote: >> 1) Test scenario was just showing test instruction with JTextArea. So added >> the JTextArea as the instruction and method says. >> 2) JTextArea is filled with contents so that and an Emoji character making >> sure that screen reader ca

Re: RFR: 8278828 : java/awt/a11y/AccessibleTextTest.java's createTextArea() just shows instructions on the UI [v2]

2022-01-27 Thread lawrence . andrews
> 1) Test scenario was just showing test instruction with JTextArea. So added > the JTextArea as the instruction and method says. > 2) JTextArea is filled with contents so that and an Emoji character making > sure that screen reader can read Emoji also. > 3) Now user can user arrow keys to navig

Re: RFR: 8278828 : java/awt/a11y/AccessibleTextTest.java's createTextArea() just shows instructions on the UI [v3]

2022-01-27 Thread lawrence . andrews
> 1) Test scenario was just showing test instruction with JTextArea. So added > the JTextArea as the instruction and method says. > 2) JTextArea is filled with contents so that and an Emoji character making > sure that screen reader can read Emoji also. > 3) Now user can user arrow keys to navig

Re: RFR: 8278828 : java/awt/a11y/AccessibleTextTest.java's createTextArea() just shows instructions on the UI [v2]

2022-01-27 Thread lawrence . andrews
On Thu, 27 Jan 2022 19:56:20 GMT, lawrence.andrews wrote: >> 1) Test scenario was just showing test instruction with JTextArea. So added >> the JTextArea as the instruction and method says. >> 2) JTextArea is filled with contents so that and an Emoji character making >> sure that screen reade

RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails

2022-01-28 Thread lawrence . andrews
1) Removed =yesno that was causing the test to fail with following exception test result: Error. Parse Exception: Arguments to `manual' option not supported: yesno After removing =yesno, test was just passing without user interaction so fixed the following Add the following so that user can user

Re: RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails

2022-02-03 Thread lawrence . andrews
On Tue, 1 Feb 2022 03:16:28 GMT, Sergey Bylokhov wrote: >> 1) Removed =yesno that was causing the test to fail with following exception >> test result: Error. Parse Exception: Arguments to `manual' option not >> supported: yesno >> After removing =yesno, test was just passing without user intera

Re: RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails

2022-02-04 Thread lawrence . andrews
On Fri, 28 Jan 2022 21:03:48 GMT, lawrence.andrews wrote: > 1) Removed =yesno that was causing the test to fail with following exception > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yesno > After removing =yesno, test was just passing without user interac

Re: RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails [v2]

2022-02-04 Thread lawrence . andrews
> 1) Removed =yesno that was causing the test to fail with following exception > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yesno > After removing =yesno, test was just passing without user interaction so > fixed the following > > Add the following so that

RFR: 8281284 : Write JSlider accessibility test

2022-02-04 Thread lawrence . andrews
This testcase covers both old and new api ( api added in jdk17 getAccessibleAction(), getAccessibleActionCount() , getAccessibleActionDescription ) @shurymury @savoptik - Commit messages: - 8281284 : Write JSlider accessibility test Changes: https://git.openjdk.java.net/jdk/pul

Re: RFR: 8281284 : Write JSlider accessibility test [v2]

2022-02-04 Thread lawrence . andrews
> This testcase covers both old and new api ( api added in jdk17 > getAccessibleAction(), getAccessibleActionCount() , > getAccessibleActionDescription ) > > @shurymury > @savoptik lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8281284 : Write JSlider accessibility test [v2]

2022-02-04 Thread lawrence . andrews
On Fri, 4 Feb 2022 22:20:32 GMT, Phil Race wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added @key headful > > test/jdk/javax/accessibility/JSlider/JSliderAccessibilityTest.java line 28: > >> 26: * @bug 82

Re: RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails [v3]

2022-02-07 Thread lawrence . andrews
> 1) Removed =yesno that was causing the test to fail with following exception > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yesno > After removing =yesno, test was just passing without user interaction so > fixed the following > > Add the following so that

Re: RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails [v2]

2022-02-07 Thread lawrence . andrews
On Sun, 6 Feb 2022 08:36:46 GMT, Sergey Bylokhov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Execute test all platform other than mac > > test/jdk/java/awt/Graphics/TextAAHintsTest.java line 231: > >> 229:

Re: RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails [v4]

2022-02-09 Thread lawrence . andrews
> 1) Removed =yesno that was causing the test to fail with following exception > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yesno > After removing =yesno, test was just passing without user interaction so > fixed the following > > Add the following so that

Re: RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails [v3]

2022-02-09 Thread lawrence . andrews
On Tue, 8 Feb 2022 19:59:57 GMT, Alexey Ivanov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Dispose the frame via EDT > > test/jdk/java/awt/Graphics/TextAAHintsTest.java line 2: > >> 1: package awt; >> 2:

Re: RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails [v5]

2022-02-10 Thread lawrence . andrews
> 1) Removed =yesno that was causing the test to fail with following exception > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yesno > After removing =yesno, test was just passing without user interaction so > fixed the following > > Add the following so that

Re: RFR: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails [v4]

2022-02-10 Thread lawrence . andrews
On Thu, 10 Feb 2022 08:47:51 GMT, Alexey Ivanov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Removed RenderingHints.VALUE_TEXT_ANTIALIAS_GASP and fixed the review >> comments > > test/jdk/java/awt/Graphics/

Integrated: 8202836 : [macosx] test java/awt/Graphics/TextAAHintsTest.java fails

2022-02-11 Thread lawrence . andrews
On Fri, 28 Jan 2022 21:03:48 GMT, lawrence.andrews wrote: > 1) Removed =yesno that was causing the test to fail with following exception > test result: Error. Parse Exception: Arguments to `manual' option not > supported: yesno > After removing =yesno, test was just passing without user interac

Re: RFR: 8281284 : Write JSlider accessibility test [v2]

2022-02-22 Thread lawrence . andrews
On Mon, 7 Feb 2022 10:48:03 GMT, Artem Semenov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added @key headful > > test/jdk/javax/accessibility/JSlider/JSliderAccessibilityTest.java line 68: > >> 66:

Re: RFR: 8281284 : Write JSlider accessibility test [v3]

2022-03-02 Thread lawrence . andrews
> This testcase covers both old and new api ( api added in jdk17 > getAccessibleAction(), getAccessibleActionCount() , > getAccessibleActionDescription ) > > @shurymury > @savoptik lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8281284 : Write JSlider accessibility test [v2]

2022-03-02 Thread lawrence . andrews
On Sun, 6 Feb 2022 08:22:04 GMT, Sergey Bylokhov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added @key headful > > test/jdk/javax/accessibility/JSlider/JSliderAccessibilityTest.java line 2: > >> 1: /* >>

Re: RFR: 8281284 : Write JSlider accessibility test [v2]

2022-03-02 Thread lawrence . andrews
On Wed, 23 Feb 2022 02:03:24 GMT, lawrence.andrews wrote: >> test/jdk/javax/accessibility/JSlider/JSliderAccessibilityTest.java line 68: >> >>> 66: frame.setLocationRelativeTo(null); >>> 67: frame.setDefaultCloseOperation(JFrame.DISPOSE_ON_CLOSE); >>> 68: frame.setVisibl

Re: RFR: 8281284 : Write JSlider accessibility test [v4]

2022-03-02 Thread lawrence . andrews
> This testcase covers both old and new api ( api added in jdk17 > getAccessibleAction(), getAccessibleActionCount() , > getAccessibleActionDescription ) > > @shurymury > @savoptik lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8281284 : Write JSlider accessibility test [v5]

2022-03-03 Thread lawrence . andrews
> This testcase covers both old and new api ( api added in jdk17 > getAccessibleAction(), getAccessibleActionCount() , > getAccessibleActionDescription ) > > @shurymury > @savoptik lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8281284 : Write JSlider accessibility test [v5]

2022-03-04 Thread lawrence . andrews
On Fri, 4 Mar 2022 09:10:02 GMT, Artem Semenov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> run the on windows and mac > > Looks good to me. I agree @savoptik , can you approve this PR so that this PR is el

RFR: 8282771 : Create test case for JDK-8262981

2022-03-07 Thread lawrence . andrews
Following methods are covered in this testcase getAccessibleAction() getAccessibleActionCount() getAccessibleActionDescription() doAccessibleAction(int direction) @shurymury - Commit messages: - Fixed white issue - 8282771 : Create test case for JDK-8262981 Changes: https://git.o

Re: RFR: 8282771 : Create test case for JDK-8262981 [v2]

2022-03-07 Thread lawrence . andrews
> Following methods are covered in this testcase > getAccessibleAction() > getAccessibleActionCount() > getAccessibleActionDescription() > doAccessibleAction(int direction) > > @shurymury lawrence.andrews has updated the pull request incrementally with one additional commit since the last revis

Re: RFR: 8281284 : Write JSlider accessibility test [v6]

2022-03-07 Thread lawrence . andrews
> This testcase covers both old and new api ( api added in jdk17 > getAccessibleAction(), getAccessibleActionCount() , > getAccessibleActionDescription ) > > @shurymury > @savoptik lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8281284 : Write JSlider accessibility test [v5]

2022-03-07 Thread lawrence . andrews
On Tue, 8 Mar 2022 04:34:35 GMT, Sergey Bylokhov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> run the on windows and mac > > test/jdk/java/awt/a11y/AccessibleJSliderTest.java line 2: > >> 1: /* >> 2: * Cop

Re: RFR: 8282771 : Create test case for JDK-8262981 [v3]

2022-03-16 Thread lawrence . andrews
> Following methods are covered in this testcase > getAccessibleAction() > getAccessibleActionCount() > doAccessibleAction(int direction) > > @shurymury lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision: Fixed review comments

Re: RFR: 8282771 : Create test case for JDK-8262981 [v2]

2022-03-16 Thread lawrence . andrews
On Wed, 9 Mar 2022 21:36:06 GMT, Alexandre Iline wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added command after the date > > test/jdk/javax/swing/JSlider/8262981/JSliderAccessibleAction.java line 179: > >

Re: RFR: 8278828 : java/awt/a11y/AccessibleTextTest.java's createTextArea() just shows instructions on the UI [v3]

2022-03-16 Thread lawrence . andrews
On Thu, 27 Jan 2022 21:47:04 GMT, lawrence.andrews wrote: >> 1) Test scenario was just showing test instruction with JTextArea. So added >> the JTextArea as the instruction and method says. >> 2) JTextArea is filled with contents so that and an Emoji character making >> sure that screen reade

Re: RFR: 8278828 : java/awt/a11y/AccessibleTextTest.java's createTextArea() just shows instructions on the UI [v3]

2022-03-16 Thread lawrence . andrews
On Thu, 16 Dec 2021 19:23:10 GMT, Artem Semenov wrote: >> Hi @savoptik, >> a) The test createTextArea() does not have JTextArea . I have attached the >> screen shot of the test https://bugs.openjdk.java.net/browse/JDK-8278828 >> b) The test does not say its a non-editable JTextArea. Even the ex

RFR: 8270331 : [TESTBUG] Error: Not a test or directory containing tests: java/awt/print/PrinterJob/InitToBlack.java

2022-03-17 Thread lawrence . andrews
1) Removed =yesno since it was throwing Error: Not a test or directory containing tests 2) Test was just printing the "Test passes" on the printer and user did not had any option to mark the test as pass or fail and test was always passing. so created test UI with test instruction and test contr

Re: RFR: 8281284 : Write JSlider accessibility test [v7]

2022-03-21 Thread lawrence . andrews
> This testcase covers both old and new api ( api added in jdk17 > getAccessibleAction(), getAccessibleActionCount() , > getAccessibleActionDescription ) > > @shurymury > @savoptik lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8282771 : Create test case for JDK-8262981 [v4]

2022-03-22 Thread lawrence . andrews
> Following methods are covered in this testcase > getAccessibleAction() > getAccessibleActionCount() > doAccessibleAction(int direction) > > @shurymury lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision: Fixed review comments

Re: RFR: 8282771 : Create test case for JDK-8262981 [v3]

2022-03-22 Thread lawrence . andrews
On Mon, 21 Mar 2022 16:52:26 GMT, Alexandre Iline wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed review comments > > test/jdk/javax/accessibility/JSlider/AccessibleAction/JSliderAccessibleAction.java >

Re: RFR: 8270331 : [TESTBUG] Error: Not a test or directory containing tests: java/awt/print/PrinterJob/InitToBlack.java [v2]

2022-03-23 Thread lawrence . andrews
> 1) Removed =yesno since it was throwing Error: Not a test or directory > containing tests > 2) Test was just printing the "Test passes" on the printer and user did not > had any option to mark the test as pass or fail and test was always passing. > so created test UI with test instruction and

Re: RFR: 8270331 : [TESTBUG] Error: Not a test or directory containing tests: java/awt/print/PrinterJob/InitToBlack.java [v2]

2022-03-23 Thread lawrence . andrews
On Wed, 23 Mar 2022 22:51:17 GMT, Phil Race wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed minor spelling > > test/jdk/java/awt/print/PrinterJob/InitToBlack.java line 172: > >> 170: if (!CountDo

Integrated: 8270331 : [TESTBUG] Error: Not a test or directory containing tests: java/awt/print/PrinterJob/InitToBlack.java

2022-03-23 Thread lawrence . andrews
On Thu, 17 Mar 2022 21:47:12 GMT, lawrence.andrews wrote: > 1) Removed =yesno since it was throwing Error: Not a test or directory > containing tests > 2) Test was just printing the "Test passes" on the printer and user did not > had any option to mark the test as pass or fail and test was alw

Withdrawn: 8278828 : java/awt/a11y/AccessibleTextTest.java's createTextArea() just shows instructions on the UI

2022-03-23 Thread lawrence . andrews
On Wed, 15 Dec 2021 02:21:35 GMT, lawrence.andrews wrote: > 1) Test scenario was just showing test instruction with JTextArea. So added > the JTextArea as the instruction and method says. > 2) JTextArea is filled with contents so that and an Emoji character making > sure that screen reader ca

RFR: 8274082 : Wrong test case name specified in jtreg run tag for java/awt/print/PrinterJob/SwingUIText.java

2022-03-24 Thread lawrence . andrews
Following issues were fixed in this test 1) Fixed - Parser error due to yesno in @run main/manual=yesno 2) Fixed Wrong test name specified in @run jtreg @run main/manual=yesno PrintTextTest . It should be @run main/manual=yesno SwingUIText 3) Instruction frame does not have 'Pass' or 'Fail' butto

RFR: 8283712 : Create a manual test framework class

2022-03-25 Thread lawrence . andrews
We need a common manual test framework code that can be shared across all the client manual test. This framework class should have the following 1) Frame which contains test instruction . 2) Pass & Fail button so that user can mark the test pass or fail 3) Upon failing the test user should be able

Re: RFR: 8283712 : Create a manual test framework class

2022-03-25 Thread lawrence . andrews
On Fri, 25 Mar 2022 21:33:46 GMT, Phil Race wrote: >> We need a common manual test framework code that can be shared across all >> the client manual test. This framework class should have the following >> 1) Frame which contains test instruction . >> 2) Pass & Fail button so that user can mark t

Re: RFR: 8283712 : Create a manual test framework class [v2]

2022-03-25 Thread lawrence . andrews
On Fri, 25 Mar 2022 21:35:49 GMT, Phil Race wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed the review comments and fixed the test using PassFailJFrame.java > > test/jdk/java/awt/regtesthelpers/PassFailJF

Re: RFR: 8283712 : Create a manual test framework class [v2]

2022-03-25 Thread lawrence . andrews
> We need a common manual test framework code that can be shared across all the > client manual test. This framework class should have the following > 1) Frame which contains test instruction . > 2) Pass & Fail button so that user can mark the test pass or fail > 3) Upon failing the test user shou

Re: RFR: 8283712 : Create a manual test framework class [v3]

2022-03-25 Thread lawrence . andrews
> We need a common manual test framework code that can be shared across all the > client manual test. This framework class should have the following > 1) Frame which contains test instruction . > 2) Pass & Fail button so that user can mark the test pass or fail > 3) Upon failing the test user shou

Re: RFR: 8283712 : Create a manual test framework class [v2]

2022-03-25 Thread lawrence . andrews
On Sat, 26 Mar 2022 02:13:24 GMT, lawrence.andrews wrote: >> We need a common manual test framework code that can be shared across all >> the client manual test. This framework class should have the following >> 1) Frame which contains test instruction . >> 2) Pass & Fail button so that user ca

Re: RFR: 8283712 : Create a manual test framework class [v3]

2022-03-28 Thread lawrence . andrews
On Sat, 26 Mar 2022 02:37:09 GMT, Phil Race wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed the white space issue > > test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 103: > >> 101: * If us

Re: RFR: 8283712 : Create a manual test framework class [v4]

2022-03-28 Thread lawrence . andrews
> We need a common manual test framework code that can be shared across all the > client manual test. This framework class should have the following > 1) Frame which contains test instruction . > 2) Pass & Fail button so that user can mark the test pass or fail > 3) Upon failing the test user shou

Re: RFR: 8283712 : Create a manual test framework class [v3]

2022-03-28 Thread lawrence . andrews
On Sat, 26 Mar 2022 02:38:41 GMT, Phil Race wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed the white space issue > > test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 127: > >> 125:

RFR: 8283803 : Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/PrintGlyphVectorTest.java and fix test

2022-03-28 Thread lawrence . andrews
Fixed the following issue. 1) Removed yes/no since test was failing due to "Parser error due to yesno in @run main/manual=yesno" 2) After removing yes/no test run( just shows the UI and gets dispose immediately). User cannot interact with the test UI and mark the test pass or failed. So added P

Integrated: 8281284 : Write JSlider accessibility test

2022-03-29 Thread lawrence . andrews
On Fri, 4 Feb 2022 18:39:52 GMT, lawrence.andrews wrote: > This testcase covers both old and new api ( api added in jdk17 > getAccessibleAction(), getAccessibleActionCount() , > getAccessibleActionDescription ) > > @shurymury > @savoptik This pull request has now been integrated. Changeset

Re: RFR: 8283712 : Create a manual test framework class [v5]

2022-04-05 Thread lawrence . andrews
> We need a common manual test framework code that can be shared across all the > client manual test. This framework class should have the following > 1) Frame which contains test instruction . > 2) Pass & Fail button so that user can mark the test pass or fail > 3) Upon failing the test user shou

Re: RFR: 8283712 : Create a manual test framework class [v4]

2022-04-05 Thread lawrence . andrews
On Mon, 4 Apr 2022 18:59:39 GMT, Phil Race wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Dispose the Frame based in EDT > > test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java line 74: > >> 72:

Re: RFR: 8284535 : Fix PrintLatinCJKTest.java test that is failing with Parse Exception [v6]

2022-04-07 Thread lawrence . andrews
> We need a common manual test framework code that can be shared across all the > client manual test. This framework class should have the following > 1) Frame which contains test instruction . > 2) Pass & Fail button so that user can mark the test pass or fail > 3) Upon failing the test user shou

Re: RFR: 8284535 : Fix PrintLatinCJKTest.java test that is failing with Parse Exception [v5]

2022-04-07 Thread lawrence . andrews
On Tue, 5 Apr 2022 20:16:28 GMT, lawrence.andrews wrote: >> We need a common manual test framework code that can be shared across all >> the client manual test. This framework class should have the following >> 1) Frame which contains test instruction . >> 2) Pass & Fail button so that user can

Re: RFR: 8284535 : Fix PrintLatinCJKTest.java test that is failing with Parse Exception [v4]

2022-04-07 Thread lawrence . andrews
On Tue, 5 Apr 2022 18:58:27 GMT, Alexey Ivanov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Dispose the Frame based in EDT > > test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java line 91: > >> 89:

Re: RFR: 8284535 : Fix PrintLatinCJKTest.java test that is failing with Parse Exception [v5]

2022-04-07 Thread lawrence . andrews
On Wed, 6 Apr 2022 10:39:44 GMT, Alexey Ivanov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fixed review comments > > test/jdk/java/awt/print/PrinterJob/PrintLatinCJKTest.java line 85: > >> 83:

Re: RFR: 8284316 : Support accessibility ManualTestFrame.java for non SwingSet tests [v2]

2022-04-07 Thread lawrence . andrews
> 1) Modified ManualTestFrame.java to support non SwingSet2 and this include > modification of SwingSetTest.java > 2) Added new TestJProgressBarAccessibility.java testcase that uses > ManualTestFrame > 3) Added timeout support in case user does not interact with the > ManualTestFrame > > @shu

Re: RFR: 8284535 : Fix PrintLatinCJKTest.java test that is failing with Parse Exception [v4]

2022-04-08 Thread lawrence . andrews
On Tue, 5 Apr 2022 20:38:58 GMT, Alexey Ivanov wrote: >> lawrence.andrews has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Dispose the Frame based in EDT > > test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 135: > >> 133:

Re: RFR: 8284535 : Fix PrintLatinCJKTest.java test that is failing with Parse Exception [v7]

2022-04-11 Thread lawrence . andrews
> We need a common manual test framework code that can be shared across all the > client manual test. This framework class should have the following > 1) Frame which contains test instruction . > 2) Pass & Fail button so that user can mark the test pass or fail > 3) Upon failing the test user shou

  1   2   >