Re: RFR: 8267374: (macos) Left Option+Up/Down arrow dont traverse to beginning/end of line in textarea

2022-06-22 Thread Prasanta Sadhukhan
On Thu, 23 Jun 2022 06:07:37 GMT, Sergey Bylokhov wrote: > > Right option key does not work at all...Left option key worked for > > left-right but not for up-down..this PR addresses that left option key > > up/down issue.. > > But the right key worked in jdk8, no? Right Option Key worked for

Re: RFR: 8288633: The ICC_ColorSpace.fromCIEXYZ method uses the wrong rendering intent [v2]

2022-06-22 Thread Sergey Bylokhov
> The specification of the ICC_ColorSpace.fromCIEXYZ method > [says](https://urldefense.com/v3/__https://github.com/openjdk/jdk/blob/9d4b25e7888098a866ff980e37b8d16d456906d8/src/java.desktop/share/classes/java/awt/color/ICC_ColorSpace.java*L428__;Iw!!ACWV5N9M2RV99hQ!IJJLWj4I9dcJ4yXCu-UdKP0SxwlTrp

Re: RFR: 8267374: (macos) Left Option+Up/Down arrow dont traverse to beginning/end of line in textarea

2022-06-22 Thread Sergey Bylokhov
On Wed, 22 Jun 2022 06:56:39 GMT, Prasanta Sadhukhan wrote: > Right option key does not work at all...Left option key worked for left-right > but not for up-down..this PR addresses that left option key up/down issue.. But the right key worked in jdk8, no? - PR: https://git.openjd

Re: RFR: JDK-8288993: Make AwtFramePackTest generic by removing @requires tag

2022-06-22 Thread Sergey Bylokhov
On Wed, 22 Jun 2022 18:50:49 GMT, Harshitha Onkar wrote: > The following test was changed to generic based on this [Review > Comment](https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9118*discussion_r897553780__;Iw!!ACWV5N9M2RV99hQ!P_GL_NjJc6mQksISE_S4ESnbESYQ3p0UToATIN3T-tcXlKTRr

Re: RFR: JDK-8288993: Make AwtFramePackTest generic by removing @requires tag

2022-06-22 Thread Harshitha Onkar
On Wed, 22 Jun 2022 18:50:49 GMT, Harshitha Onkar wrote: > The following test was changed to generic based on this [Review > Comment](https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9118*discussion_r897553780__;Iw!!ACWV5N9M2RV99hQ!OeF8K62SHfgLypmQHAuA1ZOTU2Iov7vUmm6SGGwCpt1ghTntS

Re: RFR: JDK-8288993: Make AwtFramePackTest generic by removing @requires tag

2022-06-22 Thread Harshitha Onkar
On Wed, 22 Jun 2022 21:00:30 GMT, Dmitry Markov wrote: >> The following test was changed to generic based on this [Review >> Comment](https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9118*discussion_r897553780__;Iw!!ACWV5N9M2RV99hQ!JumRvVf_p_sqpLDLCzx73muB4YOAryoWk4sWfo9E-H_wPUkRd

Re: RFR: JDK-8288993: Make AwtFramePackTest generic by removing @requires tag

2022-06-22 Thread Dmitry Markov
On Wed, 22 Jun 2022 18:50:49 GMT, Harshitha Onkar wrote: > The following test was changed to generic based on this [Review > Comment](https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9118*discussion_r897553780__;Iw!!ACWV5N9M2RV99hQ!NlZ2-nOkKDwGHMiGS-ZHpyHhmwMZwxkM78nsrp6k-TSMCrxiO

RFR: JDK-8288993: Make AwtFramePackTest generic by removing @requires tag

2022-06-22 Thread Harshitha Onkar
The following test was changed to generic based on this [Review Comment](https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9118*discussion_r897553780__;Iw!!ACWV5N9M2RV99hQ!Lvy6J9KfgCVA-2ID-oLD9YoyDyMh8Q_Go0rcyfxSVvBfdnsqtHuQV6n-qliRfxxnFGqCpYw6GNVsyMavk4WIGyE0$ ) and as the conditio

Re: RFR: 8265586: [windows] last button is not shown in AWT Frame with BorderLayout and MenuBar set. [v3]

2022-06-22 Thread Harshitha Onkar
On Wed, 15 Jun 2022 05:37:42 GMT, Sergey Bylokhov wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> minor changes > > test/jdk/java/awt/Frame/AwtFramePackTest.java line 42: > >> 40: * @bug 8265586 >> 41: * @key

Re: RFR: 8288428: javax/swing/JInternalFrame/Test6505027.java fails frequently in MacOS 12 machines

2022-06-22 Thread Manukumar V S
On Fri, 17 Jun 2022 14:28:15 GMT, Manukumar V S wrote: > javax/swing/JInternalFrame/Test6505027.java seems to be unstable in MacOS > machines, especially in MacOSX 12 machines and it fails intermittently in CI > causing some noise. > It seems to be a testbug as adding some stability improvement

Re: RFR: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines [v2]

2022-06-22 Thread Manukumar V S
On Fri, 17 Jun 2022 10:57:59 GMT, Manukumar V S wrote: >> java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS >> machines, especially in MacOSX 12 machines. It seems to be a testbug as >> adding some stability improvements fix the issue. It intermittently fails in >> CI cau

Re: RFR: 8284524: Create an automated test for JDK-4422362 [v3]

2022-06-22 Thread Srinivas Mandalika
On Thu, 16 Jun 2022 03:38:03 GMT, Sergey Bylokhov wrote: >> Srinivas Mandalika has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review Comments Fixed: Fixed File location path. > > test/jdk/javax/accessibility/MaximumAccessibleValueTest.j

Re: RFR: 8284524: Create an automated test for JDK-4422362 [v4]

2022-06-22 Thread Srinivas Mandalika
> Create an automated test for > [JDK-4422362](https://bugs.openjdk.java.net/browse/JDK-4422362) > > The BoundedRangeModel components (JScrollBar, JSlider, JProgressBar) return > BoundedRangeModel.getMaximum() from getMaximumAccessibleValue() in their > AccessibleValue implementation. > The real

Re: RFR: 8284767: Create an automated test for JDK-4422535 [v3]

2022-06-22 Thread Srinivas Mandalika
On Thu, 16 Jun 2022 03:39:12 GMT, Sergey Bylokhov wrote: >> Srinivas Mandalika has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review Comments Fixed: Fixed File location path. > > test/jdk/javax/accessibility/SetCurrentAccessibleValueTes

Re: RFR: 8284767: Create an automated test for JDK-4422535 [v4]

2022-06-22 Thread Srinivas Mandalika
> Create an automated test for > [JDK-4422535](https://bugs.openjdk.java.net/browse/JDK-4422535) > AccessibleValue implementation only accept Integers > The AccessibleValue implementations of the following components: > > java.awt.Scrollbar > javax.swing.AbstractButton > javax.swing.JInternalFram

Re: RFR: 8287609: macOS: SIGSEGV at [CoreFoundation] CFArrayGetCount / sun.font.CFont.getTableBytesNative

2022-06-22 Thread Alexey Ivanov
On Sun, 5 Jun 2022 15:38:21 GMT, Phil Race wrote: >> `CTFontCopyAvailableTables` can return null, which causes subsequent call to >> `CFArrayGetCount` to crash with SEGFAULT, just added a null-check. > > how do to backports is documented here : > https://wiki.openjdk.java.net/display/SKARA/Back

Re: RFR: 8272998: ImageIO.read() throws incorrect exception type

2022-06-22 Thread Alexey Ivanov
On Thu, 9 Jun 2022 19:53:22 GMT, Phil Race wrote: > ImageIO.read() only documents IOException for any kind of decoding problem > and since > it is a convenience API we don't want to start requiring applications to > handle other RuntimeExceptions. > So in the unlikely case of some problem decod

Re: RFR: 8267374: (macos) Option+Up/Down arrow dont traverse to beginning/end of line in textarea [v2]

2022-06-22 Thread Prasanta Sadhukhan
On Wed, 22 Jun 2022 06:27:03 GMT, Sergey Bylokhov wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix javadoc > > src/java.desktop/share/classes/javax/swing/text/DefaultEditorKit.java line > 648: > >> 646:

Re: RFR: 8267374: (macos) Option+Up/Down arrow dont traverse to beginning/end of line in textarea

2022-06-22 Thread Prasanta Sadhukhan
On Wed, 22 Jun 2022 06:22:53 GMT, Sergey Bylokhov wrote: > Is it possible that the submitter tested the right option key? I think it > stopped working somewhere after jdk8 as described in the JBS. Right option key does not work at all...Left option key worked for left-right but not for up-down

Re: RFR: 8267374: (macos) Option+Up/Down arrow dont traverse to beginning/end of line in textarea [v2]

2022-06-22 Thread Prasanta Sadhukhan
> Unlike in native "Notes" editor where Option+Up/Down traverses to start/end > of each line respectively, > Java does not honour these key combination in editor. > > Added the key combination support by moving the caret to start/end of line > and then doing caret up/down a line depending on if