On Tue, 28 Jun 2022 06:34:18 GMT, Prasanta Sadhukhan
wrote:
> @prrace Can we please ask Apple if this behaviour is a bug in Java that we
> dont overlap the taskbar for small popupmenu or is it expected?
I do not think that this is an Apple bug, since we(our code) place that menu to
the locati
On Tue, 28 Jun 2022 04:54:24 GMT, Prasanta Sadhukhan
wrote:
>> We could change it back but then we should take care of all that followup
>> changes.
>
>> That's not a mistake, the swing was updated in a few places here and there
>> to support it, for example: https://bugs.openjdk.org/browse/JD
On Tue, 28 Jun 2022 06:27:29 GMT, Sergey Bylokhov wrote:
> > > Are you sure? It has macOS specific code added as part of the
> > > https://bugs.openjdk.org/browse/JDK-8196096
> >
> >
> > It deproblemlist it for windows. macos specific code was added to check for
> > heavyweight poup in non-ma
On Fri, 24 Jun 2022 03:42:23 GMT, Prasanta Sadhukhan
wrote:
> Test was failing intermittently around 1 or 2 out of 30 runs.
> Fixed by adding stability code, wait for a sec after frame is visible, set
> frame to center.
> Modified test has run at least 50 times in all platforms and 100 times i
On Tue, 28 Jun 2022 05:53:47 GMT, Prasanta Sadhukhan
wrote:
> > Are you sure? It has macOS specific code added as part of the
> > https://bugs.openjdk.org/browse/JDK-8196096
>
> It deproblemlist it for windows. macos specific code was added to check for
> heavyweight poup in non-macos platfor
On Tue, 28 Jun 2022 05:38:36 GMT, Sergey Bylokhov wrote:
> I think for the large menu it was fixed by the changed mentioned
> [here](https://bugs.openjdk.org/browse/JDK-7124313?focusedCommentId=12546867&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-12546867)
>
On Tue, 28 Jun 2022 05:38:36 GMT, Sergey Bylokhov wrote:
> Are you sure? It has macOS specific code added as part of the
> https://bugs.openjdk.org/browse/JDK-8196096
It deproblemlist it for windows. macos specific code was added to check for
heavyweight poup in non-macos platform which we don
On Tue, 28 Jun 2022 04:48:20 GMT, Prasanta Sadhukhan
wrote:
> It says for windows and linux only
Are you sure? It has macOS specific code added as part of the
https://bugs.openjdk.org/browse/JDK-8196096
> Also, if we put hundred of items in popup , it fails in windows/linux so i
> wish not t
On Mon, 27 Jun 2022 20:21:40 GMT, Sergey Bylokhov wrote:
>> That's not a mistake, the swing was updated in a few places here and there
>> to support it, for example:
>> https://bugs.openjdk.org/browse/JDK-8194873
>
> We could change it back but then we should take care of all that followup
> ch
On Mon, 27 Jun 2022 20:45:49 GMT, Sergey Bylokhov wrote:
> An initial bug 6580930 said that the menu should be big enough to overlap the
> taskbar. I tried a simple example and it seems that if the popup is big
> enough(hundred of items) it will overlap taskbar. please double check that.
It sa
On Fri, 24 Jun 2022 03:42:23 GMT, Prasanta Sadhukhan
wrote:
> Test was failing intermittently around 1 or 2 out of 30 runs.
> Fixed by adding stability code, wait for a sec after frame is visible, set
> frame to center.
> Modified test has run at least 50 times in all platforms and 100 times i
Currently PassFailJFrame.positionTestFrame() and PassFailJFrame.addTestFrame()
take Frame as input parameter, this has been changed to Window.
Refactored the above method names to reflect the functionality & input
parameter type -
addTestWindow(), positionTestWindow()
Additionally added test fa
This is the fix for a copy-paste error. The fix JDK-8076313 replaced the usage
of the "screens" array from the parent class to the "devices" where the list of
devices is now maintained. Since "screens" array is never used nor initialized
its usage caused an NPE. That check was copied as-is, whil
On Mon, 27 Jun 2022 21:41:07 GMT, Sergey Bylokhov wrote:
>>> Other exception types are possible or very difficult to prove they won't be
>>> thrown anprop if it ever did happen
>> we'd be back here
>>
>> But then it will mean that the "read" thrown wrong exceptions, Isn't this
>> just hiding t
On Mon, 27 Jun 2022 20:27:01 GMT, Sergey Bylokhov wrote:
>> I did comment on this in the bug and the PR description.
>> Other exception types are possible or very difficult to prove they won't be
>> thrown anprop if it ever did happen
>> we'd be back here. So this seems like the best to thing to
On Wed, 22 Jun 2022 18:50:49 GMT, Harshitha Onkar wrote:
> The following test was changed to generic based on this [Review
> Comment](https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9118*discussion_r897553780__;Iw!!ACWV5N9M2RV99hQ!ORteC9U3hWXGSP9QFb9HQ3Ec2ELJfRsxaB5wzYCtAXr8pGCNM
On Mon, 27 Jun 2022 07:01:35 GMT, Prasanta Sadhukhan
wrote:
> In macos, popups does not overlap taskbar unlike windows, as can be seen here
> in "Settings"
> so we can omit this test from macOS run.
>
>  was called twice as a workaround AWT frame sizing
> issue in this particular test case on Windows. This issue was fixed
> **[JDK-8265586](https://bugs.openjdk.org/browse/JDK-8265586)** and hence the
> workaroun
On Fri, 24 Jun 2022 00:53:35 GMT, Harshitha Onkar wrote:
>> The following test was changed to generic based on this [Review
>> Comment](https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9118*discussion_r897553780__;Iw!!ACWV5N9M2RV99hQ!LHfhNGNhR2w8MuFyO5LWzC2K5BvqXSX7-n7TTtENKtBsy2X
On Tue, 21 Jun 2022 18:25:00 GMT, Phil Race wrote:
> Other exception types are possible or very difficult to prove they won't be
> thrown anprop if it ever did happen
we'd be back here
But then it will mean that the "read" thrown wrong exceptions, Isn't this just
hiding the actual bug?
--
On Mon, 27 Jun 2022 03:22:24 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/macosx/classes/com/apple/laf/AquaKeyBindings.java line 95:
>>
>>> 93: "alt altgraph LEFT", DefaultEditorKit.previousWordAction,
>>> 94: "alt altgraph RIGHT", DefaultEditorKit.nextWordAction,
>>> 95:
On Mon, 27 Jun 2022 20:20:16 GMT, Sergey Bylokhov wrote:
>> I also agree.
>
> That's not a mistake, the swing was updated in a few places here and there to
> support it, for example:
> https://bugs.openjdk.org/browse/JDK-8194873
We could change it back but then we should take care of all that f
On Mon, 27 Jun 2022 11:49:07 GMT, Jesper Wilhelmsson
wrote:
> Forwardport JDK 19 -> JDK 20
This pull request has now been integrated.
Changeset: d4b040f4
Author:Jesper Wilhelmsson
URL:
https://git.openjdk.org/jdk/commit/d4b040f42dd0a9100ad1ffa55de4ae4f20e9f182
Stats: 366 lines
> Forwardport JDK 19 -> JDK 20
Jesper Wilhelmsson has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 146 commits:
- Merge
- 8289126: Cleanup unnecessary null comparison before instanceof check in
jdk.hotspot.agent
Reviewed-by:
On Fri, 24 Jun 2022 00:53:35 GMT, Harshitha Onkar wrote:
>> The following test was changed to generic based on this [Review
>> Comment](https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9118*discussion_r897553780__;Iw!!ACWV5N9M2RV99hQ!JrM4yW8OP0OG_BKgREXWi9VYzU9Yu9M0mI3HlmjSS2xINvD
On Fri, 24 Jun 2022 03:42:23 GMT, Prasanta Sadhukhan
wrote:
> Test was failing intermittently around 1 or 2 out of 30 runs.
> Fixed by adding stability code, wait for a sec after frame is visible, set
> frame to center.
> Modified test has run at least 50 times in all platforms and 100 times i
On Fri, 11 Feb 2022 19:20:16 GMT, Damon Nguyen wrote:
> Updated Parser class doc by appending to the doc regarding lack of support
> for HTML script tags. Adding this information to the "parse" function did not
> seem as consistent for formatting as adding it to the Parser class doc.
This pull
On Fri, 24 Jun 2022 00:53:35 GMT, Harshitha Onkar wrote:
>> The following test was changed to generic based on this [Review
>> Comment](https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9118*discussion_r897553780__;Iw!!ACWV5N9M2RV99hQ!OD1nHoXjAVjPcd0j0DcrLavC4sicxaeyU7EjyHZ14_HypMb
Forwardport JDK 19 -> JDK 20
-
Commit messages:
- Merge
- 8289079: java/lang/Thread/jni/AttachCurrentThread/AttachTest.java#id1 failed
with "RuntimeException: Test failed"
- 8247407: tools/jlink/plugins/CompressorPluginTest.java test failing
- 8288983: broken link in com.sun.net.
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand of a
> compound assignment is not assignment compatibl
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand of a
> compound assignment is not assignment compatibl
In macos, popups does not overlap taskbar unlike windows, as can be seen here
in "Settings"
so we can omit this test from macOS run.
