On Tue, 28 Jun 2022 11:15:41 GMT, Abhishek Kumar wrote:
>> JLabel and AbstractButton's imageUpdate method description updated.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> passed in text added
Please review the CSR ra
On Wed, 29 Jun 2022 19:08:12 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/sun/swing/FilePane.java line 1198:
>>
>>> 1196: text = MessageFormat.format(kiloByteString, len +
>>> 1);
>>> 1197: } else if (len < 1024L) {
>>> 1198:
> Previously frame.pack() was called twice as a workaround AWT frame sizing
> issue in this particular test case on Windows. This issue was fixed
> **[JDK-8265586](https://bugs.openjdk.org/browse/JDK-8265586)** and hence the
> workaround is being removed from this test.
>
> PassFailJFrame is b
> Previously frame.pack() was called twice as a workaround AWT frame sizing
> issue in this particular test case on Windows. This issue was fixed
> **[JDK-8265586](https://bugs.openjdk.org/browse/JDK-8265586)** and hence the
> workaround is being removed from this test.
>
> PassFailJFrame is b
On Wed, 29 Jun 2022 15:26:57 GMT, Andy Goryachev wrote:
> Also, will this code work correctly for non-English locales?
It won't.
It has to use `MessageFormat` and it has to add a new string to the resource
bundle.
-
PR: https://git.openjdk.org/jdk/pull/9327
On Wed, 29 Jun 2022 13:06:21 GMT, Abhishek Kumar wrote:
> JFileChooser - empty file size issue fixed.
> For empty file, now the size 0 bytes.
> Manual Test Case "ZeroFileSizeCheck.java" created.
Changes requested by aivanov (Reviewer).
test/jdk/javax/swing/JFileChooser/ZeroFileSizeCheck.java l
On Tue, 28 Jun 2022 00:58:42 GMT, Harshitha Onkar wrote:
> Currently PassFailJFrame.positionTestFrame() and
> PassFailJFrame.addTestFrame() take Frame as input parameter, this has been
> changed to Window.
>
> Refactored the above method names to reflect the functionality & input
> parameter
On Wed, 29 Jun 2022 17:17:11 GMT, Harshitha Onkar wrote:
>> Currently PassFailJFrame.positionTestFrame() and
>> PassFailJFrame.addTestFrame() take Frame as input parameter, this has been
>> changed to Window.
>>
>> Refactored the above method names to reflect the functionality & input
>> para
On Wed, 29 Jun 2022 17:17:11 GMT, Harshitha Onkar wrote:
>> Currently PassFailJFrame.positionTestFrame() and
>> PassFailJFrame.addTestFrame() take Frame as input parameter, this has been
>> changed to Window.
>>
>> Refactored the above method names to reflect the functionality & input
>> para
> Currently PassFailJFrame.positionTestFrame() and
> PassFailJFrame.addTestFrame() take Frame as input parameter, this has been
> changed to Window.
>
> Refactored the above method names to reflect the functionality & input
> parameter type -
> addTestWindow(), positionTestWindow()
>
> Additio
> Currently PassFailJFrame.positionTestFrame() and
> PassFailJFrame.addTestFrame() take Frame as input parameter, this has been
> changed to Window.
>
> Refactored the above method names to reflect the functionality & input
> parameter type -
> addTestWindow(), positionTestWindow()
>
> Additio
On Wed, 29 Jun 2022 13:06:21 GMT, Abhishek Kumar wrote:
> JFileChooser - empty file size issue fixed.
> For empty file, now the size 0 bytes.
> Manual Test Case "ZeroFileSizeCheck.java" created.
src/java.desktop/share/classes/sun/swing/FilePane.java line 1198:
> 1196: text
On Wed, 29 Jun 2022 08:28:20 GMT, Prasanta Sadhukhan
wrote:
> Test seems to fail in macOS citing popup location is 1 pixel off compared to
> combobox position ie
> `p.y 154 cpos.y 155`
>
> But in macOS, popup location, if 1st entry is selected, is 1 pixel higher
> than combobox so it's expect
JFileChooser - empty file size issue fixed.
For empty file, now the size 0 bytes.
Manual Test Case "ZeroFileSizeCheck.java" created.
-
Commit messages:
- JFileChooser empty file size 0 bytes fixed
Changes: https://git.openjdk.org/jdk/pull/9327/files
Webrev: https://webrevs.openjdk
On Tue, 28 Jun 2022 20:30:36 GMT, Harshitha Onkar wrote:
>> Currently PassFailJFrame.positionTestFrame() and
>> PassFailJFrame.addTestFrame() take Frame as input parameter, this has been
>> changed to Window.
>>
>> Refactored the above method names to reflect the functionality & input
>> para
On Mon, 27 Jun 2022 21:17:54 GMT, Sergey Bylokhov wrote:
> This is the fix for a copy-paste error. The fix JDK-8076313 replaced the
> usage of the "screens" array from the parent class to the "devices" where the
> list of devices is now maintained. Since "screens" array is never used nor
> ini
On Tue, 28 Jun 2022 20:30:36 GMT, Harshitha Onkar wrote:
>> Currently PassFailJFrame.positionTestFrame() and
>> PassFailJFrame.addTestFrame() take Frame as input parameter, this has been
>> changed to Window.
>>
>> Refactored the above method names to reflect the functionality & input
>> para
Test seems to fail in macOS citing popup location is 1 pixel off compared to
combobox position ie
`p.y 154 cpos.y 155`
But in macOS, popup location, if 1st entry is selected, is 1 pixel higher than
combobox so it's expected as can be seen below
https://user-images.githubusercontent.com/43534309/
On Mon, 27 Jun 2022 07:01:35 GMT, Prasanta Sadhukhan
wrote:
> In macos, popups does not overlap taskbar unlike windows, as can be seen here
> in "Settings"
> so we can omit this test from macOS run.
>
> 