Re: RFR: 8282526: Default icon is not painted properly [v4]

2022-07-05 Thread Alexey Ivanov
On Thu, 9 Jun 2022 10:37:30 GMT, Alexey Ivanov wrote: > > I am not going trough all the experiments with the SHDefExtractIcon again - > > at least not in this pull request. > > I absolutely agree, not in this pull request. > > However, I'm for submitting a bug or two to explore other possibili

Re: RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad [v2]

2022-07-05 Thread Vladimir Kempik
On Tue, 5 Jul 2022 19:01:41 GMT, Phil Race wrote: > Are there any other cases like this ? We should look around. (PS I see Ajit > asked the same question and perhaps even answered it !) Did you find this by > inspection or did you hit it ? I hit this bug when running IDEA on asan-enabled buil

Re: RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad [v2]

2022-07-05 Thread Vladimir Kempik
> Please review this simple patch. When running idea on jdk17 with asan I have > found this buffer overflow. > The code checks the cache for at least one free element, while placing 6 > elements to the cache. > The fix checks the presence of 6 free elements. Vladimir Kempik has updated the pull

Re: RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad

2022-07-05 Thread Vladimir Kempik
On Mon, 4 Jul 2022 15:40:56 GMT, Vladimir Kempik wrote: > Please review this simple patch. When running idea on jdk17 with asan I have > found this buffer overflow. > The code checks the cache for at least one free element, while placing 6 > elements to the cache. > The fix checks the presence

Re: RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad

2022-07-05 Thread Ajit Ghaisas
On Mon, 4 Jul 2022 15:40:56 GMT, Vladimir Kempik wrote: > Please review this simple patch. When running idea on jdk17 with asan I have > found this buffer overflow. > The code checks the cache for at least one free element, while placing 6 > elements to the cache. > The fix checks the presence

Re: RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad [v2]

2022-07-05 Thread Phil Race
On Tue, 5 Jul 2022 11:31:38 GMT, Vladimir Kempik wrote: >> Please review this simple patch. When running idea on jdk17 with asan I have >> found this buffer overflow. >> The code checks the cache for at least one free element, while placing 6 >> elements to the cache. >> The fix checks the pres

Re: RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad

2022-07-05 Thread Vladimir Kempik
On Mon, 4 Jul 2022 15:40:56 GMT, Vladimir Kempik wrote: > Please review this simple patch. When running idea on jdk17 with asan I have > found this buffer overflow. > The code checks the cache for at least one free element, while placing 6 > elements to the cache. > The fix checks the presence

Re: RFR: 8289697: buffer overflow in MTLVertexCache.m: MTLVertexCache_AddGlyphQuad

2022-07-05 Thread Alexey Ushakov
On Mon, 4 Jul 2022 15:40:56 GMT, Vladimir Kempik wrote: > Please review this simple patch. When running idea on jdk17 with asan I have > found this buffer overflow. > The code checks the cache for at least one free element, while placing 6 > elements to the cache. > The fix checks the presence